)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"73644073fea4e6feac20f44445e3ab6f92fd49b5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Ma \u003cstephen.ma@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-27 22:58:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Router can\u0027t be removed from L3-agent in dvr mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes the problem where the L3 DVR Scheduler is unable"},{"line_number":10,"context_line":"to remove a DVR router from a L3 agent running in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_624591b1","line":7,"updated":"2015-08-28 04:58:13.000000000","message":"Resolve issue where router can\u0027t be removed from the L3-agent in dvr mode","commit_id":"e68282828d2fc7ea8ec3ebd375327ea3e0d10058"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"d51d4ca60525f58e5e8ef92360c3108f5f55c6f1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Ma \u003cstephen.ma@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-27 22:58:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Router can\u0027t be removed from L3-agent in dvr mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes the problem where the L3 DVR Scheduler is unable"},{"line_number":10,"context_line":"to remove a DVR router from a L3 agent running in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_da8f8fca","line":7,"in_reply_to":"da20952f_624591b1","updated":"2015-08-28 13:42:03.000000000","message":"Done","commit_id":"e68282828d2fc7ea8ec3ebd375327ea3e0d10058"}],"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"db8d07ea48778eb38a4193cd9579e9c2ee2134f6","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                  context, agent, router)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def remove_router_from_l3_agent(self, context, agent_id, router_id):"},{"line_number":461,"context_line":"        agent_mode_is_dvr_snat \u003d False"},{"line_number":462,"context_line":"        router \u003d self.get_router(context, router_id)"},{"line_number":463,"context_line":"        if router[\u0027external_gateway_info\u0027] and router.get(\u0027distributed\u0027):"},{"line_number":464,"context_line":"            binding \u003d self.unbind_snat(context, router_id, agent_id\u003dagent_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_1816dca7","line":461,"updated":"2015-09-01 16:43:40.000000000","message":"I think you can make a small change here to not have to define a new local variable, just check \u0027binding\u0027.\n\nbinding \u003d None","commit_id":"0242a76636bb889e63f4ea32de28089932c098c7"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"9f2ce334746e57df0e68c17a1d63d643e8ad1afb","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                  context, agent, router)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def remove_router_from_l3_agent(self, context, agent_id, router_id):"},{"line_number":461,"context_line":"        agent_mode_is_dvr_snat \u003d False"},{"line_number":462,"context_line":"        router \u003d self.get_router(context, router_id)"},{"line_number":463,"context_line":"        if router[\u0027external_gateway_info\u0027] and router.get(\u0027distributed\u0027):"},{"line_number":464,"context_line":"            binding \u003d self.unbind_snat(context, router_id, agent_id\u003dagent_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_d1a91f92","line":461,"in_reply_to":"da20952f_1816dca7","updated":"2015-09-01 17:39:32.000000000","message":"Done","commit_id":"0242a76636bb889e63f4ea32de28089932c098c7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"db8d07ea48778eb38a4193cd9579e9c2ee2134f6","unresolved":false,"context_lines":[{"line_number":464,"context_line":"            binding \u003d self.unbind_snat(context, router_id, agent_id\u003dagent_id)"},{"line_number":465,"context_line":"            # binding only exists when agent mode is dvr_snat"},{"line_number":466,"context_line":"            if binding:"},{"line_number":467,"context_line":"                agent_mode_is_dvr_snat \u003d True"},{"line_number":468,"context_line":"                notification_not_sent \u003d self.unbind_router_servicenode(context,"},{"line_number":469,"context_line":"                                             router_id, binding)"},{"line_number":470,"context_line":"                if notification_not_sent:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_786cb836","line":467,"updated":"2015-09-01 16:43:40.000000000","message":"Can be removed","commit_id":"0242a76636bb889e63f4ea32de28089932c098c7"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"9f2ce334746e57df0e68c17a1d63d643e8ad1afb","unresolved":false,"context_lines":[{"line_number":464,"context_line":"            binding \u003d self.unbind_snat(context, router_id, agent_id\u003dagent_id)"},{"line_number":465,"context_line":"            # binding only exists when agent mode is dvr_snat"},{"line_number":466,"context_line":"            if binding:"},{"line_number":467,"context_line":"                agent_mode_is_dvr_snat \u003d True"},{"line_number":468,"context_line":"                notification_not_sent \u003d self.unbind_router_servicenode(context,"},{"line_number":469,"context_line":"                                             router_id, binding)"},{"line_number":470,"context_line":"                if notification_not_sent:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_f1aea397","line":467,"in_reply_to":"da20952f_786cb836","updated":"2015-09-01 17:39:32.000000000","message":"Done","commit_id":"0242a76636bb889e63f4ea32de28089932c098c7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"db8d07ea48778eb38a4193cd9579e9c2ee2134f6","unresolved":false,"context_lines":[{"line_number":472,"context_line":"                        context, [router_id], schedule_routers\u003dFalse)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        # Below Needs to be done when agent mode is legacy or dvr."},{"line_number":475,"context_line":"        if not agent_mode_is_dvr_snat:"},{"line_number":476,"context_line":"            super(L3_DVRsch_db_mixin,"},{"line_number":477,"context_line":"                  self).remove_router_from_l3_agent("},{"line_number":478,"context_line":"                    context, agent_id, router_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_9822ec00","line":475,"updated":"2015-09-01 16:43:40.000000000","message":"if not binding:","commit_id":"0242a76636bb889e63f4ea32de28089932c098c7"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"9f2ce334746e57df0e68c17a1d63d643e8ad1afb","unresolved":false,"context_lines":[{"line_number":472,"context_line":"                        context, [router_id], schedule_routers\u003dFalse)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        # Below Needs to be done when agent mode is legacy or dvr."},{"line_number":475,"context_line":"        if not agent_mode_is_dvr_snat:"},{"line_number":476,"context_line":"            super(L3_DVRsch_db_mixin,"},{"line_number":477,"context_line":"                  self).remove_router_from_l3_agent("},{"line_number":478,"context_line":"                    context, agent_id, router_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_11a0f7a4","line":475,"in_reply_to":"da20952f_9822ec00","updated":"2015-09-01 17:39:32.000000000","message":"Done","commit_id":"0242a76636bb889e63f4ea32de28089932c098c7"}]}