)]}'
{"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"a0df336dd263635cd7eb7b997d16a9f172060592","unresolved":false,"context_lines":[{"line_number":569,"context_line":"                        device_name\u003dself.name)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    def _parse_routes(self, ip_version, output, **kwargs):"},{"line_number":572,"context_line":"        for line in output.split(\u0027\\n\u0027):"},{"line_number":573,"context_line":"            parts \u003d line.split()"},{"line_number":574,"context_line":"            if not parts:"},{"line_number":575,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_3ee403aa","line":572,"updated":"2015-09-01 09:26:37.000000000","message":"prefer output.splitlines()","commit_id":"3c478ba0149e022f37c0cb2ac1019ccd84286a48"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"60eb4a92ac4a493256b90d5ba30ddb6f91511b50","unresolved":false,"context_lines":[{"line_number":569,"context_line":"                        device_name\u003dself.name)"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    def _parse_routes(self, ip_version, output, **kwargs):"},{"line_number":572,"context_line":"        for line in output.split(\u0027\\n\u0027):"},{"line_number":573,"context_line":"            parts \u003d line.split()"},{"line_number":574,"context_line":"            if not parts:"},{"line_number":575,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_d19d9f0b","line":572,"in_reply_to":"da20952f_3ee403aa","updated":"2015-09-01 17:50:37.000000000","message":"Done","commit_id":"3c478ba0149e022f37c0cb2ac1019ccd84286a48"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"a0df336dd263635cd7eb7b997d16a9f172060592","unresolved":false,"context_lines":[{"line_number":571,"context_line":"    def _parse_routes(self, ip_version, output, **kwargs):"},{"line_number":572,"context_line":"        for line in output.split(\u0027\\n\u0027):"},{"line_number":573,"context_line":"            parts \u003d line.split()"},{"line_number":574,"context_line":"            if not parts:"},{"line_number":575,"context_line":"                continue"},{"line_number":576,"context_line":"            # Format of line is: \"\u003ccidr\u003e|default [\u003ckey\u003e \u003cvalue\u003e] ...\""},{"line_number":577,"context_line":"            route \u003d {k: v for k, v in zip(parts[1::2], parts[2::2])}"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_9e874fb4","line":574,"updated":"2015-09-01 09:26:37.000000000","message":"This condition is true only if line \u003d \u0027\u0027. Moreover this check is no more needed if we use output.splitlines() because:\n\n  \u003e\u003e\u003e \"l1\\nl2\\n\".split(\"\\n\")\n  [\u0027l1\u0027, \u0027l2\u0027, \u0027\u0027]\n  \u003e\u003e\u003e \"l1\\nl2\\n\".splitlines()\n  [\u0027l1\u0027, \u0027l2\u0027]","commit_id":"3c478ba0149e022f37c0cb2ac1019ccd84286a48"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"60eb4a92ac4a493256b90d5ba30ddb6f91511b50","unresolved":false,"context_lines":[{"line_number":571,"context_line":"    def _parse_routes(self, ip_version, output, **kwargs):"},{"line_number":572,"context_line":"        for line in output.split(\u0027\\n\u0027):"},{"line_number":573,"context_line":"            parts \u003d line.split()"},{"line_number":574,"context_line":"            if not parts:"},{"line_number":575,"context_line":"                continue"},{"line_number":576,"context_line":"            # Format of line is: \"\u003ccidr\u003e|default [\u003ckey\u003e \u003cvalue\u003e] ...\""},{"line_number":577,"context_line":"            route \u003d {k: v for k, v in zip(parts[1::2], parts[2::2])}"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_91af272b","line":574,"in_reply_to":"da20952f_9e874fb4","updated":"2015-09-01 17:50:37.000000000","message":"Done","commit_id":"3c478ba0149e022f37c0cb2ac1019ccd84286a48"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"a0df336dd263635cd7eb7b997d16a9f172060592","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        output \u003d self._run([ip_version], tuple(args))"},{"line_number":600,"context_line":"        return [r for r in self._parse_routes(ip_version, output)]"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    def list_onlink_routes(self, ip_version):"},{"line_number":603,"context_line":"        args \u003d [\u0027list\u0027]"},{"line_number":604,"context_line":"        args +\u003d self._dev_args()"},{"line_number":605,"context_line":"        args +\u003d [\u0027scope\u0027, \u0027link\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_c1c888aa","line":602,"updated":"2015-09-01 09:26:37.000000000","message":"imo, it\u0027s confusing that list_onlink_routes and list_routes have different response format but similar names","commit_id":"3c478ba0149e022f37c0cb2ac1019ccd84286a48"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"60eb4a92ac4a493256b90d5ba30ddb6f91511b50","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        output \u003d self._run([ip_version], tuple(args))"},{"line_number":600,"context_line":"        return [r for r in self._parse_routes(ip_version, output)]"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    def list_onlink_routes(self, ip_version):"},{"line_number":603,"context_line":"        args \u003d [\u0027list\u0027]"},{"line_number":604,"context_line":"        args +\u003d self._dev_args()"},{"line_number":605,"context_line":"        args +\u003d [\u0027scope\u0027, \u0027link\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_b1d7cbbe","line":602,"in_reply_to":"da20952f_c1c888aa","updated":"2015-09-01 17:50:37.000000000","message":"I know and I agree.  I considered going a bit further to unify the two.  Let me see what I can do.","commit_id":"3c478ba0149e022f37c0cb2ac1019ccd84286a48"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"619c01b1555cb3469f7ae8c7b194b1aa5d710a69","unresolved":false,"context_lines":[{"line_number":595,"context_line":""},{"line_number":596,"context_line":"            yield route"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"    def list_routes(self, ip_version):"},{"line_number":599,"context_line":"        args \u003d [\u0027list\u0027]"},{"line_number":600,"context_line":"        args +\u003d self._dev_args()"},{"line_number":601,"context_line":"        args +\u003d self._table_args()"}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_c56250d8","line":598,"updated":"2015-09-03 15:07:42.000000000","message":"1.use **kwargs, and then list_onlin_routes can use it,\n2. why add this function?","commit_id":"ef9e8c3ff114c100d0d6b3a1f3dc61d1c4951fe0"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"edbf4a7b8a7070a74e559d14d91d7fb632b663b2","unresolved":false,"context_lines":[{"line_number":595,"context_line":""},{"line_number":596,"context_line":"            yield route"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"    def list_routes(self, ip_version):"},{"line_number":599,"context_line":"        args \u003d [\u0027list\u0027]"},{"line_number":600,"context_line":"        args +\u003d self._dev_args()"},{"line_number":601,"context_line":"        args +\u003d self._table_args()"}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_922044fa","line":598,"in_reply_to":"da20952f_c56250d8","updated":"2015-09-09 20:58:49.000000000","message":"1.  I thought that went better here [1] which implements all three onlink_routes methods in terms of these.  2.  A further follow-on will make use of list_routes directly.  I thought this was a good intermediate step that would be uncomplicated enough for reviewers to digest in a short sitting.\n\n [1] https://review.openstack.org/#/c/219037/7/neutron/agent/linux/ip_lib.py","commit_id":"ef9e8c3ff114c100d0d6b3a1f3dc61d1c4951fe0"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f9a8c16aaac1eec5b3ed14814a741add576d9816","unresolved":false,"context_lines":[{"line_number":582,"context_line":"            parts \u003d line.split()"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"            # Format of line is: \"\u003ccidr\u003e|default [\u003ckey\u003e \u003cvalue\u003e] ...\""},{"line_number":585,"context_line":"            route \u003d {k: v for k, v in zip(parts[1::2], parts[2::2])}"},{"line_number":586,"context_line":"            route[\u0027cidr\u0027] \u003d parts[0]"},{"line_number":587,"context_line":"            # Avoids having to explicitly pass around the IP version"},{"line_number":588,"context_line":"            if route[\u0027cidr\u0027] \u003d\u003d \u0027default\u0027:"}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_17c94759","line":585,"updated":"2015-09-04 01:45:57.000000000","message":"it doesn\u0027t get any more pythonic than this line. a dictionary comprehension, a zip, and extended slices all in one! :)","commit_id":"d515b217e312328c77b456882ffdf500910945e8"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"204cd2820d4d9a22464b402ea094152eaa800d92","unresolved":false,"context_lines":[{"line_number":582,"context_line":"            parts \u003d line.split()"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"            # Format of line is: \"\u003ccidr\u003e|default [\u003ckey\u003e \u003cvalue\u003e] ...\""},{"line_number":585,"context_line":"            route \u003d {k: v for k, v in zip(parts[1::2], parts[2::2])}"},{"line_number":586,"context_line":"            route[\u0027cidr\u0027] \u003d parts[0]"},{"line_number":587,"context_line":"            # Avoids having to explicitly pass around the IP version"},{"line_number":588,"context_line":"            if route[\u0027cidr\u0027] \u003d\u003d \u0027default\u0027:"}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_ee527e12","line":585,"in_reply_to":"da20952f_17c94759","updated":"2015-09-06 11:04:46.000000000","message":"and a headache :)","commit_id":"d515b217e312328c77b456882ffdf500910945e8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f9a8c16aaac1eec5b3ed14814a741add576d9816","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        args +\u003d self._table_args()"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"        output \u003d self._run([ip_version], tuple(args))"},{"line_number":608,"context_line":"        return [r for r in self._parse_routes(ip_version, output)]"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    def list_onlink_routes(self, ip_version):"},{"line_number":611,"context_line":"        args \u003d [\u0027list\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_b7c17b31","line":608,"updated":"2015-09-04 01:45:57.000000000","message":"what do you think of returning generator expressions for these as well?","commit_id":"d515b217e312328c77b456882ffdf500910945e8"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"204cd2820d4d9a22464b402ea094152eaa800d92","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        args +\u003d self._table_args()"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"        output \u003d self._run([ip_version], tuple(args))"},{"line_number":608,"context_line":"        return [r for r in self._parse_routes(ip_version, output)]"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    def list_onlink_routes(self, ip_version):"},{"line_number":611,"context_line":"        args \u003d [\u0027list\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_6ead0ee8","line":608,"in_reply_to":"da20952f_b7c17b31","updated":"2015-09-06 11:04:46.000000000","message":"other methods in ip_lib return lists not iterators, so it seems better for consistency to return a list?","commit_id":"d515b217e312328c77b456882ffdf500910945e8"}]}
