)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"fdb1322f6639786cdcdba49d8556b5703179a95f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These options have a number of issues:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1) Requires editing of config file after creating subnet pool through API [1][2]."},{"line_number":12,"context_line":"2) API behavior depends on value of configuration which isn\u0027t visible through API [3]."},{"line_number":13,"context_line":"   - Namely, to use the implicit pool will require an explicit None passed to the API."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_8564fcb8","line":11,"updated":"2015-08-31 17:53:56.000000000","message":"Salvatore had some good thoughts here:  https://review.openstack.org/#/c/168098/4/etc/neutron.conf","commit_id":"46d54e527dde1d9129e13a0b31453d3f9abcc507"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"70ca22aa4f594a7e9001720cda4b51f34894c075","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These options have a number of issues:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1) Requires editing of config file after creating subnet pool through API [1][2]."},{"line_number":12,"context_line":"2) API behavior depends on value of configuration which isn\u0027t visible through API [3]."},{"line_number":13,"context_line":"   - Namely, to use the implicit pool will require an explicit None passed to the API."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_5beb7313","line":11,"in_reply_to":"9a1a9d01_ad1b79c9","updated":"2015-09-28 23:00:11.000000000","message":"+1 This is a good way to proceed.","commit_id":"46d54e527dde1d9129e13a0b31453d3f9abcc507"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"f7b4647437dda2536b3438c4646e06ad32efe20c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These options have a number of issues:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1) Requires editing of config file after creating subnet pool through API [1][2]."},{"line_number":12,"context_line":"2) API behavior depends on value of configuration which isn\u0027t visible through API [3]."},{"line_number":13,"context_line":"   - Namely, to use the implicit pool will require an explicit None passed to the API."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_b57a6e75","line":11,"in_reply_to":"da20952f_8564fcb8","updated":"2015-09-01 11:23:32.000000000","message":"I would be very much in favor of the first option Salvatore describes there. The default boolean could be toggled only by the admin, but visible to all tenants so they can find out where their subnets would come from.","commit_id":"46d54e527dde1d9129e13a0b31453d3f9abcc507"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"851d909ca0134bdb124e665fcc6fb6cde6975378","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These options have a number of issues:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1) Requires editing of config file after creating subnet pool through API [1][2]."},{"line_number":12,"context_line":"2) API behavior depends on value of configuration which isn\u0027t visible through API [3]."},{"line_number":13,"context_line":"   - Namely, to use the implicit pool will require an explicit None passed to the API."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_ad1b79c9","line":11,"in_reply_to":"da20952f_b57a6e75","updated":"2015-09-28 22:25:02.000000000","message":"I agree.  Let\u0027s make this the plan to address this concern.  Quoting Salvatore:\n\n- set a \"default\" boolean attribute on the subnet pools table. You will also need to implement the logic to ensure only one record at each time can be default (or use a unique constraint but set the value to the pool\u0027s id when default is false)\n\nI would add that one record at a time can be default for each address family.  Also, here are some things to keep in mind.\n\n- Only admin should be able to set the default but all tenants can see the default flag on pools they can see.\n- If the default pool marked by the admin is not shared with the tenant then it shouldn\u0027t be used as the default for that tenant for obvious reasons.\n- We need to document this change in the release notes and the API documentation.","commit_id":"46d54e527dde1d9129e13a0b31453d3f9abcc507"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"f7b4647437dda2536b3438c4646e06ad32efe20c","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1) Requires editing of config file after creating subnet pool through API [1][2]."},{"line_number":12,"context_line":"2) API behavior depends on value of configuration which isn\u0027t visible through API [3]."},{"line_number":13,"context_line":"   - Namely, to use the implicit pool will require an explicit None passed to the API."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Are there other issues?"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_84adb9ea","line":13,"updated":"2015-09-01 11:23:32.000000000","message":"Expanding on the solution proposed by https://review.openstack.org/#/c/198437 - What if we changed the subnetpool behaviour so that a subnet-create request with no subnetpool defined but with a cidr that falls within the range of an existing subnetpool returns a subnet from that subnetpool? That way the user would only ever have to define a subnetpool in the request when creating subnets without a specific cidr. Any request with a specific cidr that doesn\u0027t fall within the range of an existing subnetpool would return a subnet from the implicit pool.\n\nDoes that make sense or would that cause other problems? Is there a use case for creating subnets within the range of existing subnetpools without being associated with that subnetpool?","commit_id":"46d54e527dde1d9129e13a0b31453d3f9abcc507"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"851d909ca0134bdb124e665fcc6fb6cde6975378","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1) Requires editing of config file after creating subnet pool through API [1][2]."},{"line_number":12,"context_line":"2) API behavior depends on value of configuration which isn\u0027t visible through API [3]."},{"line_number":13,"context_line":"   - Namely, to use the implicit pool will require an explicit None passed to the API."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Are there other issues?"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_6d9c810f","line":13,"in_reply_to":"ba15a1d1_aa09ff85","updated":"2015-09-28 22:25:02.000000000","message":"Draft:  Agree with @Ryan.  I think the solution we discussed on L11 here should cover this pretty well.  I think as long as the user can see there is a default pool through the API then things will be a lot better.","commit_id":"46d54e527dde1d9129e13a0b31453d3f9abcc507"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"177116222e60a863adfaac737d8ac42e344a0bb4","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1) Requires editing of config file after creating subnet pool through API [1][2]."},{"line_number":12,"context_line":"2) API behavior depends on value of configuration which isn\u0027t visible through API [3]."},{"line_number":13,"context_line":"   - Namely, to use the implicit pool will require an explicit None passed to the API."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Are there other issues?"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba15a1d1_aa09ff85","line":13,"in_reply_to":"da20952f_84adb9ea","updated":"2015-09-17 00:13:25.000000000","message":"\"What if we changed the subnetpool behaviour so that a subnet-create request with no subnetpool defined but with a cidr that falls within the range of an existing subnetpool returns a subnet from that subnetpool?\"\n\nWe allow the prefix lists of subnetpools to overlap with each other when not in an address scope.  Which subnetpool would you allocate from if you had 2 subnetpools carrying the same prefix?\n\nI see where your train of thought is headed, and if we could mark a subnetpool as the default via the API, then we could potentially draw from that specific subnetpool in the way you describe.  I\u0027d have to think about this a little more.  I\u0027m not sure how this would work when the default subnetpool is placed in an address scope.  On the surface it seems OK, but there may be some gotchas there.","commit_id":"46d54e527dde1d9129e13a0b31453d3f9abcc507"}]}