)]}'
{"quantum/db/db_base_plugin_v2.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"412aeae20a9f7b06c3f3361a6ed496320fe96556","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        if not cfg.CONF.allow_overlapping_ips:"},{"line_number":691,"context_line":"            subnet_list \u003d self._get_all_subnets(context)"},{"line_number":692,"context_line":"        else:"},{"line_number":693,"context_line":"            subnet_list \u003d network.subnets"},{"line_number":694,"context_line":"        for subnet in subnet_list:"},{"line_number":695,"context_line":"            if (netaddr.IPSet([subnet.cidr]) \u0026 new_subnet_ipset):"},{"line_number":696,"context_line":"                # don\u0027t give out details of the overlapping subnet"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B8Rg%3D","line":693,"updated":"2013-02-13 19:37:03.000000000","message":"We should avoid to use negative sentence for readability\nHow about this? \nsubnet_list \u003d network.subnets if cfg.CONF.allow_overlapping_ips else self._get_all_subnets(context)","commit_id":"43139ee033669dce5b09e66932a75c18b62f2d27"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":690,"context_line":"        if not cfg.CONF.allow_overlapping_ips:"},{"line_number":691,"context_line":"            subnet_list \u003d self._get_all_subnets(context)"},{"line_number":692,"context_line":"        else:"},{"line_number":693,"context_line":"            subnet_list \u003d network.subnets"},{"line_number":694,"context_line":"        for subnet in subnet_list:"},{"line_number":695,"context_line":"            if (netaddr.IPSet([subnet.cidr]) \u0026 new_subnet_ipset):"},{"line_number":696,"context_line":"                # don\u0027t give out details of the overlapping subnet"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B5NM%3D","line":693,"in_reply_to":"AAAAM3%2F%2B7p8%3D","updated":"2013-02-15 08:47:19.000000000","message":"I wonder how many cores it takes to change a light bulb?\nI\u0027ll switch the logic.\n\n(I didn\u0027t do that because I wanted to keep the diff as small as possible)","commit_id":"43139ee033669dce5b09e66932a75c18b62f2d27"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":690,"context_line":"        if not cfg.CONF.allow_overlapping_ips:"},{"line_number":691,"context_line":"            subnet_list \u003d self._get_all_subnets(context)"},{"line_number":692,"context_line":"        else:"},{"line_number":693,"context_line":"            subnet_list \u003d network.subnets"},{"line_number":694,"context_line":"        for subnet in subnet_list:"},{"line_number":695,"context_line":"            if (netaddr.IPSet([subnet.cidr]) \u0026 new_subnet_ipset):"},{"line_number":696,"context_line":"                # don\u0027t give out details of the overlapping subnet"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B7p8%3D","line":693,"in_reply_to":"AAAAM3%2F%2B8NM%3D","updated":"2013-02-14 00:29:08.000000000","message":"how many quantum core devs does it take to decide on the order of an if/else statement?  :P  \n\nJust kidding, I agree with Sumit\u0027s suggestion.","commit_id":"43139ee033669dce5b09e66932a75c18b62f2d27"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"706613c713488334704ba371a9f197230f874051","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        if not cfg.CONF.allow_overlapping_ips:"},{"line_number":691,"context_line":"            subnet_list \u003d self._get_all_subnets(context)"},{"line_number":692,"context_line":"        else:"},{"line_number":693,"context_line":"            subnet_list \u003d network.subnets"},{"line_number":694,"context_line":"        for subnet in subnet_list:"},{"line_number":695,"context_line":"            if (netaddr.IPSet([subnet.cidr]) \u0026 new_subnet_ipset):"},{"line_number":696,"context_line":"                # don\u0027t give out details of the overlapping subnet"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B8NM%3D","line":693,"in_reply_to":"AAAAM3%2F%2B8Os%3D","updated":"2013-02-13 20:05:26.000000000","message":"Sumit: yeah this is the form we should use.","commit_id":"43139ee033669dce5b09e66932a75c18b62f2d27"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":690,"context_line":"        if not cfg.CONF.allow_overlapping_ips:"},{"line_number":691,"context_line":"            subnet_list \u003d self._get_all_subnets(context)"},{"line_number":692,"context_line":"        else:"},{"line_number":693,"context_line":"            subnet_list \u003d network.subnets"},{"line_number":694,"context_line":"        for subnet in subnet_list:"},{"line_number":695,"context_line":"            if (netaddr.IPSet([subnet.cidr]) \u0026 new_subnet_ipset):"},{"line_number":696,"context_line":"                # don\u0027t give out details of the overlapping subnet"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B8Os%3D","line":693,"in_reply_to":"AAAAM3%2F%2B8Qg%3D","updated":"2013-02-13 19:53:11.000000000","message":"Why not just:\nif cfg.CONF.allow_overlapping_ips:\n    subnet_list \u003d network.subnets\nelse:\n    subnet_list \u003d self._get_all_subnets(context)\n\nto avoid the negation. May be we are splitting hair. :-)","commit_id":"43139ee033669dce5b09e66932a75c18b62f2d27"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"706613c713488334704ba371a9f197230f874051","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        if not cfg.CONF.allow_overlapping_ips:"},{"line_number":691,"context_line":"            subnet_list \u003d self._get_all_subnets(context)"},{"line_number":692,"context_line":"        else:"},{"line_number":693,"context_line":"            subnet_list \u003d network.subnets"},{"line_number":694,"context_line":"        for subnet in subnet_list:"},{"line_number":695,"context_line":"            if (netaddr.IPSet([subnet.cidr]) \u0026 new_subnet_ipset):"},{"line_number":696,"context_line":"                # don\u0027t give out details of the overlapping subnet"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B8Qg%3D","line":693,"in_reply_to":"AAAAM3%2F%2B8Rg%3D","updated":"2013-02-13 19:41:39.000000000","message":"I agree with Nachi about changing the logic to remove the NOT, but think that the explicit assignment form is better than the one liner (it\u0027s 100 chars long and requires wrapping).","commit_id":"43139ee033669dce5b09e66932a75c18b62f2d27"}]}
