)]}'
{"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b887fc9ccc3fc80ab720d750e09f38414fe59731","unresolved":false,"context_lines":[{"line_number":598,"context_line":"    def list_routes(self, ip_version, **kwargs):"},{"line_number":599,"context_line":"        args \u003d [\u0027list\u0027]"},{"line_number":600,"context_line":"        args +\u003d self._dev_args()"},{"line_number":601,"context_line":"        args +\u003d self._table_args()"},{"line_number":602,"context_line":"        for k, v in kwargs.items():"},{"line_number":603,"context_line":"            args +\u003d [k, v]"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_21252908","line":601,"updated":"2015-09-04 00:21:36.000000000","message":"args.extend(kwargs.items()) should work instead of the iteration","commit_id":"8706e0ec66de20517a9edfd0220eab452e757382"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"4ad1803ca44eeeee8dd5428e9947fc2191f5d673","unresolved":false,"context_lines":[{"line_number":598,"context_line":"    def list_routes(self, ip_version, **kwargs):"},{"line_number":599,"context_line":"        args \u003d [\u0027list\u0027]"},{"line_number":600,"context_line":"        args +\u003d self._dev_args()"},{"line_number":601,"context_line":"        args +\u003d self._table_args()"},{"line_number":602,"context_line":"        for k, v in kwargs.items():"},{"line_number":603,"context_line":"            args +\u003d [k, v]"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_f210a0ad","line":601,"in_reply_to":"da20952f_21252908","updated":"2015-09-09 21:09:04.000000000","message":"Done.  Seems obvious now that you point it out.  :)","commit_id":"8706e0ec66de20517a9edfd0220eab452e757382"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3c3857fc1c3c43ed65e919b61dcd0f7a79c80344","unresolved":false,"context_lines":[{"line_number":598,"context_line":"    def list_routes(self, ip_version, **kwargs):"},{"line_number":599,"context_line":"        args \u003d [\u0027list\u0027]"},{"line_number":600,"context_line":"        args +\u003d self._dev_args()"},{"line_number":601,"context_line":"        args +\u003d self._table_args()"},{"line_number":602,"context_line":"        for k, v in kwargs.items():"},{"line_number":603,"context_line":"            args +\u003d [k, v]"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_b5e532dd","line":601,"in_reply_to":"da20952f_75cd5a85","updated":"2015-09-09 21:17:54.000000000","message":"zip thing doesn\u0027t work either.  Maybe I should start proof-reading my comments and trying them out before submitting.","commit_id":"8706e0ec66de20517a9edfd0220eab452e757382"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b5ab01a2fca47a9f6d7a7125db28a4141dcbcf39","unresolved":false,"context_lines":[{"line_number":598,"context_line":"    def list_routes(self, ip_version, **kwargs):"},{"line_number":599,"context_line":"        args \u003d [\u0027list\u0027]"},{"line_number":600,"context_line":"        args +\u003d self._dev_args()"},{"line_number":601,"context_line":"        args +\u003d self._table_args()"},{"line_number":602,"context_line":"        for k, v in kwargs.items():"},{"line_number":603,"context_line":"            args +\u003d [k, v]"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_eb263015","line":601,"in_reply_to":"da20952f_b5e532dd","updated":"2015-09-11 05:05:27.000000000","message":"whoops, i wasn\u0027t paying close attention to the +\u003d","commit_id":"8706e0ec66de20517a9edfd0220eab452e757382"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"19dc32101a3bd90b9c7f3f146dc95c5563ac51e9","unresolved":false,"context_lines":[{"line_number":598,"context_line":"    def list_routes(self, ip_version, **kwargs):"},{"line_number":599,"context_line":"        args \u003d [\u0027list\u0027]"},{"line_number":600,"context_line":"        args +\u003d self._dev_args()"},{"line_number":601,"context_line":"        args +\u003d self._table_args()"},{"line_number":602,"context_line":"        for k, v in kwargs.items():"},{"line_number":603,"context_line":"            args +\u003d [k, v]"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_f8fddf08","line":601,"in_reply_to":"da20952f_b5e532dd","updated":"2015-09-09 21:34:29.000000000","message":"you can do:\n\n args.extend(x for xx in kwargs.items() for x in xx)","commit_id":"8706e0ec66de20517a9edfd0220eab452e757382"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"5fc0fb9d2f700abef071b3a353051901184fc1a9","unresolved":false,"context_lines":[{"line_number":598,"context_line":"    def list_routes(self, ip_version, **kwargs):"},{"line_number":599,"context_line":"        args \u003d [\u0027list\u0027]"},{"line_number":600,"context_line":"        args +\u003d self._dev_args()"},{"line_number":601,"context_line":"        args +\u003d self._table_args()"},{"line_number":602,"context_line":"        for k, v in kwargs.items():"},{"line_number":603,"context_line":"            args +\u003d [k, v]"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_98c56891","line":601,"in_reply_to":"da20952f_eb263015","updated":"2015-09-11 21:53:38.000000000","message":"I think I\u0027ll keep it like it is if that\u0027s ok.","commit_id":"8706e0ec66de20517a9edfd0220eab452e757382"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9a4caf47059949d77decf1f1b9cb5cd6825c70a5","unresolved":false,"context_lines":[{"line_number":598,"context_line":"    def list_routes(self, ip_version, **kwargs):"},{"line_number":599,"context_line":"        args \u003d [\u0027list\u0027]"},{"line_number":600,"context_line":"        args +\u003d self._dev_args()"},{"line_number":601,"context_line":"        args +\u003d self._table_args()"},{"line_number":602,"context_line":"        for k, v in kwargs.items():"},{"line_number":603,"context_line":"            args +\u003d [k, v]"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_75cd5a85","line":601,"in_reply_to":"da20952f_f210a0ad","updated":"2015-09-09 21:16:44.000000000","message":"Except that it doesn\u0027t work.  :(  It appends each item (k, v) pair as a tuple to args.  That isn\u0027t right, it needs to append k and v independently.\n\nI could do some zip magic with kwargs.keys() and kwargs.values() again if you want.  :)","commit_id":"8706e0ec66de20517a9edfd0220eab452e757382"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b887fc9ccc3fc80ab720d750e09f38414fe59731","unresolved":false,"context_lines":[{"line_number":702,"context_line":"            args +\u003d [\u0027via\u0027, via]"},{"line_number":703,"context_line":"        args +\u003d self._dev_args()"},{"line_number":704,"context_line":"        args +\u003d self._table_args(table)"},{"line_number":705,"context_line":"        for k, v in kwargs.items():"},{"line_number":706,"context_line":"            args +\u003d [k, v]"},{"line_number":707,"context_line":"        self._as_root([ip_version], tuple(args))"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_c11d4dbf","line":705,"updated":"2015-09-04 00:21:36.000000000","message":"ditto","commit_id":"8706e0ec66de20517a9edfd0220eab452e757382"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9a4caf47059949d77decf1f1b9cb5cd6825c70a5","unresolved":false,"context_lines":[{"line_number":702,"context_line":"            args +\u003d [\u0027via\u0027, via]"},{"line_number":703,"context_line":"        args +\u003d self._dev_args()"},{"line_number":704,"context_line":"        args +\u003d self._table_args(table)"},{"line_number":705,"context_line":"        for k, v in kwargs.items():"},{"line_number":706,"context_line":"            args +\u003d [k, v]"},{"line_number":707,"context_line":"        self._as_root([ip_version], tuple(args))"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_35c7e265","line":705,"in_reply_to":"da20952f_95d7ce4e","updated":"2015-09-09 21:16:44.000000000","message":"ditto","commit_id":"8706e0ec66de20517a9edfd0220eab452e757382"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"4ad1803ca44eeeee8dd5428e9947fc2191f5d673","unresolved":false,"context_lines":[{"line_number":702,"context_line":"            args +\u003d [\u0027via\u0027, via]"},{"line_number":703,"context_line":"        args +\u003d self._dev_args()"},{"line_number":704,"context_line":"        args +\u003d self._table_args(table)"},{"line_number":705,"context_line":"        for k, v in kwargs.items():"},{"line_number":706,"context_line":"            args +\u003d [k, v]"},{"line_number":707,"context_line":"        self._as_root([ip_version], tuple(args))"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_95d7ce4e","line":705,"in_reply_to":"da20952f_c11d4dbf","updated":"2015-09-09 21:09:04.000000000","message":"Done","commit_id":"8706e0ec66de20517a9edfd0220eab452e757382"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b887fc9ccc3fc80ab720d750e09f38414fe59731","unresolved":false,"context_lines":[{"line_number":713,"context_line":"            args +\u003d [\u0027via\u0027, via]"},{"line_number":714,"context_line":"        args +\u003d self._dev_args()"},{"line_number":715,"context_line":"        args +\u003d self._table_args(table)"},{"line_number":716,"context_line":"        for k, v in kwargs.items():"},{"line_number":717,"context_line":"            args +\u003d [k, v]"},{"line_number":718,"context_line":"        self._as_root([ip_version], tuple(args))"},{"line_number":719,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_e11ad1c5","line":716,"updated":"2015-09-04 00:21:36.000000000","message":"ditto","commit_id":"8706e0ec66de20517a9edfd0220eab452e757382"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9a4caf47059949d77decf1f1b9cb5cd6825c70a5","unresolved":false,"context_lines":[{"line_number":713,"context_line":"            args +\u003d [\u0027via\u0027, via]"},{"line_number":714,"context_line":"        args +\u003d self._dev_args()"},{"line_number":715,"context_line":"        args +\u003d self._table_args(table)"},{"line_number":716,"context_line":"        for k, v in kwargs.items():"},{"line_number":717,"context_line":"            args +\u003d [k, v]"},{"line_number":718,"context_line":"        self._as_root([ip_version], tuple(args))"},{"line_number":719,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_15a3beb2","line":716,"in_reply_to":"da20952f_55e13629","updated":"2015-09-09 21:16:44.000000000","message":"ditto","commit_id":"8706e0ec66de20517a9edfd0220eab452e757382"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"4ad1803ca44eeeee8dd5428e9947fc2191f5d673","unresolved":false,"context_lines":[{"line_number":713,"context_line":"            args +\u003d [\u0027via\u0027, via]"},{"line_number":714,"context_line":"        args +\u003d self._dev_args()"},{"line_number":715,"context_line":"        args +\u003d self._table_args(table)"},{"line_number":716,"context_line":"        for k, v in kwargs.items():"},{"line_number":717,"context_line":"            args +\u003d [k, v]"},{"line_number":718,"context_line":"        self._as_root([ip_version], tuple(args))"},{"line_number":719,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_55e13629","line":716,"in_reply_to":"da20952f_e11ad1c5","updated":"2015-09-09 21:09:04.000000000","message":"Done","commit_id":"8706e0ec66de20517a9edfd0220eab452e757382"}]}