)]}'
{"neutron/db/ipam_backend_mixin.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1b1b758988fbcf13026780f2ab32a591747e5132","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        # NOTE: ROUTER_INTERFACE_OWNERS does not include the SNAT"},{"line_number":359,"context_line":"        # ports for DVR routers so including ROUTER_INTERFACE_OWNERS_SNAT,"},{"line_number":360,"context_line":"        # also ROUTER_INTERFACE_OWNERS_SNAT is a superset of"},{"line_number":361,"context_line":"        # ROUTER_INTERFACE_OWNERS."},{"line_number":362,"context_line":"        if device_owner in constants.ROUTER_INTERFACE_OWNERS_SNAT:"},{"line_number":363,"context_line":"            return True"},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_1186b716","line":361,"updated":"2015-09-08 14:49:32.000000000","message":"This comment is a little confusing now as it\u0027s talking about what *was* here, it should just describe why *SNAT is used.  Perhaps \"NOTE: Need to check the SNAT ports for DVR routers here since they consume an IP\" ?","commit_id":"aa46439830fe76f26ef4d31c1a44688081b988a2"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e02fe63863bdf270015dadfcc2fbb8178e9e7b3d","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        # NOTE: ROUTER_INTERFACE_OWNERS does not include the SNAT"},{"line_number":359,"context_line":"        # ports for DVR routers so including ROUTER_INTERFACE_OWNERS_SNAT,"},{"line_number":360,"context_line":"        # also ROUTER_INTERFACE_OWNERS_SNAT is a superset of"},{"line_number":361,"context_line":"        # ROUTER_INTERFACE_OWNERS."},{"line_number":362,"context_line":"        if device_owner in constants.ROUTER_INTERFACE_OWNERS_SNAT:"},{"line_number":363,"context_line":"            return True"},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_449f7d65","line":361,"in_reply_to":"da20952f_1186b716","updated":"2015-09-08 19:23:34.000000000","message":"Done","commit_id":"aa46439830fe76f26ef4d31c1a44688081b988a2"}],"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1b1b758988fbcf13026780f2ab32a591747e5132","unresolved":false,"context_lines":[{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        # NOTE: For IPv6 additional subnets we need to update the"},{"line_number":309,"context_line":"        # CSNAT ports with respective IPv6 subnets"},{"line_number":310,"context_line":"        if subnets and port and not new_port:"},{"line_number":311,"context_line":"            fixed_ip \u003d {\u0027subnet_id\u0027: subnets[0][\u0027id\u0027]}"},{"line_number":312,"context_line":"            if subnets[0][\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":313,"context_line":"                # Add new prefix to an existing ipv6 csnat port with the"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_d67fd515","line":310,"updated":"2015-09-08 14:49:32.000000000","message":"nit: this could be \u0027elif subnets and port:\u0027 since then you wouldn\u0027t need to check if new_port is set.","commit_id":"aa46439830fe76f26ef4d31c1a44688081b988a2"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e02fe63863bdf270015dadfcc2fbb8178e9e7b3d","unresolved":false,"context_lines":[{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        # NOTE: For IPv6 additional subnets we need to update the"},{"line_number":309,"context_line":"        # CSNAT ports with respective IPv6 subnets"},{"line_number":310,"context_line":"        if subnets and port and not new_port:"},{"line_number":311,"context_line":"            fixed_ip \u003d {\u0027subnet_id\u0027: subnets[0][\u0027id\u0027]}"},{"line_number":312,"context_line":"            if subnets[0][\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":313,"context_line":"                # Add new prefix to an existing ipv6 csnat port with the"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_84efd5e8","line":310,"in_reply_to":"da20952f_d67fd515","updated":"2015-09-08 19:23:34.000000000","message":"Done","commit_id":"aa46439830fe76f26ef4d31c1a44688081b988a2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1b1b758988fbcf13026780f2ab32a591747e5132","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                    fixed_ips \u003d ("},{"line_number":372,"context_line":"                        [fixedip for fixedip in"},{"line_number":373,"context_line":"                            cs_port[\u0027port\u0027][\u0027fixed_ips\u0027]"},{"line_number":374,"context_line":"                            if fixedip[\u0027subnet_id\u0027] !\u003d subnet_id])"},{"line_number":375,"context_line":"                    self._core_plugin.update_port("},{"line_number":376,"context_line":"                        context.elevated(),"},{"line_number":377,"context_line":"                        cs_port[\u0027port_id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_c755ddc2","line":374,"updated":"2015-09-08 14:49:32.000000000","message":"Won\u0027t this find all the fixed IPs not in the subnet?  And if not None will imply there was \u003e1 subnet?  It seems to me like the above cs_port_subnets check isn\u0027t required if that\u0027s the case, which simplifies this code.","commit_id":"aa46439830fe76f26ef4d31c1a44688081b988a2"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"f29f9ee5fdfe6d86753b6bac8362127873436545","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                    fixed_ips \u003d ("},{"line_number":372,"context_line":"                        [fixedip for fixedip in"},{"line_number":373,"context_line":"                            cs_port[\u0027port\u0027][\u0027fixed_ips\u0027]"},{"line_number":374,"context_line":"                            if fixedip[\u0027subnet_id\u0027] !\u003d subnet_id])"},{"line_number":375,"context_line":"                    self._core_plugin.update_port("},{"line_number":376,"context_line":"                        context.elevated(),"},{"line_number":377,"context_line":"                        cs_port[\u0027port_id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_e950e1d6","line":374,"in_reply_to":"da20952f_04b2e506","updated":"2015-09-08 23:19:52.000000000","message":"Yes I got it. addressed your review comments in my latest patch.","commit_id":"aa46439830fe76f26ef4d31c1a44688081b988a2"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e02fe63863bdf270015dadfcc2fbb8178e9e7b3d","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                    fixed_ips \u003d ("},{"line_number":372,"context_line":"                        [fixedip for fixedip in"},{"line_number":373,"context_line":"                            cs_port[\u0027port\u0027][\u0027fixed_ips\u0027]"},{"line_number":374,"context_line":"                            if fixedip[\u0027subnet_id\u0027] !\u003d subnet_id])"},{"line_number":375,"context_line":"                    self._core_plugin.update_port("},{"line_number":376,"context_line":"                        context.elevated(),"},{"line_number":377,"context_line":"                        cs_port[\u0027port_id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_04b2e506","line":374,"in_reply_to":"da20952f_c755ddc2","updated":"2015-09-08 19:23:34.000000000","message":"Which line of code are you saying that will find all the fixed IPs not in the subnet?","commit_id":"aa46439830fe76f26ef4d31c1a44688081b988a2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1b1b758988fbcf13026780f2ab32a591747e5132","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                        context.elevated(),"},{"line_number":377,"context_line":"                        cs_port[\u0027port_id\u0027],"},{"line_number":378,"context_line":"                        {\u0027port\u0027:"},{"line_number":379,"context_line":"                            {\u0027fixed_ips\u0027: fixed_ips}})"},{"line_number":380,"context_line":"                else:"},{"line_number":381,"context_line":"                    # Single prefix port - go ahead and delete the port"},{"line_number":382,"context_line":"                    self.delete_csnat_router_interface_ports("}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_a73c69c0","line":379,"updated":"2015-09-08 14:49:32.000000000","message":"If there was a return here, both the (duplicate) lines below could move out from under the \u0027if cs_port\u0027 and not be duplicates :)","commit_id":"aa46439830fe76f26ef4d31c1a44688081b988a2"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e02fe63863bdf270015dadfcc2fbb8178e9e7b3d","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                        context.elevated(),"},{"line_number":377,"context_line":"                        cs_port[\u0027port_id\u0027],"},{"line_number":378,"context_line":"                        {\u0027port\u0027:"},{"line_number":379,"context_line":"                            {\u0027fixed_ips\u0027: fixed_ips}})"},{"line_number":380,"context_line":"                else:"},{"line_number":381,"context_line":"                    # Single prefix port - go ahead and delete the port"},{"line_number":382,"context_line":"                    self.delete_csnat_router_interface_ports("}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_c4cced8c","line":379,"in_reply_to":"da20952f_a73c69c0","updated":"2015-09-08 19:23:34.000000000","message":"Done","commit_id":"aa46439830fe76f26ef4d31c1a44688081b988a2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fe215826b4a89f5dd1d647d23edd422060dd1643","unresolved":false,"context_lines":[{"line_number":382,"context_line":"                        {\u0027port\u0027:"},{"line_number":383,"context_line":"                            {\u0027fixed_ips\u0027: fixed_ips}})"},{"line_number":384,"context_line":"                    return True"},{"line_number":385,"context_line":"            else:"},{"line_number":386,"context_line":"                return False"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def _check_dvr_router_remove_required_and_notify_agent("}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_2a0fa72f","line":385,"updated":"2015-09-09 01:18:06.000000000","message":"I don\u0027t think you need the else here as you want to return False in all other cases.  You could even just move the self.delete_csnat_router_interface_ports() call back here too - I did that in a test patch and it passed the unit tests.","commit_id":"3ac2e3cbb06812c1bc34c1a39197f3ee1acabbfd"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"bc64297444be421169be52d3917fe59c386d3fe0","unresolved":false,"context_lines":[{"line_number":382,"context_line":"                        {\u0027port\u0027:"},{"line_number":383,"context_line":"                            {\u0027fixed_ips\u0027: fixed_ips}})"},{"line_number":384,"context_line":"                    return True"},{"line_number":385,"context_line":"            else:"},{"line_number":386,"context_line":"                return False"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def _check_dvr_router_remove_required_and_notify_agent("}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_f7fd173c","line":385,"in_reply_to":"da20952f_2a0fa72f","updated":"2015-09-09 04:53:24.000000000","message":"Yes I will remove the else, but let me keep the delete_csnat_router_interface_ports as it is for now. I think it does not hurt.","commit_id":"3ac2e3cbb06812c1bc34c1a39197f3ee1acabbfd"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"a60d61b2db69d20a002c1bf27afd47806857c829","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def _check_for_multiprefix_csnat_port_and_update("},{"line_number":356,"context_line":"        self, context, router, subnets, port):"},{"line_number":357,"context_line":"        \"\"\"Checks if the csnat port contains multiple ipv6 prefix"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        If the csnat port contains multiple ipv6 prefix for the given"},{"line_number":360,"context_line":"        subnet when a router interface is deleted, make sure we don\u0027t"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_419d0aba","line":357,"updated":"2015-09-09 14:12:36.000000000","message":"prefix -\u003e prefixes?","commit_id":"708c59308db8f30904f6fe70bd3c90f89fda8021"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"0fcbbe976df3f46642cadc43cafd978e1602b28b","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def _check_for_multiprefix_csnat_port_and_update("},{"line_number":356,"context_line":"        self, context, router, subnets, port):"},{"line_number":357,"context_line":"        \"\"\"Checks if the csnat port contains multiple ipv6 prefix"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        If the csnat port contains multiple ipv6 prefix for the given"},{"line_number":360,"context_line":"        subnet when a router interface is deleted, make sure we don\u0027t"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_f00ae678","line":357,"in_reply_to":"da20952f_419d0aba","updated":"2015-09-09 15:57:53.000000000","message":"Done","commit_id":"708c59308db8f30904f6fe70bd3c90f89fda8021"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"a60d61b2db69d20a002c1bf27afd47806857c829","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        self, context, router, subnets, port):"},{"line_number":357,"context_line":"        \"\"\"Checks if the csnat port contains multiple ipv6 prefix"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        If the csnat port contains multiple ipv6 prefix for the given"},{"line_number":360,"context_line":"        subnet when a router interface is deleted, make sure we don\u0027t"},{"line_number":361,"context_line":"        delete the port and just update it with the right fixed_ip."},{"line_number":362,"context_line":"        This function returns true if it is a multiprefix port else"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_01a7120c","line":359,"updated":"2015-09-09 14:12:36.000000000","message":"prefix -\u003e prefixes","commit_id":"708c59308db8f30904f6fe70bd3c90f89fda8021"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"0fcbbe976df3f46642cadc43cafd978e1602b28b","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        self, context, router, subnets, port):"},{"line_number":357,"context_line":"        \"\"\"Checks if the csnat port contains multiple ipv6 prefix"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        If the csnat port contains multiple ipv6 prefix for the given"},{"line_number":360,"context_line":"        subnet when a router interface is deleted, make sure we don\u0027t"},{"line_number":361,"context_line":"        delete the port and just update it with the right fixed_ip."},{"line_number":362,"context_line":"        This function returns true if it is a multiprefix port else"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_100e7a8c","line":359,"in_reply_to":"da20952f_01a7120c","updated":"2015-09-09 15:57:53.000000000","message":"Done","commit_id":"708c59308db8f30904f6fe70bd3c90f89fda8021"}],"neutron/tests/functional/services/l3_router/test_l3_dvr_router_plugin.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1b1b758988fbcf13026780f2ab32a591747e5132","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        self.assertEqual("},{"line_number":221,"context_line":"            1, len(snat_router_intfs[router1[\u0027id\u0027]]))"},{"line_number":222,"context_line":"        self.assertEqual("},{"line_number":223,"context_line":"            2, len(fixed_ips))"},{"line_number":224,"context_line":"        # Now delete the router interface and it should update the"},{"line_number":225,"context_line":"        # SNAT port with the right fixed_ips instead of deleting it."},{"line_number":226,"context_line":"        self.l3_plugin.remove_router_interface("}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_2c859e58","line":223,"updated":"2015-09-08 14:49:32.000000000","message":"nit: this could be on one line, others in this method as well.","commit_id":"aa46439830fe76f26ef4d31c1a44688081b988a2"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"e02fe63863bdf270015dadfcc2fbb8178e9e7b3d","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        self.assertEqual("},{"line_number":221,"context_line":"            1, len(snat_router_intfs[router1[\u0027id\u0027]]))"},{"line_number":222,"context_line":"        self.assertEqual("},{"line_number":223,"context_line":"            2, len(fixed_ips))"},{"line_number":224,"context_line":"        # Now delete the router interface and it should update the"},{"line_number":225,"context_line":"        # SNAT port with the right fixed_ips instead of deleting it."},{"line_number":226,"context_line":"        self.l3_plugin.remove_router_interface("}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_64a401b9","line":223,"in_reply_to":"da20952f_2c859e58","updated":"2015-09-08 19:23:34.000000000","message":"Done","commit_id":"aa46439830fe76f26ef4d31c1a44688081b988a2"}]}
