)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"77204a7af646716c8eeee4cb5cf92bf5332533cd","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This patch attempts to fix the above gaps by fetching the network information"},{"line_number":24,"context_line":"selectively instead of getting all the details all the while."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: If6df55df2a362813d63405beba62518f38841bff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_1df01c90","line":25,"updated":"2015-09-08 07:03:43.000000000","message":"can you provide a bug reference?","commit_id":"62d2d938a234c86c59a12374a54819a82440c744"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"5cc5a48330ebbb3b3ee156b38f4ea79ccecdaed5","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This patch attempts to fix the above gaps by fetching the network information"},{"line_number":24,"context_line":"selectively instead of getting all the details all the while."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: If6df55df2a362813d63405beba62518f38841bff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_b8449e72","line":25,"in_reply_to":"da20952f_1df01c90","updated":"2015-09-08 07:52:15.000000000","message":"Err...Sorry! \nDone","commit_id":"62d2d938a234c86c59a12374a54819a82440c744"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"77204a7af646716c8eeee4cb5cf92bf5332533cd","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        1.1 - Added get_active_networks_info, create_dhcp_port,"},{"line_number":400,"context_line":"              and update_dhcp_port methods."},{"line_number":401,"context_line":"        1.2 - Added get_active_networks method, updated the args list"},{"line_number":402,"context_line":"              of get_active_networks_info method"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    \"\"\""},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ddbdc468","line":402,"updated":"2015-09-08 07:03:43.000000000","message":"1.2 has already been taken for get_dhcp_port removal","commit_id":"62d2d938a234c86c59a12374a54819a82440c744"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"5cc5a48330ebbb3b3ee156b38f4ea79ccecdaed5","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        1.1 - Added get_active_networks_info, create_dhcp_port,"},{"line_number":400,"context_line":"              and update_dhcp_port methods."},{"line_number":401,"context_line":"        1.2 - Added get_active_networks method, updated the args list"},{"line_number":402,"context_line":"              of get_active_networks_info method"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    \"\"\""},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_733709e3","line":402,"in_reply_to":"da20952f_ddbdc468","updated":"2015-09-08 07:52:15.000000000","message":"To be honest, I was actually really unsure of what version to use. Server side history had 1.2 already, while the agent side is still having 1.1. \nAnd get_active_networks handler code is already present in the server side. So, wasnt sure if I had to bump up the version further. \n\nAny inputs would help.  Should I make this 1.3 on either side??","commit_id":"62d2d938a234c86c59a12374a54819a82440c744"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"802fe5f25f1c770d3770e77ce516f9b37ffb71f3","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                net_ids \u003d only_nets | unknown_network_ids"},{"line_number":167,"context_line":"            else:"},{"line_number":168,"context_line":"                net_ids \u003d active_network_ids"},{"line_number":169,"context_line":"            net_ids \u003d list(net_ids)"},{"line_number":170,"context_line":"            active_networks \u003d self.plugin_rpc.get_active_networks_info(net_ids)"},{"line_number":171,"context_line":"            for network in active_networks:"},{"line_number":172,"context_line":"                pool.spawn(self.safe_configure_dhcp_for_network, network)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_9570e1dd","line":169,"updated":"2015-09-17 17:37:58.000000000","message":"nit:  Just convert to a list when passing it to get_active_networks_info.  Not a big deal but I don\u0027t like statements like this that change the nature of what a local variable is pointing to (i.e. change set to a list permanently.)","commit_id":"72b6ecf0b8958d2262469e0f43604f1303953ad3"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"6bf93b59229e4c1b596c8ac2daef509dc30f1a60","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                net_ids \u003d only_nets | unknown_network_ids"},{"line_number":167,"context_line":"            else:"},{"line_number":168,"context_line":"                net_ids \u003d active_network_ids"},{"line_number":169,"context_line":"            net_ids \u003d list(net_ids)"},{"line_number":170,"context_line":"            active_networks \u003d self.plugin_rpc.get_active_networks_info(net_ids)"},{"line_number":171,"context_line":"            for network in active_networks:"},{"line_number":172,"context_line":"                pool.spawn(self.safe_configure_dhcp_for_network, network)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_4f7a7589","line":169,"in_reply_to":"ba15a1d1_9570e1dd","updated":"2015-09-18 06:11:08.000000000","message":"Makes sense. Done","commit_id":"72b6ecf0b8958d2262469e0f43604f1303953ad3"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"af318c38197307e61d1f6f172b7a9643aaaff584","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        known_network_ids \u003d set(self.cache.get_network_ids())"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        try:"},{"line_number":157,"context_line":"            active_network_ids \u003d set(self.plugin_rpc.get_active_network_ids())"},{"line_number":158,"context_line":"            for deleted_id in known_network_ids - active_network_ids:"},{"line_number":159,"context_line":"                try:"},{"line_number":160,"context_line":"                    self.disable_dhcp_helper(deleted_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_8dc0717e","line":157,"updated":"2015-09-19 01:05:50.000000000","message":"adding a new RPC call is not good","commit_id":"343cfe92df4ce0da0eba4168623dffdd3d997708"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"7a14c4e09534d52e3e375dcb2fcf74d6b3bcbe8e","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        known_network_ids \u003d set(self.cache.get_network_ids())"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        try:"},{"line_number":157,"context_line":"            active_network_ids \u003d set(self.plugin_rpc.get_active_network_ids())"},{"line_number":158,"context_line":"            for deleted_id in known_network_ids - active_network_ids:"},{"line_number":159,"context_line":"                try:"},{"line_number":160,"context_line":"                    self.disable_dhcp_helper(deleted_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_4a8eaa28","line":157,"in_reply_to":"ba15a1d1_8dc0717e","updated":"2015-09-21 09:22:25.000000000","message":"Done","commit_id":"343cfe92df4ce0da0eba4168623dffdd3d997708"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"af5d0292b3f529c83cb5456caf10261d9e4097f8","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        known_network_ids \u003d set(self.cache.get_network_ids())"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        try:"},{"line_number":157,"context_line":"            active_network_ids \u003d set(self.plugin_rpc.get_active_networks())"},{"line_number":158,"context_line":"            for deleted_id in known_network_ids - active_network_ids:"},{"line_number":159,"context_line":"                try:"},{"line_number":160,"context_line":"                    self.disable_dhcp_helper(deleted_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_6c5d2414","line":157,"updated":"2015-11-03 08:23:35.000000000","message":"it add one more RPC call, does it really needed?","commit_id":"ced707503148d7abfc4baea174e1cac6e1b2aa51"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"1758dc720ce8ffafef6dc8287a6f4f0440046dff","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        known_network_ids \u003d set(self.cache.get_network_ids())"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        try:"},{"line_number":157,"context_line":"            active_network_ids \u003d set(self.plugin_rpc.get_active_networks())"},{"line_number":158,"context_line":"            for deleted_id in known_network_ids - active_network_ids:"},{"line_number":159,"context_line":"                try:"},{"line_number":160,"context_line":"                    self.disable_dhcp_helper(deleted_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_8c28c0e3","line":157,"in_reply_to":"1a26ad4f_6c5d2414","updated":"2015-11-03 08:37:23.000000000","message":"Without this fix, we were stuck with 600 networks. With the fix, we comfortably could scale beyond 2000 networks.\n\nSo, given the benefits we get, I feel it definitely adds value.","commit_id":"ced707503148d7abfc4baea174e1cac6e1b2aa51"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"6c3ace72aed53786f043b15b533286ffc64fd27a","unresolved":false,"context_lines":[{"line_number":413,"context_line":"                version\u003d\u00271.0\u0027)"},{"line_number":414,"context_line":"        self.client \u003d n_rpc.get_client(target)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def get_active_networks(self):"},{"line_number":417,"context_line":"        \"\"\"Make a remote process call to retrieve all active network-ids.\"\"\""},{"line_number":418,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.2\u0027)"},{"line_number":419,"context_line":"        return cctxt.call(self.context, \u0027get_active_networks\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_498e4d7a","line":416,"range":{"start_line":416,"start_character":8,"end_line":416,"end_character":27},"updated":"2015-12-19 07:17:23.000000000","message":"So this method is just try to get network ids not network themselves. I think you should modify it name.","commit_id":"408888d520531592b6b1155d5a44d42f915d669b"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"e7481cbef4fc5b065b0f37089f75fe369b296a70","unresolved":false,"context_lines":[{"line_number":413,"context_line":"                version\u003d\u00271.0\u0027)"},{"line_number":414,"context_line":"        self.client \u003d n_rpc.get_client(target)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def get_active_networks(self):"},{"line_number":417,"context_line":"        \"\"\"Make a remote process call to retrieve all active network-ids.\"\"\""},{"line_number":418,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.2\u0027)"},{"line_number":419,"context_line":"        return cctxt.call(self.context, \u0027get_active_networks\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_dcdae4e7","line":416,"range":{"start_line":416,"start_character":8,"end_line":416,"end_character":27},"in_reply_to":"3a7e1126_498e4d7a","updated":"2015-12-21 06:15:55.000000000","message":"Done","commit_id":"408888d520531592b6b1155d5a44d42f915d669b"}],"neutron/api/rpc/handlers/dhcp_rpc.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"77204a7af646716c8eeee4cb5cf92bf5332533cd","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":112,"context_line":"        # NOTE(arosen): This method is no longer used by the DHCP agent but is"},{"line_number":113,"context_line":"        # left so that neutron-dhcp-agents will still continue to work if"},{"line_number":114,"context_line":"        # neutron-server is upgraded and not the agent."},{"line_number":115,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":116,"context_line":"        LOG.debug(\u0027get_active_networks requested from %s\u0027, host)"},{"line_number":117,"context_line":"        nets \u003d self._get_active_networks(context, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_1da81c1f","line":114,"updated":"2015-09-08 07:03:43.000000000","message":"this comment needs an update.","commit_id":"62d2d938a234c86c59a12374a54819a82440c744"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"5cc5a48330ebbb3b3ee156b38f4ea79ccecdaed5","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":112,"context_line":"        # NOTE(arosen): This method is no longer used by the DHCP agent but is"},{"line_number":113,"context_line":"        # left so that neutron-dhcp-agents will still continue to work if"},{"line_number":114,"context_line":"        # neutron-server is upgraded and not the agent."},{"line_number":115,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":116,"context_line":"        LOG.debug(\u0027get_active_networks requested from %s\u0027, host)"},{"line_number":117,"context_line":"        nets \u003d self._get_active_networks(context, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_f84e9694","line":114,"in_reply_to":"da20952f_1da81c1f","updated":"2015-09-08 07:52:15.000000000","message":"Done","commit_id":"62d2d938a234c86c59a12374a54819a82440c744"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"802fe5f25f1c770d3770e77ce516f9b37ffb71f3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":66,"context_line":"        net_ids \u003d kwargs.get(\u0027net_ids\u0027)"},{"line_number":67,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":68,"context_line":"        if not net_ids and utils.is_extension_supported("},{"line_number":69,"context_line":"            plugin, constants.DHCP_AGENT_SCHEDULER_EXT_ALIAS):"},{"line_number":70,"context_line":"            if cfg.CONF.network_auto_schedule:"},{"line_number":71,"context_line":"                plugin.auto_schedule_networks(context, host)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_4ffcff71","line":68,"updated":"2015-09-17 17:37:58.000000000","message":"Consider \"if net_ids is None\" to distinguish between None and [].","commit_id":"72b6ecf0b8958d2262469e0f43604f1303953ad3"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"6bf93b59229e4c1b596c8ac2daef509dc30f1a60","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":66,"context_line":"        net_ids \u003d kwargs.get(\u0027net_ids\u0027)"},{"line_number":67,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":68,"context_line":"        if not net_ids and utils.is_extension_supported("},{"line_number":69,"context_line":"            plugin, constants.DHCP_AGENT_SCHEDULER_EXT_ALIAS):"},{"line_number":70,"context_line":"            if cfg.CONF.network_auto_schedule:"},{"line_number":71,"context_line":"                plugin.auto_schedule_networks(context, host)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_ef7a6976","line":68,"in_reply_to":"ba15a1d1_4ffcff71","updated":"2015-09-18 06:11:08.000000000","message":"Done","commit_id":"72b6ecf0b8958d2262469e0f43604f1303953ad3"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"802fe5f25f1c770d3770e77ce516f9b37ffb71f3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                context, host)"},{"line_number":74,"context_line":"        else:"},{"line_number":75,"context_line":"            filters \u003d dict(admin_state_up\u003d[True])"},{"line_number":76,"context_line":"            if net_ids:"},{"line_number":77,"context_line":"                filters[\u0027network_id\u0027] \u003d net_ids"},{"line_number":78,"context_line":"            nets \u003d plugin.get_networks(context, filters\u003dfilters)"},{"line_number":79,"context_line":"        return nets"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_af191bd9","line":76,"updated":"2015-09-17 17:37:58.000000000","message":"\"if net_ids is not None\"?","commit_id":"72b6ecf0b8958d2262469e0f43604f1303953ad3"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"6bf93b59229e4c1b596c8ac2daef509dc30f1a60","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                context, host)"},{"line_number":74,"context_line":"        else:"},{"line_number":75,"context_line":"            filters \u003d dict(admin_state_up\u003d[True])"},{"line_number":76,"context_line":"            if net_ids:"},{"line_number":77,"context_line":"                filters[\u0027network_id\u0027] \u003d net_ids"},{"line_number":78,"context_line":"            nets \u003d plugin.get_networks(context, filters\u003dfilters)"},{"line_number":79,"context_line":"        return nets"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_4f883571","line":76,"in_reply_to":"ba15a1d1_af191bd9","updated":"2015-09-18 06:11:08.000000000","message":"Done","commit_id":"72b6ecf0b8958d2262469e0f43604f1303953ad3"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"802fe5f25f1c770d3770e77ce516f9b37ffb71f3","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                             \"could not complete successfully: %(reason)s\"),"},{"line_number":108,"context_line":"                         {\"action\": action, \"net_id\": net_id, \u0027reason\u0027: e})"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def get_active_networks(self, context, **kwargs):"},{"line_number":111,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":112,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":113,"context_line":"        LOG.debug(\u0027get_active_networks requested from %s\u0027, host)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_1ae1609a","line":110,"updated":"2015-09-17 17:37:58.000000000","message":"aside:  Shouldn\u0027t this have been called get_active_network_ids?","commit_id":"72b6ecf0b8958d2262469e0f43604f1303953ad3"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"6bf93b59229e4c1b596c8ac2daef509dc30f1a60","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                             \"could not complete successfully: %(reason)s\"),"},{"line_number":108,"context_line":"                         {\"action\": action, \"net_id\": net_id, \u0027reason\u0027: e})"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def get_active_networks(self, context, **kwargs):"},{"line_number":111,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":112,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":113,"context_line":"        LOG.debug(\u0027get_active_networks requested from %s\u0027, host)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_2f85c158","line":110,"in_reply_to":"ba15a1d1_1ae1609a","updated":"2015-09-18 06:11:08.000000000","message":"Done","commit_id":"72b6ecf0b8958d2262469e0f43604f1303953ad3"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"802fe5f25f1c770d3770e77ce516f9b37ffb71f3","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        net_ids \u003d kwargs.get(\u0027net_ids\u0027)"},{"line_number":129,"context_line":"        LOG.debug(\u0027get_active_networks_info from %s\u0027, host)"},{"line_number":130,"context_line":"        networks \u003d self._get_active_networks(context, **kwargs)"},{"line_number":131,"context_line":"        if not net_ids:"},{"line_number":132,"context_line":"            net_ids \u003d [network[\u0027id\u0027] for network in networks]"},{"line_number":133,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":134,"context_line":"        filters \u003d {\u0027network_id\u0027: net_ids}"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_8fdf770c","line":131,"updated":"2015-09-17 17:37:58.000000000","message":"Consider:  \"if net_ids is None\"","commit_id":"72b6ecf0b8958d2262469e0f43604f1303953ad3"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"6bf93b59229e4c1b596c8ac2daef509dc30f1a60","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        net_ids \u003d kwargs.get(\u0027net_ids\u0027)"},{"line_number":129,"context_line":"        LOG.debug(\u0027get_active_networks_info from %s\u0027, host)"},{"line_number":130,"context_line":"        networks \u003d self._get_active_networks(context, **kwargs)"},{"line_number":131,"context_line":"        if not net_ids:"},{"line_number":132,"context_line":"            net_ids \u003d [network[\u0027id\u0027] for network in networks]"},{"line_number":133,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":134,"context_line":"        filters \u003d {\u0027network_id\u0027: net_ids}"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_cf94458c","line":131,"in_reply_to":"ba15a1d1_8fdf770c","updated":"2015-09-18 06:11:08.000000000","message":"Done","commit_id":"72b6ecf0b8958d2262469e0f43604f1303953ad3"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"64f6e6af358d5190a03008ad1de950105fc6c15f","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def get_active_network_ids(self, context, **kwargs):"},{"line_number":111,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":112,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":113,"context_line":"        LOG.debug(\u0027get_active_network_ids requested from %s\u0027, host)"},{"line_number":114,"context_line":"        nets \u003d self._get_active_networks(context, **kwargs)"},{"line_number":115,"context_line":"        return [net[\u0027id\u0027] for net in nets]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_cdae6998","line":112,"updated":"2015-09-19 01:25:33.000000000","message":"I have the same doubt.","commit_id":"343cfe92df4ce0da0eba4168623dffdd3d997708"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"76c4f315c93b9d8b46e2c32029998d73e703cdf4","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def get_active_network_ids(self, context, **kwargs):"},{"line_number":111,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":112,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":113,"context_line":"        LOG.debug(\u0027get_active_network_ids requested from %s\u0027, host)"},{"line_number":114,"context_line":"        nets \u003d self._get_active_networks(context, **kwargs)"},{"line_number":115,"context_line":"        return [net[\u0027id\u0027] for net in nets]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_68c71a96","line":112,"updated":"2015-09-18 16:51:44.000000000","message":"Just to make sure, we are no longer worried about the scenario in the deleted NOTE where neutron-server is upgraded but dhcp agent is not, causing the old dhcp agent to call get_active_networks which no longer exists?","commit_id":"343cfe92df4ce0da0eba4168623dffdd3d997708"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"7a14c4e09534d52e3e375dcb2fcf74d6b3bcbe8e","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def get_active_network_ids(self, context, **kwargs):"},{"line_number":111,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":112,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":113,"context_line":"        LOG.debug(\u0027get_active_network_ids requested from %s\u0027, host)"},{"line_number":114,"context_line":"        nets \u003d self._get_active_networks(context, **kwargs)"},{"line_number":115,"context_line":"        return [net[\u0027id\u0027] for net in nets]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_8a75a233","line":112,"in_reply_to":"ba15a1d1_cdae6998","updated":"2015-09-21 09:22:25.000000000","message":"Big blunder. Sorry about that.\nReverting back to the old name.","commit_id":"343cfe92df4ce0da0eba4168623dffdd3d997708"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"af5d0292b3f529c83cb5456caf10261d9e4097f8","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":128,"context_line":"        net_ids \u003d kwargs.get(\u0027net_ids\u0027)"},{"line_number":129,"context_line":"        LOG.debug(\u0027get_active_networks_info from %s\u0027, host)"},{"line_number":130,"context_line":"        networks \u003d self._get_active_networks(context, **kwargs)"},{"line_number":131,"context_line":"        if net_ids is None:"},{"line_number":132,"context_line":"            net_ids \u003d [network[\u0027id\u0027] for network in networks]"},{"line_number":133,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_6c8be468","line":130,"updated":"2015-11-03 08:23:35.000000000","message":"I think the key point for this bug is method _get_active_networks, the schedule will consume much time","commit_id":"ced707503148d7abfc4baea174e1cac6e1b2aa51"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"1758dc720ce8ffafef6dc8287a6f4f0440046dff","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":128,"context_line":"        net_ids \u003d kwargs.get(\u0027net_ids\u0027)"},{"line_number":129,"context_line":"        LOG.debug(\u0027get_active_networks_info from %s\u0027, host)"},{"line_number":130,"context_line":"        networks \u003d self._get_active_networks(context, **kwargs)"},{"line_number":131,"context_line":"        if net_ids is None:"},{"line_number":132,"context_line":"            net_ids \u003d [network[\u0027id\u0027] for network in networks]"},{"line_number":133,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_6cd684f2","line":130,"in_reply_to":"1a26ad4f_6c8be468","updated":"2015-11-03 08:37:23.000000000","message":"Very true!","commit_id":"ced707503148d7abfc4baea174e1cac6e1b2aa51"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"6c3ace72aed53786f043b15b533286ffc64fd27a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                             \"could not complete successfully: %(reason)s\"),"},{"line_number":112,"context_line":"                         {\"action\": action, \"net_id\": net_id, \u0027reason\u0027: e})"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def get_active_networks(self, context, **kwargs):"},{"line_number":115,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":116,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":117,"context_line":"        LOG.debug(\u0027get_active_networks requested from %s\u0027, host)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_099da5bb","line":114,"range":{"start_line":114,"start_character":8,"end_line":114,"end_character":27},"updated":"2015-12-19 07:17:23.000000000","message":"I think you should change this method name, like get_active_network_ids.","commit_id":"408888d520531592b6b1155d5a44d42f915d669b"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"e7481cbef4fc5b065b0f37089f75fe369b296a70","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                             \"could not complete successfully: %(reason)s\"),"},{"line_number":112,"context_line":"                         {\"action\": action, \"net_id\": net_id, \u0027reason\u0027: e})"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def get_active_networks(self, context, **kwargs):"},{"line_number":115,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":116,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":117,"context_line":"        LOG.debug(\u0027get_active_networks requested from %s\u0027, host)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_9ce0dc97","line":114,"range":{"start_line":114,"start_character":8,"end_line":114,"end_character":27},"in_reply_to":"3a7e1126_099da5bb","updated":"2015-12-21 06:15:55.000000000","message":"Done","commit_id":"408888d520531592b6b1155d5a44d42f915d669b"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"6c3ace72aed53786f043b15b533286ffc64fd27a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":117,"context_line":"        LOG.debug(\u0027get_active_networks requested from %s\u0027, host)"},{"line_number":118,"context_line":"        nets \u003d self._get_active_networks(context, **kwargs)"},{"line_number":119,"context_line":"        return [net[\u0027id\u0027] for net in nets]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def _group_by_network_id(self, res):"},{"line_number":122,"context_line":"        grouped \u003d {}"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_0984c55b","line":119,"range":{"start_line":119,"start_character":15,"end_line":119,"end_character":42},"updated":"2015-12-19 07:17:23.000000000","message":"Please check list_active_networks_on_active_dhcp_agent [1], I hope you can also modify it, like adding an argument to directly return net_ids.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/agentschedulers_db.py#L434-L441","commit_id":"408888d520531592b6b1155d5a44d42f915d669b"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"e7481cbef4fc5b065b0f37089f75fe369b296a70","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":117,"context_line":"        LOG.debug(\u0027get_active_networks requested from %s\u0027, host)"},{"line_number":118,"context_line":"        nets \u003d self._get_active_networks(context, **kwargs)"},{"line_number":119,"context_line":"        return [net[\u0027id\u0027] for net in nets]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def _group_by_network_id(self, res):"},{"line_number":122,"context_line":"        grouped \u003d {}"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_9cf77c58","line":119,"range":{"start_line":119,"start_character":15,"end_line":119,"end_character":42},"in_reply_to":"3a7e1126_0984c55b","updated":"2015-12-21 06:15:55.000000000","message":"The specified method needs to go through all the networks. This is more for syncing the state rather than for selective network\u0027s information. \nSo, I feel that method need not be touched.","commit_id":"408888d520531592b6b1155d5a44d42f915d669b"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"60dc22f4779006c7d5a6abbc816fb97fe55730f7","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        nets \u003d self._get_active_networks(context, **kwargs)"},{"line_number":119,"context_line":"        return [net[\u0027id\u0027] for net in nets]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def get_active_networks(self, context, **kwargs):"},{"line_number":122,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":123,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":124,"context_line":"        LOG.debug(\u0027get_active_networks requested from %s\u0027, host)"},{"line_number":125,"context_line":"        nets \u003d self._get_active_networks(context, **kwargs)"},{"line_number":126,"context_line":"        return [net[\u0027id\u0027] for net in nets]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _group_by_network_id(self, res):"},{"line_number":129,"context_line":"        grouped \u003d {}"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_0ef560eb","line":126,"range":{"start_line":121,"start_character":3,"end_line":126,"end_character":42},"updated":"2015-12-22 05:12:12.000000000","message":"Why do you keep this method? It seems just a copy from get_active_network_ids, but I also can\u0027t find where will it be used.\n\nMaybe you\u0027re worried about backward compatibility, if so, sorry for my previous comments on PS8 to change RPC method name.\n\nBut at least, I don\u0027t think duplicated code is a good idea.","commit_id":"68ce8ff83964c746bf89c73d67a72815a879b64c"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"4cd98c891e6da7279ea8c34abb26de919a2f544f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        nets \u003d self._get_active_networks(context, **kwargs)"},{"line_number":119,"context_line":"        return [net[\u0027id\u0027] for net in nets]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def get_active_networks(self, context, **kwargs):"},{"line_number":122,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":123,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":124,"context_line":"        LOG.debug(\u0027get_active_networks requested from %s\u0027, host)"},{"line_number":125,"context_line":"        nets \u003d self._get_active_networks(context, **kwargs)"},{"line_number":126,"context_line":"        return [net[\u0027id\u0027] for net in nets]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _group_by_network_id(self, res):"},{"line_number":129,"context_line":"        grouped \u003d {}"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_3ebde301","line":126,"range":{"start_line":121,"start_character":3,"end_line":126,"end_character":42},"in_reply_to":"3a7e1126_0ef560eb","updated":"2015-12-22 08:54:21.000000000","message":"There are quite a good number of dhcp scheduler UTs which are referring to get_active_networks method. They failed as I modified the method name.","commit_id":"68ce8ff83964c746bf89c73d67a72815a879b64c"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"f79e2ee011dea4eaee0df8cd9fd857792a446892","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        nets \u003d self._get_active_networks(context, **kwargs)"},{"line_number":119,"context_line":"        return [net[\u0027id\u0027] for net in nets]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def get_active_networks(self, context, **kwargs):"},{"line_number":122,"context_line":"        \"\"\"Retrieve and return a list of the active network ids.\"\"\""},{"line_number":123,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":124,"context_line":"        LOG.debug(\u0027get_active_networks requested from %s\u0027, host)"},{"line_number":125,"context_line":"        nets \u003d self._get_active_networks(context, **kwargs)"},{"line_number":126,"context_line":"        return [net[\u0027id\u0027] for net in nets]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _group_by_network_id(self, res):"},{"line_number":129,"context_line":"        grouped \u003d {}"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a7b0d38_f6ae3284","line":126,"range":{"start_line":121,"start_character":3,"end_line":126,"end_character":42},"in_reply_to":"3a7e1126_3ebde301","updated":"2015-12-25 08:22:45.000000000","message":"I don\u0027t think it is a good idea, either. The UTs could be fixed then.","commit_id":"68ce8ff83964c746bf89c73d67a72815a879b64c"}]}
