)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"14ed02228bee48ba883d61f13405dbaa5af8c0a6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Clean tun_br_ofports when ovs restarted"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When ovs restarted, previous tunnel ports on tun_br"},{"line_number":10,"context_line":"will disappear. ovs agent will detect ovs restared,"},{"line_number":11,"context_line":"and try to reset tun_br and flows on tun_br, but not"},{"line_number":12,"context_line":"ofports cache on tun_br. That will cause fdb_add_tun"},{"line_number":13,"context_line":"fail to setup_tunnel_port, for ofport cache it checkes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_a4de0b3c","line":10,"updated":"2015-09-04 16:32:51.000000000","message":"nit: \"OVS agent will detect that OVS has restarted\"","commit_id":"c648bd502e1091cd340c0b8c7e24decece5b1178"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"e419923bd0e667101502d57d0e4a5ca4b8898d09","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Clean tun_br_ofports when ovs restarted"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When ovs restarted, previous tunnel ports on tun_br"},{"line_number":10,"context_line":"will disappear. ovs agent will detect ovs restared,"},{"line_number":11,"context_line":"and try to reset tun_br and flows on tun_br, but not"},{"line_number":12,"context_line":"ofports cache on tun_br. That will cause fdb_add_tun"},{"line_number":13,"context_line":"fail to setup_tunnel_port, for ofport cache it checkes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_cbb75e38","line":10,"in_reply_to":"da20952f_a4de0b3c","updated":"2015-09-07 07:03:12.000000000","message":"Done","commit_id":"c648bd502e1091cd340c0b8c7e24decece5b1178"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"14ed02228bee48ba883d61f13405dbaa5af8c0a6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When ovs restarted, previous tunnel ports on tun_br"},{"line_number":10,"context_line":"will disappear. ovs agent will detect ovs restared,"},{"line_number":11,"context_line":"and try to reset tun_br and flows on tun_br, but not"},{"line_number":12,"context_line":"ofports cache on tun_br. That will cause fdb_add_tun"},{"line_number":13,"context_line":"fail to setup_tunnel_port, for ofport cache it checkes"},{"line_number":14,"context_line":"is not updated, and get dirty records."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_e48de331","line":11,"updated":"2015-09-04 16:32:51.000000000","message":"I think the term reset is a bit confusing here, better to be more explicit.\n\n\"and try to create ports and install flows again on tun_br but it will not clear the cache tun_br_ofports.\"","commit_id":"c648bd502e1091cd340c0b8c7e24decece5b1178"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"e419923bd0e667101502d57d0e4a5ca4b8898d09","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When ovs restarted, previous tunnel ports on tun_br"},{"line_number":10,"context_line":"will disappear. ovs agent will detect ovs restared,"},{"line_number":11,"context_line":"and try to reset tun_br and flows on tun_br, but not"},{"line_number":12,"context_line":"ofports cache on tun_br. That will cause fdb_add_tun"},{"line_number":13,"context_line":"fail to setup_tunnel_port, for ofport cache it checkes"},{"line_number":14,"context_line":"is not updated, and get dirty records."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_8b84065e","line":11,"in_reply_to":"da20952f_e48de331","updated":"2015-09-07 07:03:12.000000000","message":"Done","commit_id":"c648bd502e1091cd340c0b8c7e24decece5b1178"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"14ed02228bee48ba883d61f13405dbaa5af8c0a6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When ovs restarted, previous tunnel ports on tun_br"},{"line_number":10,"context_line":"will disappear. ovs agent will detect ovs restared,"},{"line_number":11,"context_line":"and try to reset tun_br and flows on tun_br, but not"},{"line_number":12,"context_line":"ofports cache on tun_br. That will cause fdb_add_tun"},{"line_number":13,"context_line":"fail to setup_tunnel_port, for ofport cache it checkes"},{"line_number":14,"context_line":"is not updated, and get dirty records."},{"line_number":15,"context_line":"This patch is try to fix that."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_a4a04b43","line":12,"updated":"2015-09-04 16:32:51.000000000","message":"Again better more explicit, it took me some time to understand what you meant.\n\n\"fdb_add_tun uses this cache of tunnel ports to determine if a port should be created or not, if it\u0027s present in the cache the port won\u0027t be recreated. Since it receives a cache with stale data not all ports will be re-created and also flow will be installed using stale data.\"","commit_id":"c648bd502e1091cd340c0b8c7e24decece5b1178"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"e419923bd0e667101502d57d0e4a5ca4b8898d09","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When ovs restarted, previous tunnel ports on tun_br"},{"line_number":10,"context_line":"will disappear. ovs agent will detect ovs restared,"},{"line_number":11,"context_line":"and try to reset tun_br and flows on tun_br, but not"},{"line_number":12,"context_line":"ofports cache on tun_br. That will cause fdb_add_tun"},{"line_number":13,"context_line":"fail to setup_tunnel_port, for ofport cache it checkes"},{"line_number":14,"context_line":"is not updated, and get dirty records."},{"line_number":15,"context_line":"This patch is try to fix that."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_ab878a5f","line":12,"in_reply_to":"da20952f_a4a04b43","updated":"2015-09-07 07:03:12.000000000","message":"Done\nThanks :)","commit_id":"c648bd502e1091cd340c0b8c7e24decece5b1178"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3f9744a6176e2a16199b3b45d737d8e867937d09","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean tun_br_ofports when ovs restarted"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When OVS restarted, previous tunnel ports on tun_br"},{"line_number":10,"context_line":"will disappear. OVS agent will detect OVS has restared,"},{"line_number":11,"context_line":"and try to reset tun_br, like recreate patch ports between"},{"line_number":12,"context_line":"int_br and install flows again on tun_br. But when l2population"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da20952f_f0b42683","line":9,"updated":"2015-09-09 18:33:55.000000000","message":"Now that I think more about its, when OVS restarts the ports won\u0027t disappear. Before this patch [1] the tunnel bridge was deleted and re-created in setup_tunnel_br. Now it doesn\u0027t happen anymore. Have you checked that the bug is still there after this merged? Sorry for not noticing before\n\n[1] https://review.openstack.org/#/c/182920","commit_id":"46bd658913f99c18499e4597b3cafd5418f661c6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"7359f102ec6b4fd12b1516649b87db25c11849b4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean tun_br_ofports when ovs restarted"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When OVS restarted, previous tunnel ports on tun_br"},{"line_number":10,"context_line":"will disappear. OVS agent will detect OVS has restared,"},{"line_number":11,"context_line":"and try to reset tun_br, like recreate patch ports between"},{"line_number":12,"context_line":"int_br and install flows again on tun_br. But when l2population"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da20952f_0edc0417","line":9,"in_reply_to":"da20952f_f0b42683","updated":"2015-09-10 03:05:39.000000000","message":"Thanks Rossella.\nI checked again, [1] will handle flows on tun_br, but seems not to tunnel ports on tun_br. So I changed bug #1332450 summary from \"br-tun lost ports/flows\" to \"br-tun lost ports\".","commit_id":"46bd658913f99c18499e4597b3cafd5418f661c6"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3f9744a6176e2a16199b3b45d737d8e867937d09","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Clean tun_br_ofports when ovs restarted"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When OVS restarted, previous tunnel ports on tun_br"},{"line_number":10,"context_line":"will disappear. OVS agent will detect OVS has restared,"},{"line_number":11,"context_line":"and try to reset tun_br, like recreate patch ports between"},{"line_number":12,"context_line":"int_br and install flows again on tun_br. But when l2population"},{"line_number":13,"context_line":"is enabled, tunnel ports will not be created."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da20952f_30113eb0","line":10,"updated":"2015-09-09 18:33:55.000000000","message":"typo: restarted","commit_id":"46bd658913f99c18499e4597b3cafd5418f661c6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"7359f102ec6b4fd12b1516649b87db25c11849b4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Clean tun_br_ofports when ovs restarted"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When OVS restarted, previous tunnel ports on tun_br"},{"line_number":10,"context_line":"will disappear. OVS agent will detect OVS has restared,"},{"line_number":11,"context_line":"and try to reset tun_br, like recreate patch ports between"},{"line_number":12,"context_line":"int_br and install flows again on tun_br. But when l2population"},{"line_number":13,"context_line":"is enabled, tunnel ports will not be created."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da20952f_7bc22455","line":10,"in_reply_to":"da20952f_30113eb0","updated":"2015-09-10 03:05:39.000000000","message":"Done","commit_id":"46bd658913f99c18499e4597b3cafd5418f661c6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"8217b489c8e7532771eef143148854ba94db5e62","unresolved":false,"context_lines":[{"line_number":16,"context_line":"create tunnel ports. It uses tun_br_ofports, the cache of key"},{"line_number":17,"context_line":"paris(tunnel remote IP and tunnel ofport), to determine whether"},{"line_number":18,"context_line":"a port should be created or not. Tunnel port will be created only"},{"line_number":19,"context_line":"when ofport coundn\u0027t be found in tun_br_ofports with tunnel remote IP."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When OVS has restarted, tun_br_ofports will not be cleaned. For that,"},{"line_number":22,"context_line":"a tunnel remote IP always can be found in tun_br_ofports with a stale"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_dd7d606e","line":19,"updated":"2015-09-10 07:37:18.000000000","message":"cound\u0027t -\u003e couldn\u0027t","commit_id":"bf6e22b1dcac6d8dfd27a02f0d6236fbc833c9ab"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"251a52d3d4224b7209808b45f9bb4c078a0b57d9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"create tunnel ports. It uses tun_br_ofports, the cache of key"},{"line_number":17,"context_line":"paris(tunnel remote IP and tunnel ofport), to determine whether"},{"line_number":18,"context_line":"a port should be created or not. Tunnel port will be created only"},{"line_number":19,"context_line":"when ofport coundn\u0027t be found in tun_br_ofports with tunnel remote IP."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"When OVS has restarted, tun_br_ofports will not be cleaned. For that,"},{"line_number":22,"context_line":"a tunnel remote IP always can be found in tun_br_ofports with a stale"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_602028b1","line":19,"in_reply_to":"da20952f_dd7d606e","updated":"2015-09-10 08:29:21.000000000","message":"Done","commit_id":"bf6e22b1dcac6d8dfd27a02f0d6236fbc833c9ab"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"b32e93d188962727bc40d38926227c494a163b3a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean tun_br_ofports when ovs restarted"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When OVS restarted, previous tunnel ports on tun_br"},{"line_number":10,"context_line":"will disappear. OVS agent will detect OVS has restarted,"},{"line_number":11,"context_line":"and try to reset tun_br, like recreate patch ports between"},{"line_number":12,"context_line":"int_br and install flows again on tun_br. But when l2population"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da20952f_8b6f90fb","line":9,"updated":"2015-09-10 14:28:16.000000000","message":"I still don\u0027t understand why ports are lost. Before tun_br was deleted and recreated if ovs was restarted. But since [1] this doesn\u0027t happen anymore.\nCan you explain why the tunnel ports are deleted? I don\u0027t think this bug exists any more in the current code.\n\n[1] https://review.openstack.org/#/c/182920","commit_id":"9de0052702eb17edeec77dc79f95d386ccef956d"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"53c622658eb3889405b25a3b281944fa3f185110","unresolved":false,"context_lines":[{"line_number":985,"context_line":"            self.tun_br.delete_flows()"},{"line_number":986,"context_line":"        self.tun_br_ofports \u003d {p_const.TYPE_GENEVE: {},"},{"line_number":987,"context_line":"                               p_const.TYPE_GRE: {},"},{"line_number":988,"context_line":"                               p_const.TYPE_VXLAN: {}}"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    def setup_tunnel_br_flows(self):"},{"line_number":991,"context_line":"        \u0027\u0027\u0027Setup the tunnel bridge."}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_7fd0b553","line":988,"updated":"2015-09-03 14:37:11.000000000","message":"setup_tunnel_br is called in __init__() too. It\u0027s duplicated since the variable is initialized in __init__(). I guess that you should move it to L1630.\n\nFuthermore, I\u0027m not sure if the global variable should be clean directly.","commit_id":"2ce20e13ee8436e6d7b14075b3e53d8912714c40"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"a3bc66481c751e56c6777e944dd8255a9049e160","unresolved":false,"context_lines":[{"line_number":985,"context_line":"            self.tun_br.delete_flows()"},{"line_number":986,"context_line":"        self.tun_br_ofports \u003d {p_const.TYPE_GENEVE: {},"},{"line_number":987,"context_line":"                               p_const.TYPE_GRE: {},"},{"line_number":988,"context_line":"                               p_const.TYPE_VXLAN: {}}"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    def setup_tunnel_br_flows(self):"},{"line_number":991,"context_line":"        \u0027\u0027\u0027Setup the tunnel bridge."}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_060ef23a","line":988,"in_reply_to":"da20952f_7fd0b553","updated":"2015-09-04 07:19:21.000000000","message":"@Hirofumi\nYes, it\u0027s duplicated, but I\u0027m not understand why tun_br_ofports initialization isn\u0027t in setup_tunnel_br. tun_br_ofports belongs to tun_br, if enable_tunneling is false, do we still need tun_br_ofports?\n\nThere are two places using setup_tunnel_br, in __init__ and in rpc_loop(when ovs restarted), so for now, I think it\u0027s possible to directly clean tun_br_ofports in setup_tunnel_br. After ovs restarted, previous records in tun_br_ofports are invalid to use.","commit_id":"2ce20e13ee8436e6d7b14075b3e53d8912714c40"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"29110f88391d6811ca08c55d5e00f80749db9fae","unresolved":false,"context_lines":[{"line_number":985,"context_line":"            self.tun_br.delete_flows()"},{"line_number":986,"context_line":"        self.tun_br_ofports \u003d {p_const.TYPE_GENEVE: {},"},{"line_number":987,"context_line":"                               p_const.TYPE_GRE: {},"},{"line_number":988,"context_line":"                               p_const.TYPE_VXLAN: {}}"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    def setup_tunnel_br_flows(self):"},{"line_number":991,"context_line":"        \u0027\u0027\u0027Setup the tunnel bridge."}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_c9b10191","line":988,"in_reply_to":"da20952f_7fd0b553","updated":"2015-09-03 18:34:40.000000000","message":"@Hirofumi , i don\u0027t see what problem you see here.\n\nYou could just empty self.tun_br_ofports something like:\n\nfor key, value in self.tun_br_ofports.items():\n   self.tun_br_ofports[key] \u003d {}\n\nBut looks ok to me either way","commit_id":"2ce20e13ee8436e6d7b14075b3e53d8912714c40"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"a3bc66481c751e56c6777e944dd8255a9049e160","unresolved":false,"context_lines":[{"line_number":985,"context_line":"            self.tun_br.delete_flows()"},{"line_number":986,"context_line":"        self.tun_br_ofports \u003d {p_const.TYPE_GENEVE: {},"},{"line_number":987,"context_line":"                               p_const.TYPE_GRE: {},"},{"line_number":988,"context_line":"                               p_const.TYPE_VXLAN: {}}"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    def setup_tunnel_br_flows(self):"},{"line_number":991,"context_line":"        \u0027\u0027\u0027Setup the tunnel bridge."}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_c69c7a6c","line":988,"in_reply_to":"da20952f_c9b10191","updated":"2015-09-04 07:19:21.000000000","message":"Thanks Gal. Yes, both ways are OK to me.","commit_id":"2ce20e13ee8436e6d7b14075b3e53d8912714c40"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3f9744a6176e2a16199b3b45d737d8e867937d09","unresolved":false,"context_lines":[{"line_number":988,"context_line":"            exit(1)"},{"line_number":989,"context_line":"        if self.conf.AGENT.drop_flows_on_start:"},{"line_number":990,"context_line":"            self.tun_br.delete_flows()"},{"line_number":991,"context_line":"        self.tun_br_ofports \u003d {p_const.TYPE_GENEVE: {},"},{"line_number":992,"context_line":"                               p_const.TYPE_GRE: {},"},{"line_number":993,"context_line":"                               p_const.TYPE_VXLAN: {}}"},{"line_number":994,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_3e84a809","line":991,"updated":"2015-09-09 18:33:55.000000000","message":"I don\u0027t think it\u0027s right to reset tun_br_ofports since if tun_br exists, it\u0027s not re-created and even if ovs restarts, ports are not lost","commit_id":"46bd658913f99c18499e4597b3cafd5418f661c6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"7359f102ec6b4fd12b1516649b87db25c11849b4","unresolved":false,"context_lines":[{"line_number":988,"context_line":"            exit(1)"},{"line_number":989,"context_line":"        if self.conf.AGENT.drop_flows_on_start:"},{"line_number":990,"context_line":"            self.tun_br.delete_flows()"},{"line_number":991,"context_line":"        self.tun_br_ofports \u003d {p_const.TYPE_GENEVE: {},"},{"line_number":992,"context_line":"                               p_const.TYPE_GRE: {},"},{"line_number":993,"context_line":"                               p_const.TYPE_VXLAN: {}}"},{"line_number":994,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_ce9dac0b","line":991,"in_reply_to":"da20952f_3e84a809","updated":"2015-09-10 03:05:39.000000000","message":"setup_tunnel_br will be called in __init__ to do initialization as above shown if enable_tunneling, and tun_br_ofports should be valid to use only when enable_tunneling, so beside the reported bug, I think it\u0027s also make sense to move it here.\n\nI\u0027m not sure where get you confirm ports are not lost, but I will do more investigate to help us get more clear on this.\n\nBTW, thanks :)","commit_id":"46bd658913f99c18499e4597b3cafd5418f661c6"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"4d36c09cd03b6bf9640ccd12a34fe6d766515e6b","unresolved":false,"context_lines":[{"line_number":988,"context_line":"            exit(1)"},{"line_number":989,"context_line":"        if self.conf.AGENT.drop_flows_on_start:"},{"line_number":990,"context_line":"            self.tun_br.delete_flows()"},{"line_number":991,"context_line":"        self.tun_br_ofports \u003d {p_const.TYPE_GENEVE: {},"},{"line_number":992,"context_line":"                               p_const.TYPE_GRE: {},"},{"line_number":993,"context_line":"                               p_const.TYPE_VXLAN: {}}"},{"line_number":994,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_576da830","line":991,"in_reply_to":"da20952f_ce9dac0b","updated":"2015-09-10 10:27:45.000000000","message":"\u003e I\u0027m not sure where get you confirm ports are not lost, but I will do more investigate to help us get more clear on this.\n\ntest it. Stop the ovs agent. Restart ovs. ovs-vsctl show you\u0027ll see all the ports still there","commit_id":"46bd658913f99c18499e4597b3cafd5418f661c6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"8217b489c8e7532771eef143148854ba94db5e62","unresolved":false,"context_lines":[{"line_number":990,"context_line":"            self.tun_br.delete_flows()"},{"line_number":991,"context_line":"        self.tun_br_ofports \u003d {p_const.TYPE_GENEVE: {},"},{"line_number":992,"context_line":"                               p_const.TYPE_GRE: {},"},{"line_number":993,"context_line":"                               p_const.TYPE_VXLAN: {}}"},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"    def setup_tunnel_br_flows(self):"},{"line_number":996,"context_line":"        \u0027\u0027\u0027Setup the tunnel bridge."}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_5daaafd3","line":993,"updated":"2015-09-10 07:37:18.000000000","message":"nit: I feel strange that global variable is set at the bottom. I supposed that the variable may be used in L965-990 but it wasn\u0027t right. I think that it\u0027s better to move on the top.","commit_id":"bf6e22b1dcac6d8dfd27a02f0d6236fbc833c9ab"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"251a52d3d4224b7209808b45f9bb4c078a0b57d9","unresolved":false,"context_lines":[{"line_number":990,"context_line":"            self.tun_br.delete_flows()"},{"line_number":991,"context_line":"        self.tun_br_ofports \u003d {p_const.TYPE_GENEVE: {},"},{"line_number":992,"context_line":"                               p_const.TYPE_GRE: {},"},{"line_number":993,"context_line":"                               p_const.TYPE_VXLAN: {}}"},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"    def setup_tunnel_br_flows(self):"},{"line_number":996,"context_line":"        \u0027\u0027\u0027Setup the tunnel bridge."}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_a084000b","line":993,"in_reply_to":"da20952f_5daaafd3","updated":"2015-09-10 08:29:21.000000000","message":"Yes, you\u0027re right. Port \"patch-int\" will also have a record need to be stored in tun_br_ofports.","commit_id":"bf6e22b1dcac6d8dfd27a02f0d6236fbc833c9ab"}]}