)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"6f833c77701a8b9c81dcec06cd688afb10158d71","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2015-09-11 14:02:41 +0530"},{"line_number":4,"context_line":"Commit:     Sudhakar Babu Gariganti \u003csudhakar-babu.gariganti@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-03 10:05:33 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix call which is only specific to enhanced_rpc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"security_group_updated method is not implemented in the default"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a26ad4f_d6b3a798","line":6,"updated":"2015-11-03 07:36:41.000000000","message":"Shouldn\u0027t fix start with capital \u0027F\u0027","commit_id":"66c6292bf3691ddcae0931b1e565960e3f9a9f79"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"853467f0c444f73d90ed4fbdabbf1de2977e3e81","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2015-09-11 14:02:41 +0530"},{"line_number":4,"context_line":"Commit:     Sudhakar Babu Gariganti \u003csudhakar-babu.gariganti@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-03 10:05:33 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix call which is only specific to enhanced_rpc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"security_group_updated method is not implemented in the default"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa80f949_eb1d1f67","line":6,"in_reply_to":"1a26ad4f_d6b3a798","updated":"2015-11-04 11:23:34.000000000","message":"not a mandate I guess","commit_id":"66c6292bf3691ddcae0931b1e565960e3f9a9f79"},{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"6f833c77701a8b9c81dcec06cd688afb10158d71","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fix call which is only specific to enhanced_rpc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"security_group_updated method is not implemented in the default"},{"line_number":10,"context_line":"FirewallDriver class. But SecurityGroupAgentRpc class assumes the method"},{"line_number":11,"context_line":"is implemented by the underlying Firewall driver."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch adds a check to ensure that only the drivers which leverages"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a26ad4f_767c13b5","line":10,"updated":"2015-11-03 07:36:41.000000000","message":"Firewall should be written in lower case, I guess..","commit_id":"66c6292bf3691ddcae0931b1e565960e3f9a9f79"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"853467f0c444f73d90ed4fbdabbf1de2977e3e81","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fix call which is only specific to enhanced_rpc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"security_group_updated method is not implemented in the default"},{"line_number":10,"context_line":"FirewallDriver class. But SecurityGroupAgentRpc class assumes the method"},{"line_number":11,"context_line":"is implemented by the underlying Firewall driver."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch adds a check to ensure that only the drivers which leverages"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa80f949_eb4bdf57","line":10,"in_reply_to":"1a26ad4f_767c13b5","updated":"2015-11-04 11:23:34.000000000","message":"I was referring to the class whose name is \u0027FirewallDriver\u0027. So I think this is fine as well.","commit_id":"66c6292bf3691ddcae0931b1e565960e3f9a9f79"}],"neutron/agent/securitygroups_rpc.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"375192c70ee6d48a56e961a0cad8b99acf7af396","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            if sec_grp_set \u0026 set(device.get(attribute, [])):"},{"line_number":199,"context_line":"                devices.append(device[\u0027device\u0027])"},{"line_number":200,"context_line":"        if devices:"},{"line_number":201,"context_line":"            if self.use_enhanced_rpc:"},{"line_number":202,"context_line":"                self.firewall.security_group_updated(action_type, sec_grp_set)"},{"line_number":203,"context_line":"            if self.defer_refresh_firewall:"},{"line_number":204,"context_line":"                LOG.debug(\"Adding %s devices to the list of devices \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_27adc488","line":201,"updated":"2015-09-12 13:04:39.000000000","message":"not sure I fully understand the issue, but I could see another call being made to security_group_updated in here and it is not wrapped up by this check (unless the check is made elsewhere in the call stack).\n\nCould you provide more context to the change and possibly a bug report?","commit_id":"cf7f5149c8207616728b7d178367480f88af4bca"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"82778a5000cc42d8840fda3e454021d57b988f0b","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            if sec_grp_set \u0026 set(device.get(attribute, [])):"},{"line_number":199,"context_line":"                devices.append(device[\u0027device\u0027])"},{"line_number":200,"context_line":"        if devices:"},{"line_number":201,"context_line":"            if self.use_enhanced_rpc:"},{"line_number":202,"context_line":"                self.firewall.security_group_updated(action_type, sec_grp_set)"},{"line_number":203,"context_line":"            if self.defer_refresh_firewall:"},{"line_number":204,"context_line":"                LOG.debug(\"Adding %s devices to the list of devices \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_ed57a3c8","line":201,"in_reply_to":"ba15a1d1_27adc488","updated":"2015-09-14 04:37:31.000000000","message":"Romil had raised one LP bug [1] for this, but specific to networking-vsphere project. Sorry for missing to refer that. Updated the commit message.\n\nBasically, security_group_updated method implemented compliments the enhanced_rpc functionality, if I am not wrong. A stub is written in the base FirewallDriver and the implementation is done in IpTablesFirewallDriver. \n\nWe have been using a custom OVSFirewallDriver [1] in combination with the SecurityGroupsAgentRpc [2], in our deployments since long time, without having to use enhanced_rpc, and things were working fine. Now, with the introduction of this method, \u0027security_groups_member_updated\u0027, \u0027security_groups_rule_updated\u0027 callbacks are failing for us, throwing the NotImplementedError for this security_group_updated method. Refer to the LP bug [1] for the traceback details.  \n\nOur folks have worked around this[4] by having another stub in our firewall driver, just to cover the exception, which I think is not the correct way to fix.\n\n[1] https://bugs.launchpad.net/networking-vsphere/+bug/1493104\n[2] https://github.com/openstack/networking-vsphere/blob/master/networking_vsphere/drivers/ovs_firewall.py\n[3] https://github.com/openstack/networking-vsphere/blob/master/networking_vsphere/agent/ovsvapp_sg_agent.py\n[4] https://review.openstack.org/#/c/221076/","commit_id":"cf7f5149c8207616728b7d178367480f88af4bca"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5e697f46517dc8108a00661e0ced28578f7db668","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            if sec_grp_set \u0026 set(device.get(attribute, [])):"},{"line_number":199,"context_line":"                devices.append(device[\u0027device\u0027])"},{"line_number":200,"context_line":"        if devices:"},{"line_number":201,"context_line":"            if self.use_enhanced_rpc:"},{"line_number":202,"context_line":"                self.firewall.security_group_updated(action_type, sec_grp_set)"},{"line_number":203,"context_line":"            if self.defer_refresh_firewall:"},{"line_number":204,"context_line":"                LOG.debug(\"Adding %s devices to the list of devices \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_1de46539","line":201,"updated":"2015-10-13 05:42:52.000000000","message":"I\u0027m not sure how is use_enhanced_rpc related to security_group_updated. Where does this process use rpc?","commit_id":"b94aaaa3e95b3872aa6efacbb24a5ac0fe1a747a"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"ccb7dda9516aef351ded40bdcaca0bfea758fe2a","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            if sec_grp_set \u0026 set(device.get(attribute, [])):"},{"line_number":199,"context_line":"                devices.append(device[\u0027device\u0027])"},{"line_number":200,"context_line":"        if devices:"},{"line_number":201,"context_line":"            if self.use_enhanced_rpc:"},{"line_number":202,"context_line":"                self.firewall.security_group_updated(action_type, sec_grp_set)"},{"line_number":203,"context_line":"            if self.defer_refresh_firewall:"},{"line_number":204,"context_line":"                LOG.debug(\"Adding %s devices to the list of devices \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_1df9c54d","line":201,"in_reply_to":"7a2fa921_1de46539","updated":"2015-10-13 06:03:09.000000000","message":"security_group_updated method is introduced to support the enhanced_rpc workflow. This method updates the resources which are used by enhanced_rpc. \n\nDeployments/Firewall drivers which do not have/need enhanced_rpc are impacted if we try to invoke the method directly as they might not be implementing it in the first place.","commit_id":"b94aaaa3e95b3872aa6efacbb24a5ac0fe1a747a"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ab768d4089f4a8e4c7d4583727ee419e50f6b526","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                          \"for which firewall needs to be refreshed\","},{"line_number":206,"context_line":"                          devices)"},{"line_number":207,"context_line":"                self.devices_to_refilter |\u003d set(devices)"},{"line_number":208,"context_line":"            else:"},{"line_number":209,"context_line":"                self.refresh_firewall(devices)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def security_groups_provider_updated(self, devices_to_update):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_78ede2b5","line":208,"updated":"2015-11-03 05:45:46.000000000","message":"I would suggest adding\nLOG.debug(\"Refreshing firewall for %d devices\", len(devices))","commit_id":"66c6292bf3691ddcae0931b1e565960e3f9a9f79"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"7218496ae0e9a272cff80518e3d9eea7b1e6d269","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                          \"for which firewall needs to be refreshed\","},{"line_number":206,"context_line":"                          devices)"},{"line_number":207,"context_line":"                self.devices_to_refilter |\u003d set(devices)"},{"line_number":208,"context_line":"            else:"},{"line_number":209,"context_line":"                self.refresh_firewall(devices)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def security_groups_provider_updated(self, devices_to_update):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_18be2e65","line":208,"in_reply_to":"1a26ad4f_78ede2b5","updated":"2015-11-03 05:58:30.000000000","message":"Manjeet,\n\nThe log is not related to this patch. We are typically advised to keep the patch as focused as possible to help reviewers and any rollbacks in future.\n\nWill keep this in mind if I happen to post anything in the same area.","commit_id":"66c6292bf3691ddcae0931b1e565960e3f9a9f79"}]}