)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"54370afc9f84d4f54e3880d9c7696736d8bd9c51","unresolved":false,"context_lines":[{"line_number":11,"context_line":"The API previously allowed a VIP to be created without verifying that"},{"line_number":12,"context_line":"the tenant had access to the subnet and that the address was valid and"},{"line_number":13,"context_line":"available.  This change modifies VIP creation behavior to create a"},{"line_number":14,"context_line":"Quantum with the requested address.  If an address is not provided, an"},{"line_number":15,"context_line":"address is allocated using the normal allocation process for the subnet."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change also renames the port attribute to tcp_port to remove the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAM3%2F%2BygI%3D","line":14,"updated":"2013-02-19 06:46:22.000000000","message":"create a Quantum with \u003d\u003e create a Quantum port with","commit_id":"835469300f86fa4f0d887dfbea72335093492d91"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"54370afc9f84d4f54e3880d9c7696736d8bd9c51","unresolved":false,"context_lines":[{"line_number":15,"context_line":"address is allocated using the normal allocation process for the subnet."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change also renames the port attribute to tcp_port to remove the"},{"line_number":18,"context_line":"ambiguity about which type of port it represents."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Additional tests were added to validate the change in behavior."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAM3%2F%2Byao%3D","line":18,"updated":"2013-02-19 07:30:30.000000000","message":"maybe we should move this to l4_port. The load balancing vendors support UDP load balancing in addition to tcp. I Think that moving forwards the tc may be problematic.","commit_id":"835469300f86fa4f0d887dfbea72335093492d91"}],"quantum/db/loadbalancer/loadbalancer_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"54370afc9f84d4f54e3880d9c7696736d8bd9c51","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                \u0027name\u0027: _(\u0027LBaaS VIP Port\u0027),"},{"line_number":341,"context_line":"                \u0027network_id\u0027: subnet[\u0027network_id\u0027],"},{"line_number":342,"context_line":"                \u0027mac_address\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":343,"context_line":"                \u0027admin_state_up\u0027: False,"},{"line_number":344,"context_line":"                \u0027device_id\u0027: \u0027\u0027,"},{"line_number":345,"context_line":"                \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":346,"context_line":"                \u0027fixed_ips\u0027: [fixed_ip]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Byfo%3D","line":343,"updated":"2013-02-19 06:46:22.000000000","message":"why is this set to False? This means that the port will be down by default. Is this what you intend? i think that the default should be True.\nMaybe work considering having the attributes.py returning a \u0027default\u0027 port which can be updated accordingly.","commit_id":"835469300f86fa4f0d887dfbea72335093492d91"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"54370afc9f84d4f54e3880d9c7696736d8bd9c51","unresolved":false,"context_lines":[{"line_number":384,"context_line":"            context.session.add(vip_db)"},{"line_number":385,"context_line":"            self._update_pool_vip_info(context, v[\u0027pool_id\u0027], vip_id)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        #vip_db \u003d self._get_resource(context, Vip, vip_id)"},{"line_number":388,"context_line":"        return self._make_vip_dict(vip_db)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    def update_vip(self, context, id, vip):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Byfc%3D","line":387,"updated":"2013-02-19 06:46:22.000000000","message":"think that you can delete this comment","commit_id":"835469300f86fa4f0d887dfbea72335093492d91"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"54370afc9f84d4f54e3880d9c7696736d8bd9c51","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                pool.update({\"vip_id\": None})"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"            context.session.delete(vip)"},{"line_number":420,"context_line":"            if vip.port:"},{"line_number":421,"context_line":"                context.session.delete(vip.port)"},{"line_number":422,"context_line":"            context.session.flush()"},{"line_number":423,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2ByfY%3D","line":420,"updated":"2013-02-19 06:46:22.000000000","message":"tcp_port?","commit_id":"835469300f86fa4f0d887dfbea72335093492d91"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":340,"context_line":"                \u0027name\u0027: _(\u0027LBaaS VIP Port\u0027),"},{"line_number":341,"context_line":"                \u0027network_id\u0027: subnet[\u0027network_id\u0027],"},{"line_number":342,"context_line":"                \u0027mac_address\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":343,"context_line":"                \u0027admin_state_up\u0027: False,"},{"line_number":344,"context_line":"                \u0027device_id\u0027: \u0027\u0027,"},{"line_number":345,"context_line":"                \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":346,"context_line":"                \u0027fixed_ips\u0027: [fixed_ip]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2BvN8%3D","line":343,"updated":"2013-02-20 08:41:19.000000000","message":"why is this false?","commit_id":"a783489a5f7d927be848d64fc8ab5a6b102f7f34"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":340,"context_line":"                \u0027name\u0027: _(\u0027LBaaS VIP Port\u0027),"},{"line_number":341,"context_line":"                \u0027network_id\u0027: subnet[\u0027network_id\u0027],"},{"line_number":342,"context_line":"                \u0027mac_address\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":343,"context_line":"                \u0027admin_state_up\u0027: False,"},{"line_number":344,"context_line":"                \u0027device_id\u0027: \u0027\u0027,"},{"line_number":345,"context_line":"                \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":346,"context_line":"                \u0027fixed_ips\u0027: [fixed_ip]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Bo%2F8%3D","line":343,"in_reply_to":"AAAAM3%2F%2BvN8%3D","updated":"2013-02-23 17:42:28.000000000","message":"garyk and I discussed offline, but I\u0027ll leave answer here.  The idea of this change is to reserve the IP address via IPAM to avoid later conflicts.  The port is set down because it is up to the actual LBaaS whether it wants to use the port.","commit_id":"a783489a5f7d927be848d64fc8ab5a6b102f7f34"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":66,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":67,"context_line":"    description \u003d sa.Column(sa.String(255))"},{"line_number":68,"context_line":"    port_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027ports.id\u0027))"},{"line_number":69,"context_line":"    protocol_port \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":70,"context_line":"    protocol \u003d sa.Column(sa.Enum(\"HTTP\", \"HTTPS\", \"TCP\", name\u003d\"lb_protocols\"),"},{"line_number":71,"context_line":"                         nullable\u003dFalse)"},{"line_number":72,"context_line":"    pool_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2BnWA%3D","line":69,"updated":"2013-02-25 19:25:17.000000000","message":"nit: protocol_port is not intuitive name for me personally,\nhow about protocol_port_number ?","commit_id":"26b82726545aaf8381c377a4db9afb604601ed80"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":66,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":67,"context_line":"    description \u003d sa.Column(sa.String(255))"},{"line_number":68,"context_line":"    port_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027ports.id\u0027))"},{"line_number":69,"context_line":"    protocol_port \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":70,"context_line":"    protocol \u003d sa.Column(sa.Enum(\"HTTP\", \"HTTPS\", \"TCP\", name\u003d\"lb_protocols\"),"},{"line_number":71,"context_line":"                         nullable\u003dFalse)"},{"line_number":72,"context_line":"    pool_id \u003d sa.Column(sa.String(36), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2BnDE%3D","line":69,"in_reply_to":"AAAAM3%2F%2BnWA%3D","updated":"2013-02-25 22:44:22.000000000","message":"The original version was port, but when we added the Quantum port to the model the name was changed.  My only concern with the suggestion is a very long name which translates into a long flag name in the CLI.","commit_id":"26b82726545aaf8381c377a4db9afb604601ed80"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":248,"context_line":"               \u0027tenant_id\u0027: vip[\u0027tenant_id\u0027],"},{"line_number":249,"context_line":"               \u0027name\u0027: vip[\u0027name\u0027],"},{"line_number":250,"context_line":"               \u0027description\u0027: vip[\u0027description\u0027],"},{"line_number":251,"context_line":"               \u0027subnet_id\u0027: fixed_ip[\u0027subnet_id\u0027],"},{"line_number":252,"context_line":"               \u0027address\u0027: fixed_ip[\u0027ip_address\u0027],"},{"line_number":253,"context_line":"               \u0027port_id\u0027: vip[\u0027port_id\u0027],"},{"line_number":254,"context_line":"               \u0027protocol_port\u0027: vip[\u0027protocol_port\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Bozk%3D","line":251,"updated":"2013-02-24 02:02:38.000000000","message":"if fixed_ips is [{}], it will raise keyerror. So  I think line 245 can remove [{}] since we will always face the error.","commit_id":"26b82726545aaf8381c377a4db9afb604601ed80"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":248,"context_line":"               \u0027tenant_id\u0027: vip[\u0027tenant_id\u0027],"},{"line_number":249,"context_line":"               \u0027name\u0027: vip[\u0027name\u0027],"},{"line_number":250,"context_line":"               \u0027description\u0027: vip[\u0027description\u0027],"},{"line_number":251,"context_line":"               \u0027subnet_id\u0027: fixed_ip[\u0027subnet_id\u0027],"},{"line_number":252,"context_line":"               \u0027address\u0027: fixed_ip[\u0027ip_address\u0027],"},{"line_number":253,"context_line":"               \u0027port_id\u0027: vip[\u0027port_id\u0027],"},{"line_number":254,"context_line":"               \u0027protocol_port\u0027: vip[\u0027protocol_port\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Bosw%3D","line":251,"in_reply_to":"AAAAM3%2F%2Bozk%3D","updated":"2013-02-25 22:44:22.000000000","message":"You\u0027re correct I need to change this to a .get()","commit_id":"26b82726545aaf8381c377a4db9afb604601ed80"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":333,"context_line":"            # resolve subnet and create port"},{"line_number":334,"context_line":"            subnet \u003d self._core_plugin.get_subnet(context, subnet_id)"},{"line_number":335,"context_line":"            fixed_ip \u003d {\u0027subnet_id\u0027: subnet[\u0027id\u0027]}"},{"line_number":336,"context_line":"            if ip_address and ip_address !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":337,"context_line":"                fixed_ip[\u0027ip_address\u0027] \u003d ip_address"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"            port_data \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2Bmms%3D","line":336,"updated":"2013-02-26 02:21:12.000000000","message":"\"is not\" should be used instead of \"!\u003d\" since we\u0027re comparing ids.","commit_id":"c4b29b3138844bbcca2de9ceb0d2b4d2491cf81f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":419,"context_line":"            context.session.delete(vip)"},{"line_number":420,"context_line":"            if vip.port:  # this is a Quantum port"},{"line_number":421,"context_line":"                context.session.delete(vip.port)"},{"line_number":422,"context_line":"            context.session.flush()"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def get_vip(self, context, id, fields\u003dNone):"},{"line_number":425,"context_line":"        vip \u003d self._get_resource(context, Vip, id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2BmEQ%3D","line":422,"updated":"2013-02-26 12:23:24.000000000","message":"Is session.flush() needed? When exiting the with statement at the top level successfully the session will be flushed. Right?","commit_id":"c4b29b3138844bbcca2de9ceb0d2b4d2491cf81f"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":242,"context_line":"    ########################################################"},{"line_number":243,"context_line":"    # VIP DB access"},{"line_number":244,"context_line":"    def _make_vip_dict(self, vip, fields\u003dNone):"},{"line_number":245,"context_line":"        fixed_ip \u003d (vip.port.fixed_ips or [{}])[0]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        res \u003d {\u0027id\u0027: vip[\u0027id\u0027],"},{"line_number":248,"context_line":"               \u0027tenant_id\u0027: vip[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BkOI%3D","line":245,"updated":"2013-02-27 06:22:06.000000000","message":"i thought I saw this comment on an earlier version, so maybe i\u0027m missing something, but it seems like {} is not sufficient if we\u0027re going to access fixed_ip[\u0027subnet_id\u0027] below.","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":242,"context_line":"    ########################################################"},{"line_number":243,"context_line":"    # VIP DB access"},{"line_number":244,"context_line":"    def _make_vip_dict(self, vip, fields\u003dNone):"},{"line_number":245,"context_line":"        fixed_ip \u003d (vip.port.fixed_ips or [{}])[0]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        res \u003d {\u0027id\u0027: vip[\u0027id\u0027],"},{"line_number":248,"context_line":"               \u0027tenant_id\u0027: vip[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BjL0%3D","line":245,"in_reply_to":"AAAAM3%2F%2BkOI%3D","updated":"2013-02-27 19:18:30.000000000","message":"This has been fixed is a later version.","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"            port_data \u003d {"},{"line_number":340,"context_line":"                \u0027tenant_id\u0027: tenant_id,"},{"line_number":341,"context_line":"                \u0027name\u0027: _(\u0027LBaaS VIP Port\u0027),"},{"line_number":342,"context_line":"                \u0027network_id\u0027: subnet[\u0027network_id\u0027],"},{"line_number":343,"context_line":"                \u0027mac_address\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":344,"context_line":"                \u0027admin_state_up\u0027: False,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BkN8%3D","line":341,"updated":"2013-02-27 06:22:06.000000000","message":"I\u0027d probably make this name specific to the VIP.","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"            port_data \u003d {"},{"line_number":340,"context_line":"                \u0027tenant_id\u0027: tenant_id,"},{"line_number":341,"context_line":"                \u0027name\u0027: _(\u0027LBaaS VIP Port\u0027),"},{"line_number":342,"context_line":"                \u0027network_id\u0027: subnet[\u0027network_id\u0027],"},{"line_number":343,"context_line":"                \u0027mac_address\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":344,"context_line":"                \u0027admin_state_up\u0027: False,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BjLU%3D","line":341,"in_reply_to":"AAAAM3%2F%2BkN8%3D","updated":"2013-02-27 19:18:30.000000000","message":"Fixed.","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":341,"context_line":"                \u0027name\u0027: _(\u0027LBaaS VIP Port\u0027),"},{"line_number":342,"context_line":"                \u0027network_id\u0027: subnet[\u0027network_id\u0027],"},{"line_number":343,"context_line":"                \u0027mac_address\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":344,"context_line":"                \u0027admin_state_up\u0027: False,"},{"line_number":345,"context_line":"                \u0027device_id\u0027: \u0027\u0027,"},{"line_number":346,"context_line":"                \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":347,"context_line":"                \u0027fixed_ips\u0027: [fixed_ip]"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BkN4%3D","line":344,"updated":"2013-02-27 06:22:06.000000000","message":"huh... does agent turn this on later?","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":341,"context_line":"                \u0027name\u0027: _(\u0027LBaaS VIP Port\u0027),"},{"line_number":342,"context_line":"                \u0027network_id\u0027: subnet[\u0027network_id\u0027],"},{"line_number":343,"context_line":"                \u0027mac_address\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":344,"context_line":"                \u0027admin_state_up\u0027: False,"},{"line_number":345,"context_line":"                \u0027device_id\u0027: \u0027\u0027,"},{"line_number":346,"context_line":"                \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":347,"context_line":"                \u0027fixed_ips\u0027: [fixed_ip]"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BjJw%3D","line":344,"in_reply_to":"AAAAM3%2F%2BkN4%3D","updated":"2013-02-27 19:18:30.000000000","message":"Yeah.  The agent will turn it on.","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":342,"context_line":"                \u0027network_id\u0027: subnet[\u0027network_id\u0027],"},{"line_number":343,"context_line":"                \u0027mac_address\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":344,"context_line":"                \u0027admin_state_up\u0027: False,"},{"line_number":345,"context_line":"                \u0027device_id\u0027: \u0027\u0027,"},{"line_number":346,"context_line":"                \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":347,"context_line":"                \u0027fixed_ips\u0027: [fixed_ip]"},{"line_number":348,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BkOA%3D","line":345,"updated":"2013-02-27 06:22:06.000000000","message":"this should be some identifier of what lbaas entities owns this port.  given that in the future we think a port can be shared by multiple vips, perhaps the pool is the right \"owner\"?","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":342,"context_line":"                \u0027network_id\u0027: subnet[\u0027network_id\u0027],"},{"line_number":343,"context_line":"                \u0027mac_address\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":344,"context_line":"                \u0027admin_state_up\u0027: False,"},{"line_number":345,"context_line":"                \u0027device_id\u0027: \u0027\u0027,"},{"line_number":346,"context_line":"                \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":347,"context_line":"                \u0027fixed_ips\u0027: [fixed_ip]"},{"line_number":348,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2Bizg%3D","line":345,"in_reply_to":"AAAAM3%2F%2BjKY%3D","updated":"2013-02-27 22:15:36.000000000","message":"yeah, i guess the multiple vips could be different pools...so this seems to come back to the question of the granularity of a namespace, which is probably why you used a namespace-specific id for this in your other patch.   Seems reasonable.","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":342,"context_line":"                \u0027network_id\u0027: subnet[\u0027network_id\u0027],"},{"line_number":343,"context_line":"                \u0027mac_address\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":344,"context_line":"                \u0027admin_state_up\u0027: False,"},{"line_number":345,"context_line":"                \u0027device_id\u0027: \u0027\u0027,"},{"line_number":346,"context_line":"                \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":347,"context_line":"                \u0027fixed_ips\u0027: [fixed_ip]"},{"line_number":348,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BjKY%3D","line":345,"in_reply_to":"AAAAM3%2F%2BkOA%3D","updated":"2013-02-27 19:18:30.000000000","message":"Not sure what I should do since the port backing a VIP will eventually be shared by multiple vips.","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":343,"context_line":"                \u0027mac_address\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":344,"context_line":"                \u0027admin_state_up\u0027: False,"},{"line_number":345,"context_line":"                \u0027device_id\u0027: \u0027\u0027,"},{"line_number":346,"context_line":"                \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":347,"context_line":"                \u0027fixed_ips\u0027: [fixed_ip]"},{"line_number":348,"context_line":"            }"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BkOE%3D","line":346,"updated":"2013-02-27 06:22:06.000000000","message":"this should be something like \"quantum:lbaas\" to match things like \"quantum:router_interface\".","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":343,"context_line":"                \u0027mac_address\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":344,"context_line":"                \u0027admin_state_up\u0027: False,"},{"line_number":345,"context_line":"                \u0027device_id\u0027: \u0027\u0027,"},{"line_number":346,"context_line":"                \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":347,"context_line":"                \u0027fixed_ips\u0027: [fixed_ip]"},{"line_number":348,"context_line":"            }"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BizU%3D","line":346,"in_reply_to":"AAAAM3%2F%2BjKM%3D","updated":"2013-02-27 22:15:36.000000000","message":"but isn\u0027t quantum:lbaas the owner no matter whether it is a namespace or a VM?  The same way we use quantum:router_interface regardless of whether it is the l3-agent or NVP implementing it?","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":343,"context_line":"                \u0027mac_address\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":344,"context_line":"                \u0027admin_state_up\u0027: False,"},{"line_number":345,"context_line":"                \u0027device_id\u0027: \u0027\u0027,"},{"line_number":346,"context_line":"                \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":347,"context_line":"                \u0027fixed_ips\u0027: [fixed_ip]"},{"line_number":348,"context_line":"            }"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BjKM%3D","line":346,"in_reply_to":"AAAAM3%2F%2BkOE%3D","updated":"2013-02-27 19:18:30.000000000","message":"This is set when the port is brought up. Otherwise it will cause problems if this port is passed to a service VM.","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":419,"context_line":"            context.session.delete(vip)"},{"line_number":420,"context_line":"            if vip.port:  # this is a Quantum port"},{"line_number":421,"context_line":"                context.session.delete(vip.port)"},{"line_number":422,"context_line":"            context.session.flush()"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def get_vip(self, context, id, fields\u003dNone):"},{"line_number":425,"context_line":"        vip \u003d self._get_resource(context, Vip, id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BkTM%3D","line":422,"updated":"2013-02-27 05:36:16.000000000","message":"context.session.flush() is needed?","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":419,"context_line":"            context.session.delete(vip)"},{"line_number":420,"context_line":"            if vip.port:  # this is a Quantum port"},{"line_number":421,"context_line":"                context.session.delete(vip.port)"},{"line_number":422,"context_line":"            context.session.flush()"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def get_vip(self, context, id, fields\u003dNone):"},{"line_number":425,"context_line":"        vip \u003d self._get_resource(context, Vip, id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BjJ4%3D","line":422,"in_reply_to":"AAAAM3%2F%2BkTM%3D","updated":"2013-02-27 19:18:30.000000000","message":"Yeah.. Occasionally actions would fail because the interim state of the objects had not propagated throughout the open transaction.  The flush won\u0027t prevent any rollbacks should another problem pop up.","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":417,"context_line":"                pool.update({\"vip_id\": None})"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"            context.session.delete(vip)"},{"line_number":420,"context_line":"            if vip.port:  # this is a Quantum port"},{"line_number":421,"context_line":"                context.session.delete(vip.port)"},{"line_number":422,"context_line":"            context.session.flush()"},{"line_number":423,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAM3%2F%2Bj1E%3D","line":420,"updated":"2013-02-27 11:34:49.000000000","message":"why not - self._core_plugin.delete_port(...)","commit_id":"aba43f40da25e121615484dfbdc03eb3cdaab372"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":417,"context_line":"                pool.update({\"vip_id\": None})"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"            context.session.delete(vip)"},{"line_number":420,"context_line":"            if vip.port:  # this is a Quantum port"},{"line_number":421,"context_line":"                context.session.delete(vip.port)"},{"line_number":422,"context_line":"            context.session.flush()"},{"line_number":423,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAM3%2F%2BjcU%3D","line":420,"in_reply_to":"AAAAM3%2F%2Bj1E%3D","updated":"2013-02-27 16:59:33.000000000","message":"Good suggestion.  Updated.","commit_id":"aba43f40da25e121615484dfbdc03eb3cdaab372"}],"quantum/db/migration/alembic_migrations/versions/54c2c487e913_lbaas.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":49,"context_line":"        sa.Column(u\u0027name\u0027, sa.String(255), nullable\u003dTrue),"},{"line_number":50,"context_line":"        sa.Column(u\u0027description\u0027, sa.String(255), nullable\u003dTrue),"},{"line_number":51,"context_line":"        sa.Column(u\u0027port_id\u0027, sa.String(36), nullable\u003dTrue),"},{"line_number":52,"context_line":"        sa.Column(u\u0027protocol_port\u0027, sa.Integer(), nullable\u003dFalse),"},{"line_number":53,"context_line":"        sa.Column(u\u0027protocol\u0027,"},{"line_number":54,"context_line":"                  sa.Enum(\"HTTP\", \"HTTPS\", \"TCP\", name\u003d\"lb_protocols\"),"},{"line_number":55,"context_line":"                  nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Bozo%3D","line":52,"updated":"2013-02-24 02:02:38.000000000","message":"one question: if there is a deployment which has old db created, modification on the migration script will break it. How about creating a new script to do it?","commit_id":"26b82726545aaf8381c377a4db9afb604601ed80"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":49,"context_line":"        sa.Column(u\u0027name\u0027, sa.String(255), nullable\u003dTrue),"},{"line_number":50,"context_line":"        sa.Column(u\u0027description\u0027, sa.String(255), nullable\u003dTrue),"},{"line_number":51,"context_line":"        sa.Column(u\u0027port_id\u0027, sa.String(36), nullable\u003dTrue),"},{"line_number":52,"context_line":"        sa.Column(u\u0027protocol_port\u0027, sa.Integer(), nullable\u003dFalse),"},{"line_number":53,"context_line":"        sa.Column(u\u0027protocol\u0027,"},{"line_number":54,"context_line":"                  sa.Enum(\"HTTP\", \"HTTPS\", \"TCP\", name\u003d\"lb_protocols\"),"},{"line_number":55,"context_line":"                  nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Boss%3D","line":52,"in_reply_to":"AAAAM3%2F%2Bozo%3D","updated":"2013-02-25 22:44:22.000000000","message":"We haven\u0027t been creating migrations for changes between interim builds because there can be high variability until the RC candidate is released.","commit_id":"26b82726545aaf8381c377a4db9afb604601ed80"}],"quantum/extensions/loadbalancer.py":[{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"20fcab7777ade76605844b0ddbc7ffc9d658aaba","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \u0027port_id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":81,"context_line":"                    \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":82,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":83,"context_line":"        \u0027tcp_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":84,"context_line":"                     \u0027validate\u0027: {\u0027type:range\u0027: [0, 65535]},"},{"line_number":85,"context_line":"                     \u0027convert_to\u0027: attr.convert_to_int,"},{"line_number":86,"context_line":"                     \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2BxfE%3D","line":83,"updated":"2013-02-19 15:46:42.000000000","message":"do you have corresponding patch for python-quantumclient? otherwise it will be broken as well as horizon","commit_id":"835469300f86fa4f0d887dfbea72335093492d91"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    \u0027default\u0027: attr.ATTR_NOT_SPECIFIED,"},{"line_number":78,"context_line":"                    \u0027validate\u0027: {\u0027type:ip_address_or_none\u0027: None},"},{"line_number":79,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":80,"context_line":"        \u0027port_id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":81,"context_line":"                    \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":82,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":83,"context_line":"        \u0027protocol_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2BvLU%3D","line":80,"updated":"2013-02-20 09:22:34.000000000","message":"I think that the this should be True - this will enable more than 1 ip to be used on the same port","commit_id":"a783489a5f7d927be848d64fc8ab5a6b102f7f34"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    \u0027default\u0027: attr.ATTR_NOT_SPECIFIED,"},{"line_number":78,"context_line":"                    \u0027validate\u0027: {\u0027type:ip_address_or_none\u0027: None},"},{"line_number":79,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":80,"context_line":"        \u0027port_id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":81,"context_line":"                    \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":82,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":83,"context_line":"        \u0027protocol_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Bo%2Fo%3D","line":80,"in_reply_to":"AAAAM3%2F%2BvEM%3D","updated":"2013-02-23 17:42:28.000000000","message":"For simplicity, I decided to make this a read-only attribute.  For Grizzly let\u0027s get this working in the simple case.  In Havana, we can add the logic to make port sharing possible.  I\u0027m going to drop the unique constraint for now, so that a database migration is not required later.","commit_id":"a783489a5f7d927be848d64fc8ab5a6b102f7f34"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"c6700d772adff399bf9613b35918dda80a013c28","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    \u0027default\u0027: attr.ATTR_NOT_SPECIFIED,"},{"line_number":78,"context_line":"                    \u0027validate\u0027: {\u0027type:ip_address_or_none\u0027: None},"},{"line_number":79,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":80,"context_line":"        \u0027port_id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":81,"context_line":"                    \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":82,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":83,"context_line":"        \u0027protocol_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2BvEM%3D","line":80,"in_reply_to":"AAAAM3%2F%2BvLU%3D","updated":"2013-02-20 10:46:44.000000000","message":"Please note that to enable multiple VIPs on the same port, the DB model should support it. (currently its not)\nclass Vip(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):\n    ....\n    port_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027ports.id\u0027), unique\u003dTrue)","commit_id":"a783489a5f7d927be848d64fc8ab5a6b102f7f34"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \u0027port_id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":83,"context_line":"                    \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":84,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":85,"context_line":"        \u0027protocol_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":86,"context_line":"                          \u0027validate\u0027: {\u0027type:range\u0027: [0, 65535]},"},{"line_number":87,"context_line":"                          \u0027convert_to\u0027: attr.convert_to_int,"},{"line_number":88,"context_line":"                          \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2Bk0Q%3D","line":85,"updated":"2013-02-26 23:24:11.000000000","message":"I\u0027m not super happy with the name protocol_port but I can\u0027t think of a better name.. dest_port_number? port_number? I guess those could have the same confusion.","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \u0027port_id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":83,"context_line":"                    \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":84,"context_line":"                    \u0027is_visible\u0027: True},"},{"line_number":85,"context_line":"        \u0027protocol_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":86,"context_line":"                          \u0027validate\u0027: {\u0027type:range\u0027: [0, 65535]},"},{"line_number":87,"context_line":"                          \u0027convert_to\u0027: attr.convert_to_int,"},{"line_number":88,"context_line":"                          \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BkN0%3D","line":85,"in_reply_to":"AAAAM3%2F%2Bk0Q%3D","updated":"2013-02-27 06:22:06.000000000","message":"yeah, given that we use \u0027protocol\u0027 in the VIP object as well, it makes it pretty clear what the port refers to.","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"}],"quantum/tests/unit/db/loadbalancer/test_db_loadbalancer.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":302,"context_line":"        invalid \u003d {"},{"line_number":303,"context_line":"            \u0027protocol\u0027: \u0027UNSUPPORTED\u0027,"},{"line_number":304,"context_line":"            \u0027protocol_port\u0027: \u0027NOT_AN_INT\u0027,"},{"line_number":305,"context_line":"            \u0027protocol_port\u0027: 1000500,"},{"line_number":306,"context_line":"            \u0027subnet\u0027: {\u0027subnet\u0027: {\u0027id\u0027: \u0027invalid-subnet\u0027}}"},{"line_number":307,"context_line":"        }"},{"line_number":308,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BkNw%3D","line":305,"updated":"2013-02-27 06:22:06.000000000","message":"that\u0027s a big port!","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"}],"quantum/tests/unit/test_routerserviceinsertion.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":195,"context_line":"        res \u003d self._do_request(\u0027GET\u0027, _get_path(\u0027service-types\u0027))"},{"line_number":196,"context_line":"        self._service_type_id \u003d res[\u0027service_types\u0027][0][\u0027id\u0027]"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":200,"context_line":"        self._setup_core_resources()"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BkfA%3D","line":198,"updated":"2013-02-27 01:43:43.000000000","message":"oops.","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":195,"context_line":"        res \u003d self._do_request(\u0027GET\u0027, _get_path(\u0027service-types\u0027))"},{"line_number":196,"context_line":"        self._service_type_id \u003d res[\u0027service_types\u0027][0][\u0027id\u0027]"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":200,"context_line":"        self._setup_core_resources()"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BjJo%3D","line":198,"in_reply_to":"AAAAM3%2F%2BkfA%3D","updated":"2013-02-27 19:18:30.000000000","message":"/me hides","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":204,"context_line":"        db.clear_db()"},{"line_number":205,"context_line":"        db._ENGINE \u003d None"},{"line_number":206,"context_line":"        db._MAKER \u003d None"},{"line_number":207,"context_line":"        cfg.CONF.reset()"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    # FIXME (markmcclain):  The test setup makes it difficult to add core"},{"line_number":210,"context_line":"    # via the api. In the interim we\u0027ll create directly using the plugin with"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BkSA%3D","line":207,"updated":"2013-02-27 05:36:16.000000000","message":"Needs to add super(RouterServiceInsertionTestCase, self).tearDown()","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":204,"context_line":"        db.clear_db()"},{"line_number":205,"context_line":"        db._ENGINE \u003d None"},{"line_number":206,"context_line":"        db._MAKER \u003d None"},{"line_number":207,"context_line":"        cfg.CONF.reset()"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    # FIXME (markmcclain):  The test setup makes it difficult to add core"},{"line_number":210,"context_line":"    # via the api. In the interim we\u0027ll create directly using the plugin with"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2BjJg%3D","line":207,"in_reply_to":"AAAAM3%2F%2BkSA%3D","updated":"2013-02-27 19:18:30.000000000","message":"This has been fixed in a later version.","commit_id":"8c60de0784c4ddaa478c5cfdf05020f77751e762"}]}
