)]}'
{"neutron/agent/l3/agent.py":[{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"0e2be72a4e12054cb422540a4f5a8fa8d0111421","unresolved":false,"context_lines":[{"line_number":581,"context_line":"                        ns_manager.keep_ext_net(ext_net_id)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"                rpc_priority \u003d self.rpc_priority_updates"},{"line_number":584,"context_line":"                self.rpc_priority_updates \u003d set()"},{"line_number":585,"context_line":"                priority \u003d (queue.PRIORITY_RPC if r[\u0027id\u0027] in rpc_priority"},{"line_number":586,"context_line":"                            else queue.PRIORITY_SYNC_ROUTERS_TASK)"},{"line_number":587,"context_line":"                update \u003d queue.RouterUpdate(r[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_3c0a8027","line":584,"updated":"2015-09-15 03:23:58.000000000","message":"I don\u0027t think you want to clear self.rpc_priority_updates in the middle of the for loop, since each time through the for loop you are checking if the r[\u0027id\u0027] is in that priority list.  self_rpc_priority should only be cleared after the for loop has exited.","commit_id":"d5ba8bbba83ea5924503afd1eb0e610ea49b74e2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cf6f813883cb1d9fb0ed5edb4feed028113d8b8f","unresolved":false,"context_lines":[{"line_number":581,"context_line":"                        ns_manager.keep_ext_net(ext_net_id)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"                rpc_priority \u003d self.rpc_priority_updates"},{"line_number":584,"context_line":"                self.rpc_priority_updates \u003d set()"},{"line_number":585,"context_line":"                priority \u003d (queue.PRIORITY_RPC if r[\u0027id\u0027] in rpc_priority"},{"line_number":586,"context_line":"                            else queue.PRIORITY_SYNC_ROUTERS_TASK)"},{"line_number":587,"context_line":"                update \u003d queue.RouterUpdate(r[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_aa8cf87f","line":584,"in_reply_to":"ba15a1d1_3c0a8027","updated":"2015-09-15 09:28:28.000000000","message":"can\u0027t believe I did it in a loop.","commit_id":"d5ba8bbba83ea5924503afd1eb0e610ea49b74e2"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebfa06e6485cf4563b39defc9300a28c740ac440","unresolved":false,"context_lines":[{"line_number":600,"context_line":"            for router_id in self.rpc_priority_updates:"},{"line_number":601,"context_line":"                update \u003d queue.RouterUpdate(router_id, queue.PRIORITY_RPC)"},{"line_number":602,"context_line":"                self._queue.add(update)"},{"line_number":603,"context_line":"            self.rpc_priority_updates \u003d set()"},{"line_number":604,"context_line":"            self.fullsync \u003d False"},{"line_number":605,"context_line":"            LOG.debug(\"periodic_sync_routers_task successfully completed\")"},{"line_number":606,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_3e1f06b9","line":603,"updated":"2015-10-23 17:52:28.000000000","message":"If a router update happens at this point, this code would clear the routers added.  Maybe discard each id instead.  However, as long as fullsync\u003dTrue, rpc_priority_updates could keep getting updated.","commit_id":"d5e8b41c823f1797343bd1af0b99370bee0740c2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"888aeaa2dd83d230023e7b3cbcbfb47825e3c4a5","unresolved":false,"context_lines":[{"line_number":600,"context_line":"            for router_id in self.rpc_priority_updates:"},{"line_number":601,"context_line":"                update \u003d queue.RouterUpdate(router_id, queue.PRIORITY_RPC)"},{"line_number":602,"context_line":"                self._queue.add(update)"},{"line_number":603,"context_line":"            self.rpc_priority_updates \u003d set()"},{"line_number":604,"context_line":"            self.fullsync \u003d False"},{"line_number":605,"context_line":"            LOG.debug(\"periodic_sync_routers_task successfully completed\")"},{"line_number":606,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_c4c73c94","line":603,"in_reply_to":"3a29b11f_3e1f06b9","updated":"2015-11-13 07:46:33.000000000","message":"I\u0027ll see what can I do to make it safer","commit_id":"d5e8b41c823f1797343bd1af0b99370bee0740c2"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3038657b523db962c9d5e6b495a3374ae2c2cb19","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            if self.fullsync:"},{"line_number":394,"context_line":"                LOG.debug(\u0027Skipping notification since agent is about to \u0027"},{"line_number":395,"context_line":"                          \u0027perform a full sync\u0027)"},{"line_number":396,"context_line":"                self.rpc_priority_updates |\u003d set(routers)"},{"line_number":397,"context_line":"                return"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"            for id in routers:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_42523415","line":396,"updated":"2015-11-16 14:20:14.000000000","message":"I still think that a race condition exists since there is no locking done on the fullsync and/or rpc_priority_updates.  It is possible for fullsync to be true and and have the rpc_priority_updates cleared by line 592 after this line runs.","commit_id":"21eddfb00c25cb797eb5aa073d45b56c458e00e6"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"bf390aaa27bb8ecc8496a1724a34ad3c3e7a992d","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            if self.fullsync:"},{"line_number":394,"context_line":"                LOG.debug(\u0027Skipping notification since agent is about to \u0027"},{"line_number":395,"context_line":"                          \u0027perform a full sync\u0027)"},{"line_number":396,"context_line":"                self.rpc_priority_updates |\u003d set(routers)"},{"line_number":397,"context_line":"                return"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"            for id in routers:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_e5d1b9ce","line":396,"in_reply_to":"ba8a016a_12ebe1b1","updated":"2015-11-17 13:07:40.000000000","message":"I\u0027m not clear on how that is done, so I\u0027ll defer to others.","commit_id":"21eddfb00c25cb797eb5aa073d45b56c458e00e6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"626a5097041f330c2b5b858095c0032d91141ccd","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            if self.fullsync:"},{"line_number":394,"context_line":"                LOG.debug(\u0027Skipping notification since agent is about to \u0027"},{"line_number":395,"context_line":"                          \u0027perform a full sync\u0027)"},{"line_number":396,"context_line":"                self.rpc_priority_updates |\u003d set(routers)"},{"line_number":397,"context_line":"                return"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"            for id in routers:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_12ebe1b1","line":396,"in_reply_to":"ba8a016a_42523415","updated":"2015-11-17 12:44:25.000000000","message":"Given the nature of python green threads lines 585-592 can be considered \"atomic\", so I believe we should be on the safe side","commit_id":"21eddfb00c25cb797eb5aa073d45b56c458e00e6"}],"neutron/tests/unit/agent/l3/test_agent.py":[{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"0e2be72a4e12054cb422540a4f5a8fa8d0111421","unresolved":false,"context_lines":[{"line_number":1664,"context_line":"        agent.fullsync \u003d False"},{"line_number":1665,"context_line":"        agent._queue \u003d mock.Mock()"},{"line_number":1666,"context_line":"        agent.routers_updated(None, [FAKE_ID])"},{"line_number":1667,"context_line":"        self.assertEqual(1, agent._queue.add.call_count)"},{"line_number":1668,"context_line":""},{"line_number":1669,"context_line":"    def test_routers_updated_during_fullsync(self):"},{"line_number":1670,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_d7031db7","line":1667,"updated":"2015-09-15 03:23:58.000000000","message":"Should check self.assertEqual(0, len(agent.rpc_priority_updates)) to verify that nothing gets added to rpc_priority_updates when fullsync is false","commit_id":"d5ba8bbba83ea5924503afd1eb0e610ea49b74e2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cf6f813883cb1d9fb0ed5edb4feed028113d8b8f","unresolved":false,"context_lines":[{"line_number":1664,"context_line":"        agent.fullsync \u003d False"},{"line_number":1665,"context_line":"        agent._queue \u003d mock.Mock()"},{"line_number":1666,"context_line":"        agent.routers_updated(None, [FAKE_ID])"},{"line_number":1667,"context_line":"        self.assertEqual(1, agent._queue.add.call_count)"},{"line_number":1668,"context_line":""},{"line_number":1669,"context_line":"    def test_routers_updated_during_fullsync(self):"},{"line_number":1670,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_6aed8024","line":1667,"in_reply_to":"ba15a1d1_d7031db7","updated":"2015-09-15 09:28:28.000000000","message":"Done","commit_id":"d5ba8bbba83ea5924503afd1eb0e610ea49b74e2"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"0e2be72a4e12054cb422540a4f5a8fa8d0111421","unresolved":false,"context_lines":[{"line_number":1671,"context_line":"        agent._queue \u003d mock.Mock()"},{"line_number":1672,"context_line":"        agent.routers_updated(None, [FAKE_ID])"},{"line_number":1673,"context_line":"        self.assertEqual(1, len(agent.rpc_priority_updates))"},{"line_number":1674,"context_line":"        self.assertIn(FAKE_ID, agent.rpc_priority_updates)"},{"line_number":1675,"context_line":""},{"line_number":1676,"context_line":"    def test_removed_from_agent(self):"},{"line_number":1677,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_17faf5bd","line":1674,"updated":"2015-09-15 03:23:58.000000000","message":"Should check self.assertEqual(0, agent._queue.add.call_count) to verify that an update was NOT queued up due to fullsync being set","commit_id":"d5ba8bbba83ea5924503afd1eb0e610ea49b74e2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cf6f813883cb1d9fb0ed5edb4feed028113d8b8f","unresolved":false,"context_lines":[{"line_number":1671,"context_line":"        agent._queue \u003d mock.Mock()"},{"line_number":1672,"context_line":"        agent.routers_updated(None, [FAKE_ID])"},{"line_number":1673,"context_line":"        self.assertEqual(1, len(agent.rpc_priority_updates))"},{"line_number":1674,"context_line":"        self.assertIn(FAKE_ID, agent.rpc_priority_updates)"},{"line_number":1675,"context_line":""},{"line_number":1676,"context_line":"    def test_removed_from_agent(self):"},{"line_number":1677,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_0af404f0","line":1674,"in_reply_to":"ba15a1d1_17faf5bd","updated":"2015-09-15 09:28:28.000000000","message":"Done","commit_id":"d5ba8bbba83ea5924503afd1eb0e610ea49b74e2"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"0e2be72a4e12054cb422540a4f5a8fa8d0111421","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"        agent.fullsync \u003d False"},{"line_number":1685,"context_line":"        agent._queue \u003d mock.Mock()"},{"line_number":1686,"context_line":"        agent.router_added_to_agent(None, [FAKE_ID])"},{"line_number":1687,"context_line":"        self.assertEqual(1, agent._queue.add.call_count)"},{"line_number":1688,"context_line":""},{"line_number":1689,"context_line":"    def test_added_to_agent_during_fullsync(self):"},{"line_number":1690,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_77b9f1e8","line":1687,"updated":"2015-09-15 03:23:58.000000000","message":"See my comment above for test_routers_updated","commit_id":"d5ba8bbba83ea5924503afd1eb0e610ea49b74e2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cf6f813883cb1d9fb0ed5edb4feed028113d8b8f","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"        agent.fullsync \u003d False"},{"line_number":1685,"context_line":"        agent._queue \u003d mock.Mock()"},{"line_number":1686,"context_line":"        agent.router_added_to_agent(None, [FAKE_ID])"},{"line_number":1687,"context_line":"        self.assertEqual(1, agent._queue.add.call_count)"},{"line_number":1688,"context_line":""},{"line_number":1689,"context_line":"    def test_added_to_agent_during_fullsync(self):"},{"line_number":1690,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_8ae81412","line":1687,"in_reply_to":"ba15a1d1_77b9f1e8","updated":"2015-09-15 09:28:28.000000000","message":"Done","commit_id":"d5ba8bbba83ea5924503afd1eb0e610ea49b74e2"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"0e2be72a4e12054cb422540a4f5a8fa8d0111421","unresolved":false,"context_lines":[{"line_number":1691,"context_line":"        agent._queue \u003d mock.Mock()"},{"line_number":1692,"context_line":"        agent.router_added_to_agent(None, [FAKE_ID])"},{"line_number":1693,"context_line":"        self.assertEqual(1, len(agent.rpc_priority_updates))"},{"line_number":1694,"context_line":"        self.assertIn(FAKE_ID, agent.rpc_priority_updates)"},{"line_number":1695,"context_line":""},{"line_number":1696,"context_line":"    def test_destroy_namespace(self):"},{"line_number":1697,"context_line":"        namespace \u003d \u0027qrouter-bar\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_f7c5015b","line":1694,"updated":"2015-09-15 03:23:58.000000000","message":"See my comment above for test_routers_updated_during_fullsync","commit_id":"d5ba8bbba83ea5924503afd1eb0e610ea49b74e2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"cf6f813883cb1d9fb0ed5edb4feed028113d8b8f","unresolved":false,"context_lines":[{"line_number":1691,"context_line":"        agent._queue \u003d mock.Mock()"},{"line_number":1692,"context_line":"        agent.router_added_to_agent(None, [FAKE_ID])"},{"line_number":1693,"context_line":"        self.assertEqual(1, len(agent.rpc_priority_updates))"},{"line_number":1694,"context_line":"        self.assertIn(FAKE_ID, agent.rpc_priority_updates)"},{"line_number":1695,"context_line":""},{"line_number":1696,"context_line":"    def test_destroy_namespace(self):"},{"line_number":1697,"context_line":"        namespace \u003d \u0027qrouter-bar\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_aae39832","line":1694,"in_reply_to":"ba15a1d1_f7c5015b","updated":"2015-09-15 09:28:28.000000000","message":"Done","commit_id":"d5ba8bbba83ea5924503afd1eb0e610ea49b74e2"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebfa06e6485cf4563b39defc9300a28c740ac440","unresolved":false,"context_lines":[{"line_number":1676,"context_line":"    def test_router_deleted(self):"},{"line_number":1677,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":1678,"context_line":"        agent._queue \u003d mock.Mock()"},{"line_number":1679,"context_line":"        agent.router_deleted(None, FAKE_ID)"},{"line_number":1680,"context_line":"        self.assertEqual(1, agent._queue.add.call_count)"},{"line_number":1681,"context_line":""},{"line_number":1682,"context_line":"    def test_routers_updated(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_de5db27a","line":1679,"updated":"2015-10-23 17:52:28.000000000","message":"This should ensure that agent.rpc_priority_updates is empty too.","commit_id":"d5e8b41c823f1797343bd1af0b99370bee0740c2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"888aeaa2dd83d230023e7b3cbcbfb47825e3c4a5","unresolved":false,"context_lines":[{"line_number":1676,"context_line":"    def test_router_deleted(self):"},{"line_number":1677,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":1678,"context_line":"        agent._queue \u003d mock.Mock()"},{"line_number":1679,"context_line":"        agent.router_deleted(None, FAKE_ID)"},{"line_number":1680,"context_line":"        self.assertEqual(1, agent._queue.add.call_count)"},{"line_number":1681,"context_line":""},{"line_number":1682,"context_line":"    def test_routers_updated(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_443a6c9a","line":1679,"in_reply_to":"3a29b11f_de5db27a","updated":"2015-11-13 07:46:33.000000000","message":"Done","commit_id":"d5e8b41c823f1797343bd1af0b99370bee0740c2"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebfa06e6485cf4563b39defc9300a28c740ac440","unresolved":false,"context_lines":[{"line_number":1698,"context_line":"    def test_removed_from_agent(self):"},{"line_number":1699,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":1700,"context_line":"        agent._queue \u003d mock.Mock()"},{"line_number":1701,"context_line":"        agent.router_removed_from_agent(None, {\u0027router_id\u0027: FAKE_ID})"},{"line_number":1702,"context_line":"        self.assertEqual(1, agent._queue.add.call_count)"},{"line_number":1703,"context_line":""},{"line_number":1704,"context_line":"    def test_added_to_agent(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_1e648a47","line":1701,"updated":"2015-10-23 17:52:28.000000000","message":"This should ensure that agent.rpc_priority_updates is empty too.","commit_id":"d5e8b41c823f1797343bd1af0b99370bee0740c2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"888aeaa2dd83d230023e7b3cbcbfb47825e3c4a5","unresolved":false,"context_lines":[{"line_number":1698,"context_line":"    def test_removed_from_agent(self):"},{"line_number":1699,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":1700,"context_line":"        agent._queue \u003d mock.Mock()"},{"line_number":1701,"context_line":"        agent.router_removed_from_agent(None, {\u0027router_id\u0027: FAKE_ID})"},{"line_number":1702,"context_line":"        self.assertEqual(1, agent._queue.add.call_count)"},{"line_number":1703,"context_line":""},{"line_number":1704,"context_line":"    def test_added_to_agent(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_643d308e","line":1701,"in_reply_to":"3a29b11f_1e648a47","updated":"2015-11-13 07:46:33.000000000","message":"Done","commit_id":"d5e8b41c823f1797343bd1af0b99370bee0740c2"}]}
