)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"135a5d630fc95305a4c418af0faf469a19dd943b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds the availability_zone support for router."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"APIImpact"},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id26d9494b9a5b459767e93a850f47a3b014b11bb"},{"line_number":15,"context_line":"Co-Authored-By: IWAMOTO Toshihiro \u003ciwamoto@valinux.co.jp\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"7a740942_28dd7e14","line":12,"updated":"2015-12-04 01:11:26.000000000","message":"Something I forgot to mention:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-November/080294.html\n\nThe message that went lost in neutron.conf should be turned into a one-liner next to DocImpact. Feel to elaborate on this commit message.","commit_id":"7479b31982966a2539bf0a34ea5c6fad894bc359"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"ea43977717446e498821defb1f2eff39cd116203","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds the availability_zone support for router."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"APIImpact"},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id26d9494b9a5b459767e93a850f47a3b014b11bb"},{"line_number":15,"context_line":"Co-Authored-By: IWAMOTO Toshihiro \u003ciwamoto@valinux.co.jp\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"7a740942_b84e9dbf","line":12,"in_reply_to":"7a740942_28dd7e14","updated":"2015-12-04 02:01:27.000000000","message":"Done","commit_id":"7479b31982966a2539bf0a34ea5c6fad894bc359"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4affd34418a77c42880677db0a027175ef779481","unresolved":false,"context_lines":[{"line_number":13,"context_line":"availability zones are used, set router_scheduler_driver \u003d"},{"line_number":14,"context_line":"neutron.scheduler.l3_agent_scheduler.AZLeastRoutersScheduler. This scheduler"},{"line_number":15,"context_line":"selects agent depends on LeastRoutersScheduler logic within an availability"},{"line_number":16,"context_line":"zone so that considers the weight of agent."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Id26d9494b9a5b459767e93a850f47a3b014b11bb"},{"line_number":19,"context_line":"Co-Authored-By: IWAMOTO Toshihiro \u003ciwamoto@valinux.co.jp\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"7a740942_389f0d05","line":16,"updated":"2015-12-04 02:17:19.000000000","message":"too long?","commit_id":"2e32808c748babe893cf157394be2f149d8c3052"}],"neutron/db/availability_zone/router.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"fb67c595618f0d62189f4ec537823d64f788dd65","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            self.validate_availability_zones(context, \u0027router\u0027,"},{"line_number":43,"context_line":"                                             router_req[az_ext.AZ_HINTS])"},{"line_number":44,"context_line":"            router_req[az_ext.AZ_HINTS] \u003d az_ext.convert_az_list_to_string("},{"line_number":45,"context_line":"                                router_req[az_ext.AZ_HINTS])"},{"line_number":46,"context_line":"        super(RouterAvailabilityZoneMixin,"},{"line_number":47,"context_line":"            self)._process_extra_attr_router_create(context, router_db,"},{"line_number":48,"context_line":"                                                    router_req)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_d1e849b5","line":45,"updated":"2015-11-30 11:32:26.000000000","message":"Indentation","commit_id":"4ad343e9059841c95dffb356640ccf8a75c1e7ed"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"84c0c95c96ebcfe4ada55eea24948477942c1ee0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            self.validate_availability_zones(context, \u0027router\u0027,"},{"line_number":43,"context_line":"                                             router_req[az_ext.AZ_HINTS])"},{"line_number":44,"context_line":"            router_req[az_ext.AZ_HINTS] \u003d az_ext.convert_az_list_to_string("},{"line_number":45,"context_line":"                                router_req[az_ext.AZ_HINTS])"},{"line_number":46,"context_line":"        super(RouterAvailabilityZoneMixin,"},{"line_number":47,"context_line":"            self)._process_extra_attr_router_create(context, router_db,"},{"line_number":48,"context_line":"                                                    router_req)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_7324fd0b","line":45,"in_reply_to":"9a8ffd7b_d1e849b5","updated":"2015-11-30 13:17:40.000000000","message":"Done","commit_id":"4ad343e9059841c95dffb356640ccf8a75c1e7ed"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ddff50e993b6ce5e9855d5ce40e95e422f757d59","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.extensions import availability_zone as az_ext"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class RouterAvailabilityZoneMixin(l3_attrs_db.ExtraAttributesMixin):"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_7f2a5be9","line":21,"updated":"2015-12-01 02:12:57.000000000","message":"you\u0027re not using this here.","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c81b3ff9b738ab08d4dac788110894e63eee0ca","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.extensions import availability_zone as az_ext"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class RouterAvailabilityZoneMixin(l3_attrs_db.ExtraAttributesMixin):"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_48b47ad0","line":21,"in_reply_to":"9a8ffd7b_7f2a5be9","updated":"2015-12-01 07:37:28.000000000","message":"Done","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"}],"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"65b146b376c16bc55350a77776c49ceebdb552b5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.BoolOpt(\u0027allow_automatic_l3agent_failover\u0027, default\u003dFalse,"},{"line_number":53,"context_line":"                help\u003d_(\u0027Automatically reschedule routers from offline L3 \u0027"},{"line_number":54,"context_line":"                       \u0027agents to online L3 agents.\u0027)),"},{"line_number":55,"context_line":"    cfg.BoolOpt(\u0027router_scheduler_availability_zone_aware\u0027,"},{"line_number":56,"context_line":"                default\u003dFalse,"},{"line_number":57,"context_line":"                help\u003d_(\u0027Make router scheduler availability_zone aware. \u0027"},{"line_number":58,"context_line":"                       \u0027If multiple availability zones are used, set this \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba8a016a_107df51b","line":55,"updated":"2015-11-23 21:36:10.000000000","message":"why using a different approach for dhcp/router schedulers (ie: an AZ specific driver for dhcp, an option for router)?","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4b56921bd37cee50a650dfd3571003b17fc56a46","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.BoolOpt(\u0027allow_automatic_l3agent_failover\u0027, default\u003dFalse,"},{"line_number":53,"context_line":"                help\u003d_(\u0027Automatically reschedule routers from offline L3 \u0027"},{"line_number":54,"context_line":"                       \u0027agents to online L3 agents.\u0027)),"},{"line_number":55,"context_line":"    cfg.BoolOpt(\u0027router_scheduler_availability_zone_aware\u0027,"},{"line_number":56,"context_line":"                default\u003dFalse,"},{"line_number":57,"context_line":"                help\u003d_(\u0027Make router scheduler availability_zone aware. \u0027"},{"line_number":58,"context_line":"                       \u0027If multiple availability zones are used, set this \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_f9639d3f","line":55,"in_reply_to":"ba8a016a_107df51b","updated":"2015-11-25 15:05:48.000000000","message":"I changed option to AZ scheduler method.","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"fb67c595618f0d62189f4ec537823d64f788dd65","unresolved":false,"context_lines":[{"line_number":545,"context_line":""},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"class AZL3AgentSchedulerDbMixin(L3AgentSchedulerDbMixin,"},{"line_number":548,"context_line":"                        router_az_ext.RouterAvailabilityZonePluginBase):"},{"line_number":549,"context_line":"    \"\"\"Mixin class to add availability_zone supported l3 agent scheduler.\"\"\""},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def get_router_availability_zones(self, router_id):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_71707d0b","line":548,"updated":"2015-11-30 11:32:26.000000000","message":"Indentation","commit_id":"4ad343e9059841c95dffb356640ccf8a75c1e7ed"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"84c0c95c96ebcfe4ada55eea24948477942c1ee0","unresolved":false,"context_lines":[{"line_number":545,"context_line":""},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"class AZL3AgentSchedulerDbMixin(L3AgentSchedulerDbMixin,"},{"line_number":548,"context_line":"                        router_az_ext.RouterAvailabilityZonePluginBase):"},{"line_number":549,"context_line":"    \"\"\"Mixin class to add availability_zone supported l3 agent scheduler.\"\"\""},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def get_router_availability_zones(self, router_id):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_f37eade2","line":548,"in_reply_to":"9a8ffd7b_71707d0b","updated":"2015-11-30 13:17:40.000000000","message":"Done","commit_id":"4ad343e9059841c95dffb356640ccf8a75c1e7ed"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ddff50e993b6ce5e9855d5ce40e95e422f757d59","unresolved":false,"context_lines":[{"line_number":549,"context_line":"    \"\"\"Mixin class to add availability_zone supported l3 agent scheduler.\"\"\""},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def get_router_availability_zones(self, router_id):"},{"line_number":552,"context_line":"        context \u003d n_ctx.get_admin_context()"},{"line_number":553,"context_line":"        with context.session.begin():"},{"line_number":554,"context_line":"            query \u003d context.session.query(agents_db.Agent.availability_zone)"},{"line_number":555,"context_line":"            query \u003d query.join(RouterL3AgentBinding)"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_1f51cf62","line":552,"updated":"2015-12-01 02:12:57.000000000","message":"I think here elevating the context is not necessary. Are you sure this is necessary? You\u0027re querying the DB bypassing any sort of utility function that uses the context.","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c81b3ff9b738ab08d4dac788110894e63eee0ca","unresolved":false,"context_lines":[{"line_number":549,"context_line":"    \"\"\"Mixin class to add availability_zone supported l3 agent scheduler.\"\"\""},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def get_router_availability_zones(self, router_id):"},{"line_number":552,"context_line":"        context \u003d n_ctx.get_admin_context()"},{"line_number":553,"context_line":"        with context.session.begin():"},{"line_number":554,"context_line":"            query \u003d context.session.query(agents_db.Agent.availability_zone)"},{"line_number":555,"context_line":"            query \u003d query.join(RouterL3AgentBinding)"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_e8c9ae5b","line":552,"in_reply_to":"9a8ffd7b_1f51cf62","updated":"2015-12-01 07:37:28.000000000","message":"You\u0027re right. I updated.","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"}],"neutron/db/l3_attrs_db.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"4a4d01e1240b7df79ffb7f62011b0f825b9df01b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                   nullable\u003dFalse)"},{"line_number":46,"context_line":"    ha_vr_id \u003d sa.Column(sa.Integer())"},{"line_number":47,"context_line":"    # Availability Zone support"},{"line_number":48,"context_line":"    availability_zone_hints \u003d sa.Column(sa.String(255))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    router \u003d orm.relationship("},{"line_number":51,"context_line":"        l3_db.Router,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba8a016a_5a271e64","line":48,"updated":"2015-11-17 23:57:34.000000000","message":"why hints and not hint?","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"65b146b376c16bc55350a77776c49ceebdb552b5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                   nullable\u003dFalse)"},{"line_number":46,"context_line":"    ha_vr_id \u003d sa.Column(sa.Integer())"},{"line_number":47,"context_line":"    # Availability Zone support"},{"line_number":48,"context_line":"    availability_zone_hints \u003d sa.Column(sa.String(255))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    router \u003d orm.relationship("},{"line_number":51,"context_line":"        l3_db.Router,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba8a016a_d0c44d41","line":48,"in_reply_to":"ba8a016a_5a271e64","updated":"2015-11-23 21:36:10.000000000","message":"forget about it","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"}],"neutron/db/l3_hascheduler_db.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"434fd8d1d69d5bdebf346de5feabf7299e8227c5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                 join(sub_query))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        routers_agents \u003d []"},{"line_number":50,"context_line":"        for router, agents in query:"},{"line_number":51,"context_line":"            routers_agents.append((self._make_router_dict(router), agents))"},{"line_number":52,"context_line":"        return routers_agents"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"9a8ffd7b_ec54d4c6","line":50,"updated":"2015-12-03 06:54:28.000000000","message":"this could have been a nice comprehension:\n\n  return [\n    (self._make_router_dict(router), agents) for router, agents in query\n  ]\n\nwouldn\u0027t \u0027agents\u0027 be more aptly named agent_count?","commit_id":"36d59be9926f70b88a957386a9a5cfc18f8de7f0"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2ffc022b49336a2dc63c2dcd11d78caf5cac07c5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                 join(sub_query))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        routers_agents \u003d []"},{"line_number":50,"context_line":"        for router, agents in query:"},{"line_number":51,"context_line":"            routers_agents.append((self._make_router_dict(router), agents))"},{"line_number":52,"context_line":"        return routers_agents"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"9a8ffd7b_f41d6973","line":50,"in_reply_to":"9a8ffd7b_453293a8","updated":"2015-12-03 13:02:47.000000000","message":"Done","commit_id":"36d59be9926f70b88a957386a9a5cfc18f8de7f0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6cd5071008cd6a62ef210aa934297716f010b7de","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                 join(sub_query))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        routers_agents \u003d []"},{"line_number":50,"context_line":"        for router, agents in query:"},{"line_number":51,"context_line":"            routers_agents.append((self._make_router_dict(router), agents))"},{"line_number":52,"context_line":"        return routers_agents"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"9a8ffd7b_453293a8","line":50,"in_reply_to":"9a8ffd7b_ec54d4c6","updated":"2015-12-03 08:28:45.000000000","message":"+1, especially in the second point of naming.","commit_id":"36d59be9926f70b88a957386a9a5cfc18f8de7f0"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"bdf7a07e90cab3f0ad95ea97c26b405155b4f6f9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                 join(sub_query))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        return [(self._make_router_dict(router), agent_count)"},{"line_number":50,"context_line":"                for router, agents in query]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def get_l3_agents_ordered_by_num_routers(self, context, agent_ids):"},{"line_number":53,"context_line":"        if not agent_ids:"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a8ffd7b_5dd57119","line":50,"updated":"2015-12-03 14:53:30.000000000","message":"Oops ;)","commit_id":"34114328cb8a846a90aabeb2ce6a1382fcf2b77c"}],"neutron/extensions/router_availability_zone.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e344fd284605bd045ef1bef2ff04d862333f59e1","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @classmethod"},{"line_number":46,"context_line":"    def get_description(cls):"},{"line_number":47,"context_line":"        return \"The router availability zone extension.\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @classmethod"},{"line_number":50,"context_line":"    def get_updated(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_b885985a","line":47,"updated":"2015-11-12 02:53:17.000000000","message":"nit comment: Should this description be consistent with the one in network_availability_zone?","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4b56921bd37cee50a650dfd3571003b17fc56a46","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @classmethod"},{"line_number":46,"context_line":"    def get_description(cls):"},{"line_number":47,"context_line":"        return \"The router availability zone extension.\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @classmethod"},{"line_number":50,"context_line":"    def get_updated(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_1c63efdd","line":47,"in_reply_to":"da85f559_b885985a","updated":"2015-11-25 15:05:48.000000000","message":"Done","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"4a4d01e1240b7df79ffb7f62011b0f825b9df01b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"class RouterAvailabilityZonePluginBase(object):"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @abc.abstractmethod"},{"line_number":67,"context_line":"    def get_router_availability_zones(self, router_id):"},{"line_number":68,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba8a016a_da1b0e1a","line":67,"updated":"2015-11-17 23:57:34.000000000","message":"a docstring seems required","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4b56921bd37cee50a650dfd3571003b17fc56a46","unresolved":false,"context_lines":[{"line_number":64,"context_line":"class RouterAvailabilityZonePluginBase(object):"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @abc.abstractmethod"},{"line_number":67,"context_line":"    def get_router_availability_zones(self, router_id):"},{"line_number":68,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_dc9b27c8","line":67,"in_reply_to":"ba8a016a_da1b0e1a","updated":"2015-11-25 15:05:48.000000000","message":"Done","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ddff50e993b6ce5e9855d5ce40e95e422f757d59","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @abc.abstractmethod"},{"line_number":67,"context_line":"    def get_router_availability_zones(self, router_id):"},{"line_number":68,"context_line":"        \"\"\"Return availability zones which a router belongs to\"\"\""}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_5fbaf76f","line":68,"updated":"2015-12-01 02:12:57.000000000","message":"missing trailing period.","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c81b3ff9b738ab08d4dac788110894e63eee0ca","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @abc.abstractmethod"},{"line_number":67,"context_line":"    def get_router_availability_zones(self, router_id):"},{"line_number":68,"context_line":"        \"\"\"Return availability zones which a router belongs to\"\"\""}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_a8c3a637","line":68,"in_reply_to":"9a8ffd7b_5fbaf76f","updated":"2015-12-01 07:37:28.000000000","message":"Done","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"}],"neutron/scheduler/l3_agent_scheduler.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e344fd284605bd045ef1bef2ff04d862333f59e1","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            if max_agents_not_reached:"},{"line_number":334,"context_line":"                router \u003d plugin.get_router(admin_ctx, router_id)"},{"line_number":335,"context_line":"                az_hints \u003d (router.get(az_ext.AZ_HINTS) or"},{"line_number":336,"context_line":"                            cfg.CONF.default_availability_zones)"},{"line_number":337,"context_line":"                if az_hints and agent[\u0027availability_zone\u0027] not in az_hints:"},{"line_number":338,"context_line":"                    continue"},{"line_number":339,"context_line":"                if not self._router_has_binding(admin_ctx, router_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_7b0baa7d","line":336,"updated":"2015-11-12 02:53:17.000000000","message":"nit comment: I see these 2 lines code appears 3 times in this file. Could you consider to put them in a method?","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4b56921bd37cee50a650dfd3571003b17fc56a46","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            if max_agents_not_reached:"},{"line_number":334,"context_line":"                router \u003d plugin.get_router(admin_ctx, router_id)"},{"line_number":335,"context_line":"                az_hints \u003d (router.get(az_ext.AZ_HINTS) or"},{"line_number":336,"context_line":"                            cfg.CONF.default_availability_zones)"},{"line_number":337,"context_line":"                if az_hints and agent[\u0027availability_zone\u0027] not in az_hints:"},{"line_number":338,"context_line":"                    continue"},{"line_number":339,"context_line":"                if not self._router_has_binding(admin_ctx, router_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_fce06bce","line":336,"in_reply_to":"da85f559_7b0baa7d","updated":"2015-11-25 15:05:48.000000000","message":"I can understand but I think that it\u0027s very short sentence and a little effect.","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"4a4d01e1240b7df79ffb7f62011b0f825b9df01b","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    def _choose_agents_az_aware(self, group_by_az, num_agents):"},{"line_number":383,"context_line":"        selected_agents \u003d []"},{"line_number":384,"context_line":"        while num_agents \u003e 0:"},{"line_number":385,"context_line":"            for az in group_by_az.keys():"},{"line_number":386,"context_line":"                if not group_by_az[az]:"},{"line_number":387,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba8a016a_1a743666","line":384,"updated":"2015-11-17 23:57:34.000000000","message":"Nothing ensures this loop ends\n\nYou can use a unique loop:\n\n for az, agents in itertools.cycle(group_by_az.items()):","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4b56921bd37cee50a650dfd3571003b17fc56a46","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    def _choose_agents_az_aware(self, group_by_az, num_agents):"},{"line_number":383,"context_line":"        selected_agents \u003d []"},{"line_number":384,"context_line":"        while num_agents \u003e 0:"},{"line_number":385,"context_line":"            for az in group_by_az.keys():"},{"line_number":386,"context_line":"                if not group_by_az[az]:"},{"line_number":387,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_dc04877f","line":384,"in_reply_to":"ba8a016a_1a743666","updated":"2015-11-25 15:05:48.000000000","message":"Done","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"073586f3a27c7f69e90c7e55f480e92100796106","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    def _choose_agents_az_aware(self, group_by_az, num_agents):"},{"line_number":383,"context_line":"        selected_agents \u003d []"},{"line_number":384,"context_line":"        while num_agents \u003e 0:"},{"line_number":385,"context_line":"            for az in group_by_az.keys():"},{"line_number":386,"context_line":"                if not group_by_az[az]:"},{"line_number":387,"context_line":"                    continue"},{"line_number":388,"context_line":"                agent \u003d group_by_az[az].pop(0)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a1a9d01_4e72257e","line":385,"updated":"2015-10-02 12:12:26.000000000","message":"Don\u0027t need keys().  Could you do:\n    for az, agents in group_by_az.items():\n        if not agents:\n            continue\n        agent \u003d agents.pop(0)\n        ...","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4b56921bd37cee50a650dfd3571003b17fc56a46","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    def _choose_agents_az_aware(self, group_by_az, num_agents):"},{"line_number":383,"context_line":"        selected_agents \u003d []"},{"line_number":384,"context_line":"        while num_agents \u003e 0:"},{"line_number":385,"context_line":"            for az in group_by_az.keys():"},{"line_number":386,"context_line":"                if not group_by_az[az]:"},{"line_number":387,"context_line":"                    continue"},{"line_number":388,"context_line":"                agent \u003d group_by_az[az].pop(0)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_fc070b7f","line":385,"in_reply_to":"9a1a9d01_4e72257e","updated":"2015-11-25 15:05:48.000000000","message":"Done","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"40fb7059a715a2dcd76a5378f98ec59711eefa0f","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        num_agents \u003d self._get_num_of_agents_for_ha(len(candidates))"},{"line_number":409,"context_line":"        if cfg.CONF.router_scheduler_availability_zone_aware:"},{"line_number":410,"context_line":"            group_by_az \u003d self._group_agents_by_az("},{"line_number":411,"context_line":"                            random.sample(candidates, len(candidates)))"},{"line_number":412,"context_line":"            return self._choose_agents_az_aware(group_by_az, num_agents)"},{"line_number":413,"context_line":"        return random.sample(candidates, num_agents)"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_bfd6f025","line":411,"updated":"2015-10-09 10:36:43.000000000","message":"Indentation","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4b56921bd37cee50a650dfd3571003b17fc56a46","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        num_agents \u003d self._get_num_of_agents_for_ha(len(candidates))"},{"line_number":409,"context_line":"        if cfg.CONF.router_scheduler_availability_zone_aware:"},{"line_number":410,"context_line":"            group_by_az \u003d self._group_agents_by_az("},{"line_number":411,"context_line":"                            random.sample(candidates, len(candidates)))"},{"line_number":412,"context_line":"            return self._choose_agents_az_aware(group_by_az, num_agents)"},{"line_number":413,"context_line":"        return random.sample(candidates, num_agents)"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_7ff46d86","line":411,"in_reply_to":"7a2fa921_bfd6f025","updated":"2015-11-25 15:05:48.000000000","message":"This was deleted","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"537a6a6283b029fd831165f7f372b32a20e12894","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        # NOTE(armando-migliaccio): DVR routers should not be auto"},{"line_number":146,"context_line":"        # scheduled because auto-scheduling may interfere with the"},{"line_number":147,"context_line":"        # placement rules for IR and SNAT namespaces."},{"line_number":148,"context_line":"        unscheduled_routers_tmp \u003d self._get_routers_to_schedule("},{"line_number":149,"context_line":"            context, plugin, router_ids, exclude_distributed\u003dTrue)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        unscheduled_routers \u003d []"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_5eb4ebcf","line":148,"updated":"2015-11-26 07:43:32.000000000","message":"how about all_unscheduled_routers?","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"05c8251c3298a3a15dc8e9177330f1920a53ffce","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        # NOTE(armando-migliaccio): DVR routers should not be auto"},{"line_number":146,"context_line":"        # scheduled because auto-scheduling may interfere with the"},{"line_number":147,"context_line":"        # placement rules for IR and SNAT namespaces."},{"line_number":148,"context_line":"        unscheduled_routers_tmp \u003d self._get_routers_to_schedule("},{"line_number":149,"context_line":"            context, plugin, router_ids, exclude_distributed\u003dTrue)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        unscheduled_routers \u003d []"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_cb24240e","line":148,"in_reply_to":"9a8ffd7b_5eb4ebcf","updated":"2015-11-30 07:58:50.000000000","message":"Done","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"537a6a6283b029fd831165f7f372b32a20e12894","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        unscheduled_routers \u003d []"},{"line_number":152,"context_line":"        az \u003d l3_agent[\u0027availability_zone\u0027]"},{"line_number":153,"context_line":"        for r in unscheduled_routers_tmp:"},{"line_number":154,"context_line":"            az_hints \u003d (r.get(az_ext.AZ_HINTS) or"},{"line_number":155,"context_line":"                        cfg.CONF.default_availability_zones)"},{"line_number":156,"context_line":"            if not az_hints or az in az_hints:"},{"line_number":157,"context_line":"                unscheduled_routers.append(r)"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_be7877f3","line":155,"range":{"start_line":154,"start_character":24,"end_line":155,"end_character":59},"updated":"2015-11-26 07:43:32.000000000","message":"This pattern appears several times. It looks better to have a method to get az_hints.","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"05c8251c3298a3a15dc8e9177330f1920a53ffce","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        az \u003d l3_agent[\u0027availability_zone\u0027]"},{"line_number":153,"context_line":"        for r in unscheduled_routers_tmp:"},{"line_number":154,"context_line":"            az_hints \u003d (r.get(az_ext.AZ_HINTS) or"},{"line_number":155,"context_line":"                        cfg.CONF.default_availability_zones)"},{"line_number":156,"context_line":"            if not az_hints or az in az_hints:"},{"line_number":157,"context_line":"                unscheduled_routers.append(r)"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_e697df37","line":155,"in_reply_to":"9a8ffd7b_be7877f3","updated":"2015-11-30 07:58:50.000000000","message":"Done","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"537a6a6283b029fd831165f7f372b32a20e12894","unresolved":false,"context_lines":[{"line_number":413,"context_line":""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"class AZLeastRoutersScheduler(LeastRoutersScheduler):"},{"line_number":416,"context_line":"    \"\"\"Availability zone aware scheduler."},{"line_number":417,"context_line":"       If a router is ha router, allocate L3 agents distributed AZs"},{"line_number":418,"context_line":"       according to router\u0027s az_hints."},{"line_number":419,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_5e3f0bd6","line":416,"updated":"2015-11-26 07:43:32.000000000","message":"nit: a blank line here. it is a docstring convention.","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"05c8251c3298a3a15dc8e9177330f1920a53ffce","unresolved":false,"context_lines":[{"line_number":413,"context_line":""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"class AZLeastRoutersScheduler(LeastRoutersScheduler):"},{"line_number":416,"context_line":"    \"\"\"Availability zone aware scheduler."},{"line_number":417,"context_line":"       If a router is ha router, allocate L3 agents distributed AZs"},{"line_number":418,"context_line":"       according to router\u0027s az_hints."},{"line_number":419,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_4b7fd4df","line":416,"in_reply_to":"9a8ffd7b_5e3f0bd6","updated":"2015-11-30 07:58:50.000000000","message":"Done","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"fb67c595618f0d62189f4ec537823d64f788dd65","unresolved":false,"context_lines":[{"line_number":432,"context_line":"            group_by_az[az].append(agent)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        selected_agents \u003d []"},{"line_number":435,"context_line":"        for az, agents in itertools.cycle(group_by_az.items()):"},{"line_number":436,"context_line":"            if not agents:"},{"line_number":437,"context_line":"                continue"},{"line_number":438,"context_line":"            selected_agents.append(agents.pop(0))"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_8487e1b3","line":435,"updated":"2015-11-30 11:32:26.000000000","message":"In my opinion there is possibility to receive infinity loop here.\nIf someone will specify a big value in configuration for number of agents it is possible to exceed the amount of available agents and it will continue infinitely","commit_id":"4ad343e9059841c95dffb356640ccf8a75c1e7ed"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"84c0c95c96ebcfe4ada55eea24948477942c1ee0","unresolved":false,"context_lines":[{"line_number":432,"context_line":"            group_by_az[az].append(agent)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        selected_agents \u003d []"},{"line_number":435,"context_line":"        for az, agents in itertools.cycle(group_by_az.items()):"},{"line_number":436,"context_line":"            if not agents:"},{"line_number":437,"context_line":"                continue"},{"line_number":438,"context_line":"            selected_agents.append(agents.pop(0))"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_af8679d9","line":435,"in_reply_to":"9a8ffd7b_8487e1b3","updated":"2015-11-30 13:17:40.000000000","message":"I don\u0027t think so. Who is \"someone\"? What configuration? How does this exceed amount of available agents? Can you elaborate?\n\n \"num_agents\" is set a value: max_ha_agents or the number of candidate agents.\n \"ordered_agents\" is set candidate agents.","commit_id":"4ad343e9059841c95dffb356640ccf8a75c1e7ed"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"307ee1a19462510a84b05662a33ad40e1c3aa60d","unresolved":false,"context_lines":[{"line_number":432,"context_line":"            group_by_az[az].append(agent)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        selected_agents \u003d []"},{"line_number":435,"context_line":"        for az, agents in itertools.cycle(group_by_az.items()):"},{"line_number":436,"context_line":"            if not agents:"},{"line_number":437,"context_line":"                continue"},{"line_number":438,"context_line":"            selected_agents.append(agents.pop(0))"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_c35b96f5","line":435,"in_reply_to":"9a8ffd7b_af8679d9","updated":"2015-11-30 14:06:11.000000000","message":"I found other issue; DB transaction issue may happen num_agents \u003e len(ordered_agents) case. So I updated to avoid the case.","commit_id":"4ad343e9059841c95dffb356640ccf8a75c1e7ed"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ddff50e993b6ce5e9855d5ce40e95e422f757d59","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        return [r for r in routers if r[\u0027id\u0027] not in ids_to_discard]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _get_az_hints(self, router):"},{"line_number":130,"context_line":"        return (router.get(az_ext.AZ_HINTS) or"},{"line_number":131,"context_line":"                cfg.CONF.default_availability_zones)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_7f625b18","line":129,"updated":"2015-12-01 02:12:57.000000000","message":"Adding this to the base L3Scheduler? That looks wrong.","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c81b3ff9b738ab08d4dac788110894e63eee0ca","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        return [r for r in routers if r[\u0027id\u0027] not in ids_to_discard]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _get_az_hints(self, router):"},{"line_number":130,"context_line":"        return (router.get(az_ext.AZ_HINTS) or"},{"line_number":131,"context_line":"                cfg.CONF.default_availability_zones)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_c8162af1","line":129,"in_reply_to":"9a8ffd7b_7f625b18","updated":"2015-12-01 07:37:28.000000000","message":"Done","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ddff50e993b6ce5e9855d5ce40e95e422f757d59","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        all_unscheduled_routers \u003d self._get_routers_to_schedule("},{"line_number":153,"context_line":"            context, plugin, router_ids, exclude_distributed\u003dTrue)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        unscheduled_routers \u003d []"},{"line_number":156,"context_line":"        az \u003d l3_agent[\u0027availability_zone\u0027]"},{"line_number":157,"context_line":"        for r in all_unscheduled_routers:"},{"line_number":158,"context_line":"            az_hints \u003d self._get_az_hints(r)"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_bf052315","line":155,"updated":"2015-12-01 02:12:57.000000000","message":"this logic shouldn\u0027t belong to the base scheduler either. What is that you\u0027re trying to do? You\u0027re trying to filter out the routers that do not belong to the AZ of the specified agent?\n\nI think some refactoring is in order to locate this logic (and the one below) to the AZLeastRoutersScheduler. Perhaps you could break down auto_schedule_router into two methods, one that retrieves unscheduled_routers and the other that does the binding; then you could override the former to allow you to return the right list of routers.","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c81b3ff9b738ab08d4dac788110894e63eee0ca","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        all_unscheduled_routers \u003d self._get_routers_to_schedule("},{"line_number":153,"context_line":"            context, plugin, router_ids, exclude_distributed\u003dTrue)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        unscheduled_routers \u003d []"},{"line_number":156,"context_line":"        az \u003d l3_agent[\u0027availability_zone\u0027]"},{"line_number":157,"context_line":"        for r in all_unscheduled_routers:"},{"line_number":158,"context_line":"            az_hints \u003d self._get_az_hints(r)"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_28afb67e","line":155,"in_reply_to":"9a8ffd7b_bf052315","updated":"2015-12-01 07:37:28.000000000","message":"I got it. I removed the implementation tangled up scheduler.","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ddff50e993b6ce5e9855d5ce40e95e422f757d59","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                filters \u003d {\u0027availability_zone\u0027: az_hints}"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"            active_l3_agents \u003d plugin.get_l3_agents("},{"line_number":200,"context_line":"                context, active\u003dTrue, filters\u003dfilters)"},{"line_number":201,"context_line":"            if not active_l3_agents:"},{"line_number":202,"context_line":"                LOG.warn(_LW(\u0027No active L3 agents\u0027))"},{"line_number":203,"context_line":"                return []"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_1a3ebdb8","line":200,"updated":"2015-12-01 02:12:57.000000000","message":"we should avoid touching the base logic too.","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c81b3ff9b738ab08d4dac788110894e63eee0ca","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                filters \u003d {\u0027availability_zone\u0027: az_hints}"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"            active_l3_agents \u003d plugin.get_l3_agents("},{"line_number":200,"context_line":"                context, active\u003dTrue, filters\u003dfilters)"},{"line_number":201,"context_line":"            if not active_l3_agents:"},{"line_number":202,"context_line":"                LOG.warn(_LW(\u0027No active L3 agents\u0027))"},{"line_number":203,"context_line":"                return []"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_a8196624","line":200,"in_reply_to":"9a8ffd7b_1a3ebdb8","updated":"2015-12-01 07:37:28.000000000","message":"Done","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ddff50e993b6ce5e9855d5ce40e95e422f757d59","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                router \u003d plugin.get_router(admin_ctx, router_id)"},{"line_number":339,"context_line":"                az_hints \u003d self._get_az_hints(router)"},{"line_number":340,"context_line":"                if az_hints and agent[\u0027availability_zone\u0027] not in az_hints:"},{"line_number":341,"context_line":"                    continue"},{"line_number":342,"context_line":"                if not self._router_has_binding(admin_ctx, router_id,"},{"line_number":343,"context_line":"                                                agent.id):"},{"line_number":344,"context_line":"                    self.create_ha_port_and_bind(plugin, admin_ctx,"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_ba4a1154","line":341,"updated":"2015-12-01 02:12:57.000000000","message":"and here too.","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c81b3ff9b738ab08d4dac788110894e63eee0ca","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                router \u003d plugin.get_router(admin_ctx, router_id)"},{"line_number":339,"context_line":"                az_hints \u003d self._get_az_hints(router)"},{"line_number":340,"context_line":"                if az_hints and agent[\u0027availability_zone\u0027] not in az_hints:"},{"line_number":341,"context_line":"                    continue"},{"line_number":342,"context_line":"                if not self._router_has_binding(admin_ctx, router_id,"},{"line_number":343,"context_line":"                                                agent.id):"},{"line_number":344,"context_line":"                    self.create_ha_port_and_bind(plugin, admin_ctx,"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_482a3a2e","line":341,"in_reply_to":"9a8ffd7b_ba4a1154","updated":"2015-12-01 07:37:28.000000000","message":"Done","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"dadeeb1afe6d815c89d82426042a921563f5db64","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    \"\"\""},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def _choose_router_agents_for_ha(self, plugin, context, candidates):"},{"line_number":424,"context_line":"        # Make sure the number of ordered_agetns \u003e\u003d num_agents"},{"line_number":425,"context_line":"        ordered_agents \u003d plugin.get_l3_agents_ordered_by_num_routers("},{"line_number":426,"context_line":"            context, [candidate[\u0027id\u0027] for candidate in candidates])"},{"line_number":427,"context_line":"        num_agents \u003d self._get_num_of_agents_for_ha(len(ordered_agents))"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_a50996df","line":424,"updated":"2015-12-01 03:54:53.000000000","message":"I am not sure I understand your point here. It has nothing to do with \"ordered_agetns\"(typo, agents), it is the relationship between candidates and num_agents. And it is a normal step for scheduling a ha router.\nIn a nutshell, this comment can be removed from my point of view.","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c81b3ff9b738ab08d4dac788110894e63eee0ca","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    \"\"\""},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def _choose_router_agents_for_ha(self, plugin, context, candidates):"},{"line_number":424,"context_line":"        # Make sure the number of ordered_agetns \u003e\u003d num_agents"},{"line_number":425,"context_line":"        ordered_agents \u003d plugin.get_l3_agents_ordered_by_num_routers("},{"line_number":426,"context_line":"            context, [candidate[\u0027id\u0027] for candidate in candidates])"},{"line_number":427,"context_line":"        num_agents \u003d self._get_num_of_agents_for_ha(len(ordered_agents))"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_682b7e34","line":424,"in_reply_to":"9a8ffd7b_a50996df","updated":"2015-12-01 07:37:28.000000000","message":"Done","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"dadeeb1afe6d815c89d82426042a921563f5db64","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            context, [candidate[\u0027id\u0027] for candidate in candidates])"},{"line_number":427,"context_line":"        num_agents \u003d self._get_num_of_agents_for_ha(len(ordered_agents))"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        # order is kept in each az"},{"line_number":430,"context_line":"        group_by_az \u003d collections.defaultdict(list)"},{"line_number":431,"context_line":"        for agent in ordered_agents:"},{"line_number":432,"context_line":"            az \u003d agent[\u0027availability_zone\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_5ad525b7","line":429,"updated":"2015-12-01 03:54:53.000000000","message":"nit: Capitalize first letter.","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c81b3ff9b738ab08d4dac788110894e63eee0ca","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            context, [candidate[\u0027id\u0027] for candidate in candidates])"},{"line_number":427,"context_line":"        num_agents \u003d self._get_num_of_agents_for_ha(len(ordered_agents))"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        # order is kept in each az"},{"line_number":430,"context_line":"        group_by_az \u003d collections.defaultdict(list)"},{"line_number":431,"context_line":"        for agent in ordered_agents:"},{"line_number":432,"context_line":"            az \u003d agent[\u0027availability_zone\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_883022a0","line":429,"in_reply_to":"9a8ffd7b_5ad525b7","updated":"2015-12-01 07:37:28.000000000","message":"Done","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7f7658fbc8b8b58eb7ed68510a780eb22ddb6c85","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                context, filters\u003d{\u0027id\u0027: unscheduled_router_ids})"},{"line_number":91,"context_line":"        return []"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _get_routers_to_schedule(self, context, plugin, l3_agent,"},{"line_number":94,"context_line":"                                 router_ids\u003dNone, exclude_distributed\u003dFalse):"},{"line_number":95,"context_line":"        \"\"\"Verify that the routers specified need to be scheduled."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_e6b9ac2f","line":93,"updated":"2015-12-01 21:40:36.000000000","message":"even if this is a change to a private method, we should strive to avoid breaking consumers that might accidently use this one. Have you consider passing l3_agent as kwargs like this:\n\n  _get_routers_to_schedule(self, context, plugin,\n    router_ids\u003dNone, exclude_distributed\u003dFalse, l3_agent\u003dNone)\n\nYou don\u0027t seem to use it in the base class either, so it seems it should be possible.","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"462d0a2fa3a5c49096f0af49d5810ceb93c906c7","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                context, filters\u003d{\u0027id\u0027: unscheduled_router_ids})"},{"line_number":91,"context_line":"        return []"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _get_routers_to_schedule(self, context, plugin, l3_agent,"},{"line_number":94,"context_line":"                                 router_ids\u003dNone, exclude_distributed\u003dFalse):"},{"line_number":95,"context_line":"        \"\"\"Verify that the routers specified need to be scheduled."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_2a09a12c","line":93,"in_reply_to":"9a8ffd7b_e6b9ac2f","updated":"2015-12-02 09:52:24.000000000","message":"I decided to overwrite _get_routers_can_schedule so that this patch doesn\u0027t affect base scheduler.","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7f7658fbc8b8b58eb7ed68510a780eb22ddb6c85","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        self._bind_routers(context, plugin, target_routers, l3_agent)"},{"line_number":166,"context_line":"        return True"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def _candidates_filters(self, router):"},{"line_number":169,"context_line":"        \"\"\"Return filters to select candidates."},{"line_number":170,"context_line":"           It is assumed to be overwritten by subclass."},{"line_number":171,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_86122008","line":168,"updated":"2015-12-01 21:40:36.000000000","message":"consider this method signature:\n\n def prepare_query_filters(self, initial_filters\u003dNone):\n    \"\"\"Parse initial_filters to return a dict of additional filters.\"\"\"\n    # Passthrough if no extra filtering is required.\n    return initial_filters\n\nthen you can pass:\n\n  filters\u003d{\u0027router\u0027: sync_router}\n\nIt\u0027s more future proof\n\nand extend your logic where you need.\n\nBtw, it\u0027s a method it\u0027s meant to be overwritten then it should not be a private method.","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"462d0a2fa3a5c49096f0af49d5810ceb93c906c7","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        self._bind_routers(context, plugin, target_routers, l3_agent)"},{"line_number":166,"context_line":"        return True"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def _candidates_filters(self, router):"},{"line_number":169,"context_line":"        \"\"\"Return filters to select candidates."},{"line_number":170,"context_line":"           It is assumed to be overwritten by subclass."},{"line_number":171,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_4a12e50a","line":168,"in_reply_to":"9a8ffd7b_86122008","updated":"2015-12-02 09:52:24.000000000","message":"I decided to overwrite _get_candidates so that this patch doesn\u0027t affect base scheduler.","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7f7658fbc8b8b58eb7ed68510a780eb22ddb6c85","unresolved":false,"context_lines":[{"line_number":311,"context_line":"            port_binding.l3_agent_id \u003d agent[\u0027id\u0027]"},{"line_number":312,"context_line":"        self.bind_router(context, router_id, agent)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def _additional_check_for_agent_criteria(self, router, agent):"},{"line_number":315,"context_line":"        \"\"\"Return True if agent is OK to schedule."},{"line_number":316,"context_line":"           It is assumed to be overwritten by subclass."},{"line_number":317,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_a974d59b","line":314,"updated":"2015-12-01 21:40:36.000000000","message":"It seems here you\u0027re trying to skip the binding operation, not only if the router is not tied to the agent, but also if the agent doesn\u0027t belong to the AZ associated to the router.\n\nSo if I understand you correctly wouldn\u0027t it be easier to filter routers_agents ahead of time so that what gets passed to like 333 is already the filtered list?\n\nWe could then wrap up line 328 into a wrapper method that can itself be overridden.\n\nThe tricky part is the access to the DB: since we do get_router in a loop and we don\u0027t want to do this twice, we could make routers_agents be routers objects (returned by the wrapper method I mentioned before) and avoid the call on line 336, altogether.\n\nThere may be a danger that between line 328 and like 336 routers are gone, so you may want to wrap the block into a try-except to catch RouterNotFound and pass if it happens.","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"462d0a2fa3a5c49096f0af49d5810ceb93c906c7","unresolved":false,"context_lines":[{"line_number":311,"context_line":"            port_binding.l3_agent_id \u003d agent[\u0027id\u0027]"},{"line_number":312,"context_line":"        self.bind_router(context, router_id, agent)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def _additional_check_for_agent_criteria(self, router, agent):"},{"line_number":315,"context_line":"        \"\"\"Return True if agent is OK to schedule."},{"line_number":316,"context_line":"           It is assumed to be overwritten by subclass."},{"line_number":317,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_c1e23b2f","line":314,"in_reply_to":"9a8ffd7b_a974d59b","updated":"2015-12-02 09:52:24.000000000","message":"I got it. Done.","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"37899ad87de5c6194b80f0f23bc67a91af4b8283","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        if az_hints:"},{"line_number":427,"context_line":"            return {\u0027availability_zone\u0027: az_hints}"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def _get_routers_to_schedule(self, context, plugin, l3_agent,"},{"line_number":430,"context_line":"                                 router_ids\u003dNone, exclude_distributed\u003dFalse):"},{"line_number":431,"context_line":"        \"\"\"Overwrite L3Scheduler\u0027s method to filter by availability zone.\"\"\""},{"line_number":432,"context_line":"        all_unscheduled_routers \u003d ("}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_a6874d11","line":429,"updated":"2015-12-01 10:53:06.000000000","message":"From their names, I think you should add the functionality in this method to \"_get_routers_can_schedule\", so you don\u0027t need to change this method","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"462d0a2fa3a5c49096f0af49d5810ceb93c906c7","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        if az_hints:"},{"line_number":427,"context_line":"            return {\u0027availability_zone\u0027: az_hints}"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def _get_routers_to_schedule(self, context, plugin, l3_agent,"},{"line_number":430,"context_line":"                                 router_ids\u003dNone, exclude_distributed\u003dFalse):"},{"line_number":431,"context_line":"        \"\"\"Overwrite L3Scheduler\u0027s method to filter by availability zone.\"\"\""},{"line_number":432,"context_line":"        all_unscheduled_routers \u003d ("}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_bb508e0b","line":429,"in_reply_to":"9a8ffd7b_a6874d11","updated":"2015-12-02 09:52:24.000000000","message":"make sense","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"37899ad87de5c6194b80f0f23bc67a91af4b8283","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        \"\"\"Overwrite L3Scheduler\u0027s method to filter by availability zone.\"\"\""},{"line_number":432,"context_line":"        all_unscheduled_routers \u003d ("},{"line_number":433,"context_line":"            super(AZLeastRoutersScheduler, self)._get_routers_to_schedule("},{"line_number":434,"context_line":"                context, plugin, router_ids, exclude_distributed\u003dTrue))"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        unscheduled_routers \u003d []"},{"line_number":437,"context_line":"        az \u003d l3_agent[\u0027availability_zone\u0027]"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_320cf841","line":434,"updated":"2015-12-01 10:53:06.000000000","message":"Do you miss to pass l3_agent here?","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"462d0a2fa3a5c49096f0af49d5810ceb93c906c7","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        \"\"\"Overwrite L3Scheduler\u0027s method to filter by availability zone.\"\"\""},{"line_number":432,"context_line":"        all_unscheduled_routers \u003d ("},{"line_number":433,"context_line":"            super(AZLeastRoutersScheduler, self)._get_routers_to_schedule("},{"line_number":434,"context_line":"                context, plugin, router_ids, exclude_distributed\u003dTrue))"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        unscheduled_routers \u003d []"},{"line_number":437,"context_line":"        az \u003d l3_agent[\u0027availability_zone\u0027]"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_3b3d7ebb","line":434,"in_reply_to":"9a8ffd7b_320cf841","updated":"2015-12-02 09:52:24.000000000","message":"You\u0027re right.","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8590503a02cf6b275676ae049858585ed661104e","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            port_binding.l3_agent_id \u003d agent[\u0027id\u0027]"},{"line_number":303,"context_line":"        self.bind_router(context, router_id, agent)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def _get_ha_routers_l3_agents_count(self, plugin, context, agent\u003dNone):"},{"line_number":306,"context_line":"        router_ids_agents \u003d plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":307,"context_line":"        routers_agents \u003d []"},{"line_number":308,"context_line":"        for router_id, tenant_id, agents in router_ids_agents:"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_13538318","line":305,"updated":"2015-12-02 23:57:16.000000000","message":"I\u0027d like to have context come first:\n\nself, context, plugin, ...","commit_id":"dce9f02e5697245733a3751d7909ce23865bf93f"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e88d6643b391d7c11b662bd7cff7620dad6bb3dc","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            port_binding.l3_agent_id \u003d agent[\u0027id\u0027]"},{"line_number":303,"context_line":"        self.bind_router(context, router_id, agent)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def _get_ha_routers_l3_agents_count(self, plugin, context, agent\u003dNone):"},{"line_number":306,"context_line":"        router_ids_agents \u003d plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":307,"context_line":"        routers_agents \u003d []"},{"line_number":308,"context_line":"        for router_id, tenant_id, agents in router_ids_agents:"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_c242fe3d","line":305,"in_reply_to":"9a8ffd7b_13538318","updated":"2015-12-03 05:22:01.000000000","message":"Done","commit_id":"dce9f02e5697245733a3751d7909ce23865bf93f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"643ec73b6ec36f15c3e4b44c55f10d80e0629ed9","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        router_ids_agents \u003d plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":307,"context_line":"        routers_agents \u003d []"},{"line_number":308,"context_line":"        for router_id, tenant_id, agents in router_ids_agents:"},{"line_number":309,"context_line":"            router \u003d plugin.get_router(context, router_id)"},{"line_number":310,"context_line":"            routers_agents.append((router, tenant_id, agents))"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        return routers_agents"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_a1d92559","line":309,"updated":"2015-12-02 14:32:13.000000000","message":"If the number of routers grows, the number of get_router calls grows. It costs much. I think it is better to change get_ha_routers_l3_agents_count() to return \u0027router\u0027 instead of \u0027router_id\u0027. get_ha_routers_l3_agents_count is not private but I believe this is for internal use and we can change it.","commit_id":"dce9f02e5697245733a3751d7909ce23865bf93f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8590503a02cf6b275676ae049858585ed661104e","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        router_ids_agents \u003d plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":307,"context_line":"        routers_agents \u003d []"},{"line_number":308,"context_line":"        for router_id, tenant_id, agents in router_ids_agents:"},{"line_number":309,"context_line":"            router \u003d plugin.get_router(context, router_id)"},{"line_number":310,"context_line":"            routers_agents.append((router, tenant_id, agents))"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        return routers_agents"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_d3217b9f","line":309,"in_reply_to":"9a8ffd7b_a1d92559","updated":"2015-12-02 23:57:16.000000000","message":"I tried to make this point on PS20. Thanks for restating it so well!","commit_id":"dce9f02e5697245733a3751d7909ce23865bf93f"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e88d6643b391d7c11b662bd7cff7620dad6bb3dc","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        router_ids_agents \u003d plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":307,"context_line":"        routers_agents \u003d []"},{"line_number":308,"context_line":"        for router_id, tenant_id, agents in router_ids_agents:"},{"line_number":309,"context_line":"            router \u003d plugin.get_router(context, router_id)"},{"line_number":310,"context_line":"            routers_agents.append((router, tenant_id, agents))"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        return routers_agents"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_227e6a6a","line":309,"in_reply_to":"9a8ffd7b_d3217b9f","updated":"2015-12-03 05:22:01.000000000","message":"I hesitated to modify get_ha_routers_l3_agents_count() but I updated since I got 2 cores recommendation :)","commit_id":"dce9f02e5697245733a3751d7909ce23865bf93f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"d08d12595a5d8e693da55bd099bf7b34ef7a9344","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        all_target_routers \u003d ("},{"line_number":420,"context_line":"            super(AZLeastRoutersScheduler, self)._get_routers_can_schedule("},{"line_number":421,"context_line":"                context, plugin, routers, l3_agent))"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        target_routers \u003d []"},{"line_number":424,"context_line":"        for r in all_target_routers:"},{"line_number":425,"context_line":"            az_hints \u003d self._get_az_hints(r)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_dc0ae325","line":422,"updated":"2015-12-03 04:45:13.000000000","message":"Since [1]  is more complicating than the logic in line 423~427. Move [1] after line 423~427 can improve performance in large scale.\n\n[1] super(AZLeastRoutersScheduler, self)._get_routers_can_schedule","commit_id":"dce9f02e5697245733a3751d7909ce23865bf93f"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9c57a7ee19f051e1add5afeb8007ab61391e0c78","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        all_target_routers \u003d ("},{"line_number":420,"context_line":"            super(AZLeastRoutersScheduler, self)._get_routers_can_schedule("},{"line_number":421,"context_line":"                context, plugin, routers, l3_agent))"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        target_routers \u003d []"},{"line_number":424,"context_line":"        for r in all_target_routers:"},{"line_number":425,"context_line":"            az_hints \u003d self._get_az_hints(r)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_593280a8","line":422,"in_reply_to":"9a8ffd7b_22e98ab7","updated":"2015-12-03 06:31:19.000000000","message":"make sense! :)","commit_id":"dce9f02e5697245733a3751d7909ce23865bf93f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"9740a4575c671e8ebacffca5ac0b7aca7b93da21","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        all_target_routers \u003d ("},{"line_number":420,"context_line":"            super(AZLeastRoutersScheduler, self)._get_routers_can_schedule("},{"line_number":421,"context_line":"                context, plugin, routers, l3_agent))"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        target_routers \u003d []"},{"line_number":424,"context_line":"        for r in all_target_routers:"},{"line_number":425,"context_line":"            az_hints \u003d self._get_az_hints(r)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_22e98ab7","line":422,"in_reply_to":"9a8ffd7b_829cf66a","updated":"2015-12-03 05:35:40.000000000","message":"Something like this:\n\ndef _get_routers_can_schedule(self, context, plugin, routers, l3_agent):\n\n    # filter routers by AZ firstly, because the logic is simple\n\n    # call [1] to continue filter out routers based on other consideration","commit_id":"dce9f02e5697245733a3751d7909ce23865bf93f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4cdf911581668afc4e5bab2ef11637633b4ca103","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        all_target_routers \u003d ("},{"line_number":420,"context_line":"            super(AZLeastRoutersScheduler, self)._get_routers_can_schedule("},{"line_number":421,"context_line":"                context, plugin, routers, l3_agent))"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        target_routers \u003d []"},{"line_number":424,"context_line":"        for r in all_target_routers:"},{"line_number":425,"context_line":"            az_hints \u003d self._get_az_hints(r)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_829cf66a","line":422,"in_reply_to":"9a8ffd7b_872c08ad","updated":"2015-12-03 05:30:00.000000000","message":"I guess you can filter routers from parameter firstly, then pass the result to the method in parent class.","commit_id":"dce9f02e5697245733a3751d7909ce23865bf93f"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e88d6643b391d7c11b662bd7cff7620dad6bb3dc","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        all_target_routers \u003d ("},{"line_number":420,"context_line":"            super(AZLeastRoutersScheduler, self)._get_routers_can_schedule("},{"line_number":421,"context_line":"                context, plugin, routers, l3_agent))"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        target_routers \u003d []"},{"line_number":424,"context_line":"        for r in all_target_routers:"},{"line_number":425,"context_line":"            az_hints \u003d self._get_az_hints(r)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_872c08ad","line":422,"in_reply_to":"9a8ffd7b_dc0ae325","updated":"2015-12-03 05:22:01.000000000","message":"How do we get all_target_routers without it?","commit_id":"dce9f02e5697245733a3751d7909ce23865bf93f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"434fd8d1d69d5bdebf346de5feabf7299e8227c5","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            port_binding.l3_agent_id \u003d agent[\u0027id\u0027]"},{"line_number":303,"context_line":"        self.bind_router(context, router_id, agent)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def _get_ha_routers_l3_agents_count(self, context, plugin, agent\u003dNone):"},{"line_number":306,"context_line":"        # Subclass may overwrite to filter routers got from the method."},{"line_number":307,"context_line":"        # \u0027agent\u0027 parameter may be used at the time."},{"line_number":308,"context_line":"        return plugin.get_ha_routers_l3_agents_count(context)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a8ffd7b_cc70f074","line":305,"updated":"2015-12-03 06:54:28.000000000","message":"There\u0027s something funny about this method. Have you considered this signature:\n\n  def get_ha_router_l3_agents_counts(self, context, plugin, filters\u003dNone):\n    \"\"\"Return a mapping (routers, # agents) matching the specified filters.\"\"\"\n    ...","commit_id":"36d59be9926f70b88a957386a9a5cfc18f8de7f0"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2ffc022b49336a2dc63c2dcd11d78caf5cac07c5","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            port_binding.l3_agent_id \u003d agent[\u0027id\u0027]"},{"line_number":303,"context_line":"        self.bind_router(context, router_id, agent)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def _get_ha_routers_l3_agents_count(self, context, plugin, agent\u003dNone):"},{"line_number":306,"context_line":"        # Subclass may overwrite to filter routers got from the method."},{"line_number":307,"context_line":"        # \u0027agent\u0027 parameter may be used at the time."},{"line_number":308,"context_line":"        return plugin.get_ha_routers_l3_agents_count(context)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a8ffd7b_8fe5e8dc","line":305,"in_reply_to":"9a8ffd7b_cc70f074","updated":"2015-12-03 13:02:47.000000000","message":"Do you want to remove \"_\" and use \"counts\" instead of \"count\"? I\u0027m afraid that it confuses developers but I\u0027m OK. I changed.","commit_id":"36d59be9926f70b88a957386a9a5cfc18f8de7f0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b55a5df1299c46359939d5ea0d3cad1902991bea","unresolved":false,"context_lines":[{"line_number":331,"context_line":"                                                     router[\u0027tenant_id\u0027],"},{"line_number":332,"context_line":"                                                     agent)"},{"line_number":333,"context_line":"                        scheduled \u003d True"},{"line_number":334,"context_line":"                except l3.RouterNotFound:"},{"line_number":335,"context_line":"                    pass"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        return scheduled"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a8ffd7b_6f9c566a","line":334,"updated":"2015-12-03 07:27:05.000000000","message":"which method raises the l3.RouterNotFound? would it not be worthwhile doing a log here - that may help debugging?\n\nis there a test case for this flow?","commit_id":"36d59be9926f70b88a957386a9a5cfc18f8de7f0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6cd5071008cd6a62ef210aa934297716f010b7de","unresolved":false,"context_lines":[{"line_number":331,"context_line":"                                                     router[\u0027tenant_id\u0027],"},{"line_number":332,"context_line":"                                                     agent)"},{"line_number":333,"context_line":"                        scheduled \u003d True"},{"line_number":334,"context_line":"                except l3.RouterNotFound:"},{"line_number":335,"context_line":"                    pass"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        return scheduled"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a8ffd7b_c5cf6354","line":334,"in_reply_to":"9a8ffd7b_6f9c566a","updated":"2015-12-03 08:28:45.000000000","message":"I have a same question. It was added at patch set 21, but I cannot find any discussion on this.\n\nIf it is really required, some comment or log message would be helpful.","commit_id":"36d59be9926f70b88a957386a9a5cfc18f8de7f0"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2ffc022b49336a2dc63c2dcd11d78caf5cac07c5","unresolved":false,"context_lines":[{"line_number":331,"context_line":"                                                     router[\u0027tenant_id\u0027],"},{"line_number":332,"context_line":"                                                     agent)"},{"line_number":333,"context_line":"                        scheduled \u003d True"},{"line_number":334,"context_line":"                except l3.RouterNotFound:"},{"line_number":335,"context_line":"                    pass"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        return scheduled"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a8ffd7b_e3793594","line":334,"in_reply_to":"9a8ffd7b_c5cf6354","updated":"2015-12-03 13:02:47.000000000","message":"Oops. I missed to remove it. I added it for get_router() according with Armando\u0027s comment in PS20 but it doesn\u0027t mean now because I removed get_router().","commit_id":"36d59be9926f70b88a957386a9a5cfc18f8de7f0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"93f99d8dcfaa8ce851943494417841ddf4a84568","unresolved":false,"context_lines":[{"line_number":331,"context_line":"                                                     router[\u0027tenant_id\u0027],"},{"line_number":332,"context_line":"                                                     agent)"},{"line_number":333,"context_line":"                        scheduled \u003d True"},{"line_number":334,"context_line":"                except l3.RouterNotFound:"},{"line_number":335,"context_line":"                    pass"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        return scheduled"}],"source_content_type":"text/x-python","patch_set":25,"id":"7a740942_d52a6b2c","line":334,"in_reply_to":"9a8ffd7b_e3793594","updated":"2015-12-03 16:39:02.000000000","message":"well, the problem here is that while we loop over routers, routers might be concurrently deleted and the create_ha_port_and_bind operation may end up causing a DB error that shows up either as RouterNotFound or IntegrityError.\n\nI suppose this race hasn\u0027t showed up yet, so we can leave it for now :)","commit_id":"36d59be9926f70b88a957386a9a5cfc18f8de7f0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b55a5df1299c46359939d5ea0d3cad1902991bea","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        for r in routers:"},{"line_number":418,"context_line":"            az_hints \u003d self._get_az_hints(r)"},{"line_number":419,"context_line":"            if not az_hints or l3_agent[\u0027availability_zone\u0027] in az_hints:"},{"line_number":420,"context_line":"                target_routers.append(r)"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        return super(AZLeastRoutersScheduler, self)._get_routers_can_schedule("},{"line_number":423,"context_line":"            context, plugin, target_routers, l3_agent)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a8ffd7b_8f709a41","line":420,"updated":"2015-12-03 07:27:05.000000000","message":"dumb question - if target_routers is [] do we need to call the method below?","commit_id":"36d59be9926f70b88a957386a9a5cfc18f8de7f0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f7f23be3f80a1cdab6b120d9fae5b37a6398dfdf","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        for r in routers:"},{"line_number":418,"context_line":"            az_hints \u003d self._get_az_hints(r)"},{"line_number":419,"context_line":"            if not az_hints or l3_agent[\u0027availability_zone\u0027] in az_hints:"},{"line_number":420,"context_line":"                target_routers.append(r)"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        return super(AZLeastRoutersScheduler, self)._get_routers_can_schedule("},{"line_number":423,"context_line":"            context, plugin, target_routers, l3_agent)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a8ffd7b_9dfaf941","line":420,"in_reply_to":"9a8ffd7b_607a1b26","updated":"2015-12-03 14:55:59.000000000","message":"Ah.. I got it.","commit_id":"36d59be9926f70b88a957386a9a5cfc18f8de7f0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6cd5071008cd6a62ef210aa934297716f010b7de","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        for r in routers:"},{"line_number":418,"context_line":"            az_hints \u003d self._get_az_hints(r)"},{"line_number":419,"context_line":"            if not az_hints or l3_agent[\u0027availability_zone\u0027] in az_hints:"},{"line_number":420,"context_line":"                target_routers.append(r)"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        return super(AZLeastRoutersScheduler, self)._get_routers_can_schedule("},{"line_number":423,"context_line":"            context, plugin, target_routers, l3_agent)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a8ffd7b_e5086782","line":420,"in_reply_to":"9a8ffd7b_8f709a41","updated":"2015-12-03 08:28:45.000000000","message":"In my understanding, if az_hints is empty, it means a user does not request any specific AZs and we can schedule a router in any AZ, so it looks fine.","commit_id":"36d59be9926f70b88a957386a9a5cfc18f8de7f0"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2ffc022b49336a2dc63c2dcd11d78caf5cac07c5","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        for r in routers:"},{"line_number":418,"context_line":"            az_hints \u003d self._get_az_hints(r)"},{"line_number":419,"context_line":"            if not az_hints or l3_agent[\u0027availability_zone\u0027] in az_hints:"},{"line_number":420,"context_line":"                target_routers.append(r)"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        return super(AZLeastRoutersScheduler, self)._get_routers_can_schedule("},{"line_number":423,"context_line":"            context, plugin, target_routers, l3_agent)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a8ffd7b_607a1b26","line":420,"in_reply_to":"9a8ffd7b_e5086782","updated":"2015-12-03 13:02:47.000000000","message":"garyk means a case that there is no router which AZ of l3_agent meets az_hints. I think we doesn\u0027t need to call parent method as well.","commit_id":"36d59be9926f70b88a957386a9a5cfc18f8de7f0"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"89b1816ddc6bac557bf070be49cd721c46ba0451","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from neutron.db import l3_db"},{"line_number":32,"context_line":"from neutron.db import l3_hamode_db"},{"line_number":33,"context_line":"from neutron.extensions import availability_zone as az_ext"},{"line_number":34,"context_line":"from neutron.extensions import l3"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a8ffd7b_5df01167","line":34,"updated":"2015-12-03 14:58:51.000000000","message":"I still expect this will failed the pep8, because it is not used after you removed the exception.","commit_id":"f96e8c155a7303773cdb9759104e0aea520e2bce"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"ff4879855d207e83a5713a4292900a6f8ed9ab4b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from neutron.db import l3_db"},{"line_number":32,"context_line":"from neutron.db import l3_hamode_db"},{"line_number":33,"context_line":"from neutron.extensions import availability_zone as az_ext"},{"line_number":34,"context_line":"from neutron.extensions import l3"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a740942_b171fae2","line":34,"in_reply_to":"9a8ffd7b_5df01167","updated":"2015-12-03 15:23:02.000000000","message":"That\u0027s right ;)","commit_id":"f96e8c155a7303773cdb9759104e0aea520e2bce"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"880416b64c683c6eb4f79bb6366904f6bfd02baa","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        self.bind_router(context, router_id, agent)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def get_ha_routers_l3_agents_counts(self, context, plugin, filters\u003dNone):"},{"line_number":305,"context_line":"        \"\"\"Return a mapping (routers, # agents) matching specified filters.\"\"\""},{"line_number":306,"context_line":"        return plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def _schedule_ha_routers_to_additional_agent(self, plugin, context, agent):"}],"source_content_type":"text/x-python","patch_set":30,"id":"7a740942_5b7213e7","line":305,"updated":"2015-12-04 02:43:12.000000000","message":"(routers, # agents) -\u003e (router, # agents)\n\nEach tuple contains one router because group_by(...router_id) is used.","commit_id":"2e32808c748babe893cf157394be2f149d8c3052"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"66f1b176a0a05876314461cc2185fcaa08ee204b","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        self.bind_router(context, router_id, agent)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def get_ha_routers_l3_agents_counts(self, context, plugin, filters\u003dNone):"},{"line_number":305,"context_line":"        \"\"\"Return a mapping (routers, # agents) matching specified filters.\"\"\""},{"line_number":306,"context_line":"        return plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def _schedule_ha_routers_to_additional_agent(self, plugin, context, agent):"}],"source_content_type":"text/x-python","patch_set":30,"id":"7a740942_864a5e82","line":305,"in_reply_to":"7a740942_5b7213e7","updated":"2015-12-04 03:33:02.000000000","message":"Done","commit_id":"2e32808c748babe893cf157394be2f149d8c3052"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"880416b64c683c6eb4f79bb6366904f6bfd02baa","unresolved":false,"context_lines":[{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def get_ha_routers_l3_agents_counts(self, context, plugin, filters\u003dNone):"},{"line_number":438,"context_line":"        \"\"\"Overwrite L3Scheduler\u0027s method to filter by availability zone.\"\"\""},{"line_number":439,"context_line":"        agent \u003d filters"},{"line_number":440,"context_line":"        all_routers_agents \u003d ("},{"line_number":441,"context_line":"            super(AZLeastRoutersScheduler, self)."},{"line_number":442,"context_line":"            get_ha_routers_l3_agents_counts(context, plugin, agent))"}],"source_content_type":"text/x-python","patch_set":30,"id":"7a740942_9bf39b73","line":439,"updated":"2015-12-04 02:43:12.000000000","message":"How about using filters directly instead of using \u0027agent\u0027?","commit_id":"2e32808c748babe893cf157394be2f149d8c3052"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"66f1b176a0a05876314461cc2185fcaa08ee204b","unresolved":false,"context_lines":[{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def get_ha_routers_l3_agents_counts(self, context, plugin, filters\u003dNone):"},{"line_number":438,"context_line":"        \"\"\"Overwrite L3Scheduler\u0027s method to filter by availability zone.\"\"\""},{"line_number":439,"context_line":"        agent \u003d filters"},{"line_number":440,"context_line":"        all_routers_agents \u003d ("},{"line_number":441,"context_line":"            super(AZLeastRoutersScheduler, self)."},{"line_number":442,"context_line":"            get_ha_routers_l3_agents_counts(context, plugin, agent))"}],"source_content_type":"text/x-python","patch_set":30,"id":"7a740942_6125dca9","line":439,"in_reply_to":"7a740942_9bf39b73","updated":"2015-12-04 03:33:02.000000000","message":"I did on purpose because of feeling strange filters[\u0027availability_zone\u0027] but I\u0027m OK. I changed.","commit_id":"2e32808c748babe893cf157394be2f149d8c3052"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cdf5dcdb3e2276c224dcf22f736c9b88dbaa03f5","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        \"\"\""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        routers_agents \u003d self.get_ha_routers_l3_agents_counts(context, plugin,"},{"line_number":317,"context_line":"                                                              agent)"},{"line_number":318,"context_line":"        scheduled \u003d False"},{"line_number":319,"context_line":"        admin_ctx \u003d context.elevated()"},{"line_number":320,"context_line":"        for router, agents in routers_agents:"}],"source_content_type":"text/x-python","patch_set":31,"id":"7a740942_0cc52f8d","line":317,"updated":"2015-12-04 04:27:16.000000000","message":"I would have passed {\u0027agent\u0027: agent}, but ok, this can be cleaned up later, if need be.","commit_id":"ef2a5543cc7e15769031f81c921d4babb7e14d04"}],"neutron/tests/unit/extensions/test_availability_zone.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e344fd284605bd045ef1bef2ff04d862333f59e1","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    def test_create_router_with_not_exist_az(self):"},{"line_number":238,"context_line":"        res \u003d self._create_router(self.fmt, \u0027tenant_id\u0027,"},{"line_number":239,"context_line":"                                  availability_zone_hints\u003d[\u0027nova4\u0027])"},{"line_number":240,"context_line":"        self.assertEqual(res.status_int, 404)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_71f8abc3","line":240,"updated":"2015-11-12 02:53:17.000000000","message":"The unit test should consider such case:\n\ncreating router without AZ, however, the \"default_availability_zones\" in neutron.conf will take effect.","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"073586f3a27c7f69e90c7e55f480e92100796106","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    def test_create_router_with_not_exist_az(self):"},{"line_number":238,"context_line":"        res \u003d self._create_router(self.fmt, \u0027tenant_id\u0027,"},{"line_number":239,"context_line":"                                  availability_zone_hints\u003d[\u0027nova4\u0027])"},{"line_number":240,"context_line":"        self.assertEqual(res.status_int, 404)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a1a9d01_6ecb6973","line":240,"updated":"2015-10-02 12:12:26.000000000","message":"nit, put expected as first arg.","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"740d9adeff8089fb1fea33a1216e022f10ff960e","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    def test_create_router_with_not_exist_az(self):"},{"line_number":238,"context_line":"        res \u003d self._create_router(self.fmt, \u0027tenant_id\u0027,"},{"line_number":239,"context_line":"                                  availability_zone_hints\u003d[\u0027nova4\u0027])"},{"line_number":240,"context_line":"        self.assertEqual(res.status_int, 404)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_9031845c","line":240,"in_reply_to":"da85f559_71f8abc3","updated":"2015-11-12 06:27:31.000000000","message":"Ignore this comment, I was not so clear the implementation of the BP.","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4b56921bd37cee50a650dfd3571003b17fc56a46","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    def test_create_router_with_not_exist_az(self):"},{"line_number":238,"context_line":"        res \u003d self._create_router(self.fmt, \u0027tenant_id\u0027,"},{"line_number":239,"context_line":"                                  availability_zone_hints\u003d[\u0027nova4\u0027])"},{"line_number":240,"context_line":"        self.assertEqual(res.status_int, 404)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_9cd11fd0","line":240,"in_reply_to":"da85f559_9031845c","updated":"2015-11-25 15:05:48.000000000","message":"Done","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"537a6a6283b029fd831165f7f372b32a20e12894","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def get_request_extensions(self):"},{"line_number":49,"context_line":"        return []"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class AZL3ExtensionManager(AZExtensionManager):"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_resources(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_347263ae","line":51,"updated":"2015-11-26 07:43:32.000000000","message":"Isn\u0027t it better to have these tests in test_router_availability_zone.py?\nIn general, test cases should be contained in a test module which corresponds to a main module.","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"05c8251c3298a3a15dc8e9177330f1920a53ffce","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def get_request_extensions(self):"},{"line_number":49,"context_line":"        return []"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class AZL3ExtensionManager(AZExtensionManager):"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_resources(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_41a7b5bc","line":51,"in_reply_to":"9a8ffd7b_347263ae","updated":"2015-11-30 07:58:50.000000000","message":"Done","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"537a6a6283b029fd831165f7f372b32a20e12894","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            res \u003d self._show(\u0027routers\u0027, router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":226,"context_line":"            self.assertEqual([], res[\u0027router\u0027][\u0027availability_zone_hints\u0027])"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def test_create_router_with_not_exist_az(self):"},{"line_number":229,"context_line":"        res \u003d self._create_router(self.fmt, \u0027tenant_id\u0027,"},{"line_number":230,"context_line":"                                  availability_zone_hints\u003d[\u0027nova4\u0027])"},{"line_number":231,"context_line":"        self.assertEqual(404, res.status_int)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_94ba2f22","line":228,"range":{"start_line":228,"start_character":31,"end_line":228,"end_character":44},"updated":"2015-11-26 07:43:32.000000000","message":"-\u003e non_existing_az","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"05c8251c3298a3a15dc8e9177330f1920a53ffce","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            res \u003d self._show(\u0027routers\u0027, router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":226,"context_line":"            self.assertEqual([], res[\u0027router\u0027][\u0027availability_zone_hints\u0027])"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def test_create_router_with_not_exist_az(self):"},{"line_number":229,"context_line":"        res \u003d self._create_router(self.fmt, \u0027tenant_id\u0027,"},{"line_number":230,"context_line":"                                  availability_zone_hints\u003d[\u0027nova4\u0027])"},{"line_number":231,"context_line":"        self.assertEqual(404, res.status_int)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_a198e178","line":228,"in_reply_to":"9a8ffd7b_94ba2f22","updated":"2015-11-30 07:58:50.000000000","message":"Done","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"}],"neutron/tests/unit/extensions/test_router_availability_zone.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"dadeeb1afe6d815c89d82426042a921563f5db64","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.tests.unit.extensions import test_l3"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class AZL3ExtensionManager(test_az.AZExtensionManager):"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_80e80018","line":28,"updated":"2015-12-01 03:54:53.000000000","message":"You don\u0027t use LOG here too.","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c81b3ff9b738ab08d4dac788110894e63eee0ca","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.tests.unit.extensions import test_l3"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class AZL3ExtensionManager(test_az.AZExtensionManager):"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_28e6d6e8","line":28,"in_reply_to":"9a8ffd7b_80e80018","updated":"2015-12-01 07:37:28.000000000","message":"Done","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"}],"neutron/tests/unit/scheduler/test_l3_agent_scheduler.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"40fb7059a715a2dcd76a5378f98ec59711eefa0f","unresolved":false,"context_lines":[{"line_number":495,"context_line":"            mock.call.get_router(mock.ANY, \u0027foo_router_id\u0027),"},{"line_number":496,"context_line":"            mock.call.get_l3_agents_hosting_routers("},{"line_number":497,"context_line":"                mock.ANY, [\u0027foo_router_id\u0027], admin_state_up\u003dTrue),"},{"line_number":498,"context_line":"            mock.call.get_l3_agents(mock.ANY, active\u003dTrue,"},{"line_number":499,"context_line":"                filters\u003d{\u0027availability_zone\u0027: [\u0027nova\u0027]}),"},{"line_number":500,"context_line":"            mock.call.get_l3_agent_candidates(mock.ANY, sync_router, [agent]),"},{"line_number":501,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_5fa23c9a","line":498,"updated":"2015-10-09 10:36:43.000000000","message":"I would prefer to move mock to next line","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4b56921bd37cee50a650dfd3571003b17fc56a46","unresolved":false,"context_lines":[{"line_number":495,"context_line":"            mock.call.get_router(mock.ANY, \u0027foo_router_id\u0027),"},{"line_number":496,"context_line":"            mock.call.get_l3_agents_hosting_routers("},{"line_number":497,"context_line":"                mock.ANY, [\u0027foo_router_id\u0027], admin_state_up\u003dTrue),"},{"line_number":498,"context_line":"            mock.call.get_l3_agents(mock.ANY, active\u003dTrue,"},{"line_number":499,"context_line":"                filters\u003d{\u0027availability_zone\u0027: [\u0027nova\u0027]}),"},{"line_number":500,"context_line":"            mock.call.get_l3_agent_candidates(mock.ANY, sync_router, [agent]),"},{"line_number":501,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_1c59af5a","line":498,"in_reply_to":"7a2fa921_5fa23c9a","updated":"2015-11-25 15:05:48.000000000","message":"Why? I don\u0027t prefer to do without specific reason.","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"40fb7059a715a2dcd76a5378f98ec59711eefa0f","unresolved":false,"context_lines":[{"line_number":516,"context_line":"            mock.call.get_router(mock.ANY, \u0027foo_router_id\u0027),"},{"line_number":517,"context_line":"            mock.call.get_l3_agents_hosting_routers("},{"line_number":518,"context_line":"                mock.ANY, [\u0027foo_router_id\u0027], admin_state_up\u003dTrue),"},{"line_number":519,"context_line":"            mock.call.get_l3_agents(mock.ANY, active\u003dTrue,"},{"line_number":520,"context_line":"                filters\u003d{\u0027availability_zone\u0027: [\u0027nova\u0027]}),"},{"line_number":521,"context_line":"            mock.call.get_l3_agent_candidates(mock.ANY, sync_router, [agent]),"},{"line_number":522,"context_line":"            mock.call.unbind_snat_servicenode(mock.ANY, \u0027foo_router_id\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_bfb910ce","line":519,"updated":"2015-10-09 10:36:43.000000000","message":"Same like in 498","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"40fb7059a715a2dcd76a5378f98ec59711eefa0f","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            mock.call.get_router(mock.ANY, \u0027foo_router_id\u0027),"},{"line_number":545,"context_line":"            mock.call.get_l3_agents_hosting_routers("},{"line_number":546,"context_line":"                mock.ANY, [\u0027foo_router_id\u0027], admin_state_up\u003dTrue),"},{"line_number":547,"context_line":"            mock.call.get_l3_agents(mock.ANY, active\u003dTrue,"},{"line_number":548,"context_line":"                filters\u003d{\u0027availability_zone\u0027: [\u0027nova\u0027]}),"},{"line_number":549,"context_line":"            mock.call.get_l3_agent_candidates(mock.ANY, sync_router, [agent]),"},{"line_number":550,"context_line":"            mock.call.schedule_snat_router("}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_dfbc0cbd","line":547,"updated":"2015-10-09 10:36:43.000000000","message":"Indentation","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4b56921bd37cee50a650dfd3571003b17fc56a46","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            mock.call.get_router(mock.ANY, \u0027foo_router_id\u0027),"},{"line_number":545,"context_line":"            mock.call.get_l3_agents_hosting_routers("},{"line_number":546,"context_line":"                mock.ANY, [\u0027foo_router_id\u0027], admin_state_up\u003dTrue),"},{"line_number":547,"context_line":"            mock.call.get_l3_agents(mock.ANY, active\u003dTrue,"},{"line_number":548,"context_line":"                filters\u003d{\u0027availability_zone\u0027: [\u0027nova\u0027]}),"},{"line_number":549,"context_line":"            mock.call.get_l3_agent_candidates(mock.ANY, sync_router, [agent]),"},{"line_number":550,"context_line":"            mock.call.schedule_snat_router("}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_ff9e1db7","line":547,"in_reply_to":"7a2fa921_dfbc0cbd","updated":"2015-11-25 15:05:48.000000000","message":"Done","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e344fd284605bd045ef1bef2ff04d862333f59e1","unresolved":false,"context_lines":[{"line_number":2139,"context_line":"        self.assertEqual(expected_hosts, hosts)"},{"line_number":2140,"context_line":""},{"line_number":2141,"context_line":""},{"line_number":2142,"context_line":"class L3AgentChanceAZSchedulerTestCase(L3HATestCaseMixin):"},{"line_number":2143,"context_line":""},{"line_number":2144,"context_line":"    def setUp(self):"},{"line_number":2145,"context_line":"        super(L3AgentChanceAZSchedulerTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_31722312","line":2142,"updated":"2015-11-12 02:53:17.000000000","message":"I don\u0027t see much difference between this testcase and L3AgentLeastAZSchedulerTestCase on how to handle ha router.","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4b56921bd37cee50a650dfd3571003b17fc56a46","unresolved":false,"context_lines":[{"line_number":2139,"context_line":"        self.assertEqual(expected_hosts, hosts)"},{"line_number":2140,"context_line":""},{"line_number":2141,"context_line":""},{"line_number":2142,"context_line":"class L3AgentChanceAZSchedulerTestCase(L3HATestCaseMixin):"},{"line_number":2143,"context_line":""},{"line_number":2144,"context_line":"    def setUp(self):"},{"line_number":2145,"context_line":"        super(L3AgentChanceAZSchedulerTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_ffa4ddb9","line":2142,"in_reply_to":"da85f559_31722312","updated":"2015-11-25 15:05:48.000000000","message":"This test was deleted.","commit_id":"54b7cf5f62f33d9d31398324c57f87c68949243a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"537a6a6283b029fd831165f7f372b32a20e12894","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"        self.adminContext.tenant_id \u003d tenant_id"},{"line_number":1685,"context_line":"        router \u003d {\u0027name\u0027: \u0027router1\u0027, \u0027admin_state_up\u0027: True}"},{"line_number":1686,"context_line":"        if ha is not None:"},{"line_number":1687,"context_line":"            router[\u0027ha\u0027] \u003d ha"},{"line_number":1688,"context_line":"        if az \u003d\u003d \u0027empty_list\u0027:"},{"line_number":1689,"context_line":"            az \u003d []"},{"line_number":1690,"context_line":"        if az is not None:"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_9eed7327","line":1687,"updated":"2015-11-26 07:43:32.000000000","message":"What does None as \"az\" mean? Does it have a different meaning from \"empty_list\"? No description looks tricky.","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"05c8251c3298a3a15dc8e9177330f1920a53ffce","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"        self.adminContext.tenant_id \u003d tenant_id"},{"line_number":1685,"context_line":"        router \u003d {\u0027name\u0027: \u0027router1\u0027, \u0027admin_state_up\u0027: True}"},{"line_number":1686,"context_line":"        if ha is not None:"},{"line_number":1687,"context_line":"            router[\u0027ha\u0027] \u003d ha"},{"line_number":1688,"context_line":"        if az \u003d\u003d \u0027empty_list\u0027:"},{"line_number":1689,"context_line":"            az \u003d []"},{"line_number":1690,"context_line":"        if az is not None:"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_05a458b7","line":1687,"in_reply_to":"9a8ffd7b_9eed7327","updated":"2015-11-30 07:58:50.000000000","message":"Originally I intended to distinguish \"non specification\" from requests but it\u0027s not needed now through some changes. Therefore, I removed it.","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"dadeeb1afe6d815c89d82426042a921563f5db64","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        super(L3SchedulerBaseTestCase, self).setUp()"},{"line_number":129,"context_line":"        self.scheduler \u003d FakeL3Scheduler()"},{"line_number":130,"context_line":"        self.plugin \u003d mock.Mock()"},{"line_number":131,"context_line":"        self.agent \u003d {\u0027availability_zone\u0027: \u0027nova\u0027}"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_auto_schedule_routers(self):"},{"line_number":134,"context_line":"        self.plugin.get_enabled_agent_on_host.return_value \u003d self.agent"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_c04848cf","line":131,"updated":"2015-12-01 03:54:53.000000000","message":"I agree with Armando Migliaccio at [1], this is a test case for base scheduler, and you don\u0027t add any new case here. No need to involve AZ here.\n\n[1] https://review.openstack.org/#/c/224418/19/neutron/scheduler/l3_agent_scheduler.py","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c81b3ff9b738ab08d4dac788110894e63eee0ca","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        super(L3SchedulerBaseTestCase, self).setUp()"},{"line_number":129,"context_line":"        self.scheduler \u003d FakeL3Scheduler()"},{"line_number":130,"context_line":"        self.plugin \u003d mock.Mock()"},{"line_number":131,"context_line":"        self.agent \u003d {\u0027availability_zone\u0027: \u0027nova\u0027}"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_auto_schedule_routers(self):"},{"line_number":134,"context_line":"        self.plugin.get_enabled_agent_on_host.return_value \u003d self.agent"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_682a9ee9","line":131,"in_reply_to":"9a8ffd7b_c04848cf","updated":"2015-12-01 07:37:28.000000000","message":"Done","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"dadeeb1afe6d815c89d82426042a921563f5db64","unresolved":false,"context_lines":[{"line_number":2055,"context_line":"        self.assertEqual(self.expected_agent_modes, returned_agent_modes)"},{"line_number":2056,"context_line":""},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"class L3AgentAZLeastSchedulerTestCase(L3HATestCaseMixin):"},{"line_number":2059,"context_line":""},{"line_number":2060,"context_line":"    def setUp(self):"},{"line_number":2061,"context_line":"        super(L3AgentAZLeastSchedulerTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_946121d6","line":2058,"updated":"2015-12-01 03:54:53.000000000","message":"I think the UT here need to consider DVR snat and \"Least\" in the name \"AZLeastRoutersScheduler\".","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c81b3ff9b738ab08d4dac788110894e63eee0ca","unresolved":false,"context_lines":[{"line_number":2055,"context_line":"        self.assertEqual(self.expected_agent_modes, returned_agent_modes)"},{"line_number":2056,"context_line":""},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"class L3AgentAZLeastSchedulerTestCase(L3HATestCaseMixin):"},{"line_number":2059,"context_line":""},{"line_number":2060,"context_line":"    def setUp(self):"},{"line_number":2061,"context_line":"        super(L3AgentAZLeastSchedulerTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_1ec9c8ac","line":2058,"in_reply_to":"9a8ffd7b_946121d6","updated":"2015-12-01 07:37:28.000000000","message":"Availability zone enables neutron to get high availability. However, I noticed DVR snat still does\u0027t support HA[1]. So I will propose AZ for DVR snat after the integration feature has been merged.\n\n[1]: https://review.openstack.org/#/c/143169/","commit_id":"3e515a6f1f19570f09a4c107a7152db2fbf50264"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"37899ad87de5c6194b80f0f23bc67a91af4b8283","unresolved":false,"context_lines":[{"line_number":2045,"context_line":"        self.assertEqual(self.expected_agent_modes, returned_agent_modes)"},{"line_number":2046,"context_line":""},{"line_number":2047,"context_line":""},{"line_number":2048,"context_line":"class L3AgentAZLeastRoutersSchedulerTestCase(L3HATestCaseMixin):"},{"line_number":2049,"context_line":""},{"line_number":2050,"context_line":"    def setUp(self):"},{"line_number":2051,"context_line":"        super(L3AgentAZLeastRoutersSchedulerTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_493eb2b9","line":2048,"updated":"2015-12-01 10:53:06.000000000","message":"I think you should consider the load of agents in the UT, as what you have done in [1].\n\n\n[1] https://review.openstack.org/#/c/204436/50/neutron/tests/unit/scheduler/test_dhcp_agent_scheduler.py","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"462d0a2fa3a5c49096f0af49d5810ceb93c906c7","unresolved":false,"context_lines":[{"line_number":2045,"context_line":"        self.assertEqual(self.expected_agent_modes, returned_agent_modes)"},{"line_number":2046,"context_line":""},{"line_number":2047,"context_line":""},{"line_number":2048,"context_line":"class L3AgentAZLeastRoutersSchedulerTestCase(L3HATestCaseMixin):"},{"line_number":2049,"context_line":""},{"line_number":2050,"context_line":"    def setUp(self):"},{"line_number":2051,"context_line":"        super(L3AgentAZLeastRoutersSchedulerTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_2199c76e","line":2048,"in_reply_to":"9a8ffd7b_493eb2b9","updated":"2015-12-02 09:52:24.000000000","message":"Done","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"}],"releasenotes/notes/add-availability-zone-4440cf00be7c54ba.yaml":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"132d170599b371d43703a457c2bb71b2dda39a59","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Availability zone"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - DHCP agent is assigned to an availability zone; network can be hosted on"},{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9a8ffd7b_42841bd3","line":3,"updated":"2015-11-25 22:52:23.000000000","message":"I added prelude but we should discuss this necessity according with https://review.openstack.org/#/c/204436/49/releasenotes/notes/add-availability-zone-4440cf00be7c54ba.yaml","commit_id":"5e94220ab24575d88c6bdbec195bae9475604ada"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"537a6a6283b029fd831165f7f372b32a20e12894","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Availability zone"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - DHCP agent is assigned to an availability zone; network can be hosted on"},{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a8ffd7b_5ee14bfd","line":3,"updated":"2015-11-26 07:43:32.000000000","message":"I would like to see more detail description, for example, \"Agent scheduling aware of availability zones is now supported.\"","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"05c8251c3298a3a15dc8e9177330f1920a53ffce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Availability zone"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - DHCP agent is assigned to an availability zone; network can be hosted on"},{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a8ffd7b_103d79dc","line":3,"in_reply_to":"9a8ffd7b_5ee14bfd","updated":"2015-11-30 07:58:50.000000000","message":"Done","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"537a6a6283b029fd831165f7f372b32a20e12894","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - DHCP agent is assigned to an availability zone; network can be hosted on"},{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."},{"line_number":7,"context_line":"  - L3 agent is assigned to an availability zone; router can be hosted on the"},{"line_number":8,"context_line":"    L3 agent with availability zone which user specifies."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a8ffd7b_9ebed3d2","line":8,"updated":"2015-11-26 07:43:32.000000000","message":"It is better to mention it supports the relationship to L3HA and DVR scheduling.","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"05c8251c3298a3a15dc8e9177330f1920a53ffce","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - DHCP agent is assigned to an availability zone; network can be hosted on"},{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."},{"line_number":7,"context_line":"  - L3 agent is assigned to an availability zone; router can be hosted on the"},{"line_number":8,"context_line":"    L3 agent with availability zone which user specifies."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a8ffd7b_abfc40b8","line":8,"in_reply_to":"9a8ffd7b_9ebed3d2","updated":"2015-11-30 07:58:50.000000000","message":"Done","commit_id":"24fa4bbe8f8fe6f5bae96cdf6ca2ba1762ae8e38"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"aa4050367898aee3f40ba26a7db656a9656e052f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Agent scheduling aware of availability zones is now supported."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - DHCP agent is assigned to an availability zone; network can be hosted on"},{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a8ffd7b_a3cf7228","line":3,"updated":"2015-11-30 14:11:36.000000000","message":"Nit: how about \"Agent now supports availability zones for scheduling of routers\"","commit_id":"3ac6426b2ad17ced2983b364d6bc83be0e607acd"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0e7e992d297d0a80f6ecc067b754ec9269a87939","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Agent scheduling aware of availability zones is now supported."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - DHCP agent is assigned to an availability zone; network can be hosted on"},{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a8ffd7b_5e945943","line":3,"in_reply_to":"9a8ffd7b_a3cf7228","updated":"2015-11-30 14:20:46.000000000","message":"I don\u0027t have much opinions about release notes but at least \"routers\" is wrong because this feature is for both DHCP and L3.","commit_id":"3ac6426b2ad17ced2983b364d6bc83be0e607acd"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"aa4050367898aee3f40ba26a7db656a9656e052f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Agent scheduling aware of availability zones is now supported."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - DHCP agent is assigned to an availability zone; network can be hosted on"},{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."},{"line_number":7,"context_line":"  - L3 agent is assigned to an availability zone; router can be hosted on the"},{"line_number":8,"context_line":"    L3 agent with availability zone which user specifies. This supports to use"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a8ffd7b_a3e692ae","line":5,"updated":"2015-11-30 14:11:36.000000000","message":"nit: \"will be hosted by\" instead of \"can be hosted on\"?","commit_id":"3ac6426b2ad17ced2983b364d6bc83be0e607acd"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0e7e992d297d0a80f6ecc067b754ec9269a87939","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Agent scheduling aware of availability zones is now supported."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - DHCP agent is assigned to an availability zone; network can be hosted on"},{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."},{"line_number":7,"context_line":"  - L3 agent is assigned to an availability zone; router can be hosted on the"},{"line_number":8,"context_line":"    L3 agent with availability zone which user specifies. This supports to use"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a8ffd7b_fe2e6df9","line":5,"in_reply_to":"9a8ffd7b_a3e692ae","updated":"2015-11-30 14:20:46.000000000","message":"Done","commit_id":"3ac6426b2ad17ced2983b364d6bc83be0e607acd"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"aa4050367898aee3f40ba26a7db656a9656e052f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - DHCP agent is assigned to an availability zone; network can be hosted on"},{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."},{"line_number":7,"context_line":"  - L3 agent is assigned to an availability zone; router can be hosted on the"},{"line_number":8,"context_line":"    L3 agent with availability zone which user specifies. This supports to use"},{"line_number":9,"context_line":"    availability zone with L3HA and DVR."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a8ffd7b_83734ee7","line":8,"updated":"2015-11-30 14:11:36.000000000","message":"nit: \"the use of\" instead of \"to use\"","commit_id":"3ac6426b2ad17ced2983b364d6bc83be0e607acd"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0e7e992d297d0a80f6ecc067b754ec9269a87939","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - DHCP agent is assigned to an availability zone; network can be hosted on"},{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."},{"line_number":7,"context_line":"  - L3 agent is assigned to an availability zone; router can be hosted on the"},{"line_number":8,"context_line":"    L3 agent with availability zone which user specifies. This supports to use"},{"line_number":9,"context_line":"    availability zone with L3HA and DVR."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a8ffd7b_be38e53e","line":8,"in_reply_to":"9a8ffd7b_83734ee7","updated":"2015-11-30 14:20:46.000000000","message":"Done","commit_id":"3ac6426b2ad17ced2983b364d6bc83be0e607acd"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"aa4050367898aee3f40ba26a7db656a9656e052f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."},{"line_number":7,"context_line":"  - L3 agent is assigned to an availability zone; router can be hosted on the"},{"line_number":8,"context_line":"    L3 agent with availability zone which user specifies. This supports to use"},{"line_number":9,"context_line":"    availability zone with L3HA and DVR."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a8ffd7b_e32fbaa5","line":9,"updated":"2015-11-30 14:11:36.000000000","message":"nit: \"zones\" instead of \"zone\"","commit_id":"3ac6426b2ad17ced2983b364d6bc83be0e607acd"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0e7e992d297d0a80f6ecc067b754ec9269a87939","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."},{"line_number":7,"context_line":"  - L3 agent is assigned to an availability zone; router can be hosted on the"},{"line_number":8,"context_line":"    L3 agent with availability zone which user specifies. This supports to use"},{"line_number":9,"context_line":"    availability zone with L3HA and DVR."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a8ffd7b_1e4811cc","line":9,"in_reply_to":"9a8ffd7b_e32fbaa5","updated":"2015-11-30 14:20:46.000000000","message":"Done","commit_id":"3ac6426b2ad17ced2983b364d6bc83be0e607acd"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7f7658fbc8b8b58eb7ed68510a780eb22ddb6c85","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."},{"line_number":7,"context_line":"  - L3 agent is assigned to an availability zone; router will be hosted by the"},{"line_number":8,"context_line":"    L3 agent with availability zone which user specifies. This supports the use"},{"line_number":9,"context_line":"    of availability zones with L3HA. DVR isn\u0027t supported now because L3HA and"},{"line_number":10,"context_line":"    DVR integration isn\u0027t finished."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_098c017e","line":9,"updated":"2015-12-01 21:40:36.000000000","message":"L3HA -\u003e HA routers.","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"462d0a2fa3a5c49096f0af49d5810ceb93c906c7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    the DHCP agent with availability zone which user specifies."},{"line_number":7,"context_line":"  - L3 agent is assigned to an availability zone; router will be hosted by the"},{"line_number":8,"context_line":"    L3 agent with availability zone which user specifies. This supports the use"},{"line_number":9,"context_line":"    of availability zones with L3HA. DVR isn\u0027t supported now because L3HA and"},{"line_number":10,"context_line":"    DVR integration isn\u0027t finished."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_e1a3bf9c","line":9,"in_reply_to":"9a8ffd7b_098c017e","updated":"2015-12-02 09:52:24.000000000","message":"Done","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7f7658fbc8b8b58eb7ed68510a780eb22ddb6c85","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - L3 agent is assigned to an availability zone; router will be hosted by the"},{"line_number":8,"context_line":"    L3 agent with availability zone which user specifies. This supports the use"},{"line_number":9,"context_line":"    of availability zones with L3HA. DVR isn\u0027t supported now because L3HA and"},{"line_number":10,"context_line":"    DVR integration isn\u0027t finished."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_499209a1","line":10,"updated":"2015-12-01 21:40:36.000000000","message":"but when it is, do you need to enhance AZ support? If so, I\u0027d make this an explicit bullet point.\n\nWhat it would take to make this work with plain DVR routers? I was under the impression that it did (work)","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"462d0a2fa3a5c49096f0af49d5810ceb93c906c7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - L3 agent is assigned to an availability zone; router will be hosted by the"},{"line_number":8,"context_line":"    L3 agent with availability zone which user specifies. This supports the use"},{"line_number":9,"context_line":"    of availability zones with L3HA. DVR isn\u0027t supported now because L3HA and"},{"line_number":10,"context_line":"    DVR integration isn\u0027t finished."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"9a8ffd7b_542cc749","line":10,"in_reply_to":"9a8ffd7b_499209a1","updated":"2015-12-02 09:52:24.000000000","message":"I had such plan but I noticed DVR and L3HA integration is processing. AZ provides high availability to neutron but it doesn\u0027t mean high availability now even if AZ supports current DVR snat. And also I\u0027m afraid two points.\n\n1. It\u0027s not easy to supports current SNAT router because DVR scheduling depends on l3_dvrscheduler_db.py.\n\n2. I may take effort to fix after the integration even if AZ supports now although I don\u0027t know how to integrate.\n\nTherefore, I would add DVR support after the integration.","commit_id":"2e27efb16bf28e98764d0a2800670f332950b8b1"}]}
