)]}'
{"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d5cc87aec5bc3c53394d729e8586cebde23da7d6","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    @classmethod"},{"line_number":210,"context_line":"    def get_namespaces(cls):"},{"line_number":211,"context_line":"        output \u003d cls._execute([], \u0027netns\u0027, (\u0027list\u0027,))"},{"line_number":212,"context_line":"        return [l.strip() for l in re.findall(IP_NETNS_PATTERN, output)]"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"class IPDevice(SubProcessBase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_f22468b3","line":212,"updated":"2015-09-18 23:38:53.000000000","message":"it seems faster to do the following?\n\n return [l.split()[0] for l in output.splitlines()]\n\n\nit\u0027s no more needed to strip l","commit_id":"746663877a489351dfb2de58e771af580394cfde"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d5cc87aec5bc3c53394d729e8586cebde23da7d6","unresolved":false,"context_lines":[{"line_number":820,"context_line":"        output \u003d self._parent._execute("},{"line_number":821,"context_line":"            [\u0027o\u0027], \u0027netns\u0027, [\u0027list\u0027],"},{"line_number":822,"context_line":"            run_as_root\u003dcfg.CONF.AGENT.use_helper_for_ns_read)"},{"line_number":823,"context_line":"        for line in re.findall(IP_NETNS_PATTERN, output):"},{"line_number":824,"context_line":"            if name \u003d\u003d line.strip():"},{"line_number":825,"context_line":"                return True"},{"line_number":826,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_7212985a","line":823,"updated":"2015-09-18 23:38:53.000000000","message":"no need to strip l","commit_id":"746663877a489351dfb2de58e771af580394cfde"}],"neutron/tests/unit/agent/linux/test_ip_lib.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"4e747aef64c1dcdc6c976ebe96bc56b8ed412611","unresolved":false,"context_lines":[{"line_number":287,"context_line":"    def test_get_namespaces_iproute2_4(self):"},{"line_number":288,"context_line":"        self.execute.return_value \u003d \u0027\\n\u0027.join(NETNS_SAMPLE_IPROUTE2_4)"},{"line_number":289,"context_line":"        retval \u003d ip_lib.IPWrapper.get_namespaces()"},{"line_number":290,"context_line":"        self.assertEqual(retval,"},{"line_number":291,"context_line":"                         [\u002712345678-1234-5678-abcd-1234567890ab\u0027,"},{"line_number":292,"context_line":"                          \u0027bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb\u0027,"},{"line_number":293,"context_line":"                          \u0027cccccccc-cccc-cccc-cccc-cccccccccccc\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_923decbd","line":290,"updated":"2015-09-18 23:41:24.000000000","message":"it should be:\n\n self.assertEqual(expected, observed)","commit_id":"746663877a489351dfb2de58e771af580394cfde"}]}
