)]}'
{"quantum/plugins/nicira/nicira_nvp_plugin/nvplib.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"92a633e3db1bfe78b2a8ef09ee5311f66371ec23","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"    if taglist:"},{"line_number":1022,"context_line":"        new_taglist \u003d [x for x in taglist if x[\u0027scope\u0027] !\u003d TENANT_ID_SCOPE]"},{"line_number":1023,"context_line":"    new_taglist.append(dict(scope\u003dTENANT_ID_SCOPE, tag\u003dtenant_id))"},{"line_number":1024,"context_line":"    return new_taglist"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"def set_ext_security_profile_id_tag(external_id, taglist\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2BktU%3D","side":"PARENT","line":1024,"updated":"2013-02-27 00:11:41.000000000","message":"This function was quite handy actually.\nWhy not extend it to set os_tid and QUANTUM tags?","commit_id":"2852a4b09e9cd30a726093abb61b6dadbc2faf20"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"37bf85f8ca9ddf9b02b0b52eede506d43563387a","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"    if taglist:"},{"line_number":1022,"context_line":"        new_taglist \u003d [x for x in taglist if x[\u0027scope\u0027] !\u003d TENANT_ID_SCOPE]"},{"line_number":1023,"context_line":"    new_taglist.append(dict(scope\u003dTENANT_ID_SCOPE, tag\u003dtenant_id))"},{"line_number":1024,"context_line":"    return new_taglist"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"def set_ext_security_profile_id_tag(external_id, taglist\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2F00%3D","side":"PARENT","line":1024,"in_reply_to":"AAAAM3%2F%2BktU%3D","updated":"2013-02-28 00:03:07.000000000","message":"I chose to leave it out for now. Perhaps we can add some logic to do_request() in order to populate the quantum scope and version values later and add this function back and leverage it everywhere at a later time.","commit_id":"2852a4b09e9cd30a726093abb61b6dadbc2faf20"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"92a633e3db1bfe78b2a8ef09ee5311f66371ec23","unresolved":false,"context_lines":[{"line_number":711,"context_line":"        admin_status_enabled\u003dadmin_status_enabled,"},{"line_number":712,"context_line":"        display_name\u003ddisplay_name,"},{"line_number":713,"context_line":"        tags\u003d[dict(scope\u003d\u0027os_tid\u0027, tag\u003dtenant_id),"},{"line_number":714,"context_line":"              dict(scope\u003d\u0027q_port_id\u0027, tag\u003dquantum_port_id),"},{"line_number":715,"context_line":"              dict(scope\u003d\u0027vm_id\u0027, tag\u003dhashed_device_id)])"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    _configure_extensions(lport_obj, mac_address, fixed_ips,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2BktY%3D","line":714,"updated":"2013-02-27 00:11:41.000000000","message":"We should ensure the tag with scope \u0027QUANTUM\u0027 is passed to update operations as well, probably.\n\nOtherwise it\u0027s going to be overwritten, as I think NVP API regards \u0027tags\u0027 as a single attribute, not a list attribute.","commit_id":"fcc3c1d59cff6e803b9edd2e705fa5c43c886426"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"37bf85f8ca9ddf9b02b0b52eede506d43563387a","unresolved":false,"context_lines":[{"line_number":711,"context_line":"        admin_status_enabled\u003dadmin_status_enabled,"},{"line_number":712,"context_line":"        display_name\u003ddisplay_name,"},{"line_number":713,"context_line":"        tags\u003d[dict(scope\u003d\u0027os_tid\u0027, tag\u003dtenant_id),"},{"line_number":714,"context_line":"              dict(scope\u003d\u0027q_port_id\u0027, tag\u003dquantum_port_id),"},{"line_number":715,"context_line":"              dict(scope\u003d\u0027vm_id\u0027, tag\u003dhashed_device_id)])"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    _configure_extensions(lport_obj, mac_address, fixed_ips,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2F08%3D","line":714,"in_reply_to":"AAAAM3%2F%2BktY%3D","updated":"2013-02-28 00:03:07.000000000","message":"Done","commit_id":"fcc3c1d59cff6e803b9edd2e705fa5c43c886426"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":298,"context_line":"                                                DEF_TRANSPORT_TYPE)}"},{"line_number":299,"context_line":"    lswitch_obj \u003d {\"display_name\": _check_and_truncate_name(display_name),"},{"line_number":300,"context_line":"                   \"transport_zones\": [transport_zone_config],"},{"line_number":301,"context_line":"                   \"tags\": [{\"tag\": tenant_id, \"scope\": \"os_tid\","},{"line_number":302,"context_line":"                             \"tag\": QUANTUM_VERSION, \"scope\": \"quantum\"}]}"},{"line_number":303,"context_line":"    if nvp_binding_type \u003d\u003d \u0027bridge\u0027 and vlan_id:"},{"line_number":304,"context_line":"        transport_zone_config[\"binding_config\"] \u003d {\"vlan_translation\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2Fucg%3D","line":301,"updated":"2013-04-01 09:45:41.000000000","message":"I think this should be a list of dicts.  As written, line 301 will trump the values in 300.","commit_id":"624e287f731937f6e36f0cb1decf157f5ffef0cf"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"37bf85f8ca9ddf9b02b0b52eede506d43563387a","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                                                DEF_TRANSPORT_TYPE)}"},{"line_number":299,"context_line":"    lswitch_obj \u003d {\"display_name\": _check_and_truncate_name(display_name),"},{"line_number":300,"context_line":"                   \"transport_zones\": [transport_zone_config],"},{"line_number":301,"context_line":"                   \"tags\": [{\"tag\": tenant_id, \"scope\": \"os_tid\","},{"line_number":302,"context_line":"                             \"tag\": QUANTUM_VERSION, \"scope\": \"quantum\"}]}"},{"line_number":303,"context_line":"    if nvp_binding_type \u003d\u003d \u0027bridge\u0027 and vlan_id:"},{"line_number":304,"context_line":"        transport_zone_config[\"binding_config\"] \u003d {\"vlan_translation\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2FucA%3D","line":301,"in_reply_to":"AAAAOH%2F%2Fucg%3D","updated":"2013-04-01 09:55:36.000000000","message":"Good catch! This is missing a }, {","commit_id":"624e287f731937f6e36f0cb1decf157f5ffef0cf"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":328,"context_line":"    uri \u003d _build_uri_path(LSWITCH_RESOURCE, resource_id\u003dlswitch_id)"},{"line_number":329,"context_line":"    lswitch_obj \u003d {\"display_name\": _check_and_truncate_name(display_name),"},{"line_number":330,"context_line":"                   \"tags\": [{\"tag\": tenant_id, \"scope\": \"os_tid\","},{"line_number":331,"context_line":"                             \"tag\": QUANTUM_VERSION, \"scope\": \"quantum\"}]}"},{"line_number":332,"context_line":"    if \"tags\" in kwargs:"},{"line_number":333,"context_line":"        lswitch_obj[\"tags\"].extend(kwargs[\"tags\"])"},{"line_number":334,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2Fuck%3D","line":331,"updated":"2013-04-01 09:45:41.000000000","message":"Same as above","commit_id":"624e287f731937f6e36f0cb1decf157f5ffef0cf"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"37bf85f8ca9ddf9b02b0b52eede506d43563387a","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    uri \u003d _build_uri_path(LSWITCH_RESOURCE, resource_id\u003dlswitch_id)"},{"line_number":329,"context_line":"    lswitch_obj \u003d {\"display_name\": _check_and_truncate_name(display_name),"},{"line_number":330,"context_line":"                   \"tags\": [{\"tag\": tenant_id, \"scope\": \"os_tid\","},{"line_number":331,"context_line":"                             \"tag\": QUANTUM_VERSION, \"scope\": \"quantum\"}]}"},{"line_number":332,"context_line":"    if \"tags\" in kwargs:"},{"line_number":333,"context_line":"        lswitch_obj[\"tags\"].extend(kwargs[\"tags\"])"},{"line_number":334,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2Fub8%3D","line":331,"in_reply_to":"AAAAOH%2F%2Fuck%3D","updated":"2013-04-01 09:55:36.000000000","message":"Done","commit_id":"624e287f731937f6e36f0cb1decf157f5ffef0cf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":299,"context_line":"    lswitch_obj \u003d {\"display_name\": _check_and_truncate_name(display_name),"},{"line_number":300,"context_line":"                   \"transport_zones\": [transport_zone_config],"},{"line_number":301,"context_line":"                   \"tags\": [{\"tag\": tenant_id, \"scope\": \"os_tid\"},"},{"line_number":302,"context_line":"                            {\"tag\": QUANTUM_VERSION, \"scope\": \"quantum\"}]}"},{"line_number":303,"context_line":"    if nvp_binding_type \u003d\u003d \u0027bridge\u0027 and vlan_id:"},{"line_number":304,"context_line":"        transport_zone_config[\"binding_config\"] \u003d {\"vlan_translation\":"},{"line_number":305,"context_line":"                                                   [{\"transport\": vlan_id}]}"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F1UI%3D","line":302,"updated":"2013-04-19 15:05:57.000000000","message":"have you thought of factoring out the generation of the tag list this into a module function? By doing so, we can localize (and minimize) changes for when more common tags like QUANTUM_VERSION need to be added.","commit_id":"3234cd5ac3068cd4d2cbcea8628885057bc2c8f1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"37bf85f8ca9ddf9b02b0b52eede506d43563387a","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    lswitch_obj \u003d {\"display_name\": _check_and_truncate_name(display_name),"},{"line_number":300,"context_line":"                   \"transport_zones\": [transport_zone_config],"},{"line_number":301,"context_line":"                   \"tags\": [{\"tag\": tenant_id, \"scope\": \"os_tid\"},"},{"line_number":302,"context_line":"                            {\"tag\": QUANTUM_VERSION, \"scope\": \"quantum\"}]}"},{"line_number":303,"context_line":"    if nvp_binding_type \u003d\u003d \u0027bridge\u0027 and vlan_id:"},{"line_number":304,"context_line":"        transport_zone_config[\"binding_config\"] \u003d {\"vlan_translation\":"},{"line_number":305,"context_line":"                                                   [{\"transport\": vlan_id}]}"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F1MU%3D","line":302,"in_reply_to":"AAAAOn%2F%2F1UI%3D","updated":"2013-04-19 21:16:21.000000000","message":"yea I though about doing this in do_request() but lets do this refactoring in another set.","commit_id":"3234cd5ac3068cd4d2cbcea8628885057bc2c8f1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":754,"context_line":"    lport_obj \u003d dict("},{"line_number":755,"context_line":"        admin_status_enabled\u003dadmin_status_enabled,"},{"line_number":756,"context_line":"        display_name\u003d_check_and_truncate_name(display_name),"},{"line_number":757,"context_line":"        tags\u003d[dict(scope\u003d\u0027os_tid\u0027, tag\u003dtenant_id),"},{"line_number":758,"context_line":"              dict(scope\u003d\u0027q_port_id\u0027, tag\u003dquantum_port_id),"},{"line_number":759,"context_line":"              dict(scope\u003d\u0027vm_id\u0027, tag\u003dhashed_device_id),"},{"line_number":760,"context_line":"              dict(scope\u003d\u0027quantum\u0027, tag\u003dQUANTUM_VERSION)])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F1UE%3D","line":757,"updated":"2013-04-19 15:05:57.000000000","message":"Recently there was a discussion about using dict() vs {} in https://review.openstack.org/#/c/27059/\nOutcome is that the use of dict() may be discouraged when not done in the context of logging a message. If so, please consider using {} instead of dict()","commit_id":"3234cd5ac3068cd4d2cbcea8628885057bc2c8f1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"37bf85f8ca9ddf9b02b0b52eede506d43563387a","unresolved":false,"context_lines":[{"line_number":754,"context_line":"    lport_obj \u003d dict("},{"line_number":755,"context_line":"        admin_status_enabled\u003dadmin_status_enabled,"},{"line_number":756,"context_line":"        display_name\u003d_check_and_truncate_name(display_name),"},{"line_number":757,"context_line":"        tags\u003d[dict(scope\u003d\u0027os_tid\u0027, tag\u003dtenant_id),"},{"line_number":758,"context_line":"              dict(scope\u003d\u0027q_port_id\u0027, tag\u003dquantum_port_id),"},{"line_number":759,"context_line":"              dict(scope\u003d\u0027vm_id\u0027, tag\u003dhashed_device_id),"},{"line_number":760,"context_line":"              dict(scope\u003d\u0027quantum\u0027, tag\u003dQUANTUM_VERSION)])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F1MA%3D","line":757,"in_reply_to":"AAAAOn%2F%2F1UE%3D","updated":"2013-04-19 21:16:21.000000000","message":"since dict() is all over this file we should do that in a different patch set imo.","commit_id":"3234cd5ac3068cd4d2cbcea8628885057bc2c8f1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":789,"context_line":"    lport_obj \u003d dict("},{"line_number":790,"context_line":"        admin_status_enabled\u003dadmin_status_enabled,"},{"line_number":791,"context_line":"        display_name\u003ddisplay_name,"},{"line_number":792,"context_line":"        tags\u003d[dict(scope\u003d\u0027os_tid\u0027, tag\u003dtenant_id),"},{"line_number":793,"context_line":"              dict(scope\u003d\u0027q_port_id\u0027, tag\u003dquantum_port_id),"},{"line_number":794,"context_line":"              dict(scope\u003d\u0027vm_id\u0027, tag\u003dhashed_device_id),"},{"line_number":795,"context_line":"              dict(scope\u003d\u0027quantum\u0027, tag\u003dQUANTUM_VERSION)],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F1UA%3D","line":792,"updated":"2013-04-19 15:05:57.000000000","message":"ditto","commit_id":"3234cd5ac3068cd4d2cbcea8628885057bc2c8f1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":818,"context_line":"def create_router_lport(cluster, lrouter_uuid, tenant_id, quantum_port_id,"},{"line_number":819,"context_line":"                        display_name, admin_status_enabled, ip_addresses):"},{"line_number":820,"context_line":"    \"\"\" Creates a logical port on the assigned logical router \"\"\""},{"line_number":821,"context_line":"    tags \u003d [dict(scope\u003d\u0027os_tid\u0027, tag\u003dtenant_id),"},{"line_number":822,"context_line":"            dict(scope\u003d\u0027q_port_id\u0027, tag\u003dquantum_port_id),"},{"line_number":823,"context_line":"            dict(scope\u003d\u0027quantum\u0027, tag\u003dQUANTUM_VERSION)]"},{"line_number":824,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F1T8%3D","line":821,"updated":"2013-04-19 15:05:57.000000000","message":"ditto","commit_id":"3234cd5ac3068cd4d2cbcea8628885057bc2c8f1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":854,"context_line":"    lport_obj \u003d dict("},{"line_number":855,"context_line":"        admin_status_enabled\u003dadmin_status_enabled,"},{"line_number":856,"context_line":"        display_name\u003ddisplay_name,"},{"line_number":857,"context_line":"        tags\u003d[dict(scope\u003d\u0027os_tid\u0027, tag\u003dtenant_id),"},{"line_number":858,"context_line":"              dict(scope\u003d\u0027q_port_id\u0027, tag\u003dquantum_port_id),"},{"line_number":859,"context_line":"              dict(scope\u003d\u0027quantum\u0027, tag\u003dQUANTUM_VERSION)],"},{"line_number":860,"context_line":"        ip_addresses\u003dip_addresses,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F1T4%3D","line":857,"updated":"2013-04-19 15:05:57.000000000","message":"ditto","commit_id":"3234cd5ac3068cd4d2cbcea8628885057bc2c8f1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":1084,"context_line":"                    \u0027logical_port_ingress_rules\u0027:"},{"line_number":1085,"context_line":"                    [{\u0027ethertype\u0027: \u0027IPv4\u0027},"},{"line_number":1086,"context_line":"                     {\u0027ethertype\u0027: \u0027IPv6\u0027}]}"},{"line_number":1087,"context_line":"    tags \u003d [dict(scope\u003d\u0027os_tid\u0027, tag\u003dtenant_id),"},{"line_number":1088,"context_line":"            dict(scope\u003d\u0027quantum\u0027, tag\u003dQUANTUM_VERSION)]"},{"line_number":1089,"context_line":"    try:"},{"line_number":1090,"context_line":"        display_name \u003d _check_and_truncate_name(security_profile.get(\u0027name\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2F1T0%3D","line":1087,"updated":"2013-04-19 15:05:57.000000000","message":"ditto","commit_id":"3234cd5ac3068cd4d2cbcea8628885057bc2c8f1"}]}
