)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"08b8541a6620551aeb4e06041858e7019af75eb2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"appropriate resources and that quota usage\u0027s dirty bit"},{"line_number":13,"context_line":"is set and unset as expected."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This are not unit tests, but added in the unit test tree"},{"line_number":16,"context_line":"as they leverage code both from the DB unit test and the ML2"},{"line_number":17,"context_line":"unit test framework. This module has indeed been added to"},{"line_number":18,"context_line":"the \u0027exclusion list\u0027 in check_unit_test_structure.sh, and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a740942_7b8eef28","line":15,"updated":"2015-12-09 22:07:41.000000000","message":"This -\u003e These.","commit_id":"56fb16bb2002497906969e1bdcf3b1e59b5e3684"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d36dfc3b94b7999c7f455a5a27341b7d8263ebe0","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This are not unit tests, but added in the unit test tree"},{"line_number":16,"context_line":"as they leverage code both from the DB unit test and the ML2"},{"line_number":17,"context_line":"unit test framework. This module has indeed been added to"},{"line_number":18,"context_line":"the \u0027exclusion list\u0027 in check_unit_test_structure.sh, and"},{"line_number":19,"context_line":"should be moved to the functional test tree together with"},{"line_number":20,"context_line":"the other modules."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a740942_86049ec6","line":17,"updated":"2015-12-09 22:28:39.000000000","message":"I think functional tests can do the same. I\u0027ll let Assaf chime in.","commit_id":"56fb16bb2002497906969e1bdcf3b1e59b5e3684"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"4dd6a9b5be98488cffe5eb26edbfafba812f9c54","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This are not unit tests, but added in the unit test tree"},{"line_number":16,"context_line":"as they leverage code both from the DB unit test and the ML2"},{"line_number":17,"context_line":"unit test framework. This module has indeed been added to"},{"line_number":18,"context_line":"the \u0027exclusion list\u0027 in check_unit_test_structure.sh, and"},{"line_number":19,"context_line":"should be moved to the functional test tree together with"},{"line_number":20,"context_line":"the other modules."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a740942_819488e8","line":17,"in_reply_to":"7a740942_86049ec6","updated":"2015-12-09 23:17:34.000000000","message":"I have no problem in shuffling code around.\nI\u0027ll put it wherever you see it more fit.","commit_id":"56fb16bb2002497906969e1bdcf3b1e59b5e3684"}],"neutron/quota/resource.py":[{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"8aa619668e263389a9c743ef3c1bf2ce1afbd2d8","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def unregister_events(self):"},{"line_number":304,"context_line":"        try:"},{"line_number":305,"context_line":"            event.remove(self._model_class, \u0027after_insert\u0027,"},{"line_number":306,"context_line":"                         self._db_event_handler)"},{"line_number":307,"context_line":"            event.remove(self._model_class, \u0027after_delete\u0027,"},{"line_number":308,"context_line":"                         self._db_event_handler)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_a78d277d","line":305,"updated":"2015-11-03 17:55:05.000000000","message":"If exception occurs on the first event.remove, second one won\u0027t be attempted.   Perhaps you should have a separate try around each event.remove call.  The LOG.warning probably only needs to be done once.","commit_id":"b5dbddc15b7eb4b48fbf52e4c435f48feb0184d8"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"28b28fc3e63495261260ce619b92fdf339548d92","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def unregister_events(self):"},{"line_number":304,"context_line":"        try:"},{"line_number":305,"context_line":"            event.remove(self._model_class, \u0027after_insert\u0027,"},{"line_number":306,"context_line":"                         self._db_event_handler)"},{"line_number":307,"context_line":"            event.remove(self._model_class, \u0027after_delete\u0027,"},{"line_number":308,"context_line":"                         self._db_event_handler)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_747380e8","line":305,"in_reply_to":"fa80f949_a78d277d","updated":"2015-12-09 12:00:23.000000000","message":"If the first fails with InvalidRequestError there are 0 chances the second will succeed, so it\u0027s not worth imho doing the double handler.","commit_id":"b5dbddc15b7eb4b48fbf52e4c435f48feb0184d8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d36dfc3b94b7999c7f455a5a27341b7d8263ebe0","unresolved":false,"context_lines":[{"line_number":307,"context_line":"            event.remove(self._model_class, \u0027after_delete\u0027,"},{"line_number":308,"context_line":"                         self._db_event_handler)"},{"line_number":309,"context_line":"        except sql_exc.InvalidRequestError:"},{"line_number":310,"context_line":"            LOG.warning(_LW(\"No sqlalchemy event for resource %s found\"),"},{"line_number":311,"context_line":"                        self.name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_e6e32232","line":310,"updated":"2015-12-09 22:28:39.000000000","message":"Is this a normal condition? If so consider demoting the warning to debug, because I am not sure what the admin is supposed to do with it.\n\nhttp://docs.openstack.org/developer/neutron/devref/effective_neutron.html#translation-and-logging","commit_id":"56fb16bb2002497906969e1bdcf3b1e59b5e3684"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"4dd6a9b5be98488cffe5eb26edbfafba812f9c54","unresolved":false,"context_lines":[{"line_number":307,"context_line":"            event.remove(self._model_class, \u0027after_delete\u0027,"},{"line_number":308,"context_line":"                         self._db_event_handler)"},{"line_number":309,"context_line":"        except sql_exc.InvalidRequestError:"},{"line_number":310,"context_line":"            LOG.warning(_LW(\"No sqlalchemy event for resource %s found\"),"},{"line_number":311,"context_line":"                        self.name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_21ffd435","line":310,"in_reply_to":"7a740942_e6e32232","updated":"2015-12-09 23:17:34.000000000","message":"This condition \"Indicates that there might be a systemic issue; potential predictive failure notice\"\n\nIf the app is in a state such that sqlalchemy events were not installed, tracking won\u0027t be reliable. This could happen if a plugin did not implement tracking correctly.","commit_id":"56fb16bb2002497906969e1bdcf3b1e59b5e3684"}],"neutron/tests/unit/plugins/ml2/test_tracked_resources.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"790a3df17f212dc4d2e02f6439884ef074325faa","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        net \u003d self._make_network(\u0027json\u0027, \u0027meh\u0027, True)[\u0027network\u0027]"},{"line_number":71,"context_line":"        self._verify_event_handler_call(net)"},{"line_number":72,"context_line":"        self._delete(\u0027networks\u0027, net[\u0027id\u0027])"},{"line_number":73,"context_line":"        self._verify_event_handler_call(net, expected_call_count\u003d2)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_create_delete_port_triggers_event(self):"},{"line_number":76,"context_line":"        self._test_init(\u0027port\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_a4d36203","line":73,"updated":"2015-09-29 21:23:59.000000000","message":"iiuc, we need to test the delete of a network with subnets","commit_id":"a4474d11b97b4239d9fa0d1eb8a9b88752d266aa"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1133f37856e7c6cd322571bf527d671cedd9c11b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        net \u003d self._make_network(\u0027json\u0027, \u0027meh\u0027, True)[\u0027network\u0027]"},{"line_number":71,"context_line":"        self._verify_event_handler_call(net)"},{"line_number":72,"context_line":"        self._delete(\u0027networks\u0027, net[\u0027id\u0027])"},{"line_number":73,"context_line":"        self._verify_event_handler_call(net, expected_call_count\u003d2)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_create_delete_port_triggers_event(self):"},{"line_number":76,"context_line":"        self._test_init(\u0027port\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_495c9a18","line":73,"in_reply_to":"9a1a9d01_a4d36203","updated":"2015-10-01 08:50:19.000000000","message":"ok, it will be done","commit_id":"a4474d11b97b4239d9fa0d1eb8a9b88752d266aa"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e6fc39d5e4b23913c7c312554e26f1495fd7d820","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SgTestCaseWrapper(test_securitygroup.SecurityGroupDBTestCase):"},{"line_number":23,"context_line":"    # This wrapper calss enables Ml2PluginV2TestCase to correctly call the"},{"line_number":24,"context_line":"    # setup method in SecurityGroupDBTestCase which does not accept the"},{"line_number":25,"context_line":"    # service_plugins keyword parameter."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_999bae72","line":23,"updated":"2015-12-09 18:53:00.000000000","message":"calss \u003d\u003e class","commit_id":"56fb16bb2002497906969e1bdcf3b1e59b5e3684"}]}
