)]}'
{"quantum/agent/dhcp_agent.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"ed8049647db97959c12d7baadb3db44d5ea5cd70","unresolved":false,"context_lines":[{"line_number":565,"context_line":"                try:"},{"line_number":566,"context_line":"                    device.route.add_gateway(gateway_ip)"},{"line_number":567,"context_line":"                except Exception as e:"},{"line_number":568,"context_line":"                    LOG.warning(_(\"Gateway add failed: %s\"), e)"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"        return interface_name"},{"line_number":571,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Boqg%3D","line":568,"updated":"2013-02-24 16:23:01.000000000","message":"This isn\u0027t quite right, I think, as the add didn\u0027t necessarily \"fail\" when this is the case.  I actually have a branch for this already, but was just trying to figure out how clever I should be with the tests.  \n\nBasically, we want to slightly relax the set of error codes that can be returned by the route command to allow for the code returned when a route already exists.","commit_id":"a12e4421f9d3f1eefd1ddfa918cd17a0568edfac"}],"quantum/agent/linux/ip_lib.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0d4fa6be65c3e8f22dd055ce045c37088a0f81ec","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    COMMAND \u003d \u0027route\u0027"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def add_gateway(self, gateway, metric\u003dNone):"},{"line_number":300,"context_line":"        args \u003d [\u0027replace\u0027, \u0027default\u0027, \u0027via\u0027, gateway]"},{"line_number":301,"context_line":"        if metric:"},{"line_number":302,"context_line":"            args +\u003d [\u0027metric\u0027, metric]"},{"line_number":303,"context_line":"        args +\u003d [\u0027dev\u0027, self.name]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAANH%2F%2F%2B9M%3D","line":300,"updated":"2013-02-28 16:59:48.000000000","message":"why I have no \u0027replace\u0027 subcmd for my route command in ubuntu 12.10","commit_id":"063b7ee3a35a266eaf6548c30c697e3d55748288"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0d4fa6be65c3e8f22dd055ce045c37088a0f81ec","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    COMMAND \u003d \u0027route\u0027"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def add_gateway(self, gateway, metric\u003dNone):"},{"line_number":300,"context_line":"        args \u003d [\u0027replace\u0027, \u0027default\u0027, \u0027via\u0027, gateway]"},{"line_number":301,"context_line":"        if metric:"},{"line_number":302,"context_line":"            args +\u003d [\u0027metric\u0027, metric]"},{"line_number":303,"context_line":"        args +\u003d [\u0027dev\u0027, self.name]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAANH%2F%2F%2B6c%3D","line":300,"in_reply_to":"AAAANH%2F%2F%2B7I%3D","updated":"2013-02-28 17:11:08.000000000","message":"yes","commit_id":"063b7ee3a35a266eaf6548c30c697e3d55748288"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":297,"context_line":"    COMMAND \u003d \u0027route\u0027"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def add_gateway(self, gateway, metric\u003dNone):"},{"line_number":300,"context_line":"        args \u003d [\u0027replace\u0027, \u0027default\u0027, \u0027via\u0027, gateway]"},{"line_number":301,"context_line":"        if metric:"},{"line_number":302,"context_line":"            args +\u003d [\u0027metric\u0027, metric]"},{"line_number":303,"context_line":"        args +\u003d [\u0027dev\u0027, self.name]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAANH%2F%2F%2B7I%3D","line":300,"in_reply_to":"AAAANH%2F%2F%2B8I%3D","updated":"2013-02-28 17:07:19.000000000","message":"ah, I was being stupid and was looking at normal \"route\" command, not \"ip route\", which has the \"replace operation\".  That exists even on 12.04.","commit_id":"063b7ee3a35a266eaf6548c30c697e3d55748288"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":297,"context_line":"    COMMAND \u003d \u0027route\u0027"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def add_gateway(self, gateway, metric\u003dNone):"},{"line_number":300,"context_line":"        args \u003d [\u0027replace\u0027, \u0027default\u0027, \u0027via\u0027, gateway]"},{"line_number":301,"context_line":"        if metric:"},{"line_number":302,"context_line":"            args +\u003d [\u0027metric\u0027, metric]"},{"line_number":303,"context_line":"        args +\u003d [\u0027dev\u0027, self.name]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAANH%2F%2F%2B8I%3D","line":300,"in_reply_to":"AAAANH%2F%2F%2B9M%3D","updated":"2013-02-28 17:01:33.000000000","message":"i agree...","commit_id":"063b7ee3a35a266eaf6548c30c697e3d55748288"}]}
