)]}'
{"etc/quantum.conf":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":190,"context_line":"# pagination_max_limit \u003d -1"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"# Maximum number of DNS nameservers per subnet"},{"line_number":193,"context_line":"# max_dns_nameservers\u0027, default \u003d 5"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"# Maximum number of host routes per subnet"},{"line_number":196,"context_line":"# max_subnet_host_routes \u003d 20"}],"source_content_type":"text/plain","patch_set":5,"id":"AAAAM3%2F%2BmTs%3D","line":193,"updated":"2013-02-26 08:09:12.000000000","message":"max_dns_nameservers \u003d 5\n\nWhy didn\u0027t I notice it...","commit_id":"c7c9197b3f0bf855f744991a00ea2a0338688562"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c2938e6e49a282038521602308e57c8b039472d","unresolved":false,"context_lines":[{"line_number":190,"context_line":"# pagination_max_limit \u003d -1"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"# Maximum number of DNS nameservers per subnet"},{"line_number":193,"context_line":"# max_dns_nameservers\u0027, default \u003d 5"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"# Maximum number of host routes per subnet"},{"line_number":196,"context_line":"# max_subnet_host_routes \u003d 20"}],"source_content_type":"text/plain","patch_set":5,"id":"AAAAM3%2F%2BlsI%3D","line":193,"in_reply_to":"AAAAM3%2F%2BmTs%3D","updated":"2013-02-26 16:49:58.000000000","message":"Done","commit_id":"c7c9197b3f0bf855f744991a00ea2a0338688562"}],"quantum/common/config.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":70,"context_line":"    cfg.IntOpt(\u0027max_subnet_host_routes\u0027, default\u003d20,"},{"line_number":71,"context_line":"               help\u003d_(\"Maximum number of host routes per subnet\")),"},{"line_number":72,"context_line":"    cfg.IntOpt(\u0027max_fixed_ips_per_port\u0027, default\u003d5,"},{"line_number":73,"context_line":"               help\u003d_(\"Maximum number of fixed ips per port\")),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027dhcp_lease_duration\u0027, default\u003d120,"},{"line_number":75,"context_line":"               help\u003d_(\"DHCP lease duration\")),"},{"line_number":76,"context_line":"    cfg.BoolOpt(\u0027dhcp_agent_notification\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2BmT0%3D","line":73,"updated":"2013-02-26 08:09:12.000000000","message":"(confirmation) max_* configuration parameters are some kinds of quotas.\nIs the reason they are defined in DEFAULT section they are used in db_plugin (and not used in quota.py) ?","commit_id":"c7c9197b3f0bf855f744991a00ea2a0338688562"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c2938e6e49a282038521602308e57c8b039472d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    cfg.IntOpt(\u0027max_subnet_host_routes\u0027, default\u003d20,"},{"line_number":71,"context_line":"               help\u003d_(\"Maximum number of host routes per subnet\")),"},{"line_number":72,"context_line":"    cfg.IntOpt(\u0027max_fixed_ips_per_port\u0027, default\u003d5,"},{"line_number":73,"context_line":"               help\u003d_(\"Maximum number of fixed ips per port\")),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027dhcp_lease_duration\u0027, default\u003d120,"},{"line_number":75,"context_line":"               help\u003d_(\"DHCP lease duration\")),"},{"line_number":76,"context_line":"    cfg.BoolOpt(\u0027dhcp_agent_notification\u0027, default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Bl2Y%3D","line":73,"in_reply_to":"AAAAM3%2F%2BmT0%3D","updated":"2013-02-26 16:49:58.000000000","message":"yes, sadly so. they are on the to do list to be moved to quotas db support. i am not sure why the dns and host routes were added here","commit_id":"c7c9197b3f0bf855f744991a00ea2a0338688562"}],"quantum/db/db_base_plugin_v2.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":639,"context_line":"        \"\"\"Add or remove IPs from the port.\"\"\""},{"line_number":640,"context_line":"        ips \u003d []"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        num_original \u003d len(original_ips)"},{"line_number":643,"context_line":"        # Remove all of the intersecting elements"},{"line_number":644,"context_line":"        for original_ip in original_ips[:]:"},{"line_number":645,"context_line":"            for new_ip in new_ips[:]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2BnwU%3D","line":642,"updated":"2013-02-25 16:24:07.000000000","message":"I think we can check the number of fixed IPs here since all fixed_ips needs to be passed in the API.\n\nif len(new_ips) .CONF.max_fixed_ips_per_port:\n   raise xxxx","commit_id":"4e5a1205c4dfabd903b96e4558bad4b8acf026ba"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c2938e6e49a282038521602308e57c8b039472d","unresolved":false,"context_lines":[{"line_number":639,"context_line":"        \"\"\"Add or remove IPs from the port.\"\"\""},{"line_number":640,"context_line":"        ips \u003d []"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        num_original \u003d len(original_ips)"},{"line_number":643,"context_line":"        # Remove all of the intersecting elements"},{"line_number":644,"context_line":"        for original_ip in original_ips[:]:"},{"line_number":645,"context_line":"            for new_ip in new_ips[:]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2BmUs%3D","line":642,"in_reply_to":"AAAAM3%2F%2BnwU%3D","updated":"2013-02-26 07:36:29.000000000","message":"Done","commit_id":"4e5a1205c4dfabd903b96e4558bad4b8acf026ba"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":650,"context_line":"                        original_ips.remove(original_ip)"},{"line_number":651,"context_line":"                        new_ips.remove(new_ip)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        if num_original + len(new_ips) \u003e cfg.CONF.max_fixed_ips_per_port:"},{"line_number":654,"context_line":"            msg \u003d _(\u0027Exceeded maximim amount of fixed ips per port\u0027)"},{"line_number":655,"context_line":"            raise q_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":656,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Bnv8%3D","line":653,"updated":"2013-02-25 16:24:07.000000000","message":"This logic does not cover a case where a user want to remove the existing all three IPs and add new three IPs. In this case, num_original is 3 and len(new_ips) is 3, then an exception will be raised.\nI believe the above comment will address the issue.","commit_id":"4e5a1205c4dfabd903b96e4558bad4b8acf026ba"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c2938e6e49a282038521602308e57c8b039472d","unresolved":false,"context_lines":[{"line_number":650,"context_line":"                        original_ips.remove(original_ip)"},{"line_number":651,"context_line":"                        new_ips.remove(new_ip)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        if num_original + len(new_ips) \u003e cfg.CONF.max_fixed_ips_per_port:"},{"line_number":654,"context_line":"            msg \u003d _(\u0027Exceeded maximim amount of fixed ips per port\u0027)"},{"line_number":655,"context_line":"            raise q_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":656,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2BmUo%3D","line":653,"in_reply_to":"AAAAM3%2F%2Bnv8%3D","updated":"2013-02-26 07:36:29.000000000","message":"Done","commit_id":"4e5a1205c4dfabd903b96e4558bad4b8acf026ba"}],"quantum/tests/unit/test_db_plugin.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"1fca84453b56b6682e473b4a0be198bdd701d2eb","unresolved":false,"context_lines":[{"line_number":1741,"context_line":"                    self.assertEqual(update_context._recycled_networks,"},{"line_number":1742,"context_line":"                                     set([subnet[\u0027subnet\u0027][\u0027network_id\u0027]]))"},{"line_number":1743,"context_line":""},{"line_number":1744,"context_line":"    def test_max_fixed_ips(self):"},{"line_number":1745,"context_line":"        with self.subnet(gateway_ip\u003d\u002710.0.0.3\u0027,"},{"line_number":1746,"context_line":"                         cidr\u003d\u002710.0.0.0/29\u0027) as subnet:"},{"line_number":1747,"context_line":"                kwargs \u003d {\"fixed_ips\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Boao%3D","line":1744,"updated":"2013-02-25 03:18:23.000000000","message":"nit/suggestion: would it be better to call this method test_max_fixed_ips_exceeded()?","commit_id":"4bb95f4d067dcfc806567e6dedd905da91fc71f9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c2938e6e49a282038521602308e57c8b039472d","unresolved":false,"context_lines":[{"line_number":1741,"context_line":"                    self.assertEqual(update_context._recycled_networks,"},{"line_number":1742,"context_line":"                                     set([subnet[\u0027subnet\u0027][\u0027network_id\u0027]]))"},{"line_number":1743,"context_line":""},{"line_number":1744,"context_line":"    def test_max_fixed_ips(self):"},{"line_number":1745,"context_line":"        with self.subnet(gateway_ip\u003d\u002710.0.0.3\u0027,"},{"line_number":1746,"context_line":"                         cidr\u003d\u002710.0.0.0/29\u0027) as subnet:"},{"line_number":1747,"context_line":"                kwargs \u003d {\"fixed_ips\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BoUs%3D","line":1744,"in_reply_to":"AAAAM3%2F%2Boao%3D","updated":"2013-02-25 07:21:05.000000000","message":"Done","commit_id":"4bb95f4d067dcfc806567e6dedd905da91fc71f9"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"1fca84453b56b6682e473b4a0be198bdd701d2eb","unresolved":false,"context_lines":[{"line_number":1755,"context_line":"                res \u003d self._create_port(self.fmt, net_id\u003dnet_id, **kwargs)"},{"line_number":1756,"context_line":"                self.assertEqual(res.status_int, 400)"},{"line_number":1757,"context_line":""},{"line_number":1758,"context_line":"    def test_update_max_fixed_ips(self):"},{"line_number":1759,"context_line":"        with self.subnet(gateway_ip\u003d\u002710.0.0.3\u0027,"},{"line_number":1760,"context_line":"                         cidr\u003d\u002710.0.0.0/29\u0027) as subnet:"},{"line_number":1761,"context_line":"            with self.port(subnet) as port:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Boak%3D","line":1758,"updated":"2013-02-25 03:18:23.000000000","message":"nit/suggestion: would it be better to call this method test_update_max_fixed_ips_exceeded()?","commit_id":"4bb95f4d067dcfc806567e6dedd905da91fc71f9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c2938e6e49a282038521602308e57c8b039472d","unresolved":false,"context_lines":[{"line_number":1755,"context_line":"                res \u003d self._create_port(self.fmt, net_id\u003dnet_id, **kwargs)"},{"line_number":1756,"context_line":"                self.assertEqual(res.status_int, 400)"},{"line_number":1757,"context_line":""},{"line_number":1758,"context_line":"    def test_update_max_fixed_ips(self):"},{"line_number":1759,"context_line":"        with self.subnet(gateway_ip\u003d\u002710.0.0.3\u0027,"},{"line_number":1760,"context_line":"                         cidr\u003d\u002710.0.0.0/29\u0027) as subnet:"},{"line_number":1761,"context_line":"            with self.port(subnet) as port:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BoUo%3D","line":1758,"in_reply_to":"AAAAM3%2F%2Boak%3D","updated":"2013-02-25 07:21:05.000000000","message":"Done","commit_id":"4bb95f4d067dcfc806567e6dedd905da91fc71f9"}]}
