)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"824ee25283b1dd2a3d7b2f2e2dcb5a0cecde6882","unresolved":false,"context_lines":[{"line_number":12,"context_line":"be ignored rather than replied to with a DHCPNACK."},{"line_number":13,"context_line":"This is useful for debugging purposes if you are"},{"line_number":14,"context_line":"sharing a subnet and do not want to step on your"},{"line_number":15,"context_line":"peer\u0027s DHCP request flow."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1d3986ab38f3a2c696028e02bd6f602591a4ff0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_98ce08b3","line":15,"updated":"2015-09-28 13:54:21.000000000","message":"This changes requires a DocImpact and a bug.\n\nIMO, if the only reason of this change is debugging then why not using static ips","commit_id":"68a4649649132522194f980b4cf51f380fc33059"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"bc50382376e833e72b36b964a41993f17867940d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"be ignored rather than replied to with a DHCPNACK."},{"line_number":13,"context_line":"This is useful for debugging purposes if you are"},{"line_number":14,"context_line":"sharing a subnet and do not want to step on your"},{"line_number":15,"context_line":"peer\u0027s DHCP request flow."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1d3986ab38f3a2c696028e02bd6f602591a4ff0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_33603f01","line":15,"in_reply_to":"9a1a9d01_98ce08b3","updated":"2015-09-28 14:21:16.000000000","message":"It seems the author\u0027s intent is to insert a debugging DHCP agent to view the interaction between the VM and the dhcp agent, or some other stuff","commit_id":"68a4649649132522194f980b4cf51f380fc33059"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5a94efed47dd29ac199beb1e0b800619cec28719","unresolved":false,"context_lines":[{"line_number":12,"context_line":"be ignored rather than replied to with a DHCPNACK."},{"line_number":13,"context_line":"This is useful for debugging purposes if you are"},{"line_number":14,"context_line":"sharing a subnet and do not want to step on your"},{"line_number":15,"context_line":"peer\u0027s DHCP request flow."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: 1500990"},{"line_number":18,"context_line":"Change-Id: I1d3986ab38f3a2c696028e02bd6f602591a4ff0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a74a57a_ed8ab219","line":15,"updated":"2016-12-01 06:38:14.000000000","message":"please add DocImpact and a release note","commit_id":"0c5a0f8f566bb88b40222b47780c04134005573b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"657ccad5b64417dcfa2d9950be21a0e0d59aaf46","unresolved":false,"context_lines":[{"line_number":12,"context_line":"be ignored rather than replied to with a DHCPNACK."},{"line_number":13,"context_line":"This is useful for debugging purposes if you are"},{"line_number":14,"context_line":"sharing a subnet and do not want to step on your"},{"line_number":15,"context_line":"peer\u0027s DHCP request flow."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: 1500990"},{"line_number":18,"context_line":"Change-Id: I1d3986ab38f3a2c696028e02bd6f602591a4ff0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a71b18c_deb5c7cd","line":15,"updated":"2016-12-02 01:17:12.000000000","message":"This feels like a stop-gap and we should not add config options that we might regret in the future. My suggestion is to look at the history related to this use case and take over, if you\u0027re interested, where things were left off.","commit_id":"ee99a8daf5e5315f41fc452f4025d08150d18d38"}],"neutron/agent/dhcp/config.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"824ee25283b1dd2a3d7b2f2e2dcb5a0cecde6882","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    cfg.BoolOpt(\u0027dhcp_broadcast_reply\u0027, default\u003dFalse,"},{"line_number":73,"context_line":"                help\u003d_(\"Use broadcast in DHCP replies\")),"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    cfg.BoolOpt(\u0027dhcp_ignore_unknown_hosts\u0027, default\u003dFalse,"},{"line_number":76,"context_line":"                help\u003d_(\"If a host is not specified, then ignore it.\")),"},{"line_number":77,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_38749c66","line":75,"updated":"2015-09-28 13:54:21.000000000","message":"You should update etc/dhcp-agent.ini","commit_id":"68a4649649132522194f980b4cf51f380fc33059"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"6bf9b88ea24205f1b9cfdb0ea12bee0c93135035","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    cfg.BoolOpt(\u0027dhcp_broadcast_reply\u0027, default\u003dFalse,"},{"line_number":73,"context_line":"                help\u003d_(\"Use broadcast in DHCP replies\")),"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    cfg.BoolOpt(\u0027dhcp_ignore_unknown_hosts\u0027, default\u003dFalse,"},{"line_number":76,"context_line":"                help\u003d_(\"If a host is not specified, then ignore it.\")),"},{"line_number":77,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_d88c8037","line":75,"in_reply_to":"9a1a9d01_38749c66","updated":"2017-10-09 14:18:54.000000000","message":"Whoops, thanks! will do.","commit_id":"68a4649649132522194f980b4cf51f380fc33059"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"2b1fbd7ae982a88ae1f3979f19d204d35586bbfc","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                help\u003d_(\"Use broadcast in DHCP replies\")),"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    cfg.BoolOpt(\u0027dhcp_ignore_unknown_hosts\u0027, default\u003dFalse,"},{"line_number":76,"context_line":"                help\u003d_(\"If a host is not specified, then ignore it.\")),"},{"line_number":77,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_78b77486","line":76,"updated":"2015-09-28 14:05:56.000000000","message":"I really like this, but I would re-phrase the help here, currently it brings some questions like If the host is not specified where? Why should I do this?\nSomething like: \"DNSMasq will ignore DHCP requests coming from hosts that Neutron is not leasing IPs to. This is useful for development environments were multiple DHCP servers exists\"\nAlso I think it should reflect in the neutron\u0027s etc/dhcp_agent.ini by adding such option there","commit_id":"68a4649649132522194f980b4cf51f380fc33059"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"615c5bcc7777bb9f7d8cc64f575d44353488e278","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                help\u003d_(\"Use broadcast in DHCP replies\")),"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    cfg.BoolOpt(\u0027dhcp_ignore_unknown_hosts\u0027, default\u003dFalse,"},{"line_number":76,"context_line":"                help\u003d_(\"If a host is not specified, then ignore it.\")),"},{"line_number":77,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_bb5aa6f0","line":76,"updated":"2015-09-29 18:09:47.000000000","message":"Sorry, my proofreading background insists I point out better wording :)\n\nJust say \"Ignore any unspecified hosts\"","commit_id":"5de892c9ea72b3739e412764296fc7108f9bc442"}],"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"615c5bcc7777bb9f7d8cc64f575d44353488e278","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"            network\u003dFakeV4Network(),"},{"line_number":1159,"context_line":"            max_leases\u003d256)"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"    def test_spawn_cfg_ignore_unknown_hosts(self):"},{"line_number":1162,"context_line":"        self.conf.set_override(\u0027dhcp_ignore_unknown_hosts\u0027, True)"},{"line_number":1163,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027, \u0027--domain\u003dopenstacklocal\u0027,"},{"line_number":1164,"context_line":"                          \u0027--dhcp-ignore\u003dtag:!known\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_fb325ea6","line":1161,"updated":"2015-09-29 18:09:47.000000000","message":"There should be a test of the case where the setting is False, too.","commit_id":"5de892c9ea72b3739e412764296fc7108f9bc442"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"57bf90b4fad473c1d92a26d15b928ab8b22b77fe","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"            network\u003dFakeV4Network(),"},{"line_number":1159,"context_line":"            max_leases\u003d256)"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"    def test_spawn_cfg_ignore_unknown_hosts(self):"},{"line_number":1162,"context_line":"        self.conf.set_override(\u0027dhcp_ignore_unknown_hosts\u0027, True)"},{"line_number":1163,"context_line":"        self._test_spawn([\u0027--conf-file\u003d\u0027, \u0027--domain\u003dopenstacklocal\u0027,"},{"line_number":1164,"context_line":"                          \u0027--dhcp-ignore\u003dtag:!known\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_c8e540a4","line":1161,"in_reply_to":"9a1a9d01_fb325ea6","updated":"2015-09-30 04:09:44.000000000","message":"+1","commit_id":"5de892c9ea72b3739e412764296fc7108f9bc442"}]}