)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"17387c83e57fef921f3679be340d280627c0f1f1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Now ExtensionDescriptor defines the contract for extensions,"},{"line_number":10,"context_line":"don\u0027t bother to check existence of attributes which exists in"},{"line_number":11,"context_line":"ExtensionDescriptor."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I48e179b8739b61f336f5180a22fc66283b9b6991"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_88742868","line":12,"updated":"2015-09-30 03:45:02.000000000","message":"no need a bug or BP track this change?","commit_id":"0c4d20ec0e02f50e7f7db1662e71438ea04439f0"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"80974afd56d2bf96ee487ba7a2de5f22c73e47b5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Now ExtensionDescriptor defines the contract for extensions,"},{"line_number":10,"context_line":"don\u0027t bother to check existence of attributes which exists in"},{"line_number":11,"context_line":"ExtensionDescriptor."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I48e179b8739b61f336f5180a22fc66283b9b6991"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_52e6bae8","line":12,"in_reply_to":"9a1a9d01_88742868","updated":"2015-09-30 06:29:33.000000000","message":"Done","commit_id":"0c4d20ec0e02f50e7f7db1662e71438ea04439f0"}],"neutron/api/extensions.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"1a9143c4a5b35f773b5c60a71a8242b0d139177e","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        while exts_to_process:"},{"line_number":423,"context_line":"            processed_ext_count \u003d len(processed_exts)"},{"line_number":424,"context_line":"            for ext_name, ext in list(exts_to_process.items()):"},{"line_number":425,"context_line":"                if hasattr(ext, \u0027get_required_extensions\u0027):"},{"line_number":426,"context_line":"                    # Process extension only if all required extensions"},{"line_number":427,"context_line":"                    # have been processed already"},{"line_number":428,"context_line":"                    required_exts_set \u003d set(ext.get_required_extensions())"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_6f8519cd","line":425,"updated":"2015-09-30 06:00:17.000000000","message":"put this into ExtensionDescriptor, then we can remove this line too.","commit_id":"0c4d20ec0e02f50e7f7db1662e71438ea04439f0"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8205fc7b1c6bd6eac958dba09afa0184415bea39","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        while exts_to_process:"},{"line_number":423,"context_line":"            processed_ext_count \u003d len(processed_exts)"},{"line_number":424,"context_line":"            for ext_name, ext in list(exts_to_process.items()):"},{"line_number":425,"context_line":"                if hasattr(ext, \u0027get_required_extensions\u0027):"},{"line_number":426,"context_line":"                    # Process extension only if all required extensions"},{"line_number":427,"context_line":"                    # have been processed already"},{"line_number":428,"context_line":"                    required_exts_set \u003d set(ext.get_required_extensions())"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_72841e0a","line":425,"in_reply_to":"9a1a9d01_6f8519cd","updated":"2015-09-30 06:25:49.000000000","message":"Done","commit_id":"0c4d20ec0e02f50e7f7db1662e71438ea04439f0"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"1a9143c4a5b35f773b5c60a71a8242b0d139177e","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                self._load_all_extensions_from_path(path)"},{"line_number":476,"context_line":"            else:"},{"line_number":477,"context_line":"                LOG.error(_LE(\"Extension path \u0027%s\u0027 doesn\u0027t exist!\"), path)"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    def _load_all_extensions_from_path(self, path):"},{"line_number":480,"context_line":"        # Sorting the extension list makes the order in which they"},{"line_number":481,"context_line":"        # are loaded predictable across a cluster of load-balanced"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_2f53a16c","line":478,"updated":"2015-09-30 06:00:17.000000000","message":"check if the extension derive from ExtensionDescriptor? I think to make sure the derivation is important for this patch\u0027s change","commit_id":"0c4d20ec0e02f50e7f7db1662e71438ea04439f0"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8205fc7b1c6bd6eac958dba09afa0184415bea39","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                self._load_all_extensions_from_path(path)"},{"line_number":476,"context_line":"            else:"},{"line_number":477,"context_line":"                LOG.error(_LE(\"Extension path \u0027%s\u0027 doesn\u0027t exist!\"), path)"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    def _load_all_extensions_from_path(self, path):"},{"line_number":480,"context_line":"        # Sorting the extension list makes the order in which they"},{"line_number":481,"context_line":"        # are loaded predictable across a cluster of load-balanced"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_327b062a","line":478,"in_reply_to":"9a1a9d01_2f53a16c","updated":"2015-09-30 06:25:49.000000000","message":"Done","commit_id":"0c4d20ec0e02f50e7f7db1662e71438ea04439f0"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"c6a51233bd620956508510b834cf5f542cfe0268","unresolved":false,"context_lines":[{"line_number":497,"context_line":"                                     \u0027\"%(ext_name)s\" in %(file)s\u0027),"},{"line_number":498,"context_line":"                                 {\u0027ext_name\u0027: ext_name,"},{"line_number":499,"context_line":"                                  \u0027file\u0027: ext_path})"},{"line_number":500,"context_line":"                        continue"},{"line_number":501,"context_line":"                    new_ext \u003d new_ext_class()"},{"line_number":502,"context_line":"                    self.add_extension(new_ext)"},{"line_number":503,"context_line":"            except Exception as exception:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_52e79aab","line":500,"updated":"2015-09-30 06:38:16.000000000","message":"add line 463 here?","commit_id":"d952cfa8b0a947eedfa5d4291bac965cc4ec8626"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"c6a51233bd620956508510b834cf5f542cfe0268","unresolved":false,"context_lines":[{"line_number":506,"context_line":"                         {\u0027f\u0027: f, \u0027exception\u0027: exception})"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    def add_extension(self, ext):"},{"line_number":509,"context_line":"        # Do nothing if the extension doesn\u0027t check out"},{"line_number":510,"context_line":"        if not self._check_extension(ext):"},{"line_number":511,"context_line":"            return"},{"line_number":512,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_9298d21d","line":509,"updated":"2015-09-30 06:38:16.000000000","message":"when we can make sure extension is instance of  ExtensionDescriptor, do we need check_extension?","commit_id":"d952cfa8b0a947eedfa5d4291bac965cc4ec8626"}]}
