)]}'
{"quantum/extensions/providernet.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"SEGMENTATION_ID \u003d \u0027provider:segmentation_id\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# TODO(salvatore-orlando): Devise a solution for allowing plugins"},{"line_number":27,"context_line":"# to alter the set of allowed values"},{"line_number":28,"context_line":"NETWORK_TYPE_VALUES \u003d [\u0027flat\u0027, \u0027gre\u0027, \u0027local\u0027, \u0027vlan\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BmYw%3D","line":27,"updated":"2013-02-26 06:22:40.000000000","message":"presumably you\u0027d remove this comment if the patch merges.","commit_id":"e07afe209336c365bdaf476405090c919c0303ae"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"SEGMENTATION_ID \u003d \u0027provider:segmentation_id\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# TODO(salvatore-orlando): Devise a solution for allowing plugins"},{"line_number":27,"context_line":"# to alter the set of allowed values"},{"line_number":28,"context_line":"NETWORK_TYPE_VALUES \u003d [\u0027flat\u0027, \u0027gre\u0027, \u0027local\u0027, \u0027vlan\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BmPs%3D","line":27,"in_reply_to":"AAAAM3%2F%2BmYw%3D","updated":"2013-02-26 09:01:27.000000000","message":"I thought I did","commit_id":"e07afe209336c365bdaf476405090c919c0303ae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a69b19008f9cd9de608e7c26882eeb6d309881f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        # custom values for NETWORK_TYPE_VALUES"},{"line_number":93,"context_line":"        plugin \u003d manager.QuantumManager.get_plugin()"},{"line_number":94,"context_line":"        if (hasattr(plugin, \u0027supported_extension_aliases\u0027) and"},{"line_number":95,"context_line":"            self.get_alias() in plugin.supported_extension_aliases and"},{"line_number":96,"context_line":"            hasattr(plugin, \u0027get_custom_network_types\u0027)):"},{"line_number":97,"context_line":"            valid_network_types \u003d list(set(NETWORK_TYPE_VALUES) |"},{"line_number":98,"context_line":"                                       set(plugin.get_custom_network_types()))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BmmM%3D","line":95,"updated":"2013-02-26 02:30:56.000000000","message":"condition expression in L.94-95 is common and we see the similar ones in several places. It would be better to define a common method such as is_extension_supported(plugin, alias_name).","commit_id":"e07afe209336c365bdaf476405090c919c0303ae"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":92,"context_line":"        # custom values for NETWORK_TYPE_VALUES"},{"line_number":93,"context_line":"        plugin \u003d manager.QuantumManager.get_plugin()"},{"line_number":94,"context_line":"        if (hasattr(plugin, \u0027supported_extension_aliases\u0027) and"},{"line_number":95,"context_line":"            self.get_alias() in plugin.supported_extension_aliases and"},{"line_number":96,"context_line":"            hasattr(plugin, \u0027get_custom_network_types\u0027)):"},{"line_number":97,"context_line":"            valid_network_types \u003d list(set(NETWORK_TYPE_VALUES) |"},{"line_number":98,"context_line":"                                       set(plugin.get_custom_network_types()))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BmPw%3D","line":95,"in_reply_to":"AAAAM3%2F%2BmmM%3D","updated":"2013-02-26 09:01:27.000000000","message":"Done","commit_id":"e07afe209336c365bdaf476405090c919c0303ae"}]}