)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"905af565aeb35a1660c0b842daaddd6697c3fc07","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lzklibj \u003clzklibj@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-15 03:15:18 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"not always restart dnsmasq when dhcp-agnet restart"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current code will refresh dnsmasq configure files and"},{"line_number":10,"context_line":"restart dnsmasq process when dhcp-agent restart, even"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba8a016a_d8766cd6","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":42},"updated":"2015-11-19 09:23:31.000000000","message":"dhcp-agnet → dhcp-agent","commit_id":"40548038c48167292f6699352e05aa894fe1557d"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"08de6cb48f682147c5434003ec9958e4eea8e813","unresolved":false,"context_lines":[{"line_number":11,"context_line":"nothing changed to neutron network."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"It seems unnecessary to restart dnsmasq there is no"},{"line_number":14,"context_line":"changing to dnsmasq configures, if nothing changed"},{"line_number":15,"context_line":"happened to neutron network."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-bug: #1496844"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba8a016a_a201fc07","line":14,"updated":"2015-11-19 06:30:45.000000000","message":"configures \u003d\u003e configuration ?","commit_id":"40548038c48167292f6699352e05aa894fe1557d"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"eb7514da20ddbd4e2fc7fc8de83116bb552dac8e","unresolved":false,"context_lines":[{"line_number":1006,"context_line":"        def _file_changed(tmp_file_name):"},{"line_number":1007,"context_line":"            file_name \u003d tmp_file_name[:-4]"},{"line_number":1008,"context_line":"            if file_name \u003d\u003d \u0027leases\u0027:"},{"line_number":1009,"context_line":"                utils.execute([\"cut -d \u0027 \u0027 -f 2- %s \u003e %s-cut\" % ("},{"line_number":1010,"context_line":"                    file_name, file_name)])"},{"line_number":1011,"context_line":"                utils.execute([\"cut -d \u0027 \u0027 -f 2- %s \u003e %s-cut\" % ("},{"line_number":1012,"context_line":"                    tmp_file_name, tmp_file_name)])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_df4e493a","line":1009,"updated":"2015-10-09 11:51:56.000000000","message":"[\u0027cut\u0027,\u0027-d\u0027,\u0027-f\u0027...] instead of only one with white space.","commit_id":"71a7c62447897c745c367dd728ebc7c25d1d6688"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9229c848a4a71b28bfdf8f0c64dc4c8f3f71f245","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        \"\"\"Restart the dhcp service for the network.\"\"\""},{"line_number":135,"context_line":"        self.disable("},{"line_number":136,"context_line":"            retain_port\u003dTrue, retain_config\u003dretain_config)"},{"line_number":137,"context_line":"        self.enable(retain_config)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @abc.abstractproperty"},{"line_number":140,"context_line":"    def active(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_004e1a96","line":137,"updated":"2015-10-14 21:21:34.000000000","message":"If you are adding a keyword argument, be consistent in calling it as such, here and throughout the file.","commit_id":"40548038c48167292f6699352e05aa894fe1557d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9229c848a4a71b28bfdf8f0c64dc4c8f3f71f245","unresolved":false,"context_lines":[{"line_number":648,"context_line":"        if tempfile:"},{"line_number":649,"context_line":"            filename \u003d self.get_conf_file_name(\u0027host-tmp\u0027)"},{"line_number":650,"context_line":"        else:"},{"line_number":651,"context_line":"            filename \u003d self.get_conf_file_name(\u0027host\u0027)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        LOG.debug(\u0027Building host file: %s\u0027, filename)"},{"line_number":654,"context_line":"        dhcp_enabled_subnet_ids \u003d [s.id for s in self.network.subnets"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_80ac6a36","line":651,"updated":"2015-10-14 21:21:34.000000000","message":"Passing the filename seems like a better option than putting this if: everywhere.","commit_id":"40548038c48167292f6699352e05aa894fe1557d"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"08de6cb48f682147c5434003ec9958e4eea8e813","unresolved":false,"context_lines":[{"line_number":648,"context_line":"        if tempfile:"},{"line_number":649,"context_line":"            filename \u003d self.get_conf_file_name(\u0027host-tmp\u0027)"},{"line_number":650,"context_line":"        else:"},{"line_number":651,"context_line":"            filename \u003d self.get_conf_file_name(\u0027host\u0027)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        LOG.debug(\u0027Building host file: %s\u0027, filename)"},{"line_number":654,"context_line":"        dhcp_enabled_subnet_ids \u003d [s.id for s in self.network.subnets"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_3d28cd85","line":651,"in_reply_to":"5a2ca52d_80ac6a36","updated":"2015-11-19 06:30:45.000000000","message":"+1","commit_id":"40548038c48167292f6699352e05aa894fe1557d"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"905af565aeb35a1660c0b842daaddd6697c3fc07","unresolved":false,"context_lines":[{"line_number":648,"context_line":"        if tempfile:"},{"line_number":649,"context_line":"            filename \u003d self.get_conf_file_name(\u0027host-tmp\u0027)"},{"line_number":650,"context_line":"        else:"},{"line_number":651,"context_line":"            filename \u003d self.get_conf_file_name(\u0027host\u0027)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        LOG.debug(\u0027Building host file: %s\u0027, filename)"},{"line_number":654,"context_line":"        dhcp_enabled_subnet_ids \u003d [s.id for s in self.network.subnets"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_f8e570a3","line":651,"in_reply_to":"ba8a016a_3d28cd85","updated":"2015-11-19 09:23:31.000000000","message":"+1","commit_id":"40548038c48167292f6699352e05aa894fe1557d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9229c848a4a71b28bfdf8f0c64dc4c8f3f71f245","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"            ps_status \u003d os.popen(\u0027ps -p %d -h\u0027 % pid).read().split()"},{"line_number":1008,"context_line":"            # check where process status is stoped, dead or trying to exit"},{"line_number":1009,"context_line":"            if ps_status and set(\u0027TZE\u0027) \u0026 set(ps_status[2]):"},{"line_number":1010,"context_line":"                return True"},{"line_number":1011,"context_line":"        return False"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    def _update_config_files_if_changed(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_209476e0","line":1010,"updated":"2015-10-14 21:21:34.000000000","message":"This whole method seems like it could have problems, using something like the psutil module would be better.\n\nBut then why do you care if it\u0027s in this state?  If the pid is there I think you have to assume it\u0027s running, otherwise you\u0027re just taking guesses since it could transition right after you check.  If the process dies, the process_manager code should come along and restart it too.","commit_id":"40548038c48167292f6699352e05aa894fe1557d"}],"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":17789,"name":"Zhao Lei","email":"zhaolei@cn.fujitsu.com","username":"zhaolei"},"change_message_id":"60e074f194ede3b5cee20c7980342783e740d057","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"        dm._output_config_files \u003d mock.Mock()"},{"line_number":1172,"context_line":"        dm._spawn_or_reload_process(mock.Mock, retain_config\u003dTrue)"},{"line_number":1173,"context_line":"        self.assertFalse(dm._output_config_files.called)"},{"line_number":1174,"context_line":"        "},{"line_number":1175,"context_line":"    def test_spawn_retain_config(self):"},{"line_number":1176,"context_line":"        dm \u003d self._get_dnsmasq(FakeDualNetwork(), mock.Mock())"},{"line_number":1177,"context_line":"        dm._output_init_lease_file \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_3e766dd7","line":1174,"updated":"2015-09-30 08:58:09.000000000","message":"WHITESPACE","commit_id":"106238d1d5d230056baca81b16590cd2001933a6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"d95bd4a6219c1609544e6f458c853e5eae95928d","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"        dm._output_config_files \u003d mock.Mock()"},{"line_number":1172,"context_line":"        dm._spawn_or_reload_process(mock.Mock, retain_config\u003dTrue)"},{"line_number":1173,"context_line":"        self.assertFalse(dm._output_config_files.called)"},{"line_number":1174,"context_line":"        "},{"line_number":1175,"context_line":"    def test_spawn_retain_config(self):"},{"line_number":1176,"context_line":"        dm \u003d self._get_dnsmasq(FakeDualNetwork(), mock.Mock())"},{"line_number":1177,"context_line":"        dm._output_init_lease_file \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_56b9b8ca","line":1174,"in_reply_to":"9a1a9d01_3e766dd7","updated":"2015-09-30 15:32:07.000000000","message":"Done. Thanks :)","commit_id":"106238d1d5d230056baca81b16590cd2001933a6"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"905af565aeb35a1660c0b842daaddd6697c3fc07","unresolved":false,"context_lines":[{"line_number":866,"context_line":"        c \u003d SubClass()"},{"line_number":867,"context_line":"        c.restart(retain_config)"},{"line_number":868,"context_line":"        if retain_config:"},{"line_number":869,"context_line":"            self.assertEqual(c.called, [\u0027disable True True\u0027, \u0027enable True\u0027])"},{"line_number":870,"context_line":"        else:"},{"line_number":871,"context_line":"            self.assertEqual(c.called, [\u0027disable True False\u0027, \u0027enable False\u0027])"},{"line_number":872,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_cbf8d8c5","line":869,"updated":"2015-11-19 09:23:31.000000000","message":"Please, use pattern \"self.assertEqual(expected, observed)\" there and also in test_agent.py","commit_id":"40548038c48167292f6699352e05aa894fe1557d"}]}
