)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"988919321fc6838e81e161f20eacd5a916360c5c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"in the query could be incorrect or deleted."},{"line_number":14,"context_line":"This patch catches that exception and logs it as a"},{"line_number":15,"context_line":"debug messages."},{"line_number":16,"context_line":"The debug message will contain the excetpion reason, which"},{"line_number":17,"context_line":"should state why the exception was thrown."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I654ac62df8674122b36ec7429a6db8a1e987b182"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7a2fa921_ff94658b","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":44},"updated":"2015-10-09 11:53:47.000000000","message":"typo: exception","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"222065e3952f6cf0d4d1c7690bdebc0e665362fe","unresolved":false,"context_lines":[{"line_number":13,"context_line":"in the query could be incorrect or deleted."},{"line_number":14,"context_line":"This patch catches that exception and logs it as a"},{"line_number":15,"context_line":"debug messages."},{"line_number":16,"context_line":"The debug message will contain the excetpion reason, which"},{"line_number":17,"context_line":"should state why the exception was thrown."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I654ac62df8674122b36ec7429a6db8a1e987b182"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"fa69d971_e9f7758a","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":44},"in_reply_to":"7a2fa921_ff94658b","updated":"2016-01-07 22:28:51.000000000","message":"will fix it.","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"}],"neutron/plugins/ml2/db.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e0c9f71dce8874d611d5768d686f832a2fe72ed1","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        return (session.query(models.DVRPortBinding)."},{"line_number":212,"context_line":"                filter_by(port_id\u003dport_id, host\u003dhost).one())"},{"line_number":213,"context_line":"    except db_exc.DBReferenceError:"},{"line_number":214,"context_line":"        LOG.debug(\"DVR Port %s could not be bound\", id, exec_info\u003d1)"},{"line_number":215,"context_line":"        return None"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_ffd75321","line":214,"updated":"2015-10-05 15:00:26.000000000","message":"It should be:\n\n exc_info\u003d1","commit_id":"c1f62083f96eb3e6555b10a82b5aca1c1a7ced7c"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"339f2e1308ceb3a9e05cc5c1790405818fb5e202","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        return (session.query(models.DVRPortBinding)."},{"line_number":212,"context_line":"                filter_by(port_id\u003dport_id, host\u003dhost).one())"},{"line_number":213,"context_line":"    except db_exc.DBReferenceError:"},{"line_number":214,"context_line":"        LOG.debug(\"DVR Port %s could not be bound\", id, exec_info\u003d1)"},{"line_number":215,"context_line":"        return None"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_ca93a5a2","line":214,"in_reply_to":"7a2fa921_ffd75321","updated":"2015-10-05 21:10:50.000000000","message":"Done","commit_id":"c1f62083f96eb3e6555b10a82b5aca1c1a7ced7c"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"761b852b3a2da9d1c83e170c1fb62a4c91a9db20","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        return (session.query(models.DVRPortBinding)."},{"line_number":212,"context_line":"                filter_by(port_id\u003dport_id, host\u003dhost).one())"},{"line_number":213,"context_line":"    except db_exc.DBReferenceError:"},{"line_number":214,"context_line":"        LOG.debug(\"DVR Port %s could not be bound\", id, exc_info\u003d1)"},{"line_number":215,"context_line":"        return None"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a2fa921_55940d36","line":214,"updated":"2015-10-06 05:25:31.000000000","message":"id -\u003e port_id","commit_id":"acf0ac776a55a319ea58836e997f157fa082b711"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"8f3c32fca84b4ea0e29c2dc5e97d373d247d1d3b","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        return (session.query(models.DVRPortBinding)."},{"line_number":212,"context_line":"                filter_by(port_id\u003dport_id, host\u003dhost).one())"},{"line_number":213,"context_line":"    except db_exc.DBReferenceError:"},{"line_number":214,"context_line":"        LOG.debug(\"DVR Port %s could not be bound\", id, exc_info\u003d1)"},{"line_number":215,"context_line":"        return None"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a2fa921_f4e2db9e","line":214,"in_reply_to":"7a2fa921_55940d36","updated":"2015-10-06 18:01:36.000000000","message":"Done","commit_id":"acf0ac776a55a319ea58836e997f157fa082b711"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"68ebdaf9a57dd800c3867bf1f246d8d7efcf4ead","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                filter_by(port_id\u003dport_id, host\u003dhost).one())"},{"line_number":213,"context_line":"    except db_exc.DBReferenceError:"},{"line_number":214,"context_line":"        LOG.debug(\"DVR Port %s could not be bound\", port_id, exc_info\u003d1)"},{"line_number":215,"context_line":"        return None"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"def delete_dvr_port_binding(session, port_id, host):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a2fa921_d4e8f1e4","line":215,"updated":"2015-10-07 00:47:58.000000000","message":"nit: return not needed.","commit_id":"a43d58100d2f2f07af7c5582c734fe0f756eae1e"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"b7aa8e726b318e8ef353b4859d46f8c7f1aae979","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                filter_by(port_id\u003dport_id, host\u003dhost).one())"},{"line_number":213,"context_line":"    except db_exc.DBReferenceError:"},{"line_number":214,"context_line":"        LOG.debug(\"DVR Port %s could not be bound\", port_id, exc_info\u003d1)"},{"line_number":215,"context_line":"        return None"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"def delete_dvr_port_binding(session, port_id, host):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a2fa921_6ad7b423","line":215,"in_reply_to":"7a2fa921_d4e8f1e4","updated":"2015-10-07 02:24:04.000000000","message":"agreed. it is a nit pick, and will actually make it a bit confusing, to take it out. \nI understand that python will do this implicitely, but sometime making things explicit makes them easier to understand. For example, there could be another exception which we might need to catch later on","commit_id":"a43d58100d2f2f07af7c5582c734fe0f756eae1e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"49599dccc4308eaa8c88f20e986e66fa7a336e37","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        LOG.debug(\"DVR Port %s already bound\", port_id)"},{"line_number":211,"context_line":"        return (session.query(models.DVRPortBinding)."},{"line_number":212,"context_line":"                filter_by(port_id\u003dport_id, host\u003dhost).one())"},{"line_number":213,"context_line":"    except db_exc.DBReferenceError:"},{"line_number":214,"context_line":"        LOG.debug(\"DVR Port %s could not be bound\", port_id, exc_info\u003d1)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_e1e20901","line":213,"updated":"2015-11-14 17:57:40.000000000","message":"where is this being tested?","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"abf0499e05ea9f977dbf74aca340ab5c963ffdf9","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        LOG.debug(\"DVR Port %s already bound\", port_id)"},{"line_number":211,"context_line":"        return (session.query(models.DVRPortBinding)."},{"line_number":212,"context_line":"                filter_by(port_id\u003dport_id, host\u003dhost).one())"},{"line_number":213,"context_line":"    except db_exc.DBReferenceError:"},{"line_number":214,"context_line":"        LOG.debug(\"DVR Port %s could not be bound\", port_id, exc_info\u003d1)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_7d0eb933","line":213,"in_reply_to":"da85f559_e1e20901","updated":"2015-11-15 06:06:35.000000000","message":"I think new added test case is for this, different port_id are used to setup neutron network and to ensure, exception such as \"FOREIGN KEY constraint failed\" will raise for DBReferenceError.","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"643f44ee6c48132b1dfcd67476d388e8bfc531f6","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        return (session.query(models.DVRPortBinding)."},{"line_number":212,"context_line":"                filter_by(port_id\u003dport_id, host\u003dhost).one())"},{"line_number":213,"context_line":"    except db_exc.DBReferenceError:"},{"line_number":214,"context_line":"        LOG.debug(\"DVR Port %s could not be bound\", port_id, exc_info\u003d1)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"def delete_dvr_port_binding(session, port_id, host):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a2fa921_4c19f821","line":214,"updated":"2015-10-12 10:15:51.000000000","message":"I wonder if debug is the right level. We know that DBDuplicateEntry is not hiding any problem in this case but what about DBReferenceError? Maybe it\u0027s due to the port being deleted maybe there\u0027s something else going on and we are kind of hiding it here...","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"abf0499e05ea9f977dbf74aca340ab5c963ffdf9","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        return (session.query(models.DVRPortBinding)."},{"line_number":212,"context_line":"                filter_by(port_id\u003dport_id, host\u003dhost).one())"},{"line_number":213,"context_line":"    except db_exc.DBReferenceError:"},{"line_number":214,"context_line":"        LOG.debug(\"DVR Port %s could not be bound\", port_id, exc_info\u003d1)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"def delete_dvr_port_binding(session, port_id, host):"}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_5a773bd4","line":214,"in_reply_to":"7a2fa921_4c19f821","updated":"2015-11-15 06:06:35.000000000","message":"Hi, Rossella, so you mean it worth to dig root reasons why DBReferenceError would raise?\n\nI agree that debug level is not a good choice here.\n\nnit: return None, it makes sense to keep the same return behavior in code style as previous return statements did.","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"222065e3952f6cf0d4d1c7690bdebc0e665362fe","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        return (session.query(models.DVRPortBinding)."},{"line_number":212,"context_line":"                filter_by(port_id\u003dport_id, host\u003dhost).one())"},{"line_number":213,"context_line":"    except db_exc.DBReferenceError:"},{"line_number":214,"context_line":"        LOG.debug(\"DVR Port %s could not be bound\", port_id, exc_info\u003d1)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"def delete_dvr_port_binding(session, port_id, host):"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_09c76946","line":214,"in_reply_to":"da85f559_5a773bd4","updated":"2016-01-07 22:28:51.000000000","message":"So what is the right solution here.\nDo we proceed with the \"debug\" or you just want to return without any logging.","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b5af6f8726f7d732b759192fac365fc98e58b9c6","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        LOG.debug(\"DVR Port %s already bound\", port_id)"},{"line_number":218,"context_line":"        return (session.query(models.DVRPortBinding)."},{"line_number":219,"context_line":"                filter_by(port_id\u003dport_id, host\u003dhost).one())"},{"line_number":220,"context_line":"    except db_exc.DBReferenceError:"},{"line_number":221,"context_line":"        return"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"da6ed579_b4ca166d","line":220,"updated":"2016-01-12 22:16:13.000000000","message":"i think we need a test case that covers this.","commit_id":"e220aa322e8619984baa763e612c7f32d45e0109"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"73e1d9eca1a5e2fde6f1fdb916f189bf3b958080","unresolved":false,"context_lines":[{"line_number":1271,"context_line":"            query \u003d self._model_query(context, models_v2.Port)"},{"line_number":1272,"context_line":"            port \u003d (query.enable_eagerloads(False)."},{"line_number":1273,"context_line":"                    filter(models_v2.Port.id \u003d\u003d id)."},{"line_number":1274,"context_line":"                    with_lockmode(\u0027update\u0027).one())"},{"line_number":1275,"context_line":"            if ((\u0027dns-integration\u0027 in self.supported_extension_aliases and"},{"line_number":1276,"context_line":"                    \u0027dns_name\u0027 in port)):"},{"line_number":1277,"context_line":"                port[\u0027dns_assignment\u0027] \u003d self._get_dns_name_for_port_get("}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_e3def43c","line":1274,"updated":"2015-10-01 03:47:11.000000000","message":"There have been numerous attempts to move away from locking, and at the same time rely on db retries. Locking is problematic in certain DB configurations, like Galera etc. You should figure out an alternative approach to solve this problem.","commit_id":"34cf52553ea32037640b54830a5e67527ab7951c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"73e1d9eca1a5e2fde6f1fdb916f189bf3b958080","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"            port \u003d (query.enable_eagerloads(False)."},{"line_number":1273,"context_line":"                    filter(models_v2.Port.id \u003d\u003d id)."},{"line_number":1274,"context_line":"                    with_lockmode(\u0027update\u0027).one())"},{"line_number":1275,"context_line":"            if ((\u0027dns-integration\u0027 in self.supported_extension_aliases and"},{"line_number":1276,"context_line":"                    \u0027dns_name\u0027 in port)):"},{"line_number":1277,"context_line":"                port[\u0027dns_assignment\u0027] \u003d self._get_dns_name_for_port_get("},{"line_number":1278,"context_line":"                    context, port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_a3e55c09","line":1275,"updated":"2015-10-01 03:47:11.000000000","message":"is this relevant to the fix?","commit_id":"34cf52553ea32037640b54830a5e67527ab7951c"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"7c9a10f9ce29385a92b8c67537022a3aae599b75","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"                    except os_db_exception.DBReferenceError as e:"},{"line_number":1298,"context_line":"                        LOG.debug(\"DVR Port %s might have been concurrently\""},{"line_number":1299,"context_line":"                                  \"deleted while ensuring its bidings\", id)"},{"line_number":1300,"context_line":"                        LOG.debug(e)"},{"line_number":1301,"context_line":"                        return"},{"line_number":1302,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"},{"line_number":1303,"context_line":"                levels \u003d db.get_binding_levels(session, id, host)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_d539fdd9","line":1300,"updated":"2015-10-01 20:34:07.000000000","message":"I thought that this error was only happening in the \"ensure_dvr_port_binding\". \nDo we still need to check in different places.","commit_id":"9494ae9f353d704ff2b266840adf22eac74ef979"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"800c54da2df1cfed65d49318ced28e9e1698319d","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"                    except os_db_exception.DBReferenceError as e:"},{"line_number":1298,"context_line":"                        LOG.debug(\"DVR Port %s might have been concurrently\""},{"line_number":1299,"context_line":"                                  \"deleted while ensuring its bidings\", id)"},{"line_number":1300,"context_line":"                        LOG.debug(e)"},{"line_number":1301,"context_line":"                        return"},{"line_number":1302,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"},{"line_number":1303,"context_line":"                levels \u003d db.get_binding_levels(session, id, host)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_a18f6bcb","line":1300,"in_reply_to":"9a1a9d01_d539fdd9","updated":"2015-10-01 22:47:08.000000000","message":"yeah you are right. I will remove all but the ones around ensure_dvr_port_bindings and add others later if we see the error there.","commit_id":"9494ae9f353d704ff2b266840adf22eac74ef979"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"882b960a0523db820336591b9306c332ebd80b5e","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"                    except os_db_exception.DBReferenceError as e:"},{"line_number":1298,"context_line":"                        LOG.debug(\"DVR Port %s might have been concurrently\""},{"line_number":1299,"context_line":"                                  \"deleted while ensuring its bidings\", id)"},{"line_number":1300,"context_line":"                        LOG.debug(e)"},{"line_number":1301,"context_line":"                        return"},{"line_number":1302,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"},{"line_number":1303,"context_line":"                levels \u003d db.get_binding_levels(session, id, host)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_ee11a75e","line":1300,"updated":"2015-10-02 18:31:55.000000000","message":"it seems the rightway to log an exception is:\n\n LOG.debug(\"....\", id, exc_info\u003d1)","commit_id":"ece6b2f4a0608e7588761b81f52e636c7c779877"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"edbbf48af386b820f3ff1dd18d319aff8bb73ea3","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"                    except os_db_exception.DBReferenceError as e:"},{"line_number":1298,"context_line":"                        LOG.debug(\"DVR Port %s might have been concurrently\""},{"line_number":1299,"context_line":"                                  \"deleted while ensuring its bidings\", id)"},{"line_number":1300,"context_line":"                        LOG.debug(e)"},{"line_number":1301,"context_line":"                        return"},{"line_number":1302,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"},{"line_number":1303,"context_line":"                levels \u003d db.get_binding_levels(session, id, host)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_9a2137ff","line":1300,"in_reply_to":"9a1a9d01_ee11a75e","updated":"2015-10-03 07:52:01.000000000","message":"Done","commit_id":"ece6b2f4a0608e7588761b81f52e636c7c779877"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"882b960a0523db820336591b9306c332ebd80b5e","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"                        LOG.debug(\"DVR Port %s might have been concurrently\""},{"line_number":1299,"context_line":"                                  \"deleted while ensuring its bidings\", id)"},{"line_number":1300,"context_line":"                        LOG.debug(e)"},{"line_number":1301,"context_line":"                        return"},{"line_number":1302,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"},{"line_number":1303,"context_line":"                levels \u003d db.get_binding_levels(session, id, host)"},{"line_number":1304,"context_line":"                mech_context \u003d driver_context.PortContext(self,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_79b9df2d","line":1301,"updated":"2015-10-02 18:31:55.000000000","message":"It shouldn\u0027t work: the change catchs an SQL error which breaks the SQL session so session.begin(subtransactions\u003dTrue) context is not aware of the error and tries a COMMIT when it should perform a ROLLBACK","commit_id":"ece6b2f4a0608e7588761b81f52e636c7c779877"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"edbbf48af386b820f3ff1dd18d319aff8bb73ea3","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"                        LOG.debug(\"DVR Port %s might have been concurrently\""},{"line_number":1299,"context_line":"                                  \"deleted while ensuring its bidings\", id)"},{"line_number":1300,"context_line":"                        LOG.debug(e)"},{"line_number":1301,"context_line":"                        return"},{"line_number":1302,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"},{"line_number":1303,"context_line":"                levels \u003d db.get_binding_levels(session, id, host)"},{"line_number":1304,"context_line":"                mech_context \u003d driver_context.PortContext(self,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_3a202bf7","line":1301,"in_reply_to":"9a1a9d01_79b9df2d","updated":"2015-10-03 07:52:01.000000000","message":"Done","commit_id":"ece6b2f4a0608e7588761b81f52e636c7c779877"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ccd38f1e58ff5a75a666a4db00a76d11a90f28ba","unresolved":false,"context_lines":[{"line_number":1296,"context_line":"                            session, id, host, router_id\u003ddevice_id)"},{"line_number":1297,"context_line":"                    except os_db_exception.DBReferenceError:"},{"line_number":1298,"context_line":"                        LOG.debug(\"DVR Port %s might have been concurrently\""},{"line_number":1299,"context_line":"                                  \"deleted while ensuring its bidings\" % id,"},{"line_number":1300,"context_line":"                                  exec_info\u003d1)"},{"line_number":1301,"context_line":"                        session.rollback()"},{"line_number":1302,"context_line":"                        return"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_05770ca0","line":1299,"updated":"2015-10-03 09:11:55.000000000","message":"As mentioned in previous PS, it should:\n\n LOG.debug(\"\", id, exc_info\u003d1)","commit_id":"629f10128b789e22d3bc19e3d5ac406c834d6ee5"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"1c34e53cf29904c62e822ddb13aee30c86dcffa5","unresolved":false,"context_lines":[{"line_number":1296,"context_line":"                            session, id, host, router_id\u003ddevice_id)"},{"line_number":1297,"context_line":"                    except os_db_exception.DBReferenceError:"},{"line_number":1298,"context_line":"                        LOG.debug(\"DVR Port %s might have been concurrently\""},{"line_number":1299,"context_line":"                                  \"deleted while ensuring its bidings\" % id,"},{"line_number":1300,"context_line":"                                  exec_info\u003d1)"},{"line_number":1301,"context_line":"                        session.rollback()"},{"line_number":1302,"context_line":"                        return"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_c6703aa7","line":1299,"in_reply_to":"9a1a9d01_05770ca0","updated":"2015-10-03 17:42:34.000000000","message":"this is the same thing. just different punctuation.","commit_id":"629f10128b789e22d3bc19e3d5ac406c834d6ee5"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ccd38f1e58ff5a75a666a4db00a76d11a90f28ba","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"                        LOG.debug(\"DVR Port %s might have been concurrently\""},{"line_number":1299,"context_line":"                                  \"deleted while ensuring its bidings\" % id,"},{"line_number":1300,"context_line":"                                  exec_info\u003d1)"},{"line_number":1301,"context_line":"                        session.rollback()"},{"line_number":1302,"context_line":"                        return"},{"line_number":1303,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"},{"line_number":1304,"context_line":"                levels \u003d db.get_binding_levels(session, id, host)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_85631cdd","line":1301,"updated":"2015-10-03 09:11:55.000000000","message":"IMO, it shouldn\u0027t work.\n\nMoreover previous PS pass py27 job which means this case is not covered by a unittest \u003d\u003e no way to check it works or not","commit_id":"629f10128b789e22d3bc19e3d5ac406c834d6ee5"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"1c34e53cf29904c62e822ddb13aee30c86dcffa5","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"                        LOG.debug(\"DVR Port %s might have been concurrently\""},{"line_number":1299,"context_line":"                                  \"deleted while ensuring its bidings\" % id,"},{"line_number":1300,"context_line":"                                  exec_info\u003d1)"},{"line_number":1301,"context_line":"                        session.rollback()"},{"line_number":1302,"context_line":"                        return"},{"line_number":1303,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"},{"line_number":1304,"context_line":"                levels \u003d db.get_binding_levels(session, id, host)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_c6591a37","line":1301,"in_reply_to":"9a1a9d01_85631cdd","updated":"2015-10-03 17:42:34.000000000","message":"this can\u0027t be cover by unit test because it has to have a db to make the  call against.  not easy to do on a unit test. \nCould you please provide code example how you would accomplish the rollback? I looked at the documentation of sqalchemy and this is how it is done there. \n\nDone","commit_id":"629f10128b789e22d3bc19e3d5ac406c834d6ee5"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"68ebdaf9a57dd800c3867bf1f246d8d7efcf4ead","unresolved":false,"context_lines":[{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"},{"line_number":1300,"context_line":"                levels \u003d db.get_binding_levels(session, id, host)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a2fa921_149ae963","line":1297,"updated":"2015-10-07 00:47:58.000000000","message":"We should add:   port was deleted concurrently this way it\u0027s more obvious the reason for this to not be set.","commit_id":"a43d58100d2f2f07af7c5582c734fe0f756eae1e"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"b7aa8e726b318e8ef353b4859d46f8c7f1aae979","unresolved":false,"context_lines":[{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"},{"line_number":1300,"context_line":"                levels \u003d db.get_binding_levels(session, id, host)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a2fa921_8a6d709a","line":1297,"in_reply_to":"7a2fa921_149ae963","updated":"2015-10-07 02:24:04.000000000","message":"Actually binding being none only means that the function could not ensure the dvr binding. It does not necessarily mean the port was deleted concurrently. i.e. ensure_dvr_port_binding could actually fail for other reasons. \nIf you look at the function definition for ensure_dvr_port_binding it return None if \nDBReference is thrown. Not necessarily because the port has been deleted,\nThe LOG entry displaying the actual DBReference message will describe the reason why the DBReferenceError was thrown. \n\nexcept db_exc.DBReferenceError:\t\n          LOG.debug(\"DVR Port %s could not be bound\", port_id, exc_info\u003d1)","commit_id":"a43d58100d2f2f07af7c5582c734fe0f756eae1e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"50a45104a3316452a933c96ba1442fdac265801f","unresolved":false,"context_lines":[{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"},{"line_number":1300,"context_line":"                levels \u003d db.get_binding_levels(session, id, host)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a2fa921_7091ad46","line":1297,"updated":"2015-10-08 06:24:13.000000000","message":"I suspected that this debug message is duplicated to debug message of plugins/ml2/db.py. If this issue happens, debug message is consecutively outputted as following.\n\n \"DVR Port PORT_ID could not be bound\"\n \"Could not ensure dvr binding for port PORT_ID\"\n\nCan you gather these logs or change the message more useful?","commit_id":"0c927f3be8089c9b76a87bc72413285066ab0bb1"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"7a4b0a3b38467645fc376791cf1f660706d609c0","unresolved":false,"context_lines":[{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"},{"line_number":1300,"context_line":"                levels \u003d db.get_binding_levels(session, id, host)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a2fa921_dbc8c024","line":1297,"in_reply_to":"7a2fa921_7091ad46","updated":"2015-10-08 18:35:58.000000000","message":"Actually it is not duplicate. \n\"Could not ensure dvr binding for port %s\", id\nmeans exactly that. The functions \"ensure_dvr_port_binding\" could not verify that the port is bound.  The reason for that is not necessarily that the port could not be bound. Its a  bad idea to explicitily log information which is not 100% accurate. \nThe line: \nLOG.debug(\"DVR Port %s could not be bound\", port_id, exc_info\u003d1)\nactually gives you all the details you need. \nthe \"exec_info\u003d1\" instructs it to  print out the exception message. \nSo the message will read: \n\"DVR port could not be bound\" which is correct, \nand then it will print out the exception message which will contain the reason the DBReferenceError is being thrown. 90% of the time it is because the port has been deleted, but it is that other 10% that prevents us from conclusively stating 100% sure that the port was deleted. \nAgain we can\u0027t log something unless we are 100% sure it is accurate.\n\nSo the error actually will look like\nensure_dvr_port_binding:\"DVR Port PORT_ID could not be bound\" \nensure_dvr_port_binding:\" DBRErrorException, ... folllowed by reason for excpetion\"\nupdate_dvr_port_binding: \"Could not ensure dvr binding for PORT_ID\"","commit_id":"0c927f3be8089c9b76a87bc72413285066ab0bb1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7c189a632569cac519ad837ee7c880f1f62883f5","unresolved":false,"context_lines":[{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"},{"line_number":1300,"context_line":"                levels \u003d db.get_binding_levels(session, id, host)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a2fa921_f5857dce","line":1297,"in_reply_to":"7a2fa921_dbc8c024","updated":"2015-10-08 23:50:34.000000000","message":"make sense","commit_id":"0c927f3be8089c9b76a87bc72413285066ab0bb1"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d240f6cf5d3afa0c67d08c41a9d5da39373532cb","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"                if not binding:"},{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a2fa921_0482e9c8","line":1296,"updated":"2015-10-12 15:38:15.000000000","message":"IMO, it would be better to move this if clause inside previous if.\n\nif not binding:\n    binding \u003d db.ensure_dvr_port_binding(\n            session, id, host, router_id\u003ddevice_id)\n    if binding is None:\n        LOG.debug(\"Could not ensure dvr binding for port %s\", id)\n        return","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d25f4c4e88e418dd5861ed0a248f19aab967c50b","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"                if not binding:"},{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a2fa921_82e08d97","line":1296,"updated":"2015-10-08 23:10:44.000000000","message":"can\u0027t u just log in previous if not binding ?","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ef2eea713027b9e9d3a6ec18682b062a13320403","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"                if not binding:"},{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_e1f449d0","line":1296,"in_reply_to":"7a2fa921_0482e9c8","updated":"2015-11-14 17:55:03.000000000","message":"+1 for Vikram. Described construct makes much more sense, than current one.","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"e63d26089c97b1c147f3fcffd37d7c26fbb9af7b","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"                if not binding:"},{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a2fa921_23a146f8","line":1296,"in_reply_to":"7a2fa921_82e08d97","updated":"2015-10-10 00:53:50.000000000","message":"Done","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5ed63d29dd9002fd4a9f42c652d498e9d852ee55","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"                if not binding:"},{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a2fa921_95dd29e2","line":1296,"in_reply_to":"7a2fa921_82e08d97","updated":"2015-10-08 23:52:10.000000000","message":"Nop. The value is updated in previous if-statement.","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"e63d26089c97b1c147f3fcffd37d7c26fbb9af7b","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"                if not binding:"},{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a2fa921_c3a3b2fe","line":1296,"in_reply_to":"7a2fa921_95dd29e2","updated":"2015-10-10 00:53:50.000000000","message":"Done","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"fa1be4fcb0e95bb45e4ecb2b366adce711169134","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"                if not binding:"},{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a2fa921_ac5c7319","line":1296,"in_reply_to":"7a2fa921_95dd29e2","updated":"2015-10-09 18:14:11.000000000","message":"ok, thanks","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"e63d26089c97b1c147f3fcffd37d7c26fbb9af7b","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"                if not binding:"},{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a2fa921_e3a6ee0d","line":1296,"in_reply_to":"7a2fa921_ac5c7319","updated":"2015-10-10 00:53:50.000000000","message":"Done","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"222065e3952f6cf0d4d1c7690bdebc0e665362fe","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"                if not binding:"},{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_29fd8d6e","line":1296,"in_reply_to":"da85f559_da300b0a","updated":"2016-01-07 22:28:51.000000000","message":"will fix it.","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"abf0499e05ea9f977dbf74aca340ab5c963ffdf9","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"                if not binding:"},{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_da300b0a","line":1296,"in_reply_to":"da85f559_e1f449d0","updated":"2015-11-15 06:06:35.000000000","message":"+1, Vikram comments make more sense, even to binding is not None case, it makes no sense to check twice.","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ef2eea713027b9e9d3a6ec18682b062a13320403","unresolved":false,"context_lines":[{"line_number":1294,"context_line":"                    binding \u003d db.ensure_dvr_port_binding("},{"line_number":1295,"context_line":"                        session, id, host, router_id\u003ddevice_id)"},{"line_number":1296,"context_line":"                if not binding:"},{"line_number":1297,"context_line":"                    LOG.debug(\"Could not ensure dvr binding for port %s\", id)"},{"line_number":1298,"context_line":"                    return"},{"line_number":1299,"context_line":"                network \u003d self.get_network(context, orig_port[\u0027network_id\u0027])"},{"line_number":1300,"context_line":"                levels \u003d db.get_binding_levels(session, id, host)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_e11be91a","line":1297,"updated":"2015-11-14 17:55:03.000000000","message":"Is this really just \"debug\" and not \"error\"?","commit_id":"03bf12ba7b860f80071ca0ba954036bab82f02d4"}],"neutron/tests/unit/plugins/ml2/test_db.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e0c9f71dce8874d611d5768d686f832a2fe72ed1","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        binding \u003d \"check\""},{"line_number":319,"context_line":"        binding \u003d ml2_db.ensure_dvr_port_binding("},{"line_number":320,"context_line":"            self.ctx.session, del_port_id, \u0027foo_host_1\u0027, router.id)"},{"line_number":321,"context_line":"        self.assertEqual(None, binding)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def test_delete_dvr_port_binding(self):"},{"line_number":324,"context_line":"        network_id \u003d \u0027foo_network_id\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_dfb937ee","line":321,"updated":"2015-10-05 15:00:26.000000000","message":"self.assertNone","commit_id":"c1f62083f96eb3e6555b10a82b5aca1c1a7ced7c"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"339f2e1308ceb3a9e05cc5c1790405818fb5e202","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        binding \u003d \"check\""},{"line_number":319,"context_line":"        binding \u003d ml2_db.ensure_dvr_port_binding("},{"line_number":320,"context_line":"            self.ctx.session, del_port_id, \u0027foo_host_1\u0027, router.id)"},{"line_number":321,"context_line":"        self.assertEqual(None, binding)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def test_delete_dvr_port_binding(self):"},{"line_number":324,"context_line":"        network_id \u003d \u0027foo_network_id\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_0acf5db1","line":321,"in_reply_to":"7a2fa921_7fcee35b","updated":"2015-10-05 21:10:50.000000000","message":"Done","commit_id":"c1f62083f96eb3e6555b10a82b5aca1c1a7ced7c"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"6e42b4296afbac6c52d63d057d3e6c6d1689714f","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        binding \u003d \"check\""},{"line_number":319,"context_line":"        binding \u003d ml2_db.ensure_dvr_port_binding("},{"line_number":320,"context_line":"            self.ctx.session, del_port_id, \u0027foo_host_1\u0027, router.id)"},{"line_number":321,"context_line":"        self.assertEqual(None, binding)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def test_delete_dvr_port_binding(self):"},{"line_number":324,"context_line":"        network_id \u003d \u0027foo_network_id\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_7fcee35b","line":321,"in_reply_to":"7a2fa921_dfb937ee","updated":"2015-10-05 15:04:07.000000000","message":"+1","commit_id":"c1f62083f96eb3e6555b10a82b5aca1c1a7ced7c"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"339f2e1308ceb3a9e05cc5c1790405818fb5e202","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        binding \u003d \"check\""},{"line_number":319,"context_line":"        binding \u003d ml2_db.ensure_dvr_port_binding("},{"line_number":320,"context_line":"            self.ctx.session, del_port_id, \u0027foo_host_1\u0027, router.id)"},{"line_number":321,"context_line":"        self.assertEqual(None, binding)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def test_delete_dvr_port_binding(self):"},{"line_number":324,"context_line":"        network_id \u003d \u0027foo_network_id\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_eac9c1ad","line":321,"in_reply_to":"7a2fa921_dfb937ee","updated":"2015-10-05 21:10:50.000000000","message":"Done","commit_id":"c1f62083f96eb3e6555b10a82b5aca1c1a7ced7c"}]}
