)]}'
{"quantum/plugins/nicira/nicira_nvp_plugin/QuantumPlugin.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"79502b5a5a0e17720e3db25571fad7df92ee902b","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"        else:"},{"line_number":1054,"context_line":"            tenant_ids \u003d tenant_ids or [context.tenant_id]"},{"line_number":1055,"context_line":"            tenant_filter \u003d \u0027\u0027.join(filter_fmt % tid for tid in tenant_ids)"},{"line_number":1056,"context_line":"        lswitch_filters \u003d \"uuid,display_name,fabric_status,tags\""},{"line_number":1057,"context_line":"        lswitch_url_path_1 \u003d ("},{"line_number":1058,"context_line":"            \"/ws.v1/lswitch?fields\u003d%s\u0026relations\u003dLogicalSwitchStatus%s\""},{"line_number":1059,"context_line":"            % (lswitch_filters, tenant_filter))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Bi%2BU%3D","line":1056,"updated":"2013-02-27 20:56:49.000000000","message":"It would probably be a good idea if we abstracted some of this stuff away from QuantumPlugin.py and moved this kind of logic into nvplib. That said we do is in a few places already so i\u0027m okay with it for now.","commit_id":"8fbf5441cdc9c119b6bbe7c0cd49391886ba405e"}],"quantum/plugins/nicira/nicira_nvp_plugin/nvplib.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"60b1758939aa10fb3b233ba10bdcc78cad0f0105","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    if tenant_id:"},{"line_number":321,"context_line":"        tags.append({\"tag\": tenant_id, \"scope\": \"os_tid\"})"},{"line_number":322,"context_line":"    if tags:"},{"line_number":323,"context_line":"        lswitch_obj[\u0027tags\u0027] \u003d tags"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    try:"},{"line_number":326,"context_line":"        resp_obj \u003d do_single_request(HTTP_PUT, uri, json.dumps(lswitch_obj),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BlkQ%3D","line":323,"updated":"2013-02-26 17:44:24.000000000","message":"so this will not clear the shared tag?  i\u0027m not clear on why.","commit_id":"f4a85e2d496a018340675b3ec9103c1aa192cd75"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":320,"context_line":"    if tenant_id:"},{"line_number":321,"context_line":"        tags.append({\"tag\": tenant_id, \"scope\": \"os_tid\"})"},{"line_number":322,"context_line":"    if tags:"},{"line_number":323,"context_line":"        lswitch_obj[\u0027tags\u0027] \u003d tags"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    try:"},{"line_number":326,"context_line":"        resp_obj \u003d do_single_request(HTTP_PUT, uri, json.dumps(lswitch_obj),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BlL8%3D","line":323,"in_reply_to":"AAAAM3%2F%2BlVo%3D","updated":"2013-02-26 20:12:43.000000000","message":"I meant to say the changes in this patch to update_lswitch are not relevant.\n\nThe \u0027shared\u0027 tag, when needs to be applied, is passed by the caller, and therefore will surely be on the lswitch object\n\nSo What I need to address in this patch is just to ensure there\u0027s no change in nvplib, as no change was required, and verify that everytime it is called the \u0027shared\u0027 tag is added (if the network is shared, of course)","commit_id":"f4a85e2d496a018340675b3ec9103c1aa192cd75"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"60b1758939aa10fb3b233ba10bdcc78cad0f0105","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    if tenant_id:"},{"line_number":321,"context_line":"        tags.append({\"tag\": tenant_id, \"scope\": \"os_tid\"})"},{"line_number":322,"context_line":"    if tags:"},{"line_number":323,"context_line":"        lswitch_obj[\u0027tags\u0027] \u003d tags"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    try:"},{"line_number":326,"context_line":"        resp_obj \u003d do_single_request(HTTP_PUT, uri, json.dumps(lswitch_obj),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BlVo%3D","line":323,"in_reply_to":"AAAAM3%2F%2BlWs%3D","updated":"2013-02-26 19:08:34.000000000","message":"ok, so are you saying it needs to be addressed in this patch, or a different one?","commit_id":"f4a85e2d496a018340675b3ec9103c1aa192cd75"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":320,"context_line":"    if tenant_id:"},{"line_number":321,"context_line":"        tags.append({\"tag\": tenant_id, \"scope\": \"os_tid\"})"},{"line_number":322,"context_line":"    if tags:"},{"line_number":323,"context_line":"        lswitch_obj[\u0027tags\u0027] \u003d tags"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    try:"},{"line_number":326,"context_line":"        resp_obj \u003d do_single_request(HTTP_PUT, uri, json.dumps(lswitch_obj),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BlWs%3D","line":323,"in_reply_to":"AAAAM3%2F%2BlkQ%3D","updated":"2013-02-26 19:05:29.000000000","message":"It will actually. I know why it\u0027s not affecting us, but it should be fixed.","commit_id":"f4a85e2d496a018340675b3ec9103c1aa192cd75"}]}