)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"102b7c5d68b24db05c52a883af2a0e71fc42b17b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergey Belous \u003csbelous@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-22 09:35:19 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve OVS-agent init-method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed create_agent_config_map method which creates specific configurations"},{"line_number":10,"context_line":"dictionary according to cfg.CONF and call the OVS-agent with that structure."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a29b11f_3b4afb26","line":7,"updated":"2015-10-22 08:34:21.000000000","message":"Improve -\u003e Refactor","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"c5296557ed899abb958b74832d6e76f75f724126","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergey Belous \u003csbelous@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-22 09:35:19 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve OVS-agent init-method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed create_agent_config_map method which creates specific configurations"},{"line_number":10,"context_line":"dictionary according to cfg.CONF and call the OVS-agent with that structure."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a29b11f_8ae3a2d8","line":7,"in_reply_to":"3a29b11f_3b4afb26","updated":"2015-10-22 17:10:36.000000000","message":"Done","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"102b7c5d68b24db05c52a883af2a0e71fc42b17b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed create_agent_config_map method which creates specific configurations"},{"line_number":10,"context_line":"dictionary according to cfg.CONF and call the OVS-agent with that structure."},{"line_number":11,"context_line":"Passing oslo_config directly to init-method of OVS-agent is avoids a confusion"},{"line_number":12,"context_line":"and makes it easy to track. Also refactored unit and functional tests"},{"line_number":13,"context_line":"of OVS-agent in accordance with the changes in init-method."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a29b11f_1bd29f28","line":11,"updated":"2015-10-22 08:34:21.000000000","message":"is avoids -\u003e eliminates","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"c5296557ed899abb958b74832d6e76f75f724126","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed create_agent_config_map method which creates specific configurations"},{"line_number":10,"context_line":"dictionary according to cfg.CONF and call the OVS-agent with that structure."},{"line_number":11,"context_line":"Passing oslo_config directly to init-method of OVS-agent is avoids a confusion"},{"line_number":12,"context_line":"and makes it easy to track. Also refactored unit and functional tests"},{"line_number":13,"context_line":"of OVS-agent in accordance with the changes in init-method."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a29b11f_2ae60ee8","line":11,"in_reply_to":"3a29b11f_1bd29f28","updated":"2015-10-22 17:10:36.000000000","message":"Done","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"102b7c5d68b24db05c52a883af2a0e71fc42b17b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Removed create_agent_config_map method which creates specific configurations"},{"line_number":10,"context_line":"dictionary according to cfg.CONF and call the OVS-agent with that structure."},{"line_number":11,"context_line":"Passing oslo_config directly to init-method of OVS-agent is avoids a confusion"},{"line_number":12,"context_line":"and makes it easy to track. Also refactored unit and functional tests"},{"line_number":13,"context_line":"of OVS-agent in accordance with the changes in init-method."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-bug: #1464394"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a29b11f_db9e6762","line":12,"updated":"2015-10-22 08:34:21.000000000","message":"makes it more testable","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"c5296557ed899abb958b74832d6e76f75f724126","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Removed create_agent_config_map method which creates specific configurations"},{"line_number":10,"context_line":"dictionary according to cfg.CONF and call the OVS-agent with that structure."},{"line_number":11,"context_line":"Passing oslo_config directly to init-method of OVS-agent is avoids a confusion"},{"line_number":12,"context_line":"and makes it easy to track. Also refactored unit and functional tests"},{"line_number":13,"context_line":"of OVS-agent in accordance with the changes in init-method."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-bug: #1464394"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a29b11f_4ae90ab6","line":12,"in_reply_to":"3a29b11f_db9e6762","updated":"2015-10-22 17:10:36.000000000","message":"Done","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"3f312059b158cd2f98cd2de15212d0e6698d4aee","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed create_agent_config_map method which creates specific configurations"},{"line_number":10,"context_line":"dictionary according to cfg.CONF and call the OVS-agent with that structure."},{"line_number":11,"context_line":"Passing oslo_config directly to init-method of OVS-agent eliminates a confusion"},{"line_number":12,"context_line":"and makes it more testable. Also refactored unit and functional tests"},{"line_number":13,"context_line":"of OVS-agent in accordance with the changes in init-method."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a29b11f_d3add2e9","line":11,"updated":"2015-10-22 17:57:49.000000000","message":"nit: \"eliminates confusion\" is proper, not \"eliminates a confusion\".  Alternately, it might be more obvious what you\u0027re saying if you said \"is more straightforward\".","commit_id":"32f095d577c93569f10602d134e794190c3976c6"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"d93331bef42f17e34eb18ead884d6440836fab24","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed create_agent_config_map method which creates specific configurations"},{"line_number":10,"context_line":"dictionary according to cfg.CONF and call the OVS-agent with that structure."},{"line_number":11,"context_line":"Passing oslo_config directly to init-method of OVS-agent eliminates a confusion"},{"line_number":12,"context_line":"and makes it more testable. Also refactored unit and functional tests"},{"line_number":13,"context_line":"of OVS-agent in accordance with the changes in init-method."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3a29b11f_64f4365a","line":11,"in_reply_to":"3a29b11f_d3add2e9","updated":"2015-10-23 12:10:16.000000000","message":"Nate, thanks for suggestion! I will update commit message in next PS.","commit_id":"32f095d577c93569f10602d134e794190c3976c6"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"c624b4282cedba2d26a769b684b735794d8d99be","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    #   1.4 Added support for network_update"},{"line_number":138,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.4\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def __init__(self, bridge_classes, conf\u003dNone):"},{"line_number":141,"context_line":"        \u0027\u0027\u0027Constructor."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        :param bridge_classes: a dict for bridge classes."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_f5f1546b","line":140,"updated":"2015-10-05 11:33:04.000000000","message":"I really like getting rid of the large parameter list!","commit_id":"9c1db47c344ac95d142c0e4ea3d287fdb625d4a8"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"0efbc4bf3f8327ca39e02ba83449f0c1ba00e13d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    #   1.4 Added support for network_update"},{"line_number":138,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.4\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def __init__(self, bridge_classes, conf\u003dNone):"},{"line_number":141,"context_line":"        \u0027\u0027\u0027Constructor."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        :param bridge_classes: a dict for bridge classes."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_6909e82b","line":140,"in_reply_to":"9a1a9d01_f5f1546b","updated":"2015-10-05 12:58:18.000000000","message":"Me too :)","commit_id":"9c1db47c344ac95d142c0e4ea3d287fdb625d4a8"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"c624b4282cedba2d26a769b684b735794d8d99be","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        :param conf: an instance of ConfigOpts"},{"line_number":145,"context_line":"        \u0027\u0027\u0027"},{"line_number":146,"context_line":"        super(OVSNeutronAgent, self).__init__()"},{"line_number":147,"context_line":"        self.conf \u003d conf or cfg.CONF"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # init bridge classes with configured datapath type."},{"line_number":150,"context_line":"        self.br_int_cls, self.br_phys_cls, self.br_tun_cls \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_583dd0b9","line":147,"updated":"2015-10-05 11:33:04.000000000","message":"this line set\u0027s conf \u003d cfg.CONF if conf\u003dNone is passed in. So why do we need to pass the conf object at all? Wouldn\u0027t a modified line like\n\nself.conf \u003d cfg.CONF \n\nbe sufficient?","commit_id":"9c1db47c344ac95d142c0e4ea3d287fdb625d4a8"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"0efbc4bf3f8327ca39e02ba83449f0c1ba00e13d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        :param conf: an instance of ConfigOpts"},{"line_number":145,"context_line":"        \u0027\u0027\u0027"},{"line_number":146,"context_line":"        super(OVSNeutronAgent, self).__init__()"},{"line_number":147,"context_line":"        self.conf \u003d conf or cfg.CONF"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # init bridge classes with configured datapath type."},{"line_number":150,"context_line":"        self.br_int_cls, self.br_phys_cls, self.br_tun_cls \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_e903b8b6","line":147,"in_reply_to":"9a1a9d01_583dd0b9","updated":"2015-10-05 12:58:18.000000000","message":"Andreas, it is helpful for testing. In functional tests and some of unit tests I used custom config file (not global cfg.CONF). It reduces code coupling.","commit_id":"9c1db47c344ac95d142c0e4ea3d287fdb625d4a8"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"c624b4282cedba2d26a769b684b735794d8d99be","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        self.tunnel_count \u003d 0"},{"line_number":239,"context_line":"        self.vxlan_udp_port \u003d self.conf.AGENT.vxlan_udp_port"},{"line_number":240,"context_line":"        self.dont_fragment \u003d self.conf.AGENT.dont_fragment"},{"line_number":241,"context_line":"        self.tunnel_csum \u003d cfg.CONF.AGENT.tunnel_csum"},{"line_number":242,"context_line":"        self.tun_br \u003d None"},{"line_number":243,"context_line":"        self.patch_int_ofport \u003d constants.OFPORT_INVALID"},{"line_number":244,"context_line":"        self.patch_tun_ofport \u003d constants.OFPORT_INVALID"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_3d080e2d","line":241,"updated":"2015-10-05 11:33:04.000000000","message":"still cfg.CONF used","commit_id":"9c1db47c344ac95d142c0e4ea3d287fdb625d4a8"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"0efbc4bf3f8327ca39e02ba83449f0c1ba00e13d","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        self.tunnel_count \u003d 0"},{"line_number":239,"context_line":"        self.vxlan_udp_port \u003d self.conf.AGENT.vxlan_udp_port"},{"line_number":240,"context_line":"        self.dont_fragment \u003d self.conf.AGENT.dont_fragment"},{"line_number":241,"context_line":"        self.tunnel_csum \u003d cfg.CONF.AGENT.tunnel_csum"},{"line_number":242,"context_line":"        self.tun_br \u003d None"},{"line_number":243,"context_line":"        self.patch_int_ofport \u003d constants.OFPORT_INVALID"},{"line_number":244,"context_line":"        self.patch_tun_ofport \u003d constants.OFPORT_INVALID"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_e976583d","line":241,"in_reply_to":"9a1a9d01_3d080e2d","updated":"2015-10-05 12:58:18.000000000","message":"I will research it, I not sure, that we can use self.conf here (if config is provided for init-method), it can broke the logic.","commit_id":"9c1db47c344ac95d142c0e4ea3d287fdb625d4a8"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"c624b4282cedba2d26a769b684b735794d8d99be","unresolved":false,"context_lines":[{"line_number":1810,"context_line":"                               \"in both the Agent and Server side.\"))"},{"line_number":1811,"context_line":""},{"line_number":1812,"context_line":""},{"line_number":1813,"context_line":"def validate_local_ip(local_ip):"},{"line_number":1814,"context_line":"    \"\"\"If tunneling is enabled, verify if the ip exists on the agent\u0027s host.\"\"\""},{"line_number":1815,"context_line":"    if not cfg.CONF.AGENT.tunnel_types:"},{"line_number":1816,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_9ddd9a16","line":1813,"updated":"2015-10-05 11:33:04.000000000","message":"Can we make this a class method of LinuxBridgeNeutronAgent? Or what\u0027s the reason for keeping it outside?","commit_id":"9c1db47c344ac95d142c0e4ea3d287fdb625d4a8"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"0efbc4bf3f8327ca39e02ba83449f0c1ba00e13d","unresolved":false,"context_lines":[{"line_number":1810,"context_line":"                               \"in both the Agent and Server side.\"))"},{"line_number":1811,"context_line":""},{"line_number":1812,"context_line":""},{"line_number":1813,"context_line":"def validate_local_ip(local_ip):"},{"line_number":1814,"context_line":"    \"\"\"If tunneling is enabled, verify if the ip exists on the agent\u0027s host.\"\"\""},{"line_number":1815,"context_line":"    if not cfg.CONF.AGENT.tunnel_types:"},{"line_number":1816,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_a9b620da","line":1813,"in_reply_to":"9a1a9d01_9ddd9a16","updated":"2015-10-05 12:58:18.000000000","message":"I guess, this is a topic for another patch.","commit_id":"9c1db47c344ac95d142c0e4ea3d287fdb625d4a8"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"92a870c279333415578384fd567fc39189b29900","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                              datapath_type\u003dself.conf.OVS.datapath_type)"},{"line_number":153,"context_line":"            for b in (\u0027br_int\u0027, \u0027br_phys\u0027, \u0027br_tun\u0027))"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        self.use_veth_interconnection \u003d conf.OVS.use_veth_interconnection"},{"line_number":156,"context_line":"        self.veth_mtu \u003d conf.AGENT.veth_mtu"},{"line_number":157,"context_line":"        self.available_local_vlans \u003d set(moves.range(p_const.MIN_VLAN_TAG,"},{"line_number":158,"context_line":"                                                     p_const.MAX_VLAN_TAG))"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a2ca52d_30af7e2b","line":155,"updated":"2015-10-16 18:48:46.000000000","message":"You should use self.conf at this point.\n\nconf can be empty (look at line 147)","commit_id":"65c90c5155366f85f508bf21e44312bfd155213f"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"e32d717efcb2896da5da5b3582b437630695c931","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                              datapath_type\u003dself.conf.OVS.datapath_type)"},{"line_number":153,"context_line":"            for b in (\u0027br_int\u0027, \u0027br_phys\u0027, \u0027br_tun\u0027))"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        self.use_veth_interconnection \u003d conf.OVS.use_veth_interconnection"},{"line_number":156,"context_line":"        self.veth_mtu \u003d conf.AGENT.veth_mtu"},{"line_number":157,"context_line":"        self.available_local_vlans \u003d set(moves.range(p_const.MIN_VLAN_TAG,"},{"line_number":158,"context_line":"                                                     p_const.MAX_VLAN_TAG))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_a63f36d5","line":155,"in_reply_to":"5a2ca52d_30af7e2b","updated":"2015-10-20 12:26:20.000000000","message":"Yeah, right. Thanks, Gal. I think that in other places (L156, L160 and etc) too.","commit_id":"65c90c5155366f85f508bf21e44312bfd155213f"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"ad56c065a476015e03e42f4cf5cfe48937243694","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        self.use_call \u003d True"},{"line_number":160,"context_line":"        self.tunnel_types \u003d self.conf.AGENT.tunnel_types or []"},{"line_number":161,"context_line":"        self.local_ip \u003d self.conf.OVS.local_ip"},{"line_number":162,"context_line":"        validate_local_ip(self.local_ip)"},{"line_number":163,"context_line":"        for tun in self.tunnel_types:"},{"line_number":164,"context_line":"            if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":165,"context_line":"                msg \u003d _(\u0027Invalid tunnel type specified: %s\u0027), tun"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_19fc1db7","line":162,"updated":"2015-10-21 09:52:25.000000000","message":"why don\u0027t you make this a class method? If so, you do not need to path the self.local_ip in anymore, but could just acces it directly from within this method.","commit_id":"d9adfa8c1f1c5412df1c761137c27292bae55c0e"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"8563b7ca2ffa902858972e395f98e1da0ca82ad0","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        self.use_call \u003d True"},{"line_number":160,"context_line":"        self.tunnel_types \u003d self.conf.AGENT.tunnel_types or []"},{"line_number":161,"context_line":"        self.local_ip \u003d self.conf.OVS.local_ip"},{"line_number":162,"context_line":"        validate_local_ip(self.local_ip)"},{"line_number":163,"context_line":"        for tun in self.tunnel_types:"},{"line_number":164,"context_line":"            if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":165,"context_line":"                msg \u003d _(\u0027Invalid tunnel type specified: %s\u0027), tun"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_8228a2e3","line":162,"in_reply_to":"3a29b11f_19fc1db7","updated":"2015-10-21 15:41:31.000000000","message":"I decided to leave validate_local_ip() in main() method (will do this in next patch-set). If we make validate_local_ip() a class method, it will raise some problems in testing (the same problems that now we have in CreateAgentWithCustomConfig test-cases)","commit_id":"d9adfa8c1f1c5412df1c761137c27292bae55c0e"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"ad56c065a476015e03e42f4cf5cfe48937243694","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        self.tunnel_types \u003d self.conf.AGENT.tunnel_types or []"},{"line_number":161,"context_line":"        self.local_ip \u003d self.conf.OVS.local_ip"},{"line_number":162,"context_line":"        validate_local_ip(self.local_ip)"},{"line_number":163,"context_line":"        for tun in self.tunnel_types:"},{"line_number":164,"context_line":"            if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":165,"context_line":"                msg \u003d _(\u0027Invalid tunnel type specified: %s\u0027), tun"},{"line_number":166,"context_line":"                raise ValueError(msg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_99282d88","line":163,"updated":"2015-10-21 09:52:25.000000000","message":"what about moving this into a separate method e.t. self._validate_tunnel_types() ? Would make testing easier I guess and this code more readable.","commit_id":"d9adfa8c1f1c5412df1c761137c27292bae55c0e"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"8563b7ca2ffa902858972e395f98e1da0ca82ad0","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        self.tunnel_types \u003d self.conf.AGENT.tunnel_types or []"},{"line_number":161,"context_line":"        self.local_ip \u003d self.conf.OVS.local_ip"},{"line_number":162,"context_line":"        validate_local_ip(self.local_ip)"},{"line_number":163,"context_line":"        for tun in self.tunnel_types:"},{"line_number":164,"context_line":"            if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":165,"context_line":"                msg \u003d _(\u0027Invalid tunnel type specified: %s\u0027), tun"},{"line_number":166,"context_line":"                raise ValueError(msg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_62f78659","line":163,"in_reply_to":"3a29b11f_99282d88","updated":"2015-10-21 15:41:31.000000000","message":"It\u0027s a good idea, I will do it in PS10.","commit_id":"d9adfa8c1f1c5412df1c761137c27292bae55c0e"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"ad56c065a476015e03e42f4cf5cfe48937243694","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            self.conf.AGENT.arp_responder and self.l2_pop"},{"line_number":178,"context_line":"        self.prevent_arp_spoofing \u003d self.conf.AGENT.prevent_arp_spoofing"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            self.bridge_mappings \u003d n_utils.parse_mappings("},{"line_number":182,"context_line":"                self.conf.OVS.bridge_mappings)"},{"line_number":183,"context_line":"        except ValueError as e:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_5f3915f1","line":180,"updated":"2015-10-21 09:52:25.000000000","message":"same here, what about moving this into a separate method e.g. self._parse_bridge_mappings()?","commit_id":"d9adfa8c1f1c5412df1c761137c27292bae55c0e"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"8563b7ca2ffa902858972e395f98e1da0ca82ad0","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            self.conf.AGENT.arp_responder and self.l2_pop"},{"line_number":178,"context_line":"        self.prevent_arp_spoofing \u003d self.conf.AGENT.prevent_arp_spoofing"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            self.bridge_mappings \u003d n_utils.parse_mappings("},{"line_number":182,"context_line":"                self.conf.OVS.bridge_mappings)"},{"line_number":183,"context_line":"        except ValueError as e:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_02bed264","line":180,"in_reply_to":"3a29b11f_5f3915f1","updated":"2015-10-21 15:41:31.000000000","message":"Yeah, I will do it in PS10.","commit_id":"d9adfa8c1f1c5412df1c761137c27292bae55c0e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"102b7c5d68b24db05c52a883af2a0e71fc42b17b","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        self.polling_interval \u003d self.conf.AGENT.polling_interval"},{"line_number":211,"context_line":"        self.minimize_polling \u003d self.conf.AGENT.minimize_polling"},{"line_number":212,"context_line":"        self.ovsdb_monitor_respawn_interval \u003d ("},{"line_number":213,"context_line":"            self.conf.AGENT.ovsdb_monitor_respawn_interval or"},{"line_number":214,"context_line":"            (constants.DEFAULT_OVSDBMON_RESPAWN))"},{"line_number":215,"context_line":"        self.tunnel_count \u003d 0"},{"line_number":216,"context_line":"        self.vxlan_udp_port \u003d self.conf.AGENT.vxlan_udp_port"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_9b630f42","line":213,"updated":"2015-10-22 08:34:21.000000000","message":"this wasn\u0027t in create_agent_config_map, right?","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"c5296557ed899abb958b74832d6e76f75f724126","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        self.polling_interval \u003d self.conf.AGENT.polling_interval"},{"line_number":211,"context_line":"        self.minimize_polling \u003d self.conf.AGENT.minimize_polling"},{"line_number":212,"context_line":"        self.ovsdb_monitor_respawn_interval \u003d ("},{"line_number":213,"context_line":"            self.conf.AGENT.ovsdb_monitor_respawn_interval or"},{"line_number":214,"context_line":"            (constants.DEFAULT_OVSDBMON_RESPAWN))"},{"line_number":215,"context_line":"        self.tunnel_count \u003d 0"},{"line_number":216,"context_line":"        self.vxlan_udp_port \u003d self.conf.AGENT.vxlan_udp_port"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_fe23fc53","line":213,"in_reply_to":"3a29b11f_9b630f42","updated":"2015-10-22 17:10:36.000000000","message":"You are right. But I think it\u0027s a good idea to add the opportunity to set this value from config. Or better to add this as a parameter to init method?","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"102b7c5d68b24db05c52a883af2a0e71fc42b17b","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        self.quitting_rpc_timeout \u003d self.conf.AGENT.quitting_rpc_timeout"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def _validate_tunnel_types(self):"},{"line_number":297,"context_line":"        for tun in self.tunnel_types:"},{"line_number":298,"context_line":"            if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":299,"context_line":"                msg \u003d _(\u0027Invalid tunnel type specified: %s\u0027), tun"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_e6570a24","line":296,"updated":"2015-10-22 08:34:21.000000000","message":"consider making this static","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"c5296557ed899abb958b74832d6e76f75f724126","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        self.quitting_rpc_timeout \u003d self.conf.AGENT.quitting_rpc_timeout"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def _validate_tunnel_types(self):"},{"line_number":297,"context_line":"        for tun in self.tunnel_types:"},{"line_number":298,"context_line":"            if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":299,"context_line":"                msg \u003d _(\u0027Invalid tunnel type specified: %s\u0027), tun"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_1e403833","line":296,"in_reply_to":"3a29b11f_e6570a24","updated":"2015-10-22 17:10:36.000000000","message":"Good idea, thanks! Done.","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"102b7c5d68b24db05c52a883af2a0e71fc42b17b","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                    \u0027Tunneling cannot be enabled without a valid local_ip.\u0027)"},{"line_number":304,"context_line":"                raise ValueError(msg)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def _parse_bridge_mappings(self):"},{"line_number":307,"context_line":"        try:"},{"line_number":308,"context_line":"            self.bridge_mappings \u003d n_utils.parse_mappings("},{"line_number":309,"context_line":"                self.conf.OVS.bridge_mappings)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_3b767bd7","line":306,"updated":"2015-10-22 08:34:21.000000000","message":"please return bridge_mappings from this method and do assignment explicitly in __init__()","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"c5296557ed899abb958b74832d6e76f75f724126","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                    \u0027Tunneling cannot be enabled without a valid local_ip.\u0027)"},{"line_number":304,"context_line":"                raise ValueError(msg)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def _parse_bridge_mappings(self):"},{"line_number":307,"context_line":"        try:"},{"line_number":308,"context_line":"            self.bridge_mappings \u003d n_utils.parse_mappings("},{"line_number":309,"context_line":"                self.conf.OVS.bridge_mappings)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_1e3ef827","line":306,"in_reply_to":"3a29b11f_3b767bd7","updated":"2015-10-22 17:10:36.000000000","message":"Done","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"102b7c5d68b24db05c52a883af2a0e71fc42b17b","unresolved":false,"context_lines":[{"line_number":1834,"context_line":"                               \"in both the Agent and Server side.\"))"},{"line_number":1835,"context_line":""},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"def validate_local_ip(conf):"},{"line_number":1838,"context_line":"    \"\"\"If tunneling is enabled, verify if the ip exists on the agent\u0027s host.\"\"\""},{"line_number":1839,"context_line":"    conf \u003d conf or cfg.CONF"},{"line_number":1840,"context_line":"    if not conf.AGENT.tunnel_types:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_46403e34","line":1837,"updated":"2015-10-22 08:34:21.000000000","message":"is it nesessary to change in this patch? If not please remove to make it easier to review","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"c5296557ed899abb958b74832d6e76f75f724126","unresolved":false,"context_lines":[{"line_number":1834,"context_line":"                               \"in both the Agent and Server side.\"))"},{"line_number":1835,"context_line":""},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"def validate_local_ip(conf):"},{"line_number":1838,"context_line":"    \"\"\"If tunneling is enabled, verify if the ip exists on the agent\u0027s host.\"\"\""},{"line_number":1839,"context_line":"    conf \u003d conf or cfg.CONF"},{"line_number":1840,"context_line":"    if not conf.AGENT.tunnel_types:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_fe3d3cc4","line":1837,"in_reply_to":"3a29b11f_46403e34","updated":"2015-10-22 17:10:36.000000000","message":"It\u0027s not related with this patch, yep. This changes will be removed it in next PS.","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"102b7c5d68b24db05c52a883af2a0e71fc42b17b","unresolved":false,"context_lines":[{"line_number":1847,"context_line":"        raise SystemExit(1)"},{"line_number":1848,"context_line":""},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"def prepare_xen_compute(conf\u003dNone):"},{"line_number":1851,"context_line":"    conf \u003d conf or cfg.CONF"},{"line_number":1852,"context_line":"    is_xen_compute_host \u003d \u0027rootwrap-xen-dom0\u0027 in conf.AGENT.root_helper"},{"line_number":1853,"context_line":"    if is_xen_compute_host:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_266c22cd","line":1850,"updated":"2015-10-22 08:34:21.000000000","message":"ditto","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"c5296557ed899abb958b74832d6e76f75f724126","unresolved":false,"context_lines":[{"line_number":1847,"context_line":"        raise SystemExit(1)"},{"line_number":1848,"context_line":""},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"def prepare_xen_compute(conf\u003dNone):"},{"line_number":1851,"context_line":"    conf \u003d conf or cfg.CONF"},{"line_number":1852,"context_line":"    is_xen_compute_host \u003d \u0027rootwrap-xen-dom0\u0027 in conf.AGENT.root_helper"},{"line_number":1853,"context_line":"    if is_xen_compute_host:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_9e7a0887","line":1850,"in_reply_to":"3a29b11f_266c22cd","updated":"2015-10-22 17:10:36.000000000","message":"Done","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"91807521d08f96bf5b11b7c5a738ba8711fd4c01","unresolved":false,"context_lines":[{"line_number":1833,"context_line":"def validate_tunnel_types(tunnel_types, local_ip):"},{"line_number":1834,"context_line":"    for tun in tunnel_types:"},{"line_number":1835,"context_line":"        if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":1836,"context_line":"            msg \u003d _(\u0027Invalid tunnel type specified: %s\u0027), tun"},{"line_number":1837,"context_line":"            raise ValueError(msg)"},{"line_number":1838,"context_line":"        if not local_ip:"},{"line_number":1839,"context_line":"            msg \u003d _("}],"source_content_type":"text/x-python","patch_set":14,"id":"1a26ad4f_876331dc","line":1836,"updated":"2015-10-29 08:44:40.000000000","message":"It should be the following?\n\n msg \u003d _(...) % tun","commit_id":"a8682238b69d10442c70d800feeca7cc6fa9d8d3"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"51c33de4ef9875558cc26ff22dd81f3018401842","unresolved":false,"context_lines":[{"line_number":1833,"context_line":"def validate_tunnel_types(tunnel_types, local_ip):"},{"line_number":1834,"context_line":"    for tun in tunnel_types:"},{"line_number":1835,"context_line":"        if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":1836,"context_line":"            msg \u003d _(\u0027Invalid tunnel type specified: %s\u0027), tun"},{"line_number":1837,"context_line":"            raise ValueError(msg)"},{"line_number":1838,"context_line":"        if not local_ip:"},{"line_number":1839,"context_line":"            msg \u003d _("}],"source_content_type":"text/x-python","patch_set":14,"id":"1a26ad4f_304a8cc6","line":1836,"in_reply_to":"1a26ad4f_876331dc","updated":"2015-10-29 14:39:13.000000000","message":"not sure that this relates to this change, but I can fix it, yep.","commit_id":"a8682238b69d10442c70d800feeca7cc6fa9d8d3"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"91807521d08f96bf5b11b7c5a738ba8711fd4c01","unresolved":false,"context_lines":[{"line_number":1835,"context_line":"        if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":1836,"context_line":"            msg \u003d _(\u0027Invalid tunnel type specified: %s\u0027), tun"},{"line_number":1837,"context_line":"            raise ValueError(msg)"},{"line_number":1838,"context_line":"        if not local_ip:"},{"line_number":1839,"context_line":"            msg \u003d _("},{"line_number":1840,"context_line":"                \u0027Tunneling cannot be enabled without a valid local_ip.\u0027)"},{"line_number":1841,"context_line":"            raise ValueError(msg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a26ad4f_27801d46","line":1838,"updated":"2015-10-29 08:44:40.000000000","message":"This check is done for every tunnel it could be done once (if tunnel_types non empty?)","commit_id":"a8682238b69d10442c70d800feeca7cc6fa9d8d3"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"51c33de4ef9875558cc26ff22dd81f3018401842","unresolved":false,"context_lines":[{"line_number":1835,"context_line":"        if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":1836,"context_line":"            msg \u003d _(\u0027Invalid tunnel type specified: %s\u0027), tun"},{"line_number":1837,"context_line":"            raise ValueError(msg)"},{"line_number":1838,"context_line":"        if not local_ip:"},{"line_number":1839,"context_line":"            msg \u003d _("},{"line_number":1840,"context_line":"                \u0027Tunneling cannot be enabled without a valid local_ip.\u0027)"},{"line_number":1841,"context_line":"            raise ValueError(msg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a26ad4f_d671d0a9","line":1838,"in_reply_to":"1a26ad4f_27801d46","updated":"2015-10-29 14:39:13.000000000","message":"Yeah, right. Will be fixed in next PS.","commit_id":"a8682238b69d10442c70d800feeca7cc6fa9d8d3"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"ab0900049a7eb224685ec07338e87d2f3aebe928","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.l2_pop \u003d self.conf.AGENT.l2_population"},{"line_number":162,"context_line":"        # TODO(ethuleau): Change ARP responder so it\u0027s not dependent on the"},{"line_number":163,"context_line":"        #                 ML2 l2 population mechanism driver."},{"line_number":164,"context_line":"        self.enable_distributed_routing \u003d \\"},{"line_number":165,"context_line":"            self.conf.AGENT.enable_distributed_routing"},{"line_number":166,"context_line":"        self.arp_responder_enabled \u003d \\"},{"line_number":167,"context_line":"            self.conf.AGENT.arp_responder and self.l2_pop"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa80f949_38eceac6","line":164,"updated":"2015-11-04 04:30:50.000000000","message":"I doubt this \"\\\" could be accepted, maybe can use parentheses instead.\n\nhttp://docs.python-guide.org/en/latest/writing/style/#line-continuations","commit_id":"362ee24aa7c6d4d055e724220f956e9d9abb7ede"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"a70b637f9239cb7eccafa6d637aa316ac8987f3b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.l2_pop \u003d self.conf.AGENT.l2_population"},{"line_number":162,"context_line":"        # TODO(ethuleau): Change ARP responder so it\u0027s not dependent on the"},{"line_number":163,"context_line":"        #                 ML2 l2 population mechanism driver."},{"line_number":164,"context_line":"        self.enable_distributed_routing \u003d \\"},{"line_number":165,"context_line":"            self.conf.AGENT.enable_distributed_routing"},{"line_number":166,"context_line":"        self.arp_responder_enabled \u003d \\"},{"line_number":167,"context_line":"            self.conf.AGENT.arp_responder and self.l2_pop"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa80f949_9b2a732b","line":164,"in_reply_to":"fa80f949_38eceac6","updated":"2015-11-05 13:55:49.000000000","message":"Thanks for review. Will fix it in next PS.","commit_id":"362ee24aa7c6d4d055e724220f956e9d9abb7ede"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"ab0900049a7eb224685ec07338e87d2f3aebe928","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        #                 ML2 l2 population mechanism driver."},{"line_number":164,"context_line":"        self.enable_distributed_routing \u003d \\"},{"line_number":165,"context_line":"            self.conf.AGENT.enable_distributed_routing"},{"line_number":166,"context_line":"        self.arp_responder_enabled \u003d \\"},{"line_number":167,"context_line":"            self.conf.AGENT.arp_responder and self.l2_pop"},{"line_number":168,"context_line":"        self.prevent_arp_spoofing \u003d self.conf.AGENT.prevent_arp_spoofing"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"fa80f949_582beeeb","line":166,"updated":"2015-11-04 04:30:50.000000000","message":"ditto","commit_id":"362ee24aa7c6d4d055e724220f956e9d9abb7ede"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d65fe278a464884b66f3fc776212709fa0be6ed7","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        self.tunnel_count \u003d 0"},{"line_number":214,"context_line":"        self.vxlan_udp_port \u003d self.conf.AGENT.vxlan_udp_port"},{"line_number":215,"context_line":"        self.dont_fragment \u003d self.conf.AGENT.dont_fragment"},{"line_number":216,"context_line":"        self.tunnel_csum \u003d self.conf.AGENT.tunnel_csum"},{"line_number":217,"context_line":"        self.tun_br \u003d None"},{"line_number":218,"context_line":"        self.patch_int_ofport \u003d constants.OFPORT_INVALID"},{"line_number":219,"context_line":"        self.patch_tun_ofport \u003d constants.OFPORT_INVALID"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa80f949_38b94aea","line":216,"updated":"2015-11-04 04:12:00.000000000","message":"this one is logically a separate fix.\ni don\u0027t insist though.","commit_id":"362ee24aa7c6d4d055e724220f956e9d9abb7ede"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d65fe278a464884b66f3fc776212709fa0be6ed7","unresolved":false,"context_lines":[{"line_number":1838,"context_line":"    for tun in tunnel_types:"},{"line_number":1839,"context_line":"        if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":1840,"context_line":"            msg \u003d _(\u0027Invalid tunnel type specified: %s\u0027) % tun"},{"line_number":1841,"context_line":"            raise ValueError(msg)"},{"line_number":1842,"context_line":""},{"line_number":1843,"context_line":""},{"line_number":1844,"context_line":"def prepare_xen_compute():"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa80f949_78a6f2c2","line":1841,"updated":"2015-11-04 04:12:00.000000000","message":"these exceptions don\u0027t seem caught.","commit_id":"362ee24aa7c6d4d055e724220f956e9d9abb7ede"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"6181f0ef98361f42d073ff38a40695632d5c958e","unresolved":false,"context_lines":[{"line_number":1838,"context_line":"    for tun in tunnel_types:"},{"line_number":1839,"context_line":"        if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":1840,"context_line":"            msg \u003d _(\u0027Invalid tunnel type specified: %s\u0027) % tun"},{"line_number":1841,"context_line":"            raise ValueError(msg)"},{"line_number":1842,"context_line":""},{"line_number":1843,"context_line":""},{"line_number":1844,"context_line":"def prepare_xen_compute():"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa80f949_b9d5d51c","line":1841,"in_reply_to":"fa80f949_1d9974c4","updated":"2015-11-06 10:23:04.000000000","message":"Oh, sorry. First time I misunderstood what you meant. Now I understand. Will add try/except to main() in next PS.","commit_id":"362ee24aa7c6d4d055e724220f956e9d9abb7ede"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"23dbc6fa4e7cc835481753e0b8d7a4b516d3223e","unresolved":false,"context_lines":[{"line_number":1838,"context_line":"    for tun in tunnel_types:"},{"line_number":1839,"context_line":"        if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":1840,"context_line":"            msg \u003d _(\u0027Invalid tunnel type specified: %s\u0027) % tun"},{"line_number":1841,"context_line":"            raise ValueError(msg)"},{"line_number":1842,"context_line":""},{"line_number":1843,"context_line":""},{"line_number":1844,"context_line":"def prepare_xen_compute():"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa80f949_1d9974c4","line":1841,"in_reply_to":"fa80f949_2d1d4a0f","updated":"2015-11-06 07:24:28.000000000","message":"i don\u0027t understand what you mean.  this code validates configurations provided by user.","commit_id":"362ee24aa7c6d4d055e724220f956e9d9abb7ede"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"a70b637f9239cb7eccafa6d637aa316ac8987f3b","unresolved":false,"context_lines":[{"line_number":1838,"context_line":"    for tun in tunnel_types:"},{"line_number":1839,"context_line":"        if tun not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":1840,"context_line":"            msg \u003d _(\u0027Invalid tunnel type specified: %s\u0027) % tun"},{"line_number":1841,"context_line":"            raise ValueError(msg)"},{"line_number":1842,"context_line":""},{"line_number":1843,"context_line":""},{"line_number":1844,"context_line":"def prepare_xen_compute():"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa80f949_2d1d4a0f","line":1841,"in_reply_to":"fa80f949_78a6f2c2","updated":"2015-11-05 13:55:49.000000000","message":"What is someone trying to pass unsupported tunnel type? There is a unit-test [1], that checks this (small fix will added for that test in next PS).\n\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py#L92","commit_id":"362ee24aa7c6d4d055e724220f956e9d9abb7ede"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"873963a07eb4fb8de94af4d45bc31d08190be25f","unresolved":false,"context_lines":[{"line_number":1859,"context_line":"        validate_tunnel_types(cfg.CONF.AGENT.tunnel_types,"},{"line_number":1860,"context_line":"                              cfg.CONF.OVS.local_ip)"},{"line_number":1861,"context_line":"    except ValueError as e:"},{"line_number":1862,"context_line":"        LOG.exception(_LE(\"Validation of tunnel types failed. %s\"), e)"},{"line_number":1863,"context_line":"        raise SystemExit(1)"},{"line_number":1864,"context_line":""},{"line_number":1865,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"da85f559_0ac8a654","line":1862,"updated":"2015-11-09 11:21:49.000000000","message":"LOG.exception logs the exception by itself.\nyou don\u0027t need to include \"e\" in the message.\n\ni tend to think LOG.error is more consistent here though.","commit_id":"d268466dac60fd45c039d1d84e0fe0c1b372ea63"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"3d8d6466022b0129e41bb4ce224a76fe3891eb4b","unresolved":false,"context_lines":[{"line_number":1859,"context_line":"        validate_tunnel_types(cfg.CONF.AGENT.tunnel_types,"},{"line_number":1860,"context_line":"                              cfg.CONF.OVS.local_ip)"},{"line_number":1861,"context_line":"    except ValueError as e:"},{"line_number":1862,"context_line":"        LOG.exception(_LE(\"Validation of tunnel types failed. %s\"), e)"},{"line_number":1863,"context_line":"        raise SystemExit(1)"},{"line_number":1864,"context_line":""},{"line_number":1865,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"da85f559_a31fd206","line":1862,"in_reply_to":"da85f559_0ac8a654","updated":"2015-11-11 13:15:51.000000000","message":"Before it was LOG.exception and I decided to leave LOG.exception here. But I also think, that using LOG.error is better and more consistent. Will do it in next PS.","commit_id":"d268466dac60fd45c039d1d84e0fe0c1b372ea63"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"93871ae4b281ac635f7642ebf723584138f9771c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.available_local_vlans \u003d set(moves.range(p_const.MIN_VLAN_TAG,"},{"line_number":158,"context_line":"                                                     p_const.MAX_VLAN_TAG))"},{"line_number":159,"context_line":"        self.use_call \u003d True"},{"line_number":160,"context_line":"        self.tunnel_types \u003d self.conf.AGENT.tunnel_types or []"},{"line_number":161,"context_line":"        self.l2_pop \u003d self.conf.AGENT.l2_population"},{"line_number":162,"context_line":"        # TODO(ethuleau): Change ARP responder so it\u0027s not dependent on the"},{"line_number":163,"context_line":"        #                 ML2 l2 population mechanism driver."}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_029e6c56","line":160,"updated":"2015-11-16 14:28:58.000000000","message":"Just some nit thought. Why not using some alias? for example \"agent_conf \u003d self.conf.AGENT\". since you are using lots of self.conf.AGENT, this might help you shorten some line...\nHowever, the current code is good, if you don\u0027t like this one, just ignore it :)","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"841356cfeec653601d75a0463111d7ba2285d909","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.available_local_vlans \u003d set(moves.range(p_const.MIN_VLAN_TAG,"},{"line_number":158,"context_line":"                                                     p_const.MAX_VLAN_TAG))"},{"line_number":159,"context_line":"        self.use_call \u003d True"},{"line_number":160,"context_line":"        self.tunnel_types \u003d self.conf.AGENT.tunnel_types or []"},{"line_number":161,"context_line":"        self.l2_pop \u003d self.conf.AGENT.l2_population"},{"line_number":162,"context_line":"        # TODO(ethuleau): Change ARP responder so it\u0027s not dependent on the"},{"line_number":163,"context_line":"        #                 ML2 l2 population mechanism driver."}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_58c4e38f","line":160,"in_reply_to":"ba8a016a_029e6c56","updated":"2015-11-18 17:02:46.000000000","message":"So, it\u0027s good idea, will do it in next PS. Thanks :)","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"93871ae4b281ac635f7642ebf723584138f9771c","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        self.minimize_polling \u003d self.conf.AGENT.minimize_polling"},{"line_number":209,"context_line":"        self.ovsdb_monitor_respawn_interval \u003d ("},{"line_number":210,"context_line":"            self.conf.AGENT.ovsdb_monitor_respawn_interval or"},{"line_number":211,"context_line":"            (constants.DEFAULT_OVSDBMON_RESPAWN))"},{"line_number":212,"context_line":"        self.local_ip \u003d self.conf.OVS.local_ip"},{"line_number":213,"context_line":"        self.tunnel_count \u003d 0"},{"line_number":214,"context_line":"        self.vxlan_udp_port \u003d self.conf.AGENT.vxlan_udp_port"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_7c411e39","line":211,"updated":"2015-11-16 14:28:58.000000000","message":"Extra parenthesis here...","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"841356cfeec653601d75a0463111d7ba2285d909","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        self.minimize_polling \u003d self.conf.AGENT.minimize_polling"},{"line_number":209,"context_line":"        self.ovsdb_monitor_respawn_interval \u003d ("},{"line_number":210,"context_line":"            self.conf.AGENT.ovsdb_monitor_respawn_interval or"},{"line_number":211,"context_line":"            (constants.DEFAULT_OVSDBMON_RESPAWN))"},{"line_number":212,"context_line":"        self.local_ip \u003d self.conf.OVS.local_ip"},{"line_number":213,"context_line":"        self.tunnel_count \u003d 0"},{"line_number":214,"context_line":"        self.vxlan_udp_port \u003d self.conf.AGENT.vxlan_udp_port"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_4f9c295d","line":211,"in_reply_to":"ba8a016a_7c411e39","updated":"2015-11-18 17:02:46.000000000","message":"Done","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":15070,"name":"Ruijing","email":"ruijing.guo@intel.com","username":"ruijing"},"change_message_id":"9043e58890b66441dcc29052208fa96190e9b61c","unresolved":false,"context_lines":[{"line_number":1847,"context_line":"        raise SystemExit(1)"},{"line_number":1848,"context_line":""},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"def validate_tunnel_types(tunnel_types, local_ip):"},{"line_number":1851,"context_line":"    if tunnel_types and not local_ip:"},{"line_number":1852,"context_line":"        msg \u003d _(\u0027Tunneling cannot be enabled without a valid local_ip.\u0027)"},{"line_number":1853,"context_line":"        raise ValueError(msg)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_0c4c3dc6","line":1850,"updated":"2015-11-25 06:59:34.000000000","message":"We may combine validate_local_ip \u0026 new function validate_tunnel_types to new function validate_tunnel_config","commit_id":"a88fdfc8e113f076603f336befc90500145353ed"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"8eba71b1090bb402376843108cd9eca03cfacf63","unresolved":false,"context_lines":[{"line_number":1847,"context_line":"        raise SystemExit(1)"},{"line_number":1848,"context_line":""},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"def validate_tunnel_types(tunnel_types, local_ip):"},{"line_number":1851,"context_line":"    if tunnel_types and not local_ip:"},{"line_number":1852,"context_line":"        msg \u003d _(\u0027Tunneling cannot be enabled without a valid local_ip.\u0027)"},{"line_number":1853,"context_line":"        raise ValueError(msg)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_d01d5f67","line":1850,"in_reply_to":"9a8ffd7b_0c4c3dc6","updated":"2015-11-25 10:09:12.000000000","message":"good idea.","commit_id":"a88fdfc8e113f076603f336befc90500145353ed"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"a6e8c08725ea7bcd7e747ba548f165fa2f1d2676","unresolved":false,"context_lines":[{"line_number":1847,"context_line":"        raise SystemExit(1)"},{"line_number":1848,"context_line":""},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"def validate_tunnel_types(tunnel_types, local_ip):"},{"line_number":1851,"context_line":"    if tunnel_types and not local_ip:"},{"line_number":1852,"context_line":"        msg \u003d _(\u0027Tunneling cannot be enabled without a valid local_ip.\u0027)"},{"line_number":1853,"context_line":"        raise ValueError(msg)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_759b6e73","line":1850,"in_reply_to":"9a8ffd7b_d01d5f67","updated":"2015-11-30 18:12:52.000000000","message":"Done in https://review.openstack.org/251494","commit_id":"a88fdfc8e113f076603f336befc90500145353ed"}],"neutron/tests/functional/agent/l2/base.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"102b7c5d68b24db05c52a883af2a0e71fc42b17b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        config.set_override(\u0027host\u0027, \u0027ovs-agent\u0027)"},{"line_number":95,"context_line":"        return config"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _configure_agent(self):"},{"line_number":98,"context_line":"        local_ip \u003d \u0027192.168.10.1\u0027"},{"line_number":99,"context_line":"        bridge_mappings \u003d [\u0027\"physnet\":%s\u0027 % self.br_int]"},{"line_number":100,"context_line":"        config \u003d self._get_config_opts()"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_a62fd23d","line":97,"updated":"2015-10-22 08:34:21.000000000","message":"why this duplication needed?","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"c5296557ed899abb958b74832d6e76f75f724126","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        config.set_override(\u0027host\u0027, \u0027ovs-agent\u0027)"},{"line_number":95,"context_line":"        return config"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _configure_agent(self):"},{"line_number":98,"context_line":"        local_ip \u003d \u0027192.168.10.1\u0027"},{"line_number":99,"context_line":"        bridge_mappings \u003d [\u0027\"physnet\":%s\u0027 % self.br_int]"},{"line_number":100,"context_line":"        config \u003d self._get_config_opts()"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_0a123257","line":97,"in_reply_to":"3a29b11f_a62fd23d","updated":"2015-10-22 17:10:36.000000000","message":"I will remove duplicated code and I will make some rework in next PS.","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"102b7c5d68b24db05c52a883af2a0e71fc42b17b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            tunnel_types \u003d [p_const.TYPE_VXLAN]"},{"line_number":122,"context_line":"        else:"},{"line_number":123,"context_line":"            tunnel_types \u003d None"},{"line_number":124,"context_line":"        self.agent_config.set_override(\u0027tunnel_types\u0027, tunnel_types, \"AGENT\")"},{"line_number":125,"context_line":"        agent \u003d ovs_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":126,"context_line":"                                          self.agent_config)"},{"line_number":127,"context_line":"        self.addCleanup(self.ovs.delete_bridge, self.br_int)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_e6f06acb","line":124,"updated":"2015-10-22 08:34:21.000000000","message":"is it related to refactoring?","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"c5296557ed899abb958b74832d6e76f75f724126","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            tunnel_types \u003d [p_const.TYPE_VXLAN]"},{"line_number":122,"context_line":"        else:"},{"line_number":123,"context_line":"            tunnel_types \u003d None"},{"line_number":124,"context_line":"        self.agent_config.set_override(\u0027tunnel_types\u0027, tunnel_types, \"AGENT\")"},{"line_number":125,"context_line":"        agent \u003d ovs_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":126,"context_line":"                                          self.agent_config)"},{"line_number":127,"context_line":"        self.addCleanup(self.ovs.delete_bridge, self.br_int)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_2f3aa0e7","line":124,"in_reply_to":"3a29b11f_e6f06acb","updated":"2015-10-22 17:10:36.000000000","message":"Yes, it\u0027s related. Before refactoring, tunnel_types can be passed as argument to ovs-agent, now, it can be set only with config, and we must override config here.","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"f957cb195274f4e0457e60fec52c34f2a4549adc","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            tunnel_types \u003d [p_const.TYPE_VXLAN]"},{"line_number":106,"context_line":"        else:"},{"line_number":107,"context_line":"            tunnel_types \u003d None"},{"line_number":108,"context_line":"        self.config.set_override(\u0027tunnel_types\u0027, tunnel_types, \"AGENT\")"},{"line_number":109,"context_line":"        agent \u003d ovs_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":110,"context_line":"                                          self.config)"},{"line_number":111,"context_line":"        self.addCleanup(self.ovs.delete_bridge, self.br_int)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a29b11f_555ddfea","line":108,"updated":"2015-10-26 10:02:30.000000000","message":"So we don\u0027t need initialize local_ip and bridge_mappings in class OVSAgentTestFramework anymore?","commit_id":"230a44ebc4ce8911fa23f7b24e8db77ad05c5341"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3a4cb6ba58da64697bc6cd0d0a4ceaa1f6893890","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        bridge_mappings \u003d {\u0027physnet\u0027: self.br_int}"},{"line_number":110,"context_line":"        agent \u003d ovs_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":111,"context_line":"                                          self.br_int, self.br_tun,"},{"line_number":112,"context_line":"                                          local_ip, bridge_mappings,"},{"line_number":113,"context_line":"                                          polling_interval\u003d1,"},{"line_number":114,"context_line":"                                          tunnel_types\u003dtunnel_types,"},{"line_number":115,"context_line":"                                          prevent_arp_spoofing\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa80f949_2d72f849","side":"PARENT","line":112,"updated":"2015-11-06 13:12:43.000000000","message":"now that you don\u0027t pass them you should set these config values in the config. On the top of my head I can\u0027t find a reason for all of them but setting polling_interval\u003d1 is very important otherwise the func tests get very slow.","commit_id":"00f5fedab034830bfa743966d5625fa1899baee0"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"4e2045a42511491118ad00e32eddc4ff0c524e64","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        bridge_mappings \u003d {\u0027physnet\u0027: self.br_int}"},{"line_number":110,"context_line":"        agent \u003d ovs_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":111,"context_line":"                                          self.br_int, self.br_tun,"},{"line_number":112,"context_line":"                                          local_ip, bridge_mappings,"},{"line_number":113,"context_line":"                                          polling_interval\u003d1,"},{"line_number":114,"context_line":"                                          tunnel_types\u003dtunnel_types,"},{"line_number":115,"context_line":"                                          prevent_arp_spoofing\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa80f949_a41fda06","side":"PARENT","line":112,"in_reply_to":"fa80f949_2d72f849","updated":"2015-11-06 15:27:38.000000000","message":"Thanks for review, Rossella. Nice catch!","commit_id":"00f5fedab034830bfa743966d5625fa1899baee0"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"873963a07eb4fb8de94af4d45bc31d08190be25f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.config.set_override(\u0027tunnel_types\u0027, tunnel_types, \"AGENT\")"},{"line_number":109,"context_line":"        self.config.set_override(\u0027polling_interval\u0027, 1, \"AGENT\")"},{"line_number":110,"context_line":"        agent \u003d ovs_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":111,"context_line":"                                          self.config)"},{"line_number":112,"context_line":"        self.addCleanup(self.ovs.delete_bridge, self.br_int)"},{"line_number":113,"context_line":"        if tunnel_types:"},{"line_number":114,"context_line":"            self.addCleanup(self.ovs.delete_bridge, self.br_tun)"}],"source_content_type":"text/x-python","patch_set":19,"id":"da85f559_aa1aba15","line":111,"updated":"2015-11-09 11:21:49.000000000","message":"is it intentional to drop local_ip, bridge_mappings, prevent_arp_spoofing?","commit_id":"d268466dac60fd45c039d1d84e0fe0c1b372ea63"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"a62562a3b5968bff622586e7ffbc53392f431bfc","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.config.set_override(\u0027tunnel_types\u0027, tunnel_types, \"AGENT\")"},{"line_number":109,"context_line":"        self.config.set_override(\u0027polling_interval\u0027, 1, \"AGENT\")"},{"line_number":110,"context_line":"        agent \u003d ovs_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":111,"context_line":"                                          self.config)"},{"line_number":112,"context_line":"        self.addCleanup(self.ovs.delete_bridge, self.br_int)"},{"line_number":113,"context_line":"        if tunnel_types:"},{"line_number":114,"context_line":"            self.addCleanup(self.ovs.delete_bridge, self.br_tun)"}],"source_content_type":"text/x-python","patch_set":19,"id":"da85f559_81dc8619","line":111,"in_reply_to":"da85f559_6cb9d714","updated":"2015-11-13 12:43:54.000000000","message":"yeah, I shouldn\u0027t have to remove these options. My patch is only refactoring of init-method. I will restore them in next PS.","commit_id":"d268466dac60fd45c039d1d84e0fe0c1b372ea63"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"3d8d6466022b0129e41bb4ce224a76fe3891eb4b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.config.set_override(\u0027tunnel_types\u0027, tunnel_types, \"AGENT\")"},{"line_number":109,"context_line":"        self.config.set_override(\u0027polling_interval\u0027, 1, \"AGENT\")"},{"line_number":110,"context_line":"        agent \u003d ovs_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":111,"context_line":"                                          self.config)"},{"line_number":112,"context_line":"        self.addCleanup(self.ovs.delete_bridge, self.br_int)"},{"line_number":113,"context_line":"        if tunnel_types:"},{"line_number":114,"context_line":"            self.addCleanup(self.ovs.delete_bridge, self.br_tun)"}],"source_content_type":"text/x-python","patch_set":19,"id":"da85f559_6cb9d714","line":111,"in_reply_to":"da85f559_aa1aba15","updated":"2015-11-11 13:15:51.000000000","message":"So, actually, I didn\u0027t dive into every test, that use this method (there are 18 test cases, as far as I know). But as I can see, these parametres does not directly affects on any test-cases and they were here because they were required for create_agent_config_map().","commit_id":"d268466dac60fd45c039d1d84e0fe0c1b372ea63"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"2d9d34753e89d426e168a208e94b3f7bc9333487","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self.config.set_override(\u0027local_ip\u0027, \u0027192.168.10.1\u0027, \"OVS\")"},{"line_number":113,"context_line":"        self.config.set_override(\u0027bridge_mappings\u0027, bridge_mappings, \"OVS\")"},{"line_number":114,"context_line":"        agent \u003d ovs_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":115,"context_line":"                                          self.config)"},{"line_number":116,"context_line":"        self.addCleanup(self.ovs.delete_bridge, self.br_int)"},{"line_number":117,"context_line":"        if tunnel_types:"},{"line_number":118,"context_line":"            self.addCleanup(self.ovs.delete_bridge, self.br_tun)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da85f559_7664c548","line":115,"updated":"2015-11-13 13:46:23.000000000","message":"My question about removing parameters was about that local_ip, bridge_mappings, prevent_arp_spoofing not the whole code. You wrote that you will restore that parameters in next PS but you didn\u0027t done this.","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"fa2f15fc1b359b8816c483e72ea90c8a3d0a8ce9","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self.config.set_override(\u0027local_ip\u0027, \u0027192.168.10.1\u0027, \"OVS\")"},{"line_number":113,"context_line":"        self.config.set_override(\u0027bridge_mappings\u0027, bridge_mappings, \"OVS\")"},{"line_number":114,"context_line":"        agent \u003d ovs_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":115,"context_line":"                                          self.config)"},{"line_number":116,"context_line":"        self.addCleanup(self.ovs.delete_bridge, self.br_int)"},{"line_number":117,"context_line":"        if tunnel_types:"},{"line_number":118,"context_line":"            self.addCleanup(self.ovs.delete_bridge, self.br_tun)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_5320d649","line":115,"in_reply_to":"da85f559_7664c548","updated":"2015-11-16 09:28:40.000000000","message":"@Lubosz, as from now on OVSNeutronAgent accepts only bridge_classes and a conf file, all other parameters have been turned into config options. That is why Sergey refactored the code so that local_ip, bridge_mappings, prevent_arp_spoofing, polling_interval and tunnel_types values are set in a config instead of being passed as params.\n\nCould you please clarify what is the \"whole code\" you are talking about?","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"0acab487ac78e301da57f0546002be38f9a935ef","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self.config.set_override(\u0027local_ip\u0027, \u0027192.168.10.1\u0027, \"OVS\")"},{"line_number":113,"context_line":"        self.config.set_override(\u0027bridge_mappings\u0027, bridge_mappings, \"OVS\")"},{"line_number":114,"context_line":"        agent \u003d ovs_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":115,"context_line":"                                          self.config)"},{"line_number":116,"context_line":"        self.addCleanup(self.ovs.delete_bridge, self.br_int)"},{"line_number":117,"context_line":"        if tunnel_types:"},{"line_number":118,"context_line":"            self.addCleanup(self.ovs.delete_bridge, self.br_tun)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da85f559_2bd21901","line":115,"in_reply_to":"da85f559_7664c548","updated":"2015-11-16 07:12:52.000000000","message":"Lubosz, sorry, I think I don\u0027t exactly understand what you mean. What exactly parameters and where should I restore and why?","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"9708af935bbba63ca01326d5cb809f24383c2a5e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        with testtools.ExpectedException(ValueError):"},{"line_number":80,"context_line":"            self.mod_agent.OVSNeutronAgent(self._bridge_classes(), cfg.CONF)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def test_create_agent_config_map_fails_no_local_ip(self):"},{"line_number":83,"context_line":"        # An ip address is required for tunneling but there is no default"},{"line_number":84,"context_line":"        cfg.CONF.set_override(\u0027tunnel_types\u0027, [p_const.TYPE_VXLAN],"},{"line_number":85,"context_line":"                              group\u003d\u0027AGENT\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_cb404ca8","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":54},"updated":"2015-10-14 17:18:00.000000000","message":"Remove \"map\" in method name","commit_id":"2c7edd482daff7d0bd5e338a8d67cd41f946d839"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"9708af935bbba63ca01326d5cb809f24383c2a5e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        with testtools.ExpectedException(ValueError):"},{"line_number":87,"context_line":"            self.mod_agent.OVSNeutronAgent(self._bridge_classes(), cfg.CONF)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_create_agent_config_map_fails_for_invalid_tunnel_type(self):"},{"line_number":90,"context_line":"        cfg.CONF.set_override(\u0027tunnel_types\u0027, [\u0027foobar\u0027], group\u003d\u0027AGENT\u0027)"},{"line_number":91,"context_line":"        with testtools.ExpectedException(ValueError):"},{"line_number":92,"context_line":"            self.mod_agent.OVSNeutronAgent(self._bridge_classes(), cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_eb3bc836","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":66},"updated":"2015-10-14 17:18:00.000000000","message":"ditto","commit_id":"2c7edd482daff7d0bd5e338a8d67cd41f946d839"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"9708af935bbba63ca01326d5cb809f24383c2a5e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        with testtools.ExpectedException(ValueError):"},{"line_number":92,"context_line":"            self.mod_agent.OVSNeutronAgent(self._bridge_classes(), cfg.CONF)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_create_agent_config_map_multiple_tunnel_types(self):"},{"line_number":95,"context_line":"        mock.patch("},{"line_number":96,"context_line":"            \u0027neutron.agent.common.ovs_lib.OVSBridge.get_ports_attributes\u0027,"},{"line_number":97,"context_line":"            return_value\u003d[]).start()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_ab45d0b3","line":94,"range":{"start_line":94,"start_character":33,"end_line":94,"end_character":36},"updated":"2015-10-14 17:18:00.000000000","message":"ditto","commit_id":"2c7edd482daff7d0bd5e338a8d67cd41f946d839"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"9708af935bbba63ca01326d5cb809f24383c2a5e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            self.assertEqual(agent.tunnel_types,"},{"line_number":117,"context_line":"                             [p_const.TYPE_GRE, p_const.TYPE_VXLAN])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def test_create_agent_config_map_enable_distributed_routing(self):"},{"line_number":120,"context_line":"        mock.patch("},{"line_number":121,"context_line":"            \u0027neutron.agent.common.ovs_lib.OVSBridge.get_ports_attributes\u0027,"},{"line_number":122,"context_line":"            return_value\u003d[]).start()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_cb27ec10","line":119,"range":{"start_line":119,"start_character":33,"end_line":119,"end_character":36},"updated":"2015-10-14 17:18:00.000000000","message":"and again","commit_id":"2c7edd482daff7d0bd5e338a8d67cd41f946d839"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"ad56c065a476015e03e42f4cf5cfe48937243694","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.f()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class CreateAgentWithCustomConfig(ovs_test_base.OVSRyuTestBase):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_create_agent_config_fails_for_invalid_tunnel_config(self):"},{"line_number":71,"context_line":"        # An ip address is required for tunneling but there is no default,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_5f103559","line":68,"updated":"2015-10-21 09:52:25.000000000","message":"Is there a reason for changing the parent class?","commit_id":"d9adfa8c1f1c5412df1c761137c27292bae55c0e"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"8563b7ca2ffa902858972e395f98e1da0ca82ad0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.f()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class CreateAgentWithCustomConfig(ovs_test_base.OVSRyuTestBase):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_create_agent_config_fails_for_invalid_tunnel_config(self):"},{"line_number":71,"context_line":"        # An ip address is required for tunneling but there is no default,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_0f535ae3","line":68,"in_reply_to":"3a29b11f_5f103559","updated":"2015-10-21 15:41:31.000000000","message":"For create OVSNeutronAgent we need to be set \u0027br_int_cls\u0027, \u0027br_phys_cls\u0027 and \u0027br_tun_cls\u0027. OVSRyuTestBase already have a suitable implementation of that. Is it a bad idea and I must wrote own setUp() method here for CreateAgentWithCustomConfig? But, anyway, see my comment below. I think these tests need to replace with something more useful.","commit_id":"d9adfa8c1f1c5412df1c761137c27292bae55c0e"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"ad56c065a476015e03e42f4cf5cfe48937243694","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_create_agent_config_fails_for_invalid_tunnel_type(self):"},{"line_number":90,"context_line":"        cfg.CONF.set_override(\u0027tunnel_types\u0027, [\u0027foobar\u0027], group\u003d\u0027AGENT\u0027)"},{"line_number":91,"context_line":"        with testtools.ExpectedException(ValueError):"},{"line_number":92,"context_line":"            self.mod_agent.OVSNeutronAgent(self._bridge_classes(), cfg.CONF)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_create_agent_config_with_multiple_tunnel_types(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_aaa8298e","line":91,"updated":"2015-10-21 09:52:25.000000000","message":"Maybe this is off topic for this fix, as you were just modifying the existing code. But how can one be sure that all the Value errors (also in the tests before) occured due to this exact missconfiguration? In the init method there are so many value errors thrown. One idea would be to parse the ValueError message to know that it was exact because of this error... but as mentioned before, maybe this is out of scope.","commit_id":"d9adfa8c1f1c5412df1c761137c27292bae55c0e"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"ad56c065a476015e03e42f4cf5cfe48937243694","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            mock.patch.object(self.mod_agent.OVSNeutronAgent,"},{"line_number":111,"context_line":"                              \u0027setup_integration_br\u0027), \\"},{"line_number":112,"context_line":"            mock.patch.object(self.mod_agent.OVSNeutronAgent,"},{"line_number":113,"context_line":"                              \u0027_restore_local_vlan_map\u0027):"},{"line_number":114,"context_line":"            agent \u003d self.mod_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":115,"context_line":"                                                   cfg.CONF)"},{"line_number":116,"context_line":"            self.assertEqual(agent.tunnel_types,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_f94921b8","line":113,"updated":"2015-10-21 09:52:25.000000000","message":"you need to mock ovs.get_bridges() as well (line 1064 in ovs_neutron_agent.py)","commit_id":"d9adfa8c1f1c5412df1c761137c27292bae55c0e"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"8563b7ca2ffa902858972e395f98e1da0ca82ad0","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            mock.patch.object(self.mod_agent.OVSNeutronAgent,"},{"line_number":111,"context_line":"                              \u0027setup_integration_br\u0027), \\"},{"line_number":112,"context_line":"            mock.patch.object(self.mod_agent.OVSNeutronAgent,"},{"line_number":113,"context_line":"                              \u0027_restore_local_vlan_map\u0027):"},{"line_number":114,"context_line":"            agent \u003d self.mod_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":115,"context_line":"                                                   cfg.CONF)"},{"line_number":116,"context_line":"            self.assertEqual(agent.tunnel_types,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_ddb8bb77","line":113,"in_reply_to":"3a29b11f_f94921b8","updated":"2015-10-21 15:41:31.000000000","message":"Ok, will do it. There is a problem, that all these tests successfully pass on my local environment but fail on gates. That\u0027s why I cant test it properly and make it work.\n\nPS: is it too much mocking objects just for check, that variable was correctly set from config? It\u0027s make me upset.","commit_id":"d9adfa8c1f1c5412df1c761137c27292bae55c0e"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"ad56c065a476015e03e42f4cf5cfe48937243694","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            self.assertEqual(agent.tunnel_types,"},{"line_number":117,"context_line":"                             [p_const.TYPE_GRE, p_const.TYPE_VXLAN])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def test_create_agent_config_with_enabled_distributed_routing(self):"},{"line_number":120,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":121,"context_line":"        # Verify setting only enable_tunneling will default tunnel_type to GRE"},{"line_number":122,"context_line":"        cfg.CONF.set_override(\u0027enable_distributed_routing\u0027, True,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_dc91b3f2","line":119,"updated":"2015-10-21 09:52:25.000000000","message":"I\u0027m not sure if this is worth testing at all. We\u0027re just checking if the value that comes from a config file is set within the initialization. To be consequent we would need to do that for all variables. I don\u0027t think this makes sense.  Anybody else any thoughts?","commit_id":"d9adfa8c1f1c5412df1c761137c27292bae55c0e"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"8563b7ca2ffa902858972e395f98e1da0ca82ad0","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            self.assertEqual(agent.tunnel_types,"},{"line_number":117,"context_line":"                             [p_const.TYPE_GRE, p_const.TYPE_VXLAN])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def test_create_agent_config_with_enabled_distributed_routing(self):"},{"line_number":120,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":121,"context_line":"        # Verify setting only enable_tunneling will default tunnel_type to GRE"},{"line_number":122,"context_line":"        cfg.CONF.set_override(\u0027enable_distributed_routing\u0027, True,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_5d1b4bca","line":119,"in_reply_to":"3a29b11f_dc91b3f2","updated":"2015-10-21 15:41:31.000000000","message":"In first patch-set I removed all of these tests (tests of CreateAgentWithCustomConfig) because, actually, I also don\u0027t think, that this tests makes sense. But I afraid, that was bad idea (to remove unit tests and decrease coverage) and the last 8 patch-sets I\u0027m just trying to make these tests work. I will be very happy to remove it or replace with some usefull test-cases.","commit_id":"d9adfa8c1f1c5412df1c761137c27292bae55c0e"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"ad56c065a476015e03e42f4cf5cfe48937243694","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        # Verify setting only enable_tunneling will default tunnel_type to GRE"},{"line_number":122,"context_line":"        cfg.CONF.set_override(\u0027enable_distributed_routing\u0027, True,"},{"line_number":123,"context_line":"                              group\u003d\u0027AGENT\u0027)"},{"line_number":124,"context_line":"        with mock.patch.object(self.mod_agent.OVSNeutronAgent,"},{"line_number":125,"context_line":"                               \u0027setup_ancillary_bridges\u0027,"},{"line_number":126,"context_line":"                               return_value\u003d[]), \\"},{"line_number":127,"context_line":"            mock.patch.object(self.mod_agent.OVSNeutronAgent,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_5fe595d9","line":124,"updated":"2015-10-21 09:52:25.000000000","message":"nearly the all the inserted code is common with the code you added to test_create_agent_config_with_multiple_tunnel_types(self)\n\nThis test fails due to the same missing mock like above.","commit_id":"d9adfa8c1f1c5412df1c761137c27292bae55c0e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a0a84191ab76d4b5556fd8975b76cfdbcdc5c412","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.f()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class CreateAgentWithCustomConfig(ovs_test_base.OVSRyuTestBase):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_create_agent_config_fails_for_invalid_tunnel_config(self):"},{"line_number":71,"context_line":"        # An ip address is required for tunneling but there is no default,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_e1193423","line":68,"updated":"2015-10-22 08:40:02.000000000","message":"It will require less test changes if making validators as static methods of ovs agent","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"c5296557ed899abb958b74832d6e76f75f724126","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.f()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class CreateAgentWithCustomConfig(ovs_test_base.OVSRyuTestBase):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_create_agent_config_fails_for_invalid_tunnel_config(self):"},{"line_number":71,"context_line":"        # An ip address is required for tunneling but there is no default,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_4fea7c75","line":68,"in_reply_to":"3a29b11f_e1193423","updated":"2015-10-22 17:10:36.000000000","message":"That\u0027s right! Done.","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a0a84191ab76d4b5556fd8975b76cfdbcdc5c412","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                              \u0027get_bridges\u0027):"},{"line_number":146,"context_line":"            agent \u003d self.mod_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":147,"context_line":"                                                   cfg.CONF)"},{"line_number":148,"context_line":"            self.assertTrue(agent.enable_distributed_routing)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class TestOvsNeutronAgent(object):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_0150f0d2","line":148,"updated":"2015-10-22 08:40:02.000000000","message":"I don\u0027t see a value in checking that simple assignment works, this test can be removed IMO","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"c5296557ed899abb958b74832d6e76f75f724126","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                              \u0027get_bridges\u0027):"},{"line_number":146,"context_line":"            agent \u003d self.mod_agent.OVSNeutronAgent(self._bridge_classes(),"},{"line_number":147,"context_line":"                                                   cfg.CONF)"},{"line_number":148,"context_line":"            self.assertTrue(agent.enable_distributed_routing)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class TestOvsNeutronAgent(object):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a29b11f_6f98981c","line":148,"in_reply_to":"3a29b11f_0150f0d2","updated":"2015-10-22 17:10:36.000000000","message":"Done","commit_id":"4322cb07fafa066859272d9fa3325624ce3063de"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"91807521d08f96bf5b11b7c5a738ba8711fd4c01","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.f()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class CreateAgentWithCustomConfig(ovs_test_base.OVSAgentConfigTestBase):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_create_agent_config_fails_for_invalid_tunnel_config(self):"},{"line_number":71,"context_line":"        # An ip address is required for tunneling but there is no default,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a26ad4f_87bfb1fa","line":68,"updated":"2015-10-29 08:44:40.000000000","message":"Why renaming it?","commit_id":"a8682238b69d10442c70d800feeca7cc6fa9d8d3"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"51c33de4ef9875558cc26ff22dd81f3018401842","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.f()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class CreateAgentWithCustomConfig(ovs_test_base.OVSAgentConfigTestBase):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_create_agent_config_fails_for_invalid_tunnel_config(self):"},{"line_number":71,"context_line":"        # An ip address is required for tunneling but there is no default,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a26ad4f_102f50f7","line":68,"in_reply_to":"1a26ad4f_87bfb1fa","updated":"2015-10-29 14:39:13.000000000","message":"Before this patch it was a class with tests of create_agent_config_map() method, but now create_agent_config_map() is not exist. A couple of PS ago, it was class that creates ovs-agent with custom config and test it. Now it just tests of validate_tunnel_types() and now I understand, that it requires change the name for class (and for test-cases too). Any suggestions? :) May be \u0027TestValidateTunnelTypes\u0027?","commit_id":"a8682238b69d10442c70d800feeca7cc6fa9d8d3"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"b293985e2ca04110be1f98c625ce7ccf7d18d8d0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.f()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class ValidateTunnelTypes(ovs_test_base.OVSAgentConfigTestBase):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_validate_tunnel_types_fails_for_invalid_tunnel_config(self):"},{"line_number":71,"context_line":"        # An ip address is required for tunneling but there is no default,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_0581964a","line":68,"updated":"2015-11-16 15:00:30.000000000","message":"I\u0027m missing some positive test that succeeds.","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"841356cfeec653601d75a0463111d7ba2285d909","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.f()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class ValidateTunnelTypes(ovs_test_base.OVSAgentConfigTestBase):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_validate_tunnel_types_fails_for_invalid_tunnel_config(self):"},{"line_number":71,"context_line":"        # An ip address is required for tunneling but there is no default,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_3bfb197b","line":68,"in_reply_to":"ba8a016a_0581964a","updated":"2015-11-18 17:02:46.000000000","message":"Done","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"93871ae4b281ac635f7642ebf723584138f9771c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                              group\u003d\u0027AGENT\u0027)"},{"line_number":88,"context_line":"        with testtools.ExpectedException(ValueError):"},{"line_number":89,"context_line":"            self.mod_agent.validate_tunnel_types(cfg.CONF.AGENT.tunnel_types,"},{"line_number":90,"context_line":"                                                 cfg.CONF.OVS.local_ip)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_validate_tunnel_types_fails_for_invalid_tunnel_type(self):"},{"line_number":93,"context_line":"        cfg.CONF.set_override(\u0027local_ip\u0027, \u002710.10.10.10\u0027, group\u003d\u0027OVS\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_e27b287a","line":90,"updated":"2015-11-16 14:28:58.000000000","message":"Line 86-90 are duplicated with line 78-82.","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"841356cfeec653601d75a0463111d7ba2285d909","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                              group\u003d\u0027AGENT\u0027)"},{"line_number":88,"context_line":"        with testtools.ExpectedException(ValueError):"},{"line_number":89,"context_line":"            self.mod_agent.validate_tunnel_types(cfg.CONF.AGENT.tunnel_types,"},{"line_number":90,"context_line":"                                                 cfg.CONF.OVS.local_ip)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_validate_tunnel_types_fails_for_invalid_tunnel_type(self):"},{"line_number":93,"context_line":"        cfg.CONF.set_override(\u0027local_ip\u0027, \u002710.10.10.10\u0027, group\u003d\u0027OVS\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_b87b8ff4","line":90,"in_reply_to":"ba8a016a_85aa666f","updated":"2015-11-18 17:02:46.000000000","message":"Andreas, yeah, right. Will fix in next PS.","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"841356cfeec653601d75a0463111d7ba2285d909","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                              group\u003d\u0027AGENT\u0027)"},{"line_number":88,"context_line":"        with testtools.ExpectedException(ValueError):"},{"line_number":89,"context_line":"            self.mod_agent.validate_tunnel_types(cfg.CONF.AGENT.tunnel_types,"},{"line_number":90,"context_line":"                                                 cfg.CONF.OVS.local_ip)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_validate_tunnel_types_fails_for_invalid_tunnel_type(self):"},{"line_number":93,"context_line":"        cfg.CONF.set_override(\u0027local_ip\u0027, \u002710.10.10.10\u0027, group\u003d\u0027OVS\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_fb7591f9","line":90,"in_reply_to":"ba8a016a_e27b287a","updated":"2015-11-18 17:02:46.000000000","message":"Hong Hui Xiao, it\u0027s seems like test_create_agent_config_map_fails_for_invalid_tunnel_config would be enough. Thanks for suggestion.","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"b293985e2ca04110be1f98c625ce7ccf7d18d8d0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                              group\u003d\u0027AGENT\u0027)"},{"line_number":88,"context_line":"        with testtools.ExpectedException(ValueError):"},{"line_number":89,"context_line":"            self.mod_agent.validate_tunnel_types(cfg.CONF.AGENT.tunnel_types,"},{"line_number":90,"context_line":"                                                 cfg.CONF.OVS.local_ip)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_validate_tunnel_types_fails_for_invalid_tunnel_type(self):"},{"line_number":93,"context_line":"        cfg.CONF.set_override(\u0027local_ip\u0027, \u002710.10.10.10\u0027, group\u003d\u0027OVS\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_85aa666f","line":90,"in_reply_to":"ba8a016a_e27b287a","updated":"2015-11-16 15:00:30.000000000","message":"I think you should pass in in \"None\" except for OVS.local_ip","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_tunnel.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"dd29698b0edbca89280b71e85196f4853f82ae88","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                              self.USE_VETH_INTERCONNECTION, \u0027OVS\u0027)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        for k, v in kwargs.items():"},{"line_number":261,"context_line":"            cfg.CONF.set_override(\u0027%s\u0027 % k, v, \u0027AGENT\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        return self.mod_agent.OVSNeutronAgent(bridge_classes, cfg.CONF)"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a26ad4f_ea15bde4","line":261,"range":{"start_line":261,"start_character":34,"end_line":261,"end_character":42},"updated":"2015-11-02 10:04:53.000000000","message":"is this \u0027%s\u0027 formatting necessary?","commit_id":"013229500b859ff1492158efef149353031ea333"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"c81a2c3c5105f82016b1d7a747f082008dc5c867","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                              self.USE_VETH_INTERCONNECTION, \u0027OVS\u0027)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        for k, v in kwargs.items():"},{"line_number":261,"context_line":"            cfg.CONF.set_override(\u0027%s\u0027 % k, v, \u0027AGENT\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        return self.mod_agent.OVSNeutronAgent(bridge_classes, cfg.CONF)"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa80f949_b2fd7570","line":261,"range":{"start_line":261,"start_character":34,"end_line":261,"end_character":42},"in_reply_to":"1a26ad4f_ea15bde4","updated":"2015-11-03 14:39:43.000000000","message":"Takashi, it\u0027s not necessary. I will remove in next PS.","commit_id":"013229500b859ff1492158efef149353031ea333"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"dc35f268b45bb6aaa64fa8d921e4d20f059ad36c","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                              self.USE_VETH_INTERCONNECTION, \u0027OVS\u0027)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        for k, v in kwargs.items():"},{"line_number":261,"context_line":"            cfg.CONF.set_override(k, v, \u0027AGENT\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        return self.mod_agent.OVSNeutronAgent(bridge_classes, cfg.CONF)"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"da85f559_6782bf02","line":261,"updated":"2015-11-09 15:17:16.000000000","message":"This worries me a bit, that only AGENT configs can be passed in. A user of _build_agent might not know about that and pass in something for the ovs section. Could we rename the kwargs to kwargs_agent or so to better indicate that AGENT config is set?","commit_id":"d268466dac60fd45c039d1d84e0fe0c1b372ea63"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"a62562a3b5968bff622586e7ffbc53392f431bfc","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                              self.USE_VETH_INTERCONNECTION, \u0027OVS\u0027)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        for k, v in kwargs.items():"},{"line_number":261,"context_line":"            cfg.CONF.set_override(k, v, \u0027AGENT\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        return self.mod_agent.OVSNeutronAgent(bridge_classes, cfg.CONF)"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"da85f559_769a8ac7","line":261,"in_reply_to":"da85f559_11062886","updated":"2015-11-13 12:43:54.000000000","message":"I decided to rename the kwargs to config_opts_agent. Thanks!","commit_id":"d268466dac60fd45c039d1d84e0fe0c1b372ea63"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"3d8d6466022b0129e41bb4ce224a76fe3891eb4b","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                              self.USE_VETH_INTERCONNECTION, \u0027OVS\u0027)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        for k, v in kwargs.items():"},{"line_number":261,"context_line":"            cfg.CONF.set_override(k, v, \u0027AGENT\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        return self.mod_agent.OVSNeutronAgent(bridge_classes, cfg.CONF)"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"da85f559_11062886","line":261,"in_reply_to":"da85f559_6782bf02","updated":"2015-11-11 13:15:51.000000000","message":"Andreas, thanks for review. Good point. It also worries me :) But… how do you think, maybe is better to pass to _build_agent additional field for every key/value with name of config group (ovs or agent or etc.)? For example (at line 307) instead of:\n\n    self._build_agent(tunnel_types\u003d[\u0027vxlan\u0027])\n\nuse:\n\n    tunnel_types_override \u003d {\u0027name\u0027: \u0027tunnel_types\u0027, \u0027override\u0027: [\u0027vxlan\u0027], \u0027group\u0027: \u0027AGENT\u0027}\n    self._build_agent(tunnel_types_override)\n\nthis will increase the code a little bit, but it will be helpful in future (maybe). What do you think?","commit_id":"d268466dac60fd45c039d1d84e0fe0c1b372ea63"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"fa2f15fc1b359b8816c483e72ea90c8a3d0a8ce9","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        self.execute_expected \u003d []"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def _build_agent(self, **config_opts_agent):"},{"line_number":244,"context_line":"        \"\"\"Using config_opts_agent for override options"},{"line_number":245,"context_line":"        in AGENT group of cfg.CONF"},{"line_number":246,"context_line":"        \"\"\""},{"line_number":247,"context_line":"        bridge_classes \u003d {"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_b02498af","line":244,"updated":"2015-11-16 09:28:40.000000000","message":"Please follow the docstring conventions [1]. The first line here should be a summary, followed with more decription and/or a description of arguments, smth like\n\n    \"\"\"Configure and initialize OVS agent.\n\n    More description....\n\n    :param config_opts_agent: a dict with options to override the\n          default values for the AGENT group.\n    \"\"\"\n\n[1] https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"b293985e2ca04110be1f98c625ce7ccf7d18d8d0","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        self.execute_expected \u003d []"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def _build_agent(self, **config_opts_agent):"},{"line_number":244,"context_line":"        \"\"\"Using config_opts_agent for override options"},{"line_number":245,"context_line":"        in AGENT group of cfg.CONF"},{"line_number":246,"context_line":"        \"\"\""},{"line_number":247,"context_line":"        bridge_classes \u003d {"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_22ee108c","line":244,"in_reply_to":"ba8a016a_b02498af","updated":"2015-11-16 15:00:30.000000000","message":"+1","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"841356cfeec653601d75a0463111d7ba2285d909","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        self.execute_expected \u003d []"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def _build_agent(self, **config_opts_agent):"},{"line_number":244,"context_line":"        \"\"\"Using config_opts_agent for override options"},{"line_number":245,"context_line":"        in AGENT group of cfg.CONF"},{"line_number":246,"context_line":"        \"\"\""},{"line_number":247,"context_line":"        bridge_classes \u003d {"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_667a6879","line":244,"in_reply_to":"ba8a016a_b02498af","updated":"2015-11-18 17:02:46.000000000","message":"Done. Thanks for suggestion, Elena!","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"b293985e2ca04110be1f98c625ce7ccf7d18d8d0","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                              self.USE_VETH_INTERCONNECTION, \u0027OVS\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        for k, v in config_opts_agent.items():"},{"line_number":264,"context_line":"            cfg.CONF.set_override(k, v, \u0027AGENT\u0027)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        return self.mod_agent.OVSNeutronAgent(bridge_classes, cfg.CONF)"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_287911fd","line":264,"updated":"2015-11-16 15:00:30.000000000","message":"I still do not have a good idea for this. maybe we should pass in a tuple consiting of (param, value, section) ? Anyone a better idea?","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"fc322518de1eeb82000a782407a9caa04900b43b","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                              self.USE_VETH_INTERCONNECTION, \u0027OVS\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        for k, v in config_opts_agent.items():"},{"line_number":264,"context_line":"            cfg.CONF.set_override(k, v, \u0027AGENT\u0027)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        return self.mod_agent.OVSNeutronAgent(bridge_classes, cfg.CONF)"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_1cbbfde6","line":264,"in_reply_to":"ba8a016a_287911fd","updated":"2015-11-17 11:13:32.000000000","message":"There are not so many config sections, options from which are likely to be overridden in ovs agent tests. Fox example, it is unlikely that there would be a need to pass into this methods any options from config sections other that AGENT and OVS. In the latter case (if one wants to override OVS options) the method signature can be changed to accept config_opts_ovs in addition to config_opts_agent.\n\nSo, IMO, the current approach is OK.","commit_id":"7efa5c0fc292ccf0fa93aec05e02b35cecd765d5"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"01aa17f7a4cb5abce3099023e096f59bc6c615cf","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            \u0027br_phys\u0027: self.mock_phys_bridge_cls,"},{"line_number":257,"context_line":"            \u0027br_tun\u0027: self.mock_tun_bridge_cls,"},{"line_number":258,"context_line":"        }"},{"line_number":259,"context_line":"        cfg.CONF.set_override(\u0027integration_bridge\u0027, self.INT_BRIDGE, \u0027OVS\u0027)"},{"line_number":260,"context_line":"        cfg.CONF.set_override(\u0027tunnel_bridge\u0027, self.TUN_BRIDGE, \u0027OVS\u0027)"},{"line_number":261,"context_line":"        cfg.CONF.set_override(\u0027local_ip\u0027, \u002710.0.0.1\u0027, \u0027OVS\u0027)"},{"line_number":262,"context_line":"        cfg.CONF.set_override(\u0027bridge_mappings\u0027, self.NET_MAPPING, \u0027OVS\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_03917099","line":259,"updated":"2015-11-25 04:22:24.000000000","message":"Why not directly override cfg.CONF in L85 for \u0027integration_bridge\u0027 ? This configuration has nothing to do with config_opts_agent.\n\nThe same to following lines.","commit_id":"a88fdfc8e113f076603f336befc90500145353ed"}]}
