)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"398b689c54402daead5cfde3e854e6868d495b95","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a new boolean \u0027is_default\u0027 property to subnetpools. This"},{"line_number":10,"context_line":"allows the admin to set the default v4/v6 subnetpools via the API rather"},{"line_number":11,"context_line":"than the existing neutron.conf options - which will be removed in a later"},{"line_number":12,"context_line":"patch."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Only one subnetpool per IP family can be set to default."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a2ca52d_1614c39d","line":11,"updated":"2015-10-16 16:07:52.000000000","message":"why can\u0027t they be removed in this patch now that they are no longer useful as a result of this patch?","commit_id":"9c43bbe8653601a587f36aec091eee1f0e5ab574"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ef032f1ce18b1813bac5f94c1249e7f4e8e7d4e8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a new boolean \u0027is_default\u0027 property to subnetpools. This"},{"line_number":10,"context_line":"allows the admin to set the default v4/v6 subnetpools via the API rather"},{"line_number":11,"context_line":"than the existing neutron.conf options - which will be removed in a later"},{"line_number":12,"context_line":"patch."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Only one subnetpool per IP family can be set to default."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a2ca52d_161a837d","line":11,"in_reply_to":"5a2ca52d_1614c39d","updated":"2015-10-16 16:18:14.000000000","message":"No reason other than there\u0027s already a patch to remove them and I didn\u0027t want to step on it. https://review.openstack.org/#/c/218968/\n\nI\u0027ll leave it up to Carl whether he wants to make that change dependent on this one, or abandon it and have the options removed here.","commit_id":"9c43bbe8653601a587f36aec091eee1f0e5ab574"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"9f44b1c4088c0c1f7e9af6153d0262a717ff97e0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a new boolean \u0027is_default\u0027 property to subnetpools. This"},{"line_number":10,"context_line":"allows the admin to set the default v4/v6 subnetpools via the API rather"},{"line_number":11,"context_line":"than the existing neutron.conf options - which will be removed in a later"},{"line_number":12,"context_line":"patch."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Only one subnetpool per IP family can be set to default."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a2ca52d_d4796383","line":11,"in_reply_to":"5a2ca52d_161a837d","updated":"2015-10-16 16:48:24.000000000","message":"It looks like this patch will no longer honor the neutron.conf options.  Is it too much trouble to remove them with this patch?  It would be nice to have just one commit we can point to that enables this cutover from the neutron.conf options.  Since it\u0027s not a lot of code it might be a nice touch to lump it all together.","commit_id":"9c43bbe8653601a587f36aec091eee1f0e5ab574"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"320ae6965acb82869e036eeb4bcca695e736644d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":"ApiImpact"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Authored-By: Carl Baldwin \u003ccarl@ecbaldwin.net\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I5daba2347cfb91fac0b155b2c1b459ee7d9e4505"},{"line_number":21,"context_line":"Closes-Bug: 1501328"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"dae33548_44c9405a","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":49},"updated":"2016-02-19 00:09:14.000000000","message":"I just noticed that I\u0027m listed as a co-author on this patch *and* I co-authored it.  That escaped my notice when I approved this patch.  I\u0027m very sorry about that.  I don\u0027t mean to be trying to collect tokens this way.","commit_id":"6ee91e56c84ea6e930369f8649f1d2b50096cb80"}],"etc/neutron.conf":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"45059d642420ec37e7eb906f47b3ad5a003c0317","unresolved":false,"context_lines":[{"line_number":161,"context_line":"# CIDR must be passed to create a subnet and that subnet will not be allocated"},{"line_number":162,"context_line":"# from any pool; it will be considered part of the tenant\u0027s private address"},{"line_number":163,"context_line":"# space."},{"line_number":164,"context_line":"# default_ipv4_subnet_pool \u003d"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# Default Subnet Pool to be used for IPv6 subnet-allocation."},{"line_number":167,"context_line":"# Specifies by UUID the pool to be used in case of subnet-create being"}],"source_content_type":"text/plain","patch_set":5,"id":"3a29b11f_5a754e2f","side":"PARENT","line":164,"updated":"2015-10-22 22:35:47.000000000","message":"These can\u0027t be removed this release.  Only deprecated.","commit_id":"b215721cba458412b38685d1745ceaaadc435996"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"11acadcf6e6e0f05215b510c8887b20aa2e11a5b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"# CIDR must be passed to create a subnet and that subnet will not be allocated"},{"line_number":162,"context_line":"# from any pool; it will be considered part of the tenant\u0027s private address"},{"line_number":163,"context_line":"# space."},{"line_number":164,"context_line":"# default_ipv4_subnet_pool \u003d"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# Default Subnet Pool to be used for IPv6 subnet-allocation."},{"line_number":167,"context_line":"# Specifies by UUID the pool to be used in case of subnet-create being"}],"source_content_type":"text/plain","patch_set":5,"id":"3a29b11f_4a68d9ba","side":"PARENT","line":164,"in_reply_to":"3a29b11f_5a754e2f","updated":"2015-10-26 13:38:29.000000000","message":"Yep, getting ahead of myself! I\u0027ll include the changes from your original patch and add you as a co-author.","commit_id":"b215721cba458412b38685d1745ceaaadc435996"}],"neutron/api/v2/attributes.py":[{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"398b689c54402daead5cfde3e854e6868d495b95","unresolved":false,"context_lines":[{"line_number":864,"context_line":"                          \u0027validate\u0027: {\u0027type:non_negative\u0027: None},"},{"line_number":865,"context_line":"                          \u0027convert_to\u0027: convert_to_int,"},{"line_number":866,"context_line":"                          \u0027is_visible\u0027: True},"},{"line_number":867,"context_line":"        \u0027is_default\u0027: {\u0027allow_post\u0027: True,"},{"line_number":868,"context_line":"                       \u0027allow_put\u0027: True,"},{"line_number":869,"context_line":"                       \u0027default\u0027: False,"},{"line_number":870,"context_line":"                       \u0027convert_to\u0027: convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_f6cca7bc","line":867,"updated":"2015-10-16 16:07:52.000000000","message":"\u0027default\u0027 instead just as \u0027shared\u0027 rather than \u0027is_shared\u0027?","commit_id":"9c43bbe8653601a587f36aec091eee1f0e5ab574"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"9f44b1c4088c0c1f7e9af6153d0262a717ff97e0","unresolved":false,"context_lines":[{"line_number":864,"context_line":"                          \u0027validate\u0027: {\u0027type:non_negative\u0027: None},"},{"line_number":865,"context_line":"                          \u0027convert_to\u0027: convert_to_int,"},{"line_number":866,"context_line":"                          \u0027is_visible\u0027: True},"},{"line_number":867,"context_line":"        \u0027is_default\u0027: {\u0027allow_post\u0027: True,"},{"line_number":868,"context_line":"                       \u0027allow_put\u0027: True,"},{"line_number":869,"context_line":"                       \u0027default\u0027: False,"},{"line_number":870,"context_line":"                       \u0027convert_to\u0027: convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_9956c45a","line":867,"in_reply_to":"5a2ca52d_39f0d0fd","updated":"2015-10-16 16:48:24.000000000","message":"subnetpool.default doesn\u0027t seem to convey much meaning to me, so I do prefer is_default. It\u0027s a nit I can live with either way though.","commit_id":"9c43bbe8653601a587f36aec091eee1f0e5ab574"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ef032f1ce18b1813bac5f94c1249e7f4e8e7d4e8","unresolved":false,"context_lines":[{"line_number":864,"context_line":"                          \u0027validate\u0027: {\u0027type:non_negative\u0027: None},"},{"line_number":865,"context_line":"                          \u0027convert_to\u0027: convert_to_int,"},{"line_number":866,"context_line":"                          \u0027is_visible\u0027: True},"},{"line_number":867,"context_line":"        \u0027is_default\u0027: {\u0027allow_post\u0027: True,"},{"line_number":868,"context_line":"                       \u0027allow_put\u0027: True,"},{"line_number":869,"context_line":"                       \u0027default\u0027: False,"},{"line_number":870,"context_line":"                       \u0027convert_to\u0027: convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_39f0d0fd","line":867,"in_reply_to":"5a2ca52d_f6cca7bc","updated":"2015-10-16 16:18:14.000000000","message":"subnetpool.default seemed a little ambiguous to me, whereas subnetpool.is_default was more obviously self-referential. I\u0027m open to debate on this though.","commit_id":"9c43bbe8653601a587f36aec091eee1f0e5ab574"}],"neutron/common/config.py":[{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"00f4e24b1fe5a2bf1c046b7723cd58f478cc380f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.IntOpt(\u0027max_fixed_ips_per_port\u0027, default\u003d5,"},{"line_number":74,"context_line":"               help\u003d_(\"Maximum number of fixed ips per port\")),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027default_ipv4_subnet_pool\u0027, default\u003dNone,"},{"line_number":76,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":77,"context_line":"               help\u003d_(\"Default IPv4 subnet-pool to be used for automatic \""},{"line_number":78,"context_line":"                      \"subnet CIDR allocation. This option is deprecated for \""},{"line_number":79,"context_line":"                      \"removal in the N release.\")),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_a6e46b0d","line":76,"updated":"2015-10-27 15:14:53.000000000","message":"I don\u0027t see it being used in the code any more. So why mark it deprecated?","commit_id":"60df874c2bc328a5f94b26dedb0e6ddb4b406643"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5d68e8b486521d6d65c143a712c21f56f70ae50e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.IntOpt(\u0027max_fixed_ips_per_port\u0027, default\u003d5,"},{"line_number":74,"context_line":"               help\u003d_(\"Maximum number of fixed ips per port\")),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027default_ipv4_subnet_pool\u0027, default\u003dNone,"},{"line_number":76,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":77,"context_line":"               help\u003d_(\"Default IPv4 subnet-pool to be used for automatic \""},{"line_number":78,"context_line":"                      \"subnet CIDR allocation. This option is deprecated for \""},{"line_number":79,"context_line":"                      \"removal in the N release.\")),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_c23f0524","line":76,"in_reply_to":"1a26ad4f_a6e46b0d","updated":"2015-10-28 01:55:08.000000000","message":"I agree with Robert. You\u0027ll need to preserve the old behaviour until the deprecation period is over.","commit_id":"60df874c2bc328a5f94b26dedb0e6ddb4b406643"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0d4d83292c9239408491ff688447c5d69296408a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    cfg.IntOpt(\u0027max_fixed_ips_per_port\u0027, default\u003d5,"},{"line_number":74,"context_line":"               help\u003d_(\"Maximum number of fixed ips per port\")),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027default_ipv4_subnet_pool\u0027, default\u003dNone,"},{"line_number":76,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":77,"context_line":"               help\u003d_(\"Default IPv4 subnet-pool to be used for automatic \""},{"line_number":78,"context_line":"                      \"subnet CIDR allocation. This option is deprecated for \""},{"line_number":79,"context_line":"                      \"removal in the N release.\")),"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_4ba2dd4c","line":76,"in_reply_to":"1a26ad4f_c23f0524","updated":"2015-11-06 00:35:38.000000000","message":"What a pain!  Unfortunately, their point is correct.","commit_id":"60df874c2bc328a5f94b26dedb0e6ddb4b406643"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"00f4e24b1fe5a2bf1c046b7723cd58f478cc380f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                      \"subnet CIDR allocation. This option is deprecated for \""},{"line_number":79,"context_line":"                      \"removal in the N release.\")),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027default_ipv6_subnet_pool\u0027, default\u003dNone,"},{"line_number":81,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":82,"context_line":"               help\u003d_(\"Default IPv6 subnet-pool to be used for automatic \""},{"line_number":83,"context_line":"                      \"subnet CIDR allocation. This option is deprecated for \""},{"line_number":84,"context_line":"                      \"removal in the N release.\")),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_06baffe1","line":81,"updated":"2015-10-27 15:14:53.000000000","message":"ditto","commit_id":"60df874c2bc328a5f94b26dedb0e6ddb4b406643"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"160d93d8bcf846973a9fd7c4ac48d2cb28a9fdb5","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        for subnetpool in subnetpools:"},{"line_number":638,"context_line":"            if (subnetpool[\u0027is_default\u0027] and"},{"line_number":639,"context_line":"                subnetpool[\u0027ip_version\u0027] \u003d\u003d ip_version):"},{"line_number":640,"context_line":"                return subnetpool[\u0027id\u0027]"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"    def create_subnet(self, context, subnet):"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_0d81b74a","line":640,"updated":"2015-10-05 21:45:34.000000000","message":"Why not create a method like_get_default_subnetpool() and execute a SQL query like this:\n\nquery \u003d context.session.query(models_v2.SubnetPool)\nquery \u003d query.filter(models_v2.SubnetPool.is_default \u003d\u003d sa.sql.True(),\n                     models_v2.SubnetPool.ip_version \u003d\u003d ip_version)\nreturn query.one()\n\nWe\u0027re already throwing a query at the DB anyway, I\u0027m a fan of pushing this logic into SQL and making the DB do the searching.","commit_id":"471a6e6fc394df08f12b9b7fb0b33acc966dd1aa"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"caeb351e33c082185e99c1a7390cb489b101e433","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        for subnetpool in subnetpools:"},{"line_number":638,"context_line":"            if (subnetpool[\u0027is_default\u0027] and"},{"line_number":639,"context_line":"                subnetpool[\u0027ip_version\u0027] \u003d\u003d ip_version):"},{"line_number":640,"context_line":"                return subnetpool[\u0027id\u0027]"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"    def create_subnet(self, context, subnet):"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_b2047b7e","line":640,"in_reply_to":"7a2fa921_0d81b74a","updated":"2015-10-06 16:09:43.000000000","message":"This is a good idea. Although rather than writing a new query function, we can make use of the existing generic get_subnetpools() function, and pass it the appropriate filters","commit_id":"471a6e6fc394df08f12b9b7fb0b33acc966dd1aa"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"160d93d8bcf846973a9fd7c4ac48d2cb28a9fdb5","unresolved":false,"context_lines":[{"line_number":944,"context_line":"                subnetpool[\u0027ip_version\u0027] \u003d\u003d ip_version):"},{"line_number":945,"context_line":"                msg \u003d _(\"A default subnetpool for this IP family has already \""},{"line_number":946,"context_line":"                        \"been set. Only one default may exist per IP family.\")"},{"line_number":947,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"    def create_subnetpool(self, context, subnetpool):"},{"line_number":950,"context_line":"        \"\"\"Create a subnetpool\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_8d69478e","line":947,"updated":"2015-10-05 21:45:34.000000000","message":"Similar thoughts as expressed at L640","commit_id":"471a6e6fc394df08f12b9b7fb0b33acc966dd1aa"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"caeb351e33c082185e99c1a7390cb489b101e433","unresolved":false,"context_lines":[{"line_number":944,"context_line":"                subnetpool[\u0027ip_version\u0027] \u003d\u003d ip_version):"},{"line_number":945,"context_line":"                msg \u003d _(\"A default subnetpool for this IP family has already \""},{"line_number":946,"context_line":"                        \"been set. Only one default may exist per IP family.\")"},{"line_number":947,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"    def create_subnetpool(self, context, subnetpool):"},{"line_number":950,"context_line":"        \"\"\"Create a subnetpool\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_d209f796","line":947,"in_reply_to":"7a2fa921_8d69478e","updated":"2015-10-06 16:09:43.000000000","message":"Ditto","commit_id":"471a6e6fc394df08f12b9b7fb0b33acc966dd1aa"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ac0adbec85da20cb53cacb87ee89ca0e4ef67091","unresolved":false,"context_lines":[{"line_number":945,"context_line":"        \"\"\""},{"line_number":946,"context_line":"        if self.get_default_subnetpool(context, ip_version):"},{"line_number":947,"context_line":"            msg \u003d _(\"A default subnetpool for this IP family has already \""},{"line_number":948,"context_line":"                    \"been set. Only one default may exist per IP family.\")"},{"line_number":949,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    def create_subnetpool(self, context, subnetpool):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_4d1bb173","line":948,"updated":"2015-11-06 16:40:14.000000000","message":"The period at the end of this string isn\u0027t actually necessary and causes two to show up in the response. Will remove it.","commit_id":"b450d7f97d8a2636e180564eb732d8c46d903648"}],"neutron/db/migration/alembic_migrations/versions/mitaka/expand/13cfb89f881a_add_is_default_to_subnetpool.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"160d93d8bcf846973a9fd7c4ac48d2cb28a9fdb5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    op.add_column(\u0027subnetpools\u0027,"},{"line_number":34,"context_line":"                  sa.Column(\u0027is_default\u0027,"},{"line_number":35,"context_line":"                            sa.Boolean(),"},{"line_number":36,"context_line":"                            nullable\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_8d1dc7bf","line":36,"updated":"2015-10-05 21:45:34.000000000","message":"nullable\u003dFalse instead?","commit_id":"471a6e6fc394df08f12b9b7fb0b33acc966dd1aa"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"caeb351e33c082185e99c1a7390cb489b101e433","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    op.add_column(\u0027subnetpools\u0027,"},{"line_number":34,"context_line":"                  sa.Column(\u0027is_default\u0027,"},{"line_number":35,"context_line":"                            sa.Boolean(),"},{"line_number":36,"context_line":"                            nullable\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_0bbf43fc","line":36,"in_reply_to":"7a2fa921_8d1dc7bf","updated":"2015-10-06 16:09:43.000000000","message":"Yes, you\u0027re right. Got this the wrong way around.","commit_id":"471a6e6fc394df08f12b9b7fb0b33acc966dd1aa"}],"neutron/db/models_v2.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"160d93d8bcf846973a9fd7c4ac48d2cb28a9fdb5","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    min_prefixlen \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":233,"context_line":"    max_prefixlen \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":234,"context_line":"    shared \u003d sa.Column(sa.Boolean, nullable\u003dFalse)"},{"line_number":235,"context_line":"    is_default \u003d sa.Column(sa.Boolean, nullable\u003dTrue)"},{"line_number":236,"context_line":"    default_quota \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":237,"context_line":"    hash \u003d sa.Column(sa.String(36), nullable\u003dFalse, server_default\u003d\u0027\u0027)"},{"line_number":238,"context_line":"    address_scope_id \u003d sa.Column(sa.String(36), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_cd92df57","line":235,"updated":"2015-10-05 21:45:34.000000000","message":"nullable\u003dFalse instead?","commit_id":"471a6e6fc394df08f12b9b7fb0b33acc966dd1aa"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"caeb351e33c082185e99c1a7390cb489b101e433","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    min_prefixlen \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":233,"context_line":"    max_prefixlen \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":234,"context_line":"    shared \u003d sa.Column(sa.Boolean, nullable\u003dFalse)"},{"line_number":235,"context_line":"    is_default \u003d sa.Column(sa.Boolean, nullable\u003dTrue)"},{"line_number":236,"context_line":"    default_quota \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":237,"context_line":"    hash \u003d sa.Column(sa.String(36), nullable\u003dFalse, server_default\u003d\u0027\u0027)"},{"line_number":238,"context_line":"    address_scope_id \u003d sa.Column(sa.String(36), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_2bbc7f04","line":235,"in_reply_to":"7a2fa921_cd92df57","updated":"2015-10-06 16:09:43.000000000","message":"Done","commit_id":"471a6e6fc394df08f12b9b7fb0b33acc966dd1aa"}],"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"e3475a2a3c59aa28f98012ffac88b65d32bb6daa","unresolved":false,"context_lines":[{"line_number":2841,"context_line":"                res \u003d subnet_req.get_response(self.api)"},{"line_number":2842,"context_line":"                subnet \u003d self.deserialize(self.fmt, res)[\u0027subnet\u0027]"},{"line_number":2843,"context_line":"                ip_net \u003d netaddr.IPNetwork(subnet[\u0027cidr\u0027])"},{"line_number":2844,"context_line":"                self.assertTrue(ip_net in netaddr.IPNetwork(subnetpool_prefix))"},{"line_number":2845,"context_line":"                self.assertEqual(27, ip_net.prefixlen)"},{"line_number":2846,"context_line":"                self.assertEqual(subnetpool_id, subnet[\u0027subnetpool_id\u0027])"},{"line_number":2847,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_6df79559","line":2844,"updated":"2015-11-06 16:45:53.000000000","message":"self.assertIn(ip_net, ...)","commit_id":"b450d7f97d8a2636e180564eb732d8c46d903648"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"34265f5c50c84d02c0efd159e55a8e952275060f","unresolved":false,"context_lines":[{"line_number":2841,"context_line":"                res \u003d subnet_req.get_response(self.api)"},{"line_number":2842,"context_line":"                subnet \u003d self.deserialize(self.fmt, res)[\u0027subnet\u0027]"},{"line_number":2843,"context_line":"                ip_net \u003d netaddr.IPNetwork(subnet[\u0027cidr\u0027])"},{"line_number":2844,"context_line":"                self.assertTrue(ip_net in netaddr.IPNetwork(subnetpool_prefix))"},{"line_number":2845,"context_line":"                self.assertEqual(27, ip_net.prefixlen)"},{"line_number":2846,"context_line":"                self.assertEqual(subnetpool_id, subnet[\u0027subnetpool_id\u0027])"},{"line_number":2847,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_58f05191","line":2844,"in_reply_to":"fa80f949_6df79559","updated":"2015-11-06 17:17:18.000000000","message":"Done","commit_id":"b450d7f97d8a2636e180564eb732d8c46d903648"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"e3475a2a3c59aa28f98012ffac88b65d32bb6daa","unresolved":false,"context_lines":[{"line_number":2890,"context_line":"                subnet \u003d self.deserialize(self.fmt, res)[\u0027subnet\u0027]"},{"line_number":2891,"context_line":"                self.assertEqual(subnetpool_id, subnet[\u0027subnetpool_id\u0027])"},{"line_number":2892,"context_line":"                ip_net \u003d netaddr.IPNetwork(subnet[\u0027cidr\u0027])"},{"line_number":2893,"context_line":"                self.assertTrue(ip_net in netaddr.IPNetwork(subnetpool_prefix))"},{"line_number":2894,"context_line":"                self.assertEqual(64, ip_net.prefixlen)"},{"line_number":2895,"context_line":""},{"line_number":2896,"context_line":"    def test_create_subnet_only_ip_version_v6_old(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_cdb32199","line":2893,"updated":"2015-11-06 16:45:53.000000000","message":"ditto","commit_id":"b450d7f97d8a2636e180564eb732d8c46d903648"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"34265f5c50c84d02c0efd159e55a8e952275060f","unresolved":false,"context_lines":[{"line_number":2890,"context_line":"                subnet \u003d self.deserialize(self.fmt, res)[\u0027subnet\u0027]"},{"line_number":2891,"context_line":"                self.assertEqual(subnetpool_id, subnet[\u0027subnetpool_id\u0027])"},{"line_number":2892,"context_line":"                ip_net \u003d netaddr.IPNetwork(subnet[\u0027cidr\u0027])"},{"line_number":2893,"context_line":"                self.assertTrue(ip_net in netaddr.IPNetwork(subnetpool_prefix))"},{"line_number":2894,"context_line":"                self.assertEqual(64, ip_net.prefixlen)"},{"line_number":2895,"context_line":""},{"line_number":2896,"context_line":"    def test_create_subnet_only_ip_version_v6_old(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_b8f7fd89","line":2893,"in_reply_to":"fa80f949_cdb32199","updated":"2015-11-06 17:17:18.000000000","message":"Done","commit_id":"b450d7f97d8a2636e180564eb732d8c46d903648"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"e3475a2a3c59aa28f98012ffac88b65d32bb6daa","unresolved":false,"context_lines":[{"line_number":4931,"context_line":"                                                     name\u003dself._POOL_NAME,"},{"line_number":4932,"context_line":"                                                     min_prefixlen\u003d\u002764\u0027,"},{"line_number":4933,"context_line":"                                                     is_default\u003dTrue)"},{"line_number":4934,"context_line":"        self._validate_is_default(subnetpool_v6)"},{"line_number":4935,"context_line":""},{"line_number":4936,"context_line":"    def test_cannot_create_multiple_default_subnetpools(self):"},{"line_number":4937,"context_line":"        subnetpool \u003d self._test_create_subnetpool([\u002710.10.10.0/24\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_6d49d5b6","line":4934,"updated":"2015-11-06 16:45:53.000000000","message":"Could it be simplified as \n\nfor cidr, min_prefix in ([\u002710.10.10.0/24\u0027, \u002724\u0027], [\u0027fe80::/48\u0027, \u002764\u0027]): \n   ........","commit_id":"b450d7f97d8a2636e180564eb732d8c46d903648"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"34265f5c50c84d02c0efd159e55a8e952275060f","unresolved":false,"context_lines":[{"line_number":4931,"context_line":"                                                     name\u003dself._POOL_NAME,"},{"line_number":4932,"context_line":"                                                     min_prefixlen\u003d\u002764\u0027,"},{"line_number":4933,"context_line":"                                                     is_default\u003dTrue)"},{"line_number":4934,"context_line":"        self._validate_is_default(subnetpool_v6)"},{"line_number":4935,"context_line":""},{"line_number":4936,"context_line":"    def test_cannot_create_multiple_default_subnetpools(self):"},{"line_number":4937,"context_line":"        subnetpool \u003d self._test_create_subnetpool([\u002710.10.10.0/24\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_98fa3974","line":4934,"in_reply_to":"fa80f949_6d49d5b6","updated":"2015-11-06 17:17:18.000000000","message":"Nice suggestion! Done","commit_id":"b450d7f97d8a2636e180564eb732d8c46d903648"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"e3475a2a3c59aa28f98012ffac88b65d32bb6daa","unresolved":false,"context_lines":[{"line_number":4949,"context_line":"                          name\u003dself._POOL_NAME,"},{"line_number":4950,"context_line":"                          min_prefixlen\u003d\u002724\u0027,"},{"line_number":4951,"context_line":"                          is_default\u003dTrue)"},{"line_number":4952,"context_line":""},{"line_number":4953,"context_line":"    def test_create_subnetpool_ipv4_24_with_defaults(self):"},{"line_number":4954,"context_line":"        subnet \u003d netaddr.IPNetwork(\u002710.10.10.0/24\u0027)"},{"line_number":4955,"context_line":"        subnetpool \u003d self._test_create_subnetpool([subnet.cidr],"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_ed46257a","line":4952,"updated":"2015-11-06 16:45:53.000000000","message":"no similar test for v6?","commit_id":"b450d7f97d8a2636e180564eb732d8c46d903648"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"34265f5c50c84d02c0efd159e55a8e952275060f","unresolved":false,"context_lines":[{"line_number":4949,"context_line":"                          name\u003dself._POOL_NAME,"},{"line_number":4950,"context_line":"                          min_prefixlen\u003d\u002724\u0027,"},{"line_number":4951,"context_line":"                          is_default\u003dTrue)"},{"line_number":4952,"context_line":""},{"line_number":4953,"context_line":"    def test_create_subnetpool_ipv4_24_with_defaults(self):"},{"line_number":4954,"context_line":"        subnet \u003d netaddr.IPNetwork(\u002710.10.10.0/24\u0027)"},{"line_number":4955,"context_line":"        subnetpool \u003d self._test_create_subnetpool([subnet.cidr],"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_b312be55","line":4952,"in_reply_to":"fa80f949_ed46257a","updated":"2015-11-06 17:17:18.000000000","message":"Done","commit_id":"b450d7f97d8a2636e180564eb732d8c46d903648"}]}
