)]}'
{"neutron/agent/linux/iptables_manager.py":[{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"3cfb6853aa7ee4381c0605ffe9b7d98ac05afc9e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    # that order so _find_last_entry works"},{"line_number":70,"context_line":"    if rule.startswith(\u0027-j\u0027):"},{"line_number":71,"context_line":"        # this is a jump only rule so we just put the comment first"},{"line_number":72,"context_line":"        return \u0027-m comment --comment \"%s\" %s\u0027 % (comment, rule)"},{"line_number":73,"context_line":"    try:"},{"line_number":74,"context_line":"        start_of_jump \u003d rule.index(\u0027 -j \u0027)"},{"line_number":75,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_c53f24d5","line":72,"updated":"2015-10-05 17:48:24.000000000","message":"Did you consider trying to handle this case in the main part of this code instead of making it a special case?  It is clear enough as is, but if it\u0027s not too complicated it might be cleaner as one case instead of a separate check.","commit_id":"f52432c8c20a32f82a4d4ca86ac1becd2b5b4c2c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"70571b4b789d90def676b23290e3f3dbe8d5e009","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    # that order so _find_last_entry works"},{"line_number":70,"context_line":"    if rule.startswith(\u0027-j\u0027):"},{"line_number":71,"context_line":"        # this is a jump only rule so we just put the comment first"},{"line_number":72,"context_line":"        return \u0027-m comment --comment \"%s\" %s\u0027 % (comment, rule)"},{"line_number":73,"context_line":"    try:"},{"line_number":74,"context_line":"        start_of_jump \u003d rule.index(\u0027 -j \u0027)"},{"line_number":75,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_c597e18e","line":72,"in_reply_to":"7a2fa921_c53f24d5","updated":"2015-10-06 21:23:14.000000000","message":"I can clean it up a bit, but I haven\u0027t found a nice succinct way to do it.","commit_id":"f52432c8c20a32f82a4d4ca86ac1becd2b5b4c2c"}],"neutron/tests/unit/agent/linux/test_iptables_manager.py":[{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"3cfb6853aa7ee4381c0605ffe9b7d98ac05afc9e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        self.assertEqual("},{"line_number":157,"context_line":"            \u0027-s source -m comment --comment \"aloha\"\u0027,"},{"line_number":158,"context_line":"            iptables_manager.comment_rule(\u0027-s source\u0027, \u0027aloha\u0027))"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def test_add_filter_rule(self):"},{"line_number":161,"context_line":"        iptables_args \u003d {}"},{"line_number":162,"context_line":"        iptables_args.update(IPTABLES_ARG)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_051d1c73","line":159,"updated":"2015-10-05 17:48:24.000000000","message":"Must not have been any tests for this method as all?  Anyway, the tests look good.","commit_id":"f52432c8c20a32f82a4d4ca86ac1becd2b5b4c2c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"70571b4b789d90def676b23290e3f3dbe8d5e009","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        self.assertEqual("},{"line_number":157,"context_line":"            \u0027-s source -m comment --comment \"aloha\"\u0027,"},{"line_number":158,"context_line":"            iptables_manager.comment_rule(\u0027-s source\u0027, \u0027aloha\u0027))"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def test_add_filter_rule(self):"},{"line_number":161,"context_line":"        iptables_args \u003d {}"},{"line_number":162,"context_line":"        iptables_args.update(IPTABLES_ARG)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_de0fbddf","line":159,"in_reply_to":"7a2fa921_051d1c73","updated":"2015-10-06 21:23:14.000000000","message":"it was being tested sort of implicitly in the code that exercised comments. this just adds some explicit tests so we aren\u0027t depending on others","commit_id":"f52432c8c20a32f82a4d4ca86ac1becd2b5b4c2c"}]}
