)]}'
{"neutron/agent/l3/router_info.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"668d38f7959bf611047acf05a9352ef4eae27fde","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        finally:"},{"line_number":673,"context_line":"            self.update_fip_statuses(agent, fip_statuses)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    def update_fip_statuses(self, agent, fip_statuses):"},{"line_number":676,"context_line":"        # Identify floating IPs which were disabled"},{"line_number":677,"context_line":"        existing_floating_ips \u003d self.floating_ips"},{"line_number":678,"context_line":"        self.floating_ips \u003d set(fip_statuses.keys())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_e4effb1b","line":675,"updated":"2015-10-09 09:55:54.000000000","message":"Which tests cover(red) this method?","commit_id":"a4c686699dfb0dbc96287a30717095a9a0c26063"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"214fa59848bb76388c12464b9cb35872c5ec17da","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        finally:"},{"line_number":673,"context_line":"            self.update_fip_statuses(agent, fip_statuses)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    def update_fip_statuses(self, agent, fip_statuses):"},{"line_number":676,"context_line":"        # Identify floating IPs which were disabled"},{"line_number":677,"context_line":"        existing_floating_ips \u003d self.floating_ips"},{"line_number":678,"context_line":"        self.floating_ips \u003d set(fip_statuses.keys())"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_7b018c37","line":675,"in_reply_to":"7a2fa921_e4effb1b","updated":"2015-11-06 18:55:15.000000000","message":"@Cedric  I\u0027m sorry that I totally lost track of this question until today when I was scratching my head wondering why this hadn\u0027t merged.  :)\n\nThere are a handful of tests in neutron/tests/unit/agent/l3/test_agent.py which touch this code.  You can find some of them by looking for mocks of update_floatingip_statuses in that file where the call to the plugin is mocked.\n\nI\u0027ll go have a look at them to see if any should get attention.  Given that this patch is a simple code move, I\u0027m not sure how much work on the tests is warranted.","commit_id":"a4c686699dfb0dbc96287a30717095a9a0c26063"}]}