)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"beedb8da026de205b21f15a403830bb0b63725a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use assertFalse(observed) instead of assertEqual(False, observed)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We should use assertFalse not assertEqual."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1503074"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a26ad4f_49c883a8","line":9,"updated":"2015-11-02 08:34:15.000000000","message":"Nice change!","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"}],"neutron/hacking/checks.py":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"094659c62288480d5464554c942877cb230cc84b","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"def check_asserttrue(logical_line, filename):"},{"line_number":178,"context_line":"    if \u0027neutron/tests/\u0027 in filename:"},{"line_number":179,"context_line":"        if re.search(r\"assertEqual\\(True,.*\\)\", logical_line):"},{"line_number":180,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":181,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":182,"context_line":"            yield (0, msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_dc13d8b6","line":179,"updated":"2015-10-16 12:27:38.000000000","message":"What about \"assertEqual\\(True,[^,]*(,[^,]*)?\\)\" ? This should also match the message argument but wouldn\u0027t match calls with more that 3 arguments.","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"85d51032c99580dcce7200ea78e79024c2d10c09","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"def check_asserttrue(logical_line, filename):"},{"line_number":178,"context_line":"    if \u0027neutron/tests/\u0027 in filename:"},{"line_number":179,"context_line":"        if re.search(r\"assertEqual\\(True,.*\\)\", logical_line):"},{"line_number":180,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":181,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":182,"context_line":"            yield (0, msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_cfa675ad","line":179,"in_reply_to":"5a2ca52d_dc13d8b6","updated":"2015-11-12 13:00:54.000000000","message":"Done","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"7463f9f6da340b4ab8881ff50c732132c99737e6","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":181,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":182,"context_line":"            yield (0, msg)"},{"line_number":183,"context_line":"        if re.search(r\"assertEqual\\(.*, True\\)\\n\", logical_line):"},{"line_number":184,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":185,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":186,"context_line":"            yield (0, msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_fbdcd0e5","line":183,"range":{"start_line":183,"start_character":46,"end_line":183,"end_character":48},"updated":"2015-10-15 13:41:05.000000000","message":"Why is there \u0027\\n\u0027 at the end of the line? With \\n it will not work properly and will not catch cases where \u0027True\u0027 is second argument for assertEqual.","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"094659c62288480d5464554c942877cb230cc84b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":181,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":182,"context_line":"            yield (0, msg)"},{"line_number":183,"context_line":"        if re.search(r\"assertEqual\\(.*, True\\)\\n\", logical_line):"},{"line_number":184,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":185,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":186,"context_line":"            yield (0, msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_7c6c0435","line":183,"in_reply_to":"5a2ca52d_0b56e829","updated":"2015-10-16 12:27:38.000000000","message":"Same as for L179: assertEqual\\([^,]*, True(,.*)?\\)","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"b6b183db136caf6308d8a86ad0acaef1c5bc3851","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":181,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":182,"context_line":"            yield (0, msg)"},{"line_number":183,"context_line":"        if re.search(r\"assertEqual\\(.*, True\\)\\n\", logical_line):"},{"line_number":184,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":185,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":186,"context_line":"            yield (0, msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_dc4bd885","line":183,"in_reply_to":"5a2ca52d_7c6c0435","updated":"2015-10-16 12:31:37.000000000","message":"Sorry, I meant assertEqual\\([^,]*, True(,[^,]*)?\\)","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"24a5610a5fb3ea936476a51fce5071649cae1741","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":181,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":182,"context_line":"            yield (0, msg)"},{"line_number":183,"context_line":"        if re.search(r\"assertEqual\\(.*, True\\)\\n\", logical_line):"},{"line_number":184,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":185,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":186,"context_line":"            yield (0, msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_0b56e829","line":183,"in_reply_to":"5a2ca52d_8df0e368","updated":"2015-10-16 11:32:16.000000000","message":"\u003e Why did you think that it doesn\u0027t work properly?\n\nI just checked it.\nI added in some unit test this line:\n\n    self.assertEqual(\"\", True)\n\n\nAfter I ran tox -e pep8 and it\u0027s succeeded.\nAfter that I removed \u0027\\n\u0027 on 183 line, ran tox -e pep8 again and got right result [1]. I think, we need anoter regexp to catch all cases.\n\n[1] http://paste.openstack.org/show/476471/","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"c52bde87b7341fbe1dbc457864c6411356c54bb3","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":181,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":182,"context_line":"            yield (0, msg)"},{"line_number":183,"context_line":"        if re.search(r\"assertEqual\\(.*, True\\)\\n\", logical_line):"},{"line_number":184,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":185,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":186,"context_line":"            yield (0, msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_8df0e368","line":183,"in_reply_to":"5a2ca52d_fbdcd0e5","updated":"2015-10-15 23:51:09.000000000","message":"This is necessary. Otherwise, this matches some unnecessary cases. e.g. self.assertEqual(self.parse([\u0027key1:val\u0027, \u0027key2:val\u0027], False), {\u0027key1\u0027: \u0027val\u0027, \u0027key2\u0027: \u0027val\u0027}) in neutron/tests/unit/common/test_utils.py\n\nI believe that it runs properly although I know this cannot catch assertEqual(observed, True, msg). Why did you think that it doesn\u0027t work properly?","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"7463f9f6da340b4ab8881ff50c732132c99737e6","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":182,"context_line":"            yield (0, msg)"},{"line_number":183,"context_line":"        if re.search(r\"assertEqual\\(.*, True\\)\\n\", logical_line):"},{"line_number":184,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":185,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":186,"context_line":"            yield (0, msg)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_3b0d6890","line":185,"range":{"start_line":184,"start_character":20,"end_line":185,"end_character":47},"updated":"2015-10-15 13:41:05.000000000","message":"May be in these case better to write this:\n\n    N328: Use assertTrue(observed) instead of assertEqual(observed, True)\n\n?\nBecause… this search will catch the cases like that:\n\n    self.assertEqual(shared_network[\u0027exist\u0027], True)\n\nIt\u0027s not a error, just for consistency.","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"c52bde87b7341fbe1dbc457864c6411356c54bb3","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            yield (0, msg)"},{"line_number":183,"context_line":"        if re.search(r\"assertEqual\\(.*, True\\)\\n\", logical_line):"},{"line_number":184,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":185,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":186,"context_line":"            yield (0, msg)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_8db8e3c9","line":185,"in_reply_to":"5a2ca52d_3b0d6890","updated":"2015-10-15 23:51:09.000000000","message":"I describe on purpose because assertEqual(observed, expected) is wrong case[1]. Although I added this check, I don\u0027t want to make developer misunderstand that assertEqual(observed, expected) is correct description.\n\n[1]: https://github.com/openstack/neutron/blob/master/doc/source/devref/effective_neutron.rst#mocking-and-testing","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"24a5610a5fb3ea936476a51fce5071649cae1741","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            yield (0, msg)"},{"line_number":183,"context_line":"        if re.search(r\"assertEqual\\(.*, True\\)\\n\", logical_line):"},{"line_number":184,"context_line":"            msg \u003d (\"N328: Use assertTrue(observed) instead of\""},{"line_number":185,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":186,"context_line":"            yield (0, msg)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_cb90f045","line":185,"in_reply_to":"5a2ca52d_8db8e3c9","updated":"2015-10-16 11:32:16.000000000","message":"Got it. You are right, it\u0027s more correct.","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"7463f9f6da340b4ab8881ff50c732132c99737e6","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            msg \u003d (\"N328: Use assertFalse(observed) instead of\""},{"line_number":193,"context_line":"                   \"assertEqual(False, observed)\")"},{"line_number":194,"context_line":"            yield (0, msg)"},{"line_number":195,"context_line":"        if re.search(r\"assertEqual\\(.*, False\\)\\n\", logical_line):"},{"line_number":196,"context_line":"            msg \u003d (\"N328: Use assertFalse(observed) instead of\""},{"line_number":197,"context_line":"                   \"assertEqual(False, observed)\")"},{"line_number":198,"context_line":"            yield (0, msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_aee85411","line":195,"range":{"start_line":195,"start_character":47,"end_line":195,"end_character":49},"updated":"2015-10-15 13:41:05.000000000","message":"ditto","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"b6b183db136caf6308d8a86ad0acaef1c5bc3851","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            msg \u003d (\"N328: Use assertFalse(observed) instead of\""},{"line_number":193,"context_line":"                   \"assertEqual(False, observed)\")"},{"line_number":194,"context_line":"            yield (0, msg)"},{"line_number":195,"context_line":"        if re.search(r\"assertEqual\\(.*, False\\)\\n\", logical_line):"},{"line_number":196,"context_line":"            msg \u003d (\"N328: Use assertFalse(observed) instead of\""},{"line_number":197,"context_line":"                   \"assertEqual(False, observed)\")"},{"line_number":198,"context_line":"            yield (0, msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_fc501434","line":195,"in_reply_to":"5a2ca52d_aee85411","updated":"2015-10-16 12:31:37.000000000","message":"same as above","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"beedb8da026de205b21f15a403830bb0b63725a2","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                   \"assertEqual(False, observed)\")"},{"line_number":194,"context_line":"            yield (0, msg)"},{"line_number":195,"context_line":"        if re.search(r\"assertEqual\\(.*, False\\)\\n\", logical_line):"},{"line_number":196,"context_line":"            msg \u003d (\"N328: Use assertFalse(observed) instead of\""},{"line_number":197,"context_line":"                   \"assertEqual(False, observed)\")"},{"line_number":198,"context_line":"            yield (0, msg)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_2920a747","line":196,"updated":"2015-11-02 08:34:15.000000000","message":"missing space at the end of the line","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"7463f9f6da340b4ab8881ff50c732132c99737e6","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            yield (0, msg)"},{"line_number":195,"context_line":"        if re.search(r\"assertEqual\\(.*, False\\)\\n\", logical_line):"},{"line_number":196,"context_line":"            msg \u003d (\"N328: Use assertFalse(observed) instead of\""},{"line_number":197,"context_line":"                   \"assertEqual(False, observed)\")"},{"line_number":198,"context_line":"            yield (0, msg)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_fb73707e","line":197,"range":{"start_line":197,"start_character":20,"end_line":197,"end_character":48},"updated":"2015-10-15 13:41:05.000000000","message":"ditto","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"85d51032c99580dcce7200ea78e79024c2d10c09","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            yield (0, msg)"},{"line_number":195,"context_line":"        if re.search(r\"assertEqual\\(.*, False\\)\\n\", logical_line):"},{"line_number":196,"context_line":"            msg \u003d (\"N328: Use assertFalse(observed) instead of\""},{"line_number":197,"context_line":"                   \"assertEqual(False, observed)\")"},{"line_number":198,"context_line":"            yield (0, msg)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_6f18a9d3","line":197,"in_reply_to":"5a2ca52d_9c41e065","updated":"2015-11-12 13:00:54.000000000","message":"Done","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"b6b183db136caf6308d8a86ad0acaef1c5bc3851","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            yield (0, msg)"},{"line_number":195,"context_line":"        if re.search(r\"assertEqual\\(.*, False\\)\\n\", logical_line):"},{"line_number":196,"context_line":"            msg \u003d (\"N328: Use assertFalse(observed) instead of\""},{"line_number":197,"context_line":"                   \"assertEqual(False, observed)\")"},{"line_number":198,"context_line":"            yield (0, msg)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_9c41e065","line":197,"in_reply_to":"5a2ca52d_fb73707e","updated":"2015-10-16 12:31:37.000000000","message":"same as above","commit_id":"75effe7099e8a054cc0c7b16adaab1321ffee08c"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"97eb36a3cd18f65ba70a5d1c0aeffb59a7689a23","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    if \u0027neutron/tests/\u0027 in filename:"},{"line_number":198,"context_line":"        if re.search(r\"assertEqual\\(False,[^,]*(,[^,]*)?\\)\", logical_line):"},{"line_number":199,"context_line":"            msg \u003d (\"N328: Use assertFalse(observed) instead of \""},{"line_number":200,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":201,"context_line":"            yield (0, msg)"},{"line_number":202,"context_line":"        if re.search(r\"assertEqual\\([^,]*, False(,[^,]*)?\\)\", logical_line):"},{"line_number":203,"context_line":"            msg \u003d (\"N328: Use assertFalse(observed) instead of \""}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_3e3df48e","line":200,"updated":"2015-11-12 13:16:42.000000000","message":"assertEqual(False","commit_id":"0a32571b328a13ea74265c05cdb318791d9b74ad"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"97eb36a3cd18f65ba70a5d1c0aeffb59a7689a23","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            yield (0, msg)"},{"line_number":202,"context_line":"        if re.search(r\"assertEqual\\([^,]*, False(,[^,]*)?\\)\", logical_line):"},{"line_number":203,"context_line":"            msg \u003d (\"N328: Use assertFalse(observed) instead of \""},{"line_number":204,"context_line":"                   \"assertEqual(True, observed)\")"},{"line_number":205,"context_line":"            yield (0, msg)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_5e6b1885","line":204,"updated":"2015-11-12 13:16:42.000000000","message":"assertEqual(observed, False)","commit_id":"0a32571b328a13ea74265c05cdb318791d9b74ad"}]}
