)]}'
{"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"0f4cdd46685199f6dec5ce1a8804da60496de18a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        query \u003d context.session.query(RouterL3AgentBinding)"},{"line_number":186,"context_line":"        bindings \u003d query.filter_by(router_id\u003drouter_id,"},{"line_number":187,"context_line":"                                   l3_agent_id\u003dagent_id).all()"},{"line_number":188,"context_line":"        return bool(bindings)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def check_agent_router_scheduling_needed(self, context, agent, router):"},{"line_number":191,"context_line":"        \"\"\"Check if the router scheduling is needed."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_b9483ecd","line":188,"updated":"2015-10-22 15:59:11.000000000","message":"Seems we already have a similar method check_agent_router_scheduling_needed. Maybe you should optimize that, instead of writing a new one.","commit_id":"b7f8677bf107f567b1112088e31fee47e6f029a6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"dafb3aa6bd79c147b8ae300170246bf9ca3d0760","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        query \u003d context.session.query(RouterL3AgentBinding)"},{"line_number":186,"context_line":"        bindings \u003d query.filter_by(router_id\u003drouter_id,"},{"line_number":187,"context_line":"                                   l3_agent_id\u003dagent_id).all()"},{"line_number":188,"context_line":"        return bool(bindings)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def check_agent_router_scheduling_needed(self, context, agent, router):"},{"line_number":191,"context_line":"        \"\"\"Check if the router scheduling is needed."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_d2bd8803","line":188,"in_reply_to":"3a29b11f_1137b0ff","updated":"2015-10-26 06:50:02.000000000","message":"Thanks, I get it now.","commit_id":"b7f8677bf107f567b1112088e31fee47e6f029a6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3ef47dc502a0447cc1293559d05320f6de88eafc","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        query \u003d context.session.query(RouterL3AgentBinding)"},{"line_number":186,"context_line":"        bindings \u003d query.filter_by(router_id\u003drouter_id,"},{"line_number":187,"context_line":"                                   l3_agent_id\u003dagent_id).all()"},{"line_number":188,"context_line":"        return bool(bindings)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def check_agent_router_scheduling_needed(self, context, agent, router):"},{"line_number":191,"context_line":"        \"\"\"Check if the router scheduling is needed."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_1137b0ff","line":188,"in_reply_to":"3a29b11f_b9483ecd","updated":"2015-10-23 09:35:47.000000000","message":"At the point where we call this method we already know that router should be scheduled to that agent (please see next file), the only thing we need is to know if the binding exists or not. check_agent_router_scheduling_needed() will do double work.","commit_id":"b7f8677bf107f567b1112088e31fee47e6f029a6"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"7dfa07f5161b8389d982a4fb5fb836ad0c14cb7e","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        query \u003d context.session.query(RouterL3AgentBinding)"},{"line_number":186,"context_line":"        bindings \u003d query.filter_by(router_id\u003drouter_id,"},{"line_number":187,"context_line":"                                   l3_agent_id\u003dagent_id).all()"},{"line_number":188,"context_line":"        return bool(bindings)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def check_agent_router_scheduling_needed(self, context, agent, router):"},{"line_number":191,"context_line":"        \"\"\"Check if the router scheduling is needed."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_eb6b2eef","line":188,"in_reply_to":"3a29b11f_b9483ecd","updated":"2015-10-23 01:29:34.000000000","message":"I think it is hard to reuse method check_agent_router_scheduling_needed","commit_id":"b7f8677bf107f567b1112088e31fee47e6f029a6"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a650b6a4762d95af0e9aada73709df2eb2ce9e23","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        query \u003d context.session.query(RouterL3AgentBinding)"},{"line_number":186,"context_line":"        bindings \u003d query.filter_by(router_id\u003drouter_id,"},{"line_number":187,"context_line":"                                   l3_agent_id\u003dagent_id).all()"},{"line_number":188,"context_line":"        return bool(bindings)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def check_agent_router_scheduling_needed(self, context, agent, router):"},{"line_number":191,"context_line":"        \"\"\"Check if the router scheduling is needed."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_05253c5a","line":188,"in_reply_to":"3a29b11f_b9483ecd","updated":"2015-11-05 23:39:14.000000000","message":"I think that could do more harm than good.","commit_id":"b7f8677bf107f567b1112088e31fee47e6f029a6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"60b178066b276af1f5256e5dbb8e200f72c694ea","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        query \u003d context.session.query(RouterL3AgentBinding)"},{"line_number":186,"context_line":"        bindings \u003d query.filter_by(router_id\u003drouter_id,"},{"line_number":187,"context_line":"                                   l3_agent_id\u003dagent_id).all()"},{"line_number":188,"context_line":"        return bool(bindings)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def check_agent_router_scheduling_needed(self, context, agent, router):"},{"line_number":191,"context_line":"        \"\"\"Check if the router scheduling is needed."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_d6e92e80","line":188,"in_reply_to":"3a29b11f_eb6b2eef","updated":"2015-10-23 09:03:58.000000000","message":"how to define that \"hard\"?","commit_id":"b7f8677bf107f567b1112088e31fee47e6f029a6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"60b178066b276af1f5256e5dbb8e200f72c694ea","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        \"\"\""},{"line_number":197,"context_line":"        router_id \u003d router[\u0027id\u0027]"},{"line_number":198,"context_line":"        agent_id \u003d agent[\u0027id\u0027]"},{"line_number":199,"context_line":"        query \u003d context.session.query(RouterL3AgentBinding)"},{"line_number":200,"context_line":"        bindings \u003d query.filter_by(router_id\u003drouter_id).all()"},{"line_number":201,"context_line":"        if not bindings:"},{"line_number":202,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_311c2c69","line":199,"updated":"2015-10-23 09:03:58.000000000","message":"I think we can adding some code here:\n\n    if router.get(\u0027distributed\u0027):\n\n        bindings \u003d query.filter_by(router_id\u003drouter_id,\n                                   l3_agent_id\u003dagent_id).all()\n        return bool(bindings)\n\nAnd when dvr_update_router_addvm call this method, passing {\u0027id\u0027: router_id, \u0027distributed\u0027: True} instead of router_id. for router_ids get by get_dvr_routers_by_portid are all distributed routers\u0027 id, so it make sense to set \u0027distributed\u0027 to True.","commit_id":"b7f8677bf107f567b1112088e31fee47e6f029a6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3ef47dc502a0447cc1293559d05320f6de88eafc","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        \"\"\""},{"line_number":197,"context_line":"        router_id \u003d router[\u0027id\u0027]"},{"line_number":198,"context_line":"        agent_id \u003d agent[\u0027id\u0027]"},{"line_number":199,"context_line":"        query \u003d context.session.query(RouterL3AgentBinding)"},{"line_number":200,"context_line":"        bindings \u003d query.filter_by(router_id\u003drouter_id).all()"},{"line_number":201,"context_line":"        if not bindings:"},{"line_number":202,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_b19d9c0b","line":199,"in_reply_to":"3a29b11f_311c2c69","updated":"2015-10-23 09:35:47.000000000","message":"please see check_agent_router_scheduling_needed() overriden method in l3_dvrscheduler_db and it\u0027s usage in this file.","commit_id":"b7f8677bf107f567b1112088e31fee47e6f029a6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"dafb3aa6bd79c147b8ae300170246bf9ca3d0760","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        \"\"\""},{"line_number":197,"context_line":"        router_id \u003d router[\u0027id\u0027]"},{"line_number":198,"context_line":"        agent_id \u003d agent[\u0027id\u0027]"},{"line_number":199,"context_line":"        query \u003d context.session.query(RouterL3AgentBinding)"},{"line_number":200,"context_line":"        bindings \u003d query.filter_by(router_id\u003drouter_id).all()"},{"line_number":201,"context_line":"        if not bindings:"},{"line_number":202,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_f2ba040a","line":199,"in_reply_to":"3a29b11f_b19d9c0b","updated":"2015-10-26 06:50:02.000000000","message":"Thanks, I get it now.","commit_id":"b7f8677bf107f567b1112088e31fee47e6f029a6"}],"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0d9ddac993afcbd373d4511562cea9daff9c1d9a","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def get_dvr_routers_by_portid(self, context, port_id, fixed_ips\u003dNone):"},{"line_number":122,"context_line":"        \"\"\"Gets the dvr routers on vmport subnets.\"\"\""},{"line_number":123,"context_line":"        router_ids \u003d set()"},{"line_number":124,"context_line":"        if not fixed_ips:"},{"line_number":125,"context_line":"            port_dict \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":126,"context_line":"            fixed_ips \u003d port_dict[\u0027fixed_ips\u0027]"},{"line_number":127,"context_line":"        for fixedip in fixed_ips:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_ab944f8a","line":124,"updated":"2015-10-23 07:57:30.000000000","message":"I am good with the patch. But when the fixed_ips is [] here, line 125~126 is duplicated with line 102 and 109. So I would think \"if fixed_ips is not None\" here is better here.","commit_id":"b7f8677bf107f567b1112088e31fee47e6f029a6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3ef47dc502a0447cc1293559d05320f6de88eafc","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def get_dvr_routers_by_portid(self, context, port_id, fixed_ips\u003dNone):"},{"line_number":122,"context_line":"        \"\"\"Gets the dvr routers on vmport subnets.\"\"\""},{"line_number":123,"context_line":"        router_ids \u003d set()"},{"line_number":124,"context_line":"        if not fixed_ips:"},{"line_number":125,"context_line":"            port_dict \u003d self._core_plugin.get_port(context, port_id)"},{"line_number":126,"context_line":"            fixed_ips \u003d port_dict[\u0027fixed_ips\u0027]"},{"line_number":127,"context_line":"        for fixedip in fixed_ips:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_bc56d3cb","line":124,"in_reply_to":"3a29b11f_ab944f8a","updated":"2015-10-23 09:35:47.000000000","message":"I guess you mean \u0027if fixed_ips is None\u0027, makes sense, thanks","commit_id":"b7f8677bf107f567b1112088e31fee47e6f029a6"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"de53750bd9df44910c054a5be3b3c09e4c174a71","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        port_dict \u003d self._core_plugin.get_port(context, port[\u0027id\u0027])"},{"line_number":103,"context_line":"        port_host \u003d port_dict[\u0027binding:host_id\u0027]"},{"line_number":104,"context_line":"        l3_agent_on_host \u003d (self.get_l3_agents("},{"line_number":105,"context_line":"            context, filters\u003d{\u0027host\u0027: [port_host]}) or [None])[0]"},{"line_number":106,"context_line":"        if not l3_agent_on_host:"},{"line_number":107,"context_line":"            return"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_5a6c579c","line":105,"updated":"2015-11-03 17:19:26.000000000","message":"why is this \"[None]\" passed in here. Just to clarify my doubts.","commit_id":"d3b191984cfe2b24f16bd57c1b4bb8c555ee10e0"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"185d8a7ff1a9c4963a2b32a9376fc05e65d93a46","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        port_dict \u003d self._core_plugin.get_port(context, port[\u0027id\u0027])"},{"line_number":103,"context_line":"        port_host \u003d port_dict[\u0027binding:host_id\u0027]"},{"line_number":104,"context_line":"        l3_agent_on_host \u003d (self.get_l3_agents("},{"line_number":105,"context_line":"            context, filters\u003d{\u0027host\u0027: [port_host]}) or [None])[0]"},{"line_number":106,"context_line":"        if not l3_agent_on_host:"},{"line_number":107,"context_line":"            return"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_d8ca7e4f","line":105,"in_reply_to":"fa80f949_5a6c579c","updated":"2015-11-04 04:23:25.000000000","message":"It\u0027s just to avoid IndexError in case no agents found on host","commit_id":"d3b191984cfe2b24f16bd57c1b4bb8c555ee10e0"}]}
