)]}'
{"quantum/agent/securitygroups_rpc.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ed8939c7ea515eb1fa3a41744a012acf357af5da","unresolved":false,"context_lines":[{"line_number":43,"context_line":"def disable_security_group_extension_if_noop_driver("},{"line_number":44,"context_line":"    supported_extension_aliases):"},{"line_number":45,"context_line":"    if not is_firewall_enabled():"},{"line_number":46,"context_line":"        LOG.debug(\u0027security-group disbled\u0027)"},{"line_number":47,"context_line":"        supported_extension_aliases.remove(\u0027security-group\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAANH%2F%2F73U%3D","line":46,"updated":"2013-03-03 10:16:43.000000000","message":"please have i18n support here.\ndisbled \u003d\u003e disabled","commit_id":"4f481b2e314e8cd82fe7ce51c0829200f11f6a87"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":"def disable_security_group_extension_if_noop_driver("},{"line_number":44,"context_line":"    supported_extension_aliases):"},{"line_number":45,"context_line":"    if not is_firewall_enabled():"},{"line_number":46,"context_line":"        LOG.debug(\u0027security-group disbled\u0027)"},{"line_number":47,"context_line":"        supported_extension_aliases.remove(\u0027security-group\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAANH%2F%2F7zk%3D","line":46,"in_reply_to":"AAAANH%2F%2F73U%3D","updated":"2013-03-03 14:55:34.000000000","message":"Done","commit_id":"4f481b2e314e8cd82fe7ce51c0829200f11f6a87"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"30670ee3d47f1116706daabfdde06eceee4e6e02","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def is_firewall_enabled():"},{"line_number":37,"context_line":"    if (cfg.CONF.SECURITYGROUP.firewall_driver !\u003d"},{"line_number":38,"context_line":"        \u0027quantum.agent.firewall.NoopFirewallDriver\u0027):"},{"line_number":39,"context_line":"        return True"},{"line_number":40,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAN3%2F%2F8wE%3D","line":37,"updated":"2013-03-05 16:26:39.000000000","message":"the conditional is unneeded.\n\nreturn (cfg.CONF.SECURITYGROUP.firewall_driver !\u003d \u0027quantum.agent.firewall.NoopFirewallDriver\u0027)","commit_id":"709cca5ac47d33fe60e44df62c39e8476988fdb7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def is_firewall_enabled():"},{"line_number":37,"context_line":"    if (cfg.CONF.SECURITYGROUP.firewall_driver !\u003d"},{"line_number":38,"context_line":"        \u0027quantum.agent.firewall.NoopFirewallDriver\u0027):"},{"line_number":39,"context_line":"        return True"},{"line_number":40,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAN3%2F%2F8mk%3D","line":37,"in_reply_to":"AAAAN3%2F%2F8wE%3D","updated":"2013-03-05 16:48:43.000000000","message":"Done","commit_id":"709cca5ac47d33fe60e44df62c39e8476988fdb7"}],"quantum/plugins/linuxbridge/lb_quantum_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"30670ee3d47f1116706daabfdde06eceee4e6e02","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    @property"},{"line_number":211,"context_line":"    def supported_extension_aliases(self):"},{"line_number":212,"context_line":"        if not hasattr(self, \u0027_aliases\u0027):"},{"line_number":213,"context_line":"            aliases \u003d copy.deepcopy(self._supported_extension_aliases)"},{"line_number":214,"context_line":"            sg_rpc.disable_security_group_extension_if_noop_driver(aliases)"},{"line_number":215,"context_line":"            self._aliases \u003d aliases"},{"line_number":216,"context_line":"        return self._aliases"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAN3%2F%2F8q4%3D","line":213,"updated":"2013-03-05 16:26:39.000000000","message":"Deep copy is not necessary here.  The contents are strings which are immutable, so a deep copy is not need here. A simple one will do:\n\naliases \u003d self._support_extension_aliases[:]","commit_id":"709cca5ac47d33fe60e44df62c39e8476988fdb7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":210,"context_line":"    @property"},{"line_number":211,"context_line":"    def supported_extension_aliases(self):"},{"line_number":212,"context_line":"        if not hasattr(self, \u0027_aliases\u0027):"},{"line_number":213,"context_line":"            aliases \u003d copy.deepcopy(self._supported_extension_aliases)"},{"line_number":214,"context_line":"            sg_rpc.disable_security_group_extension_if_noop_driver(aliases)"},{"line_number":215,"context_line":"            self._aliases \u003d aliases"},{"line_number":216,"context_line":"        return self._aliases"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAN3%2F%2F8j4%3D","line":213,"in_reply_to":"AAAAN3%2F%2F8q4%3D","updated":"2013-03-05 16:48:43.000000000","message":"Done","commit_id":"709cca5ac47d33fe60e44df62c39e8476988fdb7"}],"quantum/plugins/nec/nec_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"30670ee3d47f1116706daabfdde06eceee4e6e02","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    @property"},{"line_number":90,"context_line":"    def supported_extension_aliases(self):"},{"line_number":91,"context_line":"        if not hasattr(self, \u0027_aliases\u0027):"},{"line_number":92,"context_line":"            aliases \u003d copy.deepcopy(self._supported_extension_aliases)"},{"line_number":93,"context_line":"            sg_rpc.disable_security_group_extension_if_noop_driver(aliases)"},{"line_number":94,"context_line":"            self._aliases \u003d aliases"},{"line_number":95,"context_line":"        return self._aliases"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAN3%2F%2F8qw%3D","line":92,"updated":"2013-03-05 16:26:39.000000000","message":"Same as before.","commit_id":"709cca5ac47d33fe60e44df62c39e8476988fdb7"}],"quantum/plugins/openvswitch/ovs_quantum_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"30670ee3d47f1116706daabfdde06eceee4e6e02","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                                    \"agent\", \"extraroute\", \"agent_scheduler\"]"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    @property"},{"line_number":250,"context_line":"    def supported_extension_aliases(self):"},{"line_number":251,"context_line":"        if not hasattr(self, \u0027_aliases\u0027):"},{"line_number":252,"context_line":"            aliases \u003d copy.deepcopy(self._supported_extension_aliases)"},{"line_number":253,"context_line":"            sg_rpc.disable_security_group_extension_if_noop_driver(aliases)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAN3%2F%2F8qo%3D","line":250,"updated":"2013-03-05 16:26:39.000000000","message":"Same","commit_id":"709cca5ac47d33fe60e44df62c39e8476988fdb7"}],"quantum/plugins/ryu/ryu_quantum_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"30670ee3d47f1116706daabfdde06eceee4e6e02","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    _supported_extension_aliases \u003d [\"router\", \"extraroute\", \"security-group\"]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @property"},{"line_number":97,"context_line":"    def supported_extension_aliases(self):"},{"line_number":98,"context_line":"        if not hasattr(self, \u0027_aliases\u0027):"},{"line_number":99,"context_line":"            aliases \u003d copy.deepcopy(self._supported_extension_aliases)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAN3%2F%2F8qg%3D","line":96,"updated":"2013-03-05 16:26:39.000000000","message":"Same","commit_id":"709cca5ac47d33fe60e44df62c39e8476988fdb7"}],"quantum/tests/unit/linuxbridge/test_lb_security_group.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"30670ee3d47f1116706daabfdde06eceee4e6e02","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"from mock import call"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from quantum.api.v2 import attributes"},{"line_number":23,"context_line":"from quantum.extensions import securitygroup as ext_sg"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAN3%2F%2F6uU%3D","line":20,"updated":"2013-03-06 15:19:19.000000000","message":"why do we need this import?","commit_id":"009f78e4252be1c5246d3bc400d4042853bfd427"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"from mock import call"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from quantum.api.v2 import attributes"},{"line_number":23,"context_line":"from quantum.extensions import securitygroup as ext_sg"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAN3%2F%2F6n4%3D","line":20,"in_reply_to":"AAAAN3%2F%2F6uU%3D","updated":"2013-03-06 16:31:51.000000000","message":"Thanks, fixed.\n\nmock.call is also unused and I will remove it too","commit_id":"009f78e4252be1c5246d3bc400d4042853bfd427"}]}
