)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"ed5f723a067958291439f718c8ae0b40636332fe","unresolved":false,"context_lines":[{"line_number":19,"context_line":"which is not working in PY3K if an UnicodeError is raised because line"},{"line_number":20,"context_line":"is not decoded and concatened to a string."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This change delegates decoding to safe_decode[1] which returns a text"},{"line_number":23,"context_line":"object or raises an error."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1] oslo_utils.encodeutils"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a2fa921_bac5f43c","line":22,"updated":"2015-10-07 19:56:27.000000000","message":"No longer correct","commit_id":"c3175a452e660a6b64466316a290138cd14e674a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f06bcfb67d3c7520fcedc09b2aa76a48033aa3cb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"which is not working in PY3K if an UnicodeError is raised because line"},{"line_number":20,"context_line":"is not decoded and concatened to a string."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This change delegates decoding to safe_decode[1] which returns a text"},{"line_number":23,"context_line":"object or raises an error."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1] oslo_utils.encodeutils"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a2fa921_ed7df41c","line":22,"in_reply_to":"7a2fa921_bac5f43c","updated":"2015-10-07 20:16:32.000000000","message":"Done","commit_id":"c3175a452e660a6b64466316a290138cd14e674a"}],"neutron/agent/linux/utils.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"a85431de5d251375c8e9e3a960798bb644b80082","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            _stdout, _stderr \u003d obj.communicate(_process_input)"},{"line_number":123,"context_line":"            returncode \u003d obj.returncode"},{"line_number":124,"context_line":"            obj.stdin.close()"},{"line_number":125,"context_line":"        _stdout \u003d encodeutils.safe_decode(_stdout, \u0027utf-8\u0027)"},{"line_number":126,"context_line":"        _stderr \u003d encodeutils.safe_decode(_stderr, \u0027utf-8\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        command_str \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_0983a457","line":125,"updated":"2015-10-07 09:16:57.000000000","message":"Please don\u0027t use this complex function. For OS data, you must use the surrogateescape error handler on Python 3. For example:\n\nif six.PY3:\n    stdout \u003d stdout.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)\nelse:\n    stdout \u003d encodeutils.safe_decode(stdout, \u0027utf-8\u0027)\n\nYou may also try to use the universal_newlines\u003dTrue parameter to subprocess.Popen(): on Python 3, it uses Unicode for standard streams (stdin, stdout, stderr).","commit_id":"7de8fe8f433018e405b15e500ff74703c73a146e"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"80f574460949ab233e6f9cf9d5114b7639b4bc50","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            obj.stdin.close()"},{"line_number":124,"context_line":"        if six.PY3:"},{"line_number":125,"context_line":"            if isinstance(_stdout, bytes):"},{"line_number":126,"context_line":"                _stdout \u003d _stdout.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":"            if isinstance(_stderr, bytes):"},{"line_number":128,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a2ca52d_8d54ec54","line":126,"updated":"2015-10-13 13:37:22.000000000","message":"\u0027surrogateescape\u0027 is an error handler arg for open(), not decode().\n\nHere _stdout/err are from subprocess.Popen(), so I wonder if we should be specifying universal_newlines there?","commit_id":"5096b384e8fd97a9052d2ed99b0af7bb973b7fe7"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"efeccd0e960ac0b68c0b74036305a909806240ec","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            obj.stdin.close()"},{"line_number":124,"context_line":"        if six.PY3:"},{"line_number":125,"context_line":"            if isinstance(_stdout, bytes):"},{"line_number":126,"context_line":"                _stdout \u003d _stdout.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":"            if isinstance(_stderr, bytes):"},{"line_number":128,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a2ca52d_96c5cf5c","line":126,"in_reply_to":"5a2ca52d_1bd6c8c5","updated":"2015-10-13 18:43:41.000000000","message":"Oh... I read the python34 check job log, and I now understand your confusion. The test uses a custom bytes object with an overriden decode() method.\n\nIMHO test_raise_unicodeerror_in_decoding_out_data() must be fixed, and maybe skipped on Python 3. Decoding using surrogateescape cannot fail on Python 3, so the test doesn\u0027t make sense on Python 3.\n\nBut the test may ensure that surrogateescape handles undecodable bytes as expected. For example, return b\u0027abc\\xff\u0027 in the mock stdout, and expect \u0027abc\\udcff\u0027 in the result stdout.","commit_id":"5096b384e8fd97a9052d2ed99b0af7bb973b7fe7"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"c550a38ebf1d637904d54755c94df55da1121118","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            obj.stdin.close()"},{"line_number":124,"context_line":"        if six.PY3:"},{"line_number":125,"context_line":"            if isinstance(_stdout, bytes):"},{"line_number":126,"context_line":"                _stdout \u003d _stdout.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":"            if isinstance(_stderr, bytes):"},{"line_number":128,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a2ca52d_e83f8ed4","line":126,"in_reply_to":"5a2ca52d_8d54ec54","updated":"2015-10-13 13:57:06.000000000","message":"\u003e \u0027surrogateescape\u0027 is an error handler arg for open(), not decode().\n\nWhere did you read that? Error handlers are written for Unicode encoders and decoders (codecs). open() uses these codecs.\n\nPlease just try in a terminal:\n\n $ python3\n Python 3.4.2 (default, Jul  9 2015, 17:24:30) \n \u003e\u003e\u003e b\u0027abc\\xff\u0027.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)\n \u0027abc\\udcff\u0027","commit_id":"5096b384e8fd97a9052d2ed99b0af7bb973b7fe7"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"849af55dc0ef77cda5f4765a10d6601f950cf2d5","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            obj.stdin.close()"},{"line_number":124,"context_line":"        if six.PY3:"},{"line_number":125,"context_line":"            if isinstance(_stdout, bytes):"},{"line_number":126,"context_line":"                _stdout \u003d _stdout.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":"            if isinstance(_stderr, bytes):"},{"line_number":128,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a2ca52d_1bd6c8c5","line":126,"in_reply_to":"5a2ca52d_a33c5930","updated":"2015-10-13 18:24:26.000000000","message":"ok, no problem ;)","commit_id":"5096b384e8fd97a9052d2ed99b0af7bb973b7fe7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"a77b229ffed2041a61ee54b389f5e9886f046ae0","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            obj.stdin.close()"},{"line_number":124,"context_line":"        if six.PY3:"},{"line_number":125,"context_line":"            if isinstance(_stdout, bytes):"},{"line_number":126,"context_line":"                _stdout \u003d _stdout.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":"            if isinstance(_stderr, bytes):"},{"line_number":128,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a2ca52d_a33c5930","line":126,"in_reply_to":"5a2ca52d_e83f8ed4","updated":"2015-10-13 14:09:27.000000000","message":"\u003e Where did you read that? Error handlers are written for Unicode encoders and decoders (codecs). open() uses these codecs.\n\nOops, sorry, I assumed it after seeing the error in the unit test log,\n\nhttp://logs.openstack.org/09/231709/6/check/gate-neutron-python34/c479339/console.html#_2015-10-13_10_37_07_966\n\nand then reading\n\nhttps://docs.python.org/3/howto/unicode.html#files-in-an-unknown-encoding","commit_id":"5096b384e8fd97a9052d2ed99b0af7bb973b7fe7"}],"neutron/tests/unit/agent/linux/test_utils.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"19e86546f0c857ae0f9cab2cdaf73482f95df7ee","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    @testtools.skipUnless(six.PY3, \u0027This test makes sense only in Python 3\u0027)"},{"line_number":151,"context_line":"    def test_surrogateescape_in_decoding_out_data(self):"},{"line_number":152,"context_line":"        err_data \u003d \u0027\\udced\\udca0\\udcbd\u0027"},{"line_number":153,"context_line":"        bytes_err_data \u003d b\u0027\\xed\\xa0\\xbd\u0027"},{"line_number":154,"context_line":"        out_data \u003d \"%s\\n\" % self.test_file"},{"line_number":155,"context_line":"        bytes_out_data \u003d out_data.encode(encoding\u003d\u0027utf-8\u0027)"},{"line_number":156,"context_line":"        self.mock_popen.return_value \u003d [bytes_out_data, bytes_err_data]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_47c28335","line":153,"updated":"2015-11-03 09:07:46.000000000","message":"You may define err_data as:\n\nerr_data \u003d bytes_err_data.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)","commit_id":"e0d577cd6bf69f7ec51f47d5383d13a841bf2533"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f3329423943826cf9399cc17f5d080113f7ff066","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    @testtools.skipUnless(six.PY3, \u0027This test makes sense only in Python 3\u0027)"},{"line_number":151,"context_line":"    def test_surrogateescape_in_decoding_out_data(self):"},{"line_number":152,"context_line":"        err_data \u003d \u0027\\udced\\udca0\\udcbd\u0027"},{"line_number":153,"context_line":"        bytes_err_data \u003d b\u0027\\xed\\xa0\\xbd\u0027"},{"line_number":154,"context_line":"        out_data \u003d \"%s\\n\" % self.test_file"},{"line_number":155,"context_line":"        bytes_out_data \u003d out_data.encode(encoding\u003d\u0027utf-8\u0027)"},{"line_number":156,"context_line":"        self.mock_popen.return_value \u003d [bytes_out_data, bytes_err_data]"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_eec1b881","line":153,"in_reply_to":"1a26ad4f_47c28335","updated":"2015-11-04 06:03:21.000000000","message":"Done","commit_id":"e0d577cd6bf69f7ec51f47d5383d13a841bf2533"}]}
