)]}'
{"tox.ini":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"6459e5558c7613c74168cc659f78b8159208425a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"deps \u003d"},{"line_number":57,"context_line":"  {[testenv:functional]deps}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[testenv:dsvm-functional-py34]"},{"line_number":60,"context_line":"basepython \u003d python3.4"},{"line_number":61,"context_line":"setenv \u003d {[testenv:dsvm-functional]setenv}"},{"line_number":62,"context_line":"sitepackages\u003d{[testenv:dsvm-functional]sitepackages}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7a2fa921_96b11392","line":59,"updated":"2015-10-07 09:08:16.000000000","message":"You should also define functional-py34","commit_id":"d499e511597087765e5b3cba7e6567de23934917"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"523534301cb7e661561fabd5e49cc1fb566a3395","unresolved":false,"context_lines":[{"line_number":39,"context_line":"         OS_FAIL_ON_MISSING_DEPS\u003d1"},{"line_number":40,"context_line":"commands \u003d false"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"[testenv:functional]"},{"line_number":43,"context_line":"basepython \u003d python2.7"},{"line_number":44,"context_line":"setenv \u003d {[testenv]setenv}"},{"line_number":45,"context_line":"         {[testenv:common]setenv}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a2fa921_02005900","line":42,"updated":"2015-10-07 10:14:43.000000000","message":"Would it be better to name this as follows: [testenv:functional-py2x]? As will be moving towards python3.","commit_id":"477fcca1c0789dcd7b51e410c255777e56e02788"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"85e2d255bb7d6eee3ba770d5101d22b5bbb8bfc1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"         OS_FAIL_ON_MISSING_DEPS\u003d1"},{"line_number":40,"context_line":"commands \u003d false"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"[testenv:functional]"},{"line_number":43,"context_line":"basepython \u003d python2.7"},{"line_number":44,"context_line":"setenv \u003d {[testenv]setenv}"},{"line_number":45,"context_line":"         {[testenv:common]setenv}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a2fa921_7d5f7241","line":42,"in_reply_to":"7a2fa921_02005900","updated":"2015-10-07 11:09:35.000000000","message":"No. That would break gate jobs and existing workflow for contributors.","commit_id":"477fcca1c0789dcd7b51e410c255777e56e02788"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"523534301cb7e661561fabd5e49cc1fb566a3395","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  {[testenv]deps}"},{"line_number":49,"context_line":"  -r{toxinidir}/neutron/tests/functional/requirements.txt"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[testenv:functional-py34]"},{"line_number":52,"context_line":"basepython \u003d python3.4"},{"line_number":53,"context_line":"setenv \u003d {[testenv:functional]setenv}"},{"line_number":54,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a2fa921_e223dda5","line":51,"updated":"2015-10-07 10:14:43.000000000","message":"Name this then as : [testenv:functional]?","commit_id":"477fcca1c0789dcd7b51e410c255777e56e02788"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"85e2d255bb7d6eee3ba770d5101d22b5bbb8bfc1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  {[testenv]deps}"},{"line_number":49,"context_line":"  -r{toxinidir}/neutron/tests/functional/requirements.txt"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[testenv:functional-py34]"},{"line_number":52,"context_line":"basepython \u003d python3.4"},{"line_number":53,"context_line":"setenv \u003d {[testenv:functional]setenv}"},{"line_number":54,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a2fa921_3d59fa5a","line":51,"in_reply_to":"7a2fa921_e223dda5","updated":"2015-10-07 11:09:35.000000000","message":"py2 is still the only supported option, we don\u0027t go to py3 only any time soon.","commit_id":"477fcca1c0789dcd7b51e410c255777e56e02788"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"523534301cb7e661561fabd5e49cc1fb566a3395","unresolved":false,"context_lines":[{"line_number":52,"context_line":"basepython \u003d python3.4"},{"line_number":53,"context_line":"setenv \u003d {[testenv:functional]setenv}"},{"line_number":54,"context_line":"deps \u003d"},{"line_number":55,"context_line":"  {[testenv:functional]deps}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[testenv:dsvm-functional]"},{"line_number":58,"context_line":"basepython \u003d python2.7"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a2fa921_2251d50e","line":55,"updated":"2015-10-07 10:14:43.000000000","message":"should this reference the reqs file (i.e. -r{toxinidir}/neutron/tests/functional/requirements.txt)?","commit_id":"477fcca1c0789dcd7b51e410c255777e56e02788"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"85e2d255bb7d6eee3ba770d5101d22b5bbb8bfc1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"basepython \u003d python3.4"},{"line_number":53,"context_line":"setenv \u003d {[testenv:functional]setenv}"},{"line_number":54,"context_line":"deps \u003d"},{"line_number":55,"context_line":"  {[testenv:functional]deps}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[testenv:dsvm-functional]"},{"line_number":58,"context_line":"basepython \u003d python2.7"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a2fa921_7d2692cf","line":55,"in_reply_to":"7a2fa921_2251d50e","updated":"2015-10-07 11:09:35.000000000","message":"It\u0027s inherited from functional target.","commit_id":"477fcca1c0789dcd7b51e410c255777e56e02788"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"523534301cb7e661561fabd5e49cc1fb566a3395","unresolved":false,"context_lines":[{"line_number":54,"context_line":"deps \u003d"},{"line_number":55,"context_line":"  {[testenv:functional]deps}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[testenv:dsvm-functional]"},{"line_number":58,"context_line":"basepython \u003d python2.7"},{"line_number":59,"context_line":"setenv \u003d {[testenv:functional]setenv}"},{"line_number":60,"context_line":"         {[testenv:dsvm]setenv}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a2fa921_2278f58e","line":57,"updated":"2015-10-07 10:14:43.000000000","message":"Similar naming convention as mentioned for testenv:functional","commit_id":"477fcca1c0789dcd7b51e410c255777e56e02788"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"54e419bac440a8fec2aed3ed6ddba12de8fc0d6e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"deps \u003d"},{"line_number":55,"context_line":"  {[testenv:functional]deps}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[testenv:dsvm-functional]"},{"line_number":58,"context_line":"basepython \u003d python2.7"},{"line_number":59,"context_line":"setenv \u003d {[testenv:functional]setenv}"},{"line_number":60,"context_line":"         {[testenv:dsvm]setenv}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a2fa921_82d229ff","line":57,"in_reply_to":"7a2fa921_226235ae","updated":"2015-10-07 10:26:02.000000000","message":"Ok but can you call this [testenv:dsvm-functional-py2x]?","commit_id":"477fcca1c0789dcd7b51e410c255777e56e02788"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d8083d694c9422b8fafb9a1562ffb3e9dbb8741f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"deps \u003d"},{"line_number":55,"context_line":"  {[testenv:functional]deps}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[testenv:dsvm-functional]"},{"line_number":58,"context_line":"basepython \u003d python2.7"},{"line_number":59,"context_line":"setenv \u003d {[testenv:functional]setenv}"},{"line_number":60,"context_line":"         {[testenv:dsvm]setenv}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a2fa921_226235ae","line":57,"in_reply_to":"7a2fa921_2278f58e","updated":"2015-10-07 10:20:10.000000000","message":"This name is used by the gate","commit_id":"477fcca1c0789dcd7b51e410c255777e56e02788"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"85e2d255bb7d6eee3ba770d5101d22b5bbb8bfc1","unresolved":false,"context_lines":[{"line_number":54,"context_line":"deps \u003d"},{"line_number":55,"context_line":"  {[testenv:functional]deps}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[testenv:dsvm-functional]"},{"line_number":58,"context_line":"basepython \u003d python2.7"},{"line_number":59,"context_line":"setenv \u003d {[testenv:functional]setenv}"},{"line_number":60,"context_line":"         {[testenv:dsvm]setenv}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a2fa921_5d2b9694","line":57,"in_reply_to":"7a2fa921_82d229ff","updated":"2015-10-07 11:09:35.000000000","message":"No.","commit_id":"477fcca1c0789dcd7b51e410c255777e56e02788"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"523534301cb7e661561fabd5e49cc1fb566a3395","unresolved":false,"context_lines":[{"line_number":62,"context_line":"deps \u003d"},{"line_number":63,"context_line":"  {[testenv:functional]deps}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[testenv:dsvm-functional-py34]"},{"line_number":66,"context_line":"basepython \u003d python3.4"},{"line_number":67,"context_line":"setenv \u003d {[testenv:dsvm-functional]setenv}"},{"line_number":68,"context_line":"sitepackages\u003d{[testenv:dsvm-functional]sitepackages}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a2fa921_0275b996","line":65,"updated":"2015-10-07 10:14:43.000000000","message":"Similar naming convention as mentioned for testenv:functional","commit_id":"477fcca1c0789dcd7b51e410c255777e56e02788"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"54e419bac440a8fec2aed3ed6ddba12de8fc0d6e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"deps \u003d"},{"line_number":63,"context_line":"  {[testenv:functional]deps}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[testenv:dsvm-functional-py34]"},{"line_number":66,"context_line":"basepython \u003d python3.4"},{"line_number":67,"context_line":"setenv \u003d {[testenv:dsvm-functional]setenv}"},{"line_number":68,"context_line":"sitepackages\u003d{[testenv:dsvm-functional]sitepackages}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a2fa921_c2fee16a","line":65,"in_reply_to":"7a2fa921_0275b996","updated":"2015-10-07 10:26:02.000000000","message":"and this [testenv:dsvm-functional] as moving towards python3?","commit_id":"477fcca1c0789dcd7b51e410c255777e56e02788"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"be8f21aabd8041b2fee53980c6b75d01407a3705","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[testenv:dsvm-functional-py34]"},{"line_number":66,"context_line":"basepython \u003d python3.4"},{"line_number":67,"context_line":"setenv \u003d {[testenv:dsvm-functional]setenv}"},{"line_number":68,"context_line":"sitepackages\u003d{[testenv:dsvm-functional]sitepackages}"},{"line_number":69,"context_line":"deps \u003d"},{"line_number":70,"context_line":"  {[testenv:dsvm-functional]deps}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a2fa921_a4095cdf","line":67,"updated":"2015-10-07 17:35:27.000000000","message":"Should this be referencing testenv:functional-py34? (same below)","commit_id":"477fcca1c0789dcd7b51e410c255777e56e02788"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"963202681a4ce20420f8418ba9c35031d1a9c08b","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"[testenv:dsvm-functional-py34]"},{"line_number":66,"context_line":"basepython \u003d python3.4"},{"line_number":67,"context_line":"setenv \u003d {[testenv:dsvm-functional]setenv}"},{"line_number":68,"context_line":"sitepackages\u003d{[testenv:dsvm-functional]sitepackages}"},{"line_number":69,"context_line":"deps \u003d"},{"line_number":70,"context_line":"  {[testenv:dsvm-functional]deps}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"7a2fa921_37e6c7b0","line":67,"in_reply_to":"7a2fa921_a4095cdf","updated":"2015-10-08 08:52:57.000000000","message":"I wrote the code so that testenv:\u003cfoo\u003e-py34 references testenv:\u003cfoo\u003e, which is the most logical thing to me.\n\nIn the end, it\u0027s the same, since dsvm-functional-py34 inherits from dsvm-functional, which in turn inherits from functional.","commit_id":"477fcca1c0789dcd7b51e410c255777e56e02788"}]}