)]}'
{"neutron/api/rpc/handlers/dhcp_rpc.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"1c05439dca7f73da04e0164cbbaaade669e84a21","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    # API version history:"},{"line_number":50,"context_line":"    #     1.0 - Initial version."},{"line_number":51,"context_line":"    #     1.1 - Added get_active_networks_info, create_dhcp_port,"},{"line_number":52,"context_line":"    #           and update_dhcp_port methods."},{"line_number":53,"context_line":"    #     1.2 - Removed get_dhcp_port. When removing a method (Making a"},{"line_number":54,"context_line":"    #           backwards incompatible change) you would normally bump the"},{"line_number":55,"context_line":"    #           major version. However, since the method was unused in the"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_aec86023","line":52,"updated":"2015-10-07 16:18:27.000000000","message":"I think the same procedure applies and we should bump the minor version to 1.3.","commit_id":"1b8ca69af67bc4ec9e4331bc3aabf7f71868bb29"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7bbde808415ac3e0b6fd546e028601e9631fcda8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    # API version history:"},{"line_number":50,"context_line":"    #     1.0 - Initial version."},{"line_number":51,"context_line":"    #     1.1 - Added get_active_networks_info, create_dhcp_port,"},{"line_number":52,"context_line":"    #           and update_dhcp_port methods."},{"line_number":53,"context_line":"    #     1.2 - Removed get_dhcp_port. When removing a method (Making a"},{"line_number":54,"context_line":"    #           backwards incompatible change) you would normally bump the"},{"line_number":55,"context_line":"    #           major version. However, since the method was unused in the"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_0e2cf4a9","line":52,"in_reply_to":"7a2fa921_aec86023","updated":"2015-10-07 16:20:21.000000000","message":"Oh right!","commit_id":"1b8ca69af67bc4ec9e4331bc3aabf7f71868bb29"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"7b16c4aec09cae3d5faf43b5977ff194b40ee0cc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    #           minor release instead and claim RPC compatibility with the"},{"line_number":58,"context_line":"    #           last few client versions."},{"line_number":59,"context_line":"    #     1.3 - Removed release_port_fixed_ip. It\u0027s not used by reference DHCP"},{"line_number":60,"context_line":"    #     agent since Juno, so similar rationale for not bumping the major"},{"line_number":61,"context_line":"    #     version as above applies here too."},{"line_number":62,"context_line":"    target \u003d oslo_messaging.Target("},{"line_number":63,"context_line":"        namespace\u003dconstants.RPC_NAMESPACE_DHCP_PLUGIN,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_81d5191d","line":60,"updated":"2015-10-08 07:53:37.000000000","message":"nit: better to align indentation with above version descriptions","commit_id":"b1c3ea95cd6415e7c6aac8ddbc73eb53ed67a33a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4a0df180889eb1ad11caf1ad9fed1b53267e48bb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    #           minor release instead and claim RPC compatibility with the"},{"line_number":58,"context_line":"    #           last few client versions."},{"line_number":59,"context_line":"    #     1.3 - Removed release_port_fixed_ip. It\u0027s not used by reference DHCP"},{"line_number":60,"context_line":"    #     agent since Juno, so similar rationale for not bumping the major"},{"line_number":61,"context_line":"    #     version as above applies here too."},{"line_number":62,"context_line":"    target \u003d oslo_messaging.Target("},{"line_number":63,"context_line":"        namespace\u003dconstants.RPC_NAMESPACE_DHCP_PLUGIN,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_dba216fd","line":60,"in_reply_to":"7a2fa921_81d5191d","updated":"2015-10-08 12:03:20.000000000","message":"Done","commit_id":"b1c3ea95cd6415e7c6aac8ddbc73eb53ed67a33a"}]}