)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"3130a36c444f9f7ad7307f7ca60aa4f1b56f02e9","unresolved":false,"context_lines":[{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"        These ports already have fixed_ips populated."},{"line_number":1193,"context_line":"        \"\"\""},{"line_number":1194,"context_line":"        if not ports:"},{"line_number":1195,"context_line":"            return"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"        def each_port_having_fixed_ips():"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_066fed92","side":"PARENT","line":1194,"updated":"2015-10-07 21:31:53.000000000","message":"why removing this?","commit_id":"57a9f245e6b46fe619951190d91b57f516614318"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"179b3860e7f3cbf0be8310a0f2e05e1d31cc6da2","unresolved":false,"context_lines":[{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"        These ports already have fixed_ips populated."},{"line_number":1193,"context_line":"        \"\"\""},{"line_number":1194,"context_line":"        if not ports:"},{"line_number":1195,"context_line":"            return"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"        def each_port_having_fixed_ips():"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_617f9d66","side":"PARENT","line":1194,"in_reply_to":"7a2fa921_066fed92","updated":"2015-10-08 07:46:05.000000000","message":"I guess it doen\u0027s buy us much given 1208-1209","commit_id":"57a9f245e6b46fe619951190d91b57f516614318"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0fc4526ed9e7de9f2f2ae5cd13f90f3f5e599b99","unresolved":false,"context_lines":[{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"        These ports already have fixed_ips populated."},{"line_number":1193,"context_line":"        \"\"\""},{"line_number":1194,"context_line":"        if not ports:"},{"line_number":1195,"context_line":"            return"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"        def each_port_having_fixed_ips():"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_befb6fc0","side":"PARENT","line":1194,"in_reply_to":"7a2fa921_5b3eed8c","updated":"2015-10-08 19:56:31.000000000","message":"I\u0027m guessing ports is typically valid, so this wasn\u0027t doing much, but the below check is required.  At least that\u0027s what I\u0027m going with :)","commit_id":"57a9f245e6b46fe619951190d91b57f516614318"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"bc34b1fd4830b8afcfe853d4e21ba06bf753b7bc","unresolved":false,"context_lines":[{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"        These ports already have fixed_ips populated."},{"line_number":1193,"context_line":"        \"\"\""},{"line_number":1194,"context_line":"        if not ports:"},{"line_number":1195,"context_line":"            return"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"        def each_port_having_fixed_ips():"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_5b3eed8c","side":"PARENT","line":1194,"in_reply_to":"7a2fa921_617f9d66","updated":"2015-10-08 19:28:43.000000000","message":"Right, I considered leaving it in.  But, I agree with @Oleg that it doesn\u0027t do much.  If bool(ports) is False here then network_ids will quickly be empty and we\u0027ll return anyway.  It is three lines of code that don\u0027t help much.","commit_id":"57a9f245e6b46fe619951190d91b57f516614318"}]}
