)]}'
{"doc/source/devref/effective_neutron.rst":[{"author":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"change_message_id":"08a1fb5325ff28ff915de8183756a3bd9fd91e94","unresolved":false,"context_lines":[{"line_number":155,"context_line":"* Don\u0027t mimic existing tests that violate these guidelines. We are attempting to"},{"line_number":156,"context_line":"  replace all of these so more tests like them create more work. If you need help"},{"line_number":157,"context_line":"  writing a test, reach out to the testing lieutenants and the team on IRC."},{"line_number":158,"context_line":"* Mocking open() is a dangerous practice because it can lead to wierd bugs like"},{"line_number":159,"context_line":"  `bug 1503847 \u003chttps://bugs.launchpad.net/neutron/+bug/1503847\u003e`_. In fact,"},{"line_number":160,"context_line":"  when the builtin open method is mocked during tests, some utilities (like"},{"line_number":161,"context_line":"  debtcollector) may still rely on the real thing, and may end up using the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_ca6a3aee","line":158,"updated":"2015-10-08 13:48:34.000000000","message":"+1","commit_id":"8bd4d92bb5495da060de13963db860d99da93e3d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d081ff88048ca42ac7fa61feab6c31050bbe336a","unresolved":false,"context_lines":[{"line_number":155,"context_line":"* Don\u0027t mimic existing tests that violate these guidelines. We are attempting to"},{"line_number":156,"context_line":"  replace all of these so more tests like them create more work. If you need help"},{"line_number":157,"context_line":"  writing a test, reach out to the testing lieutenants and the team on IRC."},{"line_number":158,"context_line":"* Mocking open() is a dangerous practice because it can lead to wierd bugs like"},{"line_number":159,"context_line":"  `bug 1503847 \u003chttps://bugs.launchpad.net/neutron/+bug/1503847\u003e`_. In fact,"},{"line_number":160,"context_line":"  when the builtin open method is mocked during tests, some utilities (like"},{"line_number":161,"context_line":"  debtcollector) may still rely on the real thing, and may end up using the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_74b2ef07","line":158,"updated":"2015-10-08 13:07:12.000000000","message":"weird","commit_id":"8bd4d92bb5495da060de13963db860d99da93e3d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0a8b458bb3a44fa638cc853f29c9de730fd31229","unresolved":false,"context_lines":[{"line_number":155,"context_line":"* Don\u0027t mimic existing tests that violate these guidelines. We are attempting to"},{"line_number":156,"context_line":"  replace all of these so more tests like them create more work. If you need help"},{"line_number":157,"context_line":"  writing a test, reach out to the testing lieutenants and the team on IRC."},{"line_number":158,"context_line":"* Mocking open() is a dangerous practice because it can lead to wierd bugs like"},{"line_number":159,"context_line":"  `bug 1503847 \u003chttps://bugs.launchpad.net/neutron/+bug/1503847\u003e`_. In fact,"},{"line_number":160,"context_line":"  when the builtin open method is mocked during tests, some utilities (like"},{"line_number":161,"context_line":"  debtcollector) may still rely on the real thing, and may end up using the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_ff96cfee","line":158,"updated":"2015-10-08 16:11:56.000000000","message":"weird looks weird here i\u0027ll suggest it to change it to unexpected bugs like ?","commit_id":"8bd4d92bb5495da060de13963db860d99da93e3d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"27db0c72a90c549242452d9f10540f4d564e5d70","unresolved":false,"context_lines":[{"line_number":155,"context_line":"* Don\u0027t mimic existing tests that violate these guidelines. We are attempting to"},{"line_number":156,"context_line":"  replace all of these so more tests like them create more work. If you need help"},{"line_number":157,"context_line":"  writing a test, reach out to the testing lieutenants and the team on IRC."},{"line_number":158,"context_line":"* Mocking open() is a dangerous practice because it can lead to wierd bugs like"},{"line_number":159,"context_line":"  `bug 1503847 \u003chttps://bugs.launchpad.net/neutron/+bug/1503847\u003e`_. In fact,"},{"line_number":160,"context_line":"  when the builtin open method is mocked during tests, some utilities (like"},{"line_number":161,"context_line":"  debtcollector) may still rely on the real thing, and may end up using the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_8a80b4c0","line":158,"in_reply_to":"7a2fa921_ff96cfee","updated":"2015-10-08 17:26:57.000000000","message":"Done","commit_id":"8bd4d92bb5495da060de13963db860d99da93e3d"},{"author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"change_message_id":"5f0322270d6204be0879235810b4d99bd2824a94","unresolved":false,"context_lines":[{"line_number":157,"context_line":"  writing a test, reach out to the testing lieutenants and the team on IRC."},{"line_number":158,"context_line":"* Mocking open() is a dangerous practice because it can lead to wierd bugs like"},{"line_number":159,"context_line":"  `bug 1503847 \u003chttps://bugs.launchpad.net/neutron/+bug/1503847\u003e`_. In fact,"},{"line_number":160,"context_line":"  when the builtin open method is mocked during tests, some utilities (like"},{"line_number":161,"context_line":"  debtcollector) may still rely on the real thing, and may end up using the"},{"line_number":162,"context_line":"  mock rather what they are really looking for. If you must, consider scoping"},{"line_number":163,"context_line":"  by `module https://review.openstack.org/#/c/232265/`_. Better not to mock"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_aa07bec8","line":160,"updated":"2015-10-08 13:39:40.000000000","message":"\"built-in\"\n\nI think that is the correct way to write it with the hyphen.\n\nhttps://en.wikipedia.org/wiki/Built-in","commit_id":"8bd4d92bb5495da060de13963db860d99da93e3d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"27db0c72a90c549242452d9f10540f4d564e5d70","unresolved":false,"context_lines":[{"line_number":157,"context_line":"  writing a test, reach out to the testing lieutenants and the team on IRC."},{"line_number":158,"context_line":"* Mocking open() is a dangerous practice because it can lead to wierd bugs like"},{"line_number":159,"context_line":"  `bug 1503847 \u003chttps://bugs.launchpad.net/neutron/+bug/1503847\u003e`_. In fact,"},{"line_number":160,"context_line":"  when the builtin open method is mocked during tests, some utilities (like"},{"line_number":161,"context_line":"  debtcollector) may still rely on the real thing, and may end up using the"},{"line_number":162,"context_line":"  mock rather what they are really looking for. If you must, consider scoping"},{"line_number":163,"context_line":"  by `module https://review.openstack.org/#/c/232265/`_. Better not to mock"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_4a6ffc2a","line":160,"in_reply_to":"7a2fa921_aa07bec8","updated":"2015-10-08 17:26:57.000000000","message":"Done","commit_id":"8bd4d92bb5495da060de13963db860d99da93e3d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6a1d164ec40098c7223db9d65c5331f8ed85b572","unresolved":false,"context_lines":[{"line_number":159,"context_line":"  bugs like `bug 1503847 \u003chttps://bugs.launchpad.net/neutron/+bug/1503847\u003e`_."},{"line_number":160,"context_line":"  In fact, when the built-in open method is mocked during tests, some"},{"line_number":161,"context_line":"  utilities (like debtcollector) may still rely on the real thing, and may"},{"line_number":162,"context_line":"  end up using the mock rather what they are really looking for. If you must,"},{"line_number":163,"context_line":"  consider scoping by `module https://review.openstack.org/#/c/232265/`_, but"},{"line_number":164,"context_line":"  it is better not to mock open() at all."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a2fa921_a5a281fa","line":162,"updated":"2015-10-08 17:36:15.000000000","message":"nit: rather than","commit_id":"1585e197d691dd3a9a4af44e4cc724e2f52e947e"}]}