)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nachi Ueno \u003cnachi@nttmcl.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-02-28 16:46:52 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Notify creation or deletion of dhcp port for sg"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"fixes bug 1103840"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAANH%2F%2F8SE%3D","line":7,"updated":"2013-03-04 08:29:22.000000000","message":"sg -\u003e security group\n\nThe first line is a summary of the commit, so it is better to use a word everyone understand easier.","commit_id":"db9b977a058141f1123d93e37e45772a21d24e60"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"a01f101d8e7a206e265282fc1d6623887f257b9f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nachi Ueno \u003cnachi@nttmcl.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-02-28 16:46:52 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Notify creation or deletion of dhcp port for sg"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"fixes bug 1103840"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAN3%2F%2F%2BZU%3D","line":7,"in_reply_to":"AAAANH%2F%2F8SE%3D","updated":"2013-03-04 21:36:34.000000000","message":"Done.\nHowever it exceeds 80 chars.\nhmm","commit_id":"db9b977a058141f1123d93e37e45772a21d24e60"}],"quantum/db/securitygroups_rpc_base.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"47c26abba424362ea4d4ce1b899602762d2e9f8c","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def notify_security_groups_member_updated(self, context, port):"},{"line_number":105,"context_line":"        #Note(nati): In order to allow dhcp packets,"},{"line_number":106,"context_line":"        # changes for dhcp ip should be notifified"},{"line_number":107,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"},{"line_number":108,"context_line":"            self.notifier.security_groups_provider_updated(context)"},{"line_number":109,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BBg%3D","line":106,"updated":"2013-03-01 01:42:20.000000000","message":"How about:\n\nChanges to dhcp ip should be notifified to security groups in order to allow dhcp packets?","commit_id":"db9b977a058141f1123d93e37e45772a21d24e60"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def notify_security_groups_member_updated(self, context, port):"},{"line_number":105,"context_line":"        #Note(nati): In order to allow dhcp packets,"},{"line_number":106,"context_line":"        # changes for dhcp ip should be notifified"},{"line_number":107,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"},{"line_number":108,"context_line":"            self.notifier.security_groups_provider_updated(context)"},{"line_number":109,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F73g%3D","line":106,"updated":"2013-03-03 10:12:30.000000000","message":"I do not understand the comment. notifified is a typo.","commit_id":"db9b977a058141f1123d93e37e45772a21d24e60"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"a01f101d8e7a206e265282fc1d6623887f257b9f","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def notify_security_groups_member_updated(self, context, port):"},{"line_number":105,"context_line":"        #Note(nati): In order to allow dhcp packets,"},{"line_number":106,"context_line":"        # changes for dhcp ip should be notifified"},{"line_number":107,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"},{"line_number":108,"context_line":"            self.notifier.security_groups_provider_updated(context)"},{"line_number":109,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2BY4%3D","line":106,"in_reply_to":"AAAAN3%2F%2F%2Frg%3D","updated":"2013-03-04 21:36:34.000000000","message":"Thanks Akihiro\nAdded it here.","commit_id":"db9b977a058141f1123d93e37e45772a21d24e60"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def notify_security_groups_member_updated(self, context, port):"},{"line_number":105,"context_line":"        #Note(nati): In order to allow dhcp packets,"},{"line_number":106,"context_line":"        # changes for dhcp ip should be notifified"},{"line_number":107,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"},{"line_number":108,"context_line":"            self.notifier.security_groups_provider_updated(context)"},{"line_number":109,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2Frg%3D","line":106,"in_reply_to":"AAAANH%2F%2F73g%3D","updated":"2013-03-04 08:29:22.000000000","message":"How about writing the following in the comment:\n\nThe agent setups the iptables rule to allow ingress packet from the dhcp server (as a part of provider rules), so we need to notify an update of dhcp server ip address to the plugin agent.\n\nsecurity_groups_provider_updated() just notifies that an event occurs and the plugin agent fetches the update provider rule in the other RPC call (security_group_rules_for_devices).","commit_id":"db9b977a058141f1123d93e37e45772a21d24e60"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":113,"context_line":"        rule in the other RPC call (security_group_rules_for_devices)."},{"line_number":114,"context_line":"        \"\"\""},{"line_number":115,"context_line":"        #Note(nati): In order to allow dhcp packets,"},{"line_number":116,"context_line":"        # changes for dhcp ip should be notifified"},{"line_number":117,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"},{"line_number":118,"context_line":"            self.notifier.security_groups_provider_updated(context)"},{"line_number":119,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F7Cw%3D","line":116,"updated":"2013-03-06 09:54:03.000000000","message":"I agree with Akihiro the comment should be dropped. There is also a typo with it.","commit_id":"9e78c6835774d11c3201c99c61cf59e6f39d9f74"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":113,"context_line":"        rule in the other RPC call (security_group_rules_for_devices)."},{"line_number":114,"context_line":"        \"\"\""},{"line_number":115,"context_line":"        #Note(nati): In order to allow dhcp packets,"},{"line_number":116,"context_line":"        # changes for dhcp ip should be notifified"},{"line_number":117,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"},{"line_number":118,"context_line":"            self.notifier.security_groups_provider_updated(context)"},{"line_number":119,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F7G0%3D","line":116,"updated":"2013-03-06 09:05:28.000000000","message":"This note looks no longer necessary.","commit_id":"9e78c6835774d11c3201c99c61cf59e6f39d9f74"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"a01f101d8e7a206e265282fc1d6623887f257b9f","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        rule in the other RPC call (security_group_rules_for_devices)."},{"line_number":114,"context_line":"        \"\"\""},{"line_number":115,"context_line":"        #Note(nati): In order to allow dhcp packets,"},{"line_number":116,"context_line":"        # changes for dhcp ip should be notifified"},{"line_number":117,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d q_const.DEVICE_OWNER_DHCP:"},{"line_number":118,"context_line":"            self.notifier.security_groups_provider_updated(context)"},{"line_number":119,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F6dY%3D","line":116,"in_reply_to":"AAAAN3%2F%2F7Cw%3D","updated":"2013-03-06 18:51:51.000000000","message":"Thanks Done","commit_id":"9e78c6835774d11c3201c99c61cf59e6f39d9f74"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def notify_security_groups_member_updated(self, context, port):"},{"line_number":105,"context_line":"        \"\"\" notify update event of security group members"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        The agent setups the iptables rule to allow"},{"line_number":108,"context_line":"        ingress packet from the dhcp server (as a part of provider rules),"},{"line_number":109,"context_line":"        so we need to notify an update of dhcp server ip"},{"line_number":110,"context_line":"        address to the plugin agent."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F5X0%3D","line":107,"updated":"2013-03-07 06:47:23.000000000","message":"setups \u003d\u003e sets up","commit_id":"705dde46dd17caa03617b17609b6e935dc875948"}],"quantum/plugins/linuxbridge/lb_quantum_plugin.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":519,"context_line":"            need_port_update_notify \u003d True"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        if need_port_update_notify:"},{"line_number":522,"context_line":"            self._notify_port_updated(context, updated_port)"},{"line_number":523,"context_line":"        return self._extend_port_dict_binding(context, updated_port)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    def delete_port(self, context, id, l3_port_check\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2Frc%3D","line":522,"updated":"2013-03-04 08:29:22.000000000","message":"Don\u0027t we need to notify an event that an IP address of dhcp aserver is changed? (I don\u0027t know it is supported to change an IP address of dhcp server)","commit_id":"db9b977a058141f1123d93e37e45772a21d24e60"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":519,"context_line":"            need_port_update_notify \u003d True"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        if need_port_update_notify:"},{"line_number":522,"context_line":"            self._notify_port_updated(context, updated_port)"},{"line_number":523,"context_line":"        return self._extend_port_dict_binding(context, updated_port)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    def delete_port(self, context, id, l3_port_check\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F7HA%3D","line":522,"in_reply_to":"AAAAN3%2F%2F%2BYI%3D","updated":"2013-03-06 09:03:30.000000000","message":"We can change fixed ip of dhcp port but the ip address used by dnsmasq is still unchaged. Thus it looks better to keep the code here unchanged.","commit_id":"db9b977a058141f1123d93e37e45772a21d24e60"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"a01f101d8e7a206e265282fc1d6623887f257b9f","unresolved":false,"context_lines":[{"line_number":519,"context_line":"            need_port_update_notify \u003d True"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        if need_port_update_notify:"},{"line_number":522,"context_line":"            self._notify_port_updated(context, updated_port)"},{"line_number":523,"context_line":"        return self._extend_port_dict_binding(context, updated_port)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    def delete_port(self, context, id, l3_port_check\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2BYI%3D","line":522,"in_reply_to":"AAAAN3%2F%2F%2Frc%3D","updated":"2013-03-04 21:36:34.000000000","message":"Now, We can also update fixed ip of dhcp port.\nSo we need to discuss about the correct spec.","commit_id":"db9b977a058141f1123d93e37e45772a21d24e60"}]}