)]}'
{"neutron/tests/tools.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"87f310ba53553a59a6648308c1114837d894bc5c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                \"always\", category\u003dwtype, module\u003d\u0027^neutron\\\\.\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class FileFixture(fixtures.Fixture):"},{"line_number":72,"context_line":"    \"\"\"Mock access to a specific file while preserving open for others.\"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, filepath, contents\u003d\u0027\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_4ed050f6","line":71,"updated":"2015-10-09 09:30:28.000000000","message":"FileFixture is confusing as it mocks open() not file(), OpenFixture seems better","commit_id":"a1be7290fc9815bcb567481496f4f8464906374a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e8ea4b71d88d316306420f4ef38b1865757574df","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                \"always\", category\u003dwtype, module\u003d\u0027^neutron\\\\.\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class FileFixture(fixtures.Fixture):"},{"line_number":72,"context_line":"    \"\"\"Mock access to a specific file while preserving open for others.\"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, filepath, contents\u003d\u0027\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_673d148e","line":71,"in_reply_to":"7a2fa921_4ed050f6","updated":"2015-10-09 18:47:22.000000000","message":"Done","commit_id":"a1be7290fc9815bcb567481496f4f8464906374a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"87f310ba53553a59a6648308c1114837d894bc5c","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, filepath, contents\u003d\u0027\u0027):"},{"line_number":75,"context_line":"        self.path \u003d filepath"},{"line_number":76,"context_line":"        self.mock_open \u003d mock.mock_open(read_data\u003dcontents)"},{"line_number":77,"context_line":"        self._orig_open \u003d open"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        def replacement_open(name, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_0e5d7814","line":76,"updated":"2015-10-09 09:30:28.000000000","message":"i would prefer we perform lazily such setup in _setUp as it\u0027s done in fixtures(package) and neutron fixtures. It disallows to do:\n\n FileFixture(...).mock_open\n\nwhich is imo an incorrect usage","commit_id":"a1be7290fc9815bcb567481496f4f8464906374a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"28a0127cd7b6e9b1b2b2142c06f1088c6fec1fa7","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, filepath, contents\u003d\u0027\u0027):"},{"line_number":75,"context_line":"        self.path \u003d filepath"},{"line_number":76,"context_line":"        self.mock_open \u003d mock.mock_open(read_data\u003dcontents)"},{"line_number":77,"context_line":"        self._orig_open \u003d open"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        def replacement_open(name, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_990f7836","line":76,"in_reply_to":"7a2fa921_0740e005","updated":"2015-10-09 19:30:50.000000000","message":"It doesn\u0027t look like you addressed Cedric\u0027s comment entirely? He believes that FileFixture(...).mock_open is not a good pattern.","commit_id":"a1be7290fc9815bcb567481496f4f8464906374a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e8ea4b71d88d316306420f4ef38b1865757574df","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, filepath, contents\u003d\u0027\u0027):"},{"line_number":75,"context_line":"        self.path \u003d filepath"},{"line_number":76,"context_line":"        self.mock_open \u003d mock.mock_open(read_data\u003dcontents)"},{"line_number":77,"context_line":"        self._orig_open \u003d open"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        def replacement_open(name, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_0740e005","line":76,"in_reply_to":"7a2fa921_0e5d7814","updated":"2015-10-09 18:47:22.000000000","message":"Done","commit_id":"a1be7290fc9815bcb567481496f4f8464906374a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7b0146e84eab91fe46b233c70c4972c883363ebb","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, filepath, contents\u003d\u0027\u0027):"},{"line_number":75,"context_line":"        self.path \u003d filepath"},{"line_number":76,"context_line":"        self.mock_open \u003d mock.mock_open(read_data\u003dcontents)"},{"line_number":77,"context_line":"        self._orig_open \u003d open"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        def replacement_open(name, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_39688b87","line":76,"in_reply_to":"7a2fa921_5c19ce20","updated":"2015-10-11 17:34:55.000000000","message":"Exactly, the fixture is \"active\" after setUp not after __init__ so we should avoid its usage before setUp (commonly done by self.useFixture). It also helps to detect the common wrong usage:\n\n MyFixture().attribute\n # it should be:\n self.useFixture(MyFixture()).attribute\n\nwhich could be (at least for me) quite difficult to find!","commit_id":"a1be7290fc9815bcb567481496f4f8464906374a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"33dc62b2729372bc059c96a1540e19ead1d67b62","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, filepath, contents\u003d\u0027\u0027):"},{"line_number":75,"context_line":"        self.path \u003d filepath"},{"line_number":76,"context_line":"        self.mock_open \u003d mock.mock_open(read_data\u003dcontents)"},{"line_number":77,"context_line":"        self._orig_open \u003d open"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        def replacement_open(name, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_5c19ce20","line":76,"in_reply_to":"7a2fa921_990f7836","updated":"2015-10-09 19:40:31.000000000","message":"I think he meant it\u0027s not a good pattern to have access to the resource until it\u0027s setup. I didn\u0027t think he meant it was a bad pattern to have access to the fixture at all...","commit_id":"a1be7290fc9815bcb567481496f4f8464906374a"}]}
