)]}'
{"HACKING.rst":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"0e86faa2ed8fe55f33f10a3361ff4c0f71bdf290","unresolved":false,"context_lines":[{"line_number":18,"context_line":"- [N326] Python 3: do not use basestring."},{"line_number":19,"context_line":"- [N327] Python 3: do not use dict.iteritems."},{"line_number":20,"context_line":"- [N328] Detect wrong usage with assertEqual"},{"line_number":21,"context_line":"- [N329] Detect a case using assertTrue/False to check value in list"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Creating Unit Tests"},{"line_number":24,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da85f559_0143f113","line":21,"updated":"2015-11-12 13:29:00.000000000","message":"HACKING.rst already has N329 in it: https://github.com/openstack/neutron/blob/master/HACKING.rst Could you rebase your patchset to update it?","commit_id":"64e7849f05eff68e01425c13c951d1857b2bff8b"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0e0196b1a6e2cee30cd4815f91a270543945c7a0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"- [N326] Python 3: do not use basestring."},{"line_number":19,"context_line":"- [N327] Python 3: do not use dict.iteritems."},{"line_number":20,"context_line":"- [N328] Detect wrong usage with assertEqual"},{"line_number":21,"context_line":"- [N329] Detect a case using assertTrue/False to check value in list"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Creating Unit Tests"},{"line_number":24,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da85f559_32f1a56b","line":21,"in_reply_to":"da85f559_0143f113","updated":"2015-11-12 14:12:26.000000000","message":"I will update.","commit_id":"64e7849f05eff68e01425c13c951d1857b2bff8b"}],"neutron/hacking/checks.py":[{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"e9e204f87a4d06429f5363e04ffa5d05a4f9d946","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        if re.search(r\"assertTrue\\(\\s*[^(for)]*\\ in\\ [^)]*(,[^,]*)?\\)\","},{"line_number":248,"context_line":"                     logical_line):"},{"line_number":249,"context_line":"            msg \u003d (\"N333: Use assertIn(value, list) instead of \""},{"line_number":250,"context_line":"                   \"assertTrue(value in list)\")"},{"line_number":251,"context_line":"            yield (0, msg)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_abfebfab","line":250,"updated":"2016-01-31 05:55:13.000000000","message":"I think regExp in L247 will not match case:\n  assertTrue(X in [..])\nbut also match:\n  assertTrue(X in set(..))\n  assertTrue(X in tuple(..))\n\ncan you update msg here?","commit_id":"89f4bb98113f0b83a7b9340cf059bb2646c48c29"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"e9e204f87a4d06429f5363e04ffa5d05a4f9d946","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        if re.search(r\"assertFalse\\(\\s*[^(for)]*\\ in\\ [^)]*(,[^,]*)?\\)\","},{"line_number":257,"context_line":"                     logical_line):"},{"line_number":258,"context_line":"            msg \u003d (\"N333: Use assertNotIn(value, list) instead of \""},{"line_number":259,"context_line":"                   \"assertFalse(value in list)\")"},{"line_number":260,"context_line":"            yield (0, msg)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_6b33e7ab","line":259,"updated":"2016-01-31 05:55:13.000000000","message":"ditto","commit_id":"89f4bb98113f0b83a7b9340cf059bb2646c48c29"}]}