)]}'
{"etc/dhcp_agent.ini":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"3fc6e11d68908502f23989a64fab5496bac433a7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# enable_metadata_network \u003d False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# The Quantum DHCP agent manager."},{"line_number":45,"context_line":"# dhcp_agent_manager \u003d quantum.agent.dhcp_agent.DhcpAgentWithStateReport"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAN3%2F%2F%2F1I%3D","line":45,"updated":"2013-03-04 01:47:30.000000000","message":"I\u0027m confused why this flag is still needed.  Couldn\u0027t we now just have the agents do the same thing regardless, and the agent will work with the plugin either way.","commit_id":"d3e3710f272d9bbfcdd2e75adeb82e75b035da2c"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"# enable_metadata_network \u003d False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# The Quantum DHCP agent manager."},{"line_number":45,"context_line":"# dhcp_agent_manager \u003d quantum.agent.dhcp_agent.DhcpAgentWithStateReport"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAN3%2F%2F%2Fw8%3D","line":45,"in_reply_to":"AAAAN3%2F%2F%2F0c%3D","updated":"2013-03-04 05:08:39.000000000","message":"I guess my question is whether we need to have the old DhcpAgent at all anymore, if DhcpAgentWithStateReport knows to fall back.  Ideally, I think we don\u0027t have to expose this complexity to the user and could just always use the DhcpAgentWithStateReport mechanism, knowing that it will fall-back when appropriate.  Or does that not work for some reason?","commit_id":"d3e3710f272d9bbfcdd2e75adeb82e75b035da2c"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"af9709c405e7a48cfd035eea99b8feb50fcbb78a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# enable_metadata_network \u003d False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# The Quantum DHCP agent manager."},{"line_number":45,"context_line":"# dhcp_agent_manager \u003d quantum.agent.dhcp_agent.DhcpAgentWithStateReport"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAN3%2F%2F%2F0c%3D","line":45,"in_reply_to":"AAAAN3%2F%2F%2F1I%3D","updated":"2013-03-04 02:16:46.000000000","message":"DhcpAgentWithStateReport has the ability to fall back to normal DhcpAgent.\nDhcpAgent is not as smart.","commit_id":"d3e3710f272d9bbfcdd2e75adeb82e75b035da2c"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"# enable_metadata_network \u003d False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# The Quantum DHCP agent manager."},{"line_number":45,"context_line":"# dhcp_agent_manager \u003d quantum.agent.dhcp_agent.DhcpAgentWithStateReport"}],"source_content_type":"text/x-properties","patch_set":2,"id":"AAAAN3%2F%2F%2FwQ%3D","line":45,"in_reply_to":"AAAAN3%2F%2F%2Fw8%3D","updated":"2013-03-04 05:31:36.000000000","message":"our framework is able to allow user to use another manager. these managers can be developed by themselves.  We can see the advantages that nova gives developers with this configurable options.","commit_id":"d3e3710f272d9bbfcdd2e75adeb82e75b035da2c"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"fe78ffaa57fcce0801c929a6154e5504c34ade32","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# enable_metadata_network \u003d False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# The Quantum DHCP agent manager."},{"line_number":45,"context_line":"# dhcp_agent_manager \u003d quantum.agent.dhcp_agent.DhcpAgentWithStateReport"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAN3%2F%2F%2Fyk%3D","line":45,"updated":"2013-03-04 03:12:17.000000000","message":"We also can delete this option. \u0027DhcpAgentWithStateReport\u0027 can instead of \u0027DhcpAgent\u0027 totally. So it needn\u0027t second choice for this option","commit_id":"5cba598a9023e4ead9a4bd6735c588c23e8718bf"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"# enable_metadata_network \u003d False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# The Quantum DHCP agent manager."},{"line_number":45,"context_line":"# dhcp_agent_manager \u003d quantum.agent.dhcp_agent.DhcpAgentWithStateReport"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAN3%2F%2F%2FwY%3D","line":45,"in_reply_to":"AAAAN3%2F%2F%2Fyk%3D","updated":"2013-03-04 05:29:06.000000000","message":"keep this opt is good to third part to extend the manager or use another manager.","commit_id":"5cba598a9023e4ead9a4bd6735c588c23e8718bf"}],"quantum/agent/dhcp_agent.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":682,"context_line":"                                        self.agent_state)"},{"line_number":683,"context_line":"        except AttributeError:"},{"line_number":684,"context_line":"            # This means the server does not support report_state"},{"line_number":685,"context_line":"            LOG.warn(_(\"Quantum server does not support state report.\"))"},{"line_number":686,"context_line":"            self.heartbeat.stop()"},{"line_number":687,"context_line":"            self.run()"},{"line_number":688,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F%2FtQ%3D","line":685,"updated":"2013-03-04 06:57:44.000000000","message":"It is better to add \"Disabled state reports\".","commit_id":"5cba598a9023e4ead9a4bd6735c588c23e8718bf"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":682,"context_line":"                                        self.agent_state)"},{"line_number":683,"context_line":"        except AttributeError:"},{"line_number":684,"context_line":"            # This means the server does not support report_state"},{"line_number":685,"context_line":"            LOG.warn(_(\"Quantum server does not support state report.\"))"},{"line_number":686,"context_line":"            self.heartbeat.stop()"},{"line_number":687,"context_line":"            self.run()"},{"line_number":688,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F%2FqU%3D","line":685,"in_reply_to":"AAAAN3%2F%2F%2FtQ%3D","updated":"2013-03-04 08:46:28.000000000","message":"Done","commit_id":"5cba598a9023e4ead9a4bd6735c588c23e8718bf"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"fe78ffaa57fcce0801c929a6154e5504c34ade32","unresolved":false,"context_lines":[{"line_number":684,"context_line":"            # This means the server does not support report_state"},{"line_number":685,"context_line":"            LOG.warn(_(\"Quantum server does not support state report.\"))"},{"line_number":686,"context_line":"            self.heartbeat.stop()"},{"line_number":687,"context_line":"            self.run()"},{"line_number":688,"context_line":"            return"},{"line_number":689,"context_line":"        except Exception:"},{"line_number":690,"context_line":"            LOG.exception(_(\"Failed reporting state!\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F%2FzA%3D","line":687,"updated":"2013-03-04 03:06:56.000000000","message":"line 693 exec \u0027self.run\u0027 too, we can just stop heartbeat at here and needn\u0027t return at line 688","commit_id":"5cba598a9023e4ead9a4bd6735c588c23e8718bf"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":684,"context_line":"            # This means the server does not support report_state"},{"line_number":685,"context_line":"            LOG.warn(_(\"Quantum server does not support state report.\"))"},{"line_number":686,"context_line":"            self.heartbeat.stop()"},{"line_number":687,"context_line":"            self.run()"},{"line_number":688,"context_line":"            return"},{"line_number":689,"context_line":"        except Exception:"},{"line_number":690,"context_line":"            LOG.exception(_(\"Failed reporting state!\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F%2Fwc%3D","line":687,"in_reply_to":"AAAAN3%2F%2F%2FzA%3D","updated":"2013-03-04 05:29:06.000000000","message":"lines after 692 is to be run after reporting state successfully. I don\u0027t want to mix these together.","commit_id":"5cba598a9023e4ead9a4bd6735c588c23e8718bf"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":38,"context_line":"from quantum.openstack.common import jsonutils"},{"line_number":39,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":40,"context_line":"from quantum.openstack.common import loopingcall"},{"line_number":41,"context_line":"from quantum.openstack.common.rpc import common as rpc_common"},{"line_number":42,"context_line":"from quantum.openstack.common.rpc import proxy"},{"line_number":43,"context_line":"from quantum.openstack.common import service"},{"line_number":44,"context_line":"from quantum.openstack.common import uuidutils"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F%2Fok%3D","line":41,"updated":"2013-03-04 09:19:32.000000000","message":"why?","commit_id":"835471f28e84e9a95250734e46d9125c920838fa"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":682,"context_line":"            LOG.warn(_(\"Quantum server does not support state report.\""},{"line_number":683,"context_line":"                       \" State report for this agent will be disabled.\"))"},{"line_number":684,"context_line":"            self.heartbeat.stop()"},{"line_number":685,"context_line":"            self.run()"},{"line_number":686,"context_line":"            return"},{"line_number":687,"context_line":"        except Exception:"},{"line_number":688,"context_line":"            LOG.exception(_(\"Failed reporting state!\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F%2Fo0%3D","line":685,"updated":"2013-03-04 09:19:32.000000000","message":"The above line seems unnecessary (start_flag is there and equal to True even if report_state is not defined on the server).\n\nAddressing this comment is not mandatory.","commit_id":"835471f28e84e9a95250734e46d9125c920838fa"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":682,"context_line":"            LOG.warn(_(\"Quantum server does not support state report.\""},{"line_number":683,"context_line":"                       \" State report for this agent will be disabled.\"))"},{"line_number":684,"context_line":"            self.heartbeat.stop()"},{"line_number":685,"context_line":"            self.run()"},{"line_number":686,"context_line":"            return"},{"line_number":687,"context_line":"        except Exception:"},{"line_number":688,"context_line":"            LOG.exception(_(\"Failed reporting state!\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F%2Fho%3D","line":685,"in_reply_to":"AAAAN3%2F%2F%2Fh0%3D","updated":"2013-03-04 11:38:57.000000000","message":"I was just thinking that if you do not return at line 686 line 691 would be executed anyway.\n\nAs I said - there\u0027s no need to address it.","commit_id":"835471f28e84e9a95250734e46d9125c920838fa"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":682,"context_line":"            LOG.warn(_(\"Quantum server does not support state report.\""},{"line_number":683,"context_line":"                       \" State report for this agent will be disabled.\"))"},{"line_number":684,"context_line":"            self.heartbeat.stop()"},{"line_number":685,"context_line":"            self.run()"},{"line_number":686,"context_line":"            return"},{"line_number":687,"context_line":"        except Exception:"},{"line_number":688,"context_line":"            LOG.exception(_(\"Failed reporting state!\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F%2Fgo%3D","line":685,"in_reply_to":"AAAAN3%2F%2F%2FhQ%3D","updated":"2013-03-04 11:54:46.000000000","message":"ok no worries","commit_id":"835471f28e84e9a95250734e46d9125c920838fa"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":682,"context_line":"            LOG.warn(_(\"Quantum server does not support state report.\""},{"line_number":683,"context_line":"                       \" State report for this agent will be disabled.\"))"},{"line_number":684,"context_line":"            self.heartbeat.stop()"},{"line_number":685,"context_line":"            self.run()"},{"line_number":686,"context_line":"            return"},{"line_number":687,"context_line":"        except Exception:"},{"line_number":688,"context_line":"            LOG.exception(_(\"Failed reporting state!\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F%2FhQ%3D","line":685,"in_reply_to":"AAAAN3%2F%2F%2Fho%3D","updated":"2013-03-04 11:42:49.000000000","message":"I have answered alex xu. I just want to terminate the disable logic as quick as it runs. After line 686, all logic is for normal report_state logic. So Line 690 means if we report the first state successfully, we can remove this start_flag, and start the network sync logic. remove Line 686 will pollute it.","commit_id":"835471f28e84e9a95250734e46d9125c920838fa"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":682,"context_line":"            LOG.warn(_(\"Quantum server does not support state report.\""},{"line_number":683,"context_line":"                       \" State report for this agent will be disabled.\"))"},{"line_number":684,"context_line":"            self.heartbeat.stop()"},{"line_number":685,"context_line":"            self.run()"},{"line_number":686,"context_line":"            return"},{"line_number":687,"context_line":"        except Exception:"},{"line_number":688,"context_line":"            LOG.exception(_(\"Failed reporting state!\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F%2Fh0%3D","line":685,"in_reply_to":"AAAAN3%2F%2F%2Fo0%3D","updated":"2013-03-04 11:37:10.000000000","message":"which is not necessary? Line 685?","commit_id":"835471f28e84e9a95250734e46d9125c920838fa"}],"quantum/agent/rpc.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":57,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def report_state(self, context, agent_state):"},{"line_number":60,"context_line":"        return self.call(context,"},{"line_number":61,"context_line":"                         self.make_msg(\u0027report_state\u0027,"},{"line_number":62,"context_line":"                                       agent_state\u003d{\u0027agent_state\u0027:"},{"line_number":63,"context_line":"                                                    agent_state}),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F%2FxI%3D","line":60,"updated":"2013-03-04 06:57:44.000000000","message":"It is not related to the bug directly, but I do not think it should be done in a separate patch. Instead it should be described in the commit message.","commit_id":"5cba598a9023e4ead9a4bd6735c588c23e8718bf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":57,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def report_state(self, context, agent_state):"},{"line_number":60,"context_line":"        return self.call(context,"},{"line_number":61,"context_line":"                         self.make_msg(\u0027report_state\u0027,"},{"line_number":62,"context_line":"                                       agent_state\u003d{\u0027agent_state\u0027:"},{"line_number":63,"context_line":"                                                    agent_state}),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F%2Fos%3D","line":60,"in_reply_to":"AAAAN3%2F%2F%2Fqg%3D","updated":"2013-03-04 09:16:17.000000000","message":"I got it. Changing to call() is reasonable.","commit_id":"5cba598a9023e4ead9a4bd6735c588c23e8718bf"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":57,"context_line":"            topic\u003dtopic, default_version\u003dself.BASE_RPC_API_VERSION)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def report_state(self, context, agent_state):"},{"line_number":60,"context_line":"        return self.call(context,"},{"line_number":61,"context_line":"                         self.make_msg(\u0027report_state\u0027,"},{"line_number":62,"context_line":"                                       agent_state\u003d{\u0027agent_state\u0027:"},{"line_number":63,"context_line":"                                                    agent_state}),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F%2Fqg%3D","line":60,"in_reply_to":"AAAAN3%2F%2F%2FxI%3D","updated":"2013-03-04 08:46:28.000000000","message":"call does not return the Exception, So I put it into cast.","commit_id":"5cba598a9023e4ead9a4bd6735c588c23e8718bf"}]}