)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"unresolved":false,"context_lines":[{"line_number":9,"context_line":"Bug #1144370"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"we add argv[1:] to cfg.CONF() because cfg.CONF.log_opt_values"},{"line_number":12,"context_line":"cannot print the command line right without it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I35ac570dd55006d0133736588f0302d6f70294de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAN3%2F%2F9Xg%3D","line":12,"updated":"2013-03-05 08:27:06.000000000","message":"Doesn\u0027t make any sense to me, cfg should be defaulting to sys.argv[1:] if you don\u0027t pass any args:\n\n  :param args: command line arguments (defaults to sys.argv[1:])","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Bug #1144370"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"we add argv[1:] to cfg.CONF() because cfg.CONF.log_opt_values"},{"line_number":12,"context_line":"cannot print the command line right without it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I35ac570dd55006d0133736588f0302d6f70294de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAN3%2F%2F9Tc%3D","line":12,"in_reply_to":"AAAAN3%2F%2F9Xg%3D","updated":"2013-03-05 08:58:42.000000000","message":"with and without does mean difference in the current cfg implementation. see my inline comment.","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"}],"quantum/agent/common/agent_utils.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack LLC"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F5iM%3D","line":1,"updated":"2013-03-07 04:59:27.000000000","message":"This method should go in quantum/agent/common/config.py  I don\u0027t see the need for a new module.","commit_id":"e2316b1ee82d01e14885342145a6ce9c02912392"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack LLC"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F3io%3D","line":1,"in_reply_to":"AAAAN3%2F%2F43w%3D","updated":"2013-03-08 06:50:46.000000000","message":"I got it. I second Mark\u0027s suggestion.","commit_id":"e2316b1ee82d01e14885342145a6ce9c02912392"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack LLC"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F43w%3D","line":1,"in_reply_to":"AAAAN3%2F%2F5AQ%3D","updated":"2013-03-07 15:55:42.000000000","message":"The method extracts information from a config object.  Placing it in the config.py module groups it with related functions.","commit_id":"e2316b1ee82d01e14885342145a6ce9c02912392"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack LLC"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F5AQ%3D","line":1,"in_reply_to":"AAAAN3%2F%2F5XM%3D","updated":"2013-03-07 14:12:51.000000000","message":"I think utils and config are different things.\n\nRegarding the file name I prefer to renaming it to agent/common/utils.py, but the current filename is okay.","commit_id":"e2316b1ee82d01e14885342145a6ce9c02912392"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack LLC"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F5XM%3D","line":1,"in_reply_to":"AAAAN3%2F%2F5iM%3D","updated":"2013-03-07 07:12:50.000000000","message":"I thing the config is for config stuff. If u think it is a place, let me do it.","commit_id":"e2316b1ee82d01e14885342145a6ce9c02912392"}],"quantum/agent/dhcp_agent.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":288,"context_line":"                         \u0027--state_path\u003d%s\u0027 % self.conf.state_path,"},{"line_number":289,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":290,"context_line":"            if cfg.CONF.debug and (cfg.CONF.log_dir or"},{"line_number":291,"context_line":"                                   cfg.CONF.log_file):"},{"line_number":292,"context_line":"                proxy_cmd.append(\u0027--log-file\u003dquantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":293,"context_line":"                                 network.id)"},{"line_number":294,"context_line":"            return proxy_cmd"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2BJU%3D","line":291,"updated":"2013-03-04 23:50:08.000000000","message":"nit: I prefer have a helper method here which doing same check.","commit_id":"919d4e46a90ad09bfdda30c959ae7a4dc83c05c5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c347c10311297fe07b06f45bb853fdf24db68e04","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":290,"context_line":"            if cfg.CONF.debug and (cfg.CONF.log_dir or"},{"line_number":291,"context_line":"                                   cfg.CONF.log_file):"},{"line_number":292,"context_line":"                proxy_cmd.append(\u0027--log-file\u003dquantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":293,"context_line":"                                 network.id)"},{"line_number":294,"context_line":"            return proxy_cmd"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2Fbc%3D","line":292,"updated":"2013-03-04 13:48:17.000000000","message":"When cfg.CONF.log_dir is not specified and cfg.CONF.log_file is an absolute path, I think we need to extract the base directory from cfg.CONF.log_file.","commit_id":"919d4e46a90ad09bfdda30c959ae7a4dc83c05c5"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":290,"context_line":"            if cfg.CONF.debug and (cfg.CONF.log_dir or"},{"line_number":291,"context_line":"                                   cfg.CONF.log_file):"},{"line_number":292,"context_line":"                proxy_cmd.append(\u0027--log-file\u003dquantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":293,"context_line":"                                 network.id)"},{"line_number":294,"context_line":"            return proxy_cmd"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2BcE%3D","line":292,"in_reply_to":"AAAAN3%2F%2F%2Fbc%3D","updated":"2013-03-04 21:02:50.000000000","message":"This is default behavior of common log, please have a look at log.py of quantum.openstack.common.","commit_id":"919d4e46a90ad09bfdda30c959ae7a4dc83c05c5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c347c10311297fe07b06f45bb853fdf24db68e04","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            if cfg.CONF.debug and (cfg.CONF.log_dir or"},{"line_number":291,"context_line":"                                   cfg.CONF.log_file):"},{"line_number":292,"context_line":"                proxy_cmd.append(\u0027--log-file\u003dquantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":293,"context_line":"                                 network.id)"},{"line_number":294,"context_line":"            return proxy_cmd"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        pm \u003d external_process.ProcessManager("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FbQ%3D","line":293,"updated":"2013-03-04 13:48:17.000000000","message":"Don\u0027t we need to take care of router.id?","commit_id":"919d4e46a90ad09bfdda30c959ae7a4dc83c05c5"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            if cfg.CONF.debug and (cfg.CONF.log_dir or"},{"line_number":291,"context_line":"                                   cfg.CONF.log_file):"},{"line_number":292,"context_line":"                proxy_cmd.append(\u0027--log-file\u003dquantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":293,"context_line":"                                 network.id)"},{"line_number":294,"context_line":"            return proxy_cmd"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        pm \u003d external_process.ProcessManager("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2BcU%3D","line":293,"in_reply_to":"AAAAN3%2F%2F%2FbQ%3D","updated":"2013-03-04 21:02:50.000000000","message":"that is just part of name used to make difference and avoid to override other log files","commit_id":"919d4e46a90ad09bfdda30c959ae7a4dc83c05c5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":288,"context_line":"                         quantum_lookup_param,"},{"line_number":289,"context_line":"                         \u0027--state_path\u003d%s\u0027 % self.conf.state_path,"},{"line_number":290,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":291,"context_line":"            if cfg.CONF.debug:"},{"line_number":292,"context_line":"                proxy_cmd.append(\u0027--debug\u0027)"},{"line_number":293,"context_line":"                if (cfg.CONF.log_dir or cfg.CONF.log_file):"},{"line_number":294,"context_line":"                    proxy_cmd.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9jE%3D","line":291,"updated":"2013-03-05 06:46:38.000000000","message":"Why is the logging done when the debug flag is set?","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                         quantum_lookup_param,"},{"line_number":289,"context_line":"                         \u0027--state_path\u003d%s\u0027 % self.conf.state_path,"},{"line_number":290,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":291,"context_line":"            if cfg.CONF.debug:"},{"line_number":292,"context_line":"                proxy_cmd.append(\u0027--debug\u0027)"},{"line_number":293,"context_line":"                if (cfg.CONF.log_dir or cfg.CONF.log_file):"},{"line_number":294,"context_line":"                    proxy_cmd.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9hc%3D","line":291,"in_reply_to":"AAAAN3%2F%2F9jE%3D","updated":"2013-03-05 06:58:03.000000000","message":"ah, good question, warn also should have it.","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"unresolved":false,"context_lines":[{"line_number":296,"context_line":"                        network.id)"},{"line_number":297,"context_line":"                if cfg.CONF.log_dir:"},{"line_number":298,"context_line":"                    proxy_cmd.append(\u0027--log-dir\u003d%s\u0027 % cfg.CONF.log_dir)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"            return proxy_cmd"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        pm \u003d external_process.ProcessManager("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9XI%3D","line":299,"updated":"2013-03-05 08:27:06.000000000","message":"These changes aren\u0027t described in the commit message","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                        network.id)"},{"line_number":297,"context_line":"                if cfg.CONF.log_dir:"},{"line_number":298,"context_line":"                    proxy_cmd.append(\u0027--log-dir\u003d%s\u0027 % cfg.CONF.log_dir)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"            return proxy_cmd"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        pm \u003d external_process.ProcessManager("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9UA%3D","line":299,"in_reply_to":"AAAAN3%2F%2F9XI%3D","updated":"2013-03-05 08:58:42.000000000","message":"This is for subprocess to have a log set right. so the commit topic should have contained this.","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":288,"context_line":"                         quantum_lookup_param,"},{"line_number":289,"context_line":"                         \u0027--state_path\u003d%s\u0027 % self.conf.state_path,"},{"line_number":290,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":291,"context_line":"            if cfg.CONF.debug:"},{"line_number":292,"context_line":"                proxy_cmd.append(\u0027--debug\u0027)"},{"line_number":293,"context_line":"            if (cfg.CONF.log_dir or cfg.CONF.log_file):"},{"line_number":294,"context_line":"                proxy_cmd.append("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F7M8%3D","line":291,"updated":"2013-03-06 07:19:21.000000000","message":"please add in verbose support too","commit_id":"76d5bf1d8d4bf59a66ac55e93f68d88de655fad6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                         quantum_lookup_param,"},{"line_number":289,"context_line":"                         \u0027--state_path\u003d%s\u0027 % self.conf.state_path,"},{"line_number":290,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":291,"context_line":"            if cfg.CONF.debug:"},{"line_number":292,"context_line":"                proxy_cmd.append(\u0027--debug\u0027)"},{"line_number":293,"context_line":"            if (cfg.CONF.log_dir or cfg.CONF.log_file):"},{"line_number":294,"context_line":"                proxy_cmd.append("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F7HM%3D","line":291,"in_reply_to":"AAAAN3%2F%2F7M8%3D","updated":"2013-03-06 09:47:12.000000000","message":"Done","commit_id":"76d5bf1d8d4bf59a66ac55e93f68d88de655fad6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":292,"context_line":"                proxy_cmd.append(\u0027--debug\u0027)"},{"line_number":293,"context_line":"            if (cfg.CONF.log_dir or cfg.CONF.log_file):"},{"line_number":294,"context_line":"                proxy_cmd.append("},{"line_number":295,"context_line":"                    \u0027--log-file\u003dquantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":296,"context_line":"                    network.id)"},{"line_number":297,"context_line":"            if cfg.CONF.log_dir:"},{"line_number":298,"context_line":"                proxy_cmd.append(\u0027--log-dir\u003d%s\u0027 % cfg.CONF.log_dir)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F7M4%3D","line":295,"updated":"2013-03-06 07:19:21.000000000","message":"one minor issue here\n\nsay we have --log-file\u003d/var/log/quantum/mylog.log\n\nThis code will not write to the log directory it will write the log to the current directory.\n\nI think that this is a problem.","commit_id":"76d5bf1d8d4bf59a66ac55e93f68d88de655fad6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                proxy_cmd.append(\u0027--debug\u0027)"},{"line_number":293,"context_line":"            if (cfg.CONF.log_dir or cfg.CONF.log_file):"},{"line_number":294,"context_line":"                proxy_cmd.append("},{"line_number":295,"context_line":"                    \u0027--log-file\u003dquantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":296,"context_line":"                    network.id)"},{"line_number":297,"context_line":"            if cfg.CONF.log_dir:"},{"line_number":298,"context_line":"                proxy_cmd.append(\u0027--log-dir\u003d%s\u0027 % cfg.CONF.log_dir)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F7DQ%3D","line":295,"in_reply_to":"AAAAN3%2F%2F7M4%3D","updated":"2013-03-06 09:47:12.000000000","message":"Done","commit_id":"76d5bf1d8d4bf59a66ac55e93f68d88de655fad6"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"unresolved":false,"context_lines":[{"line_number":719,"context_line":"    cfg.CONF.register_opts(DhcpLeaseRelay.OPTS)"},{"line_number":720,"context_line":"    cfg.CONF.register_opts(dhcp.OPTS)"},{"line_number":721,"context_line":"    cfg.CONF.register_opts(interface.OPTS)"},{"line_number":722,"context_line":"    cfg.CONF(args\u003dsys.argv[1:], project\u003d\u0027quantum\u0027)"},{"line_number":723,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":724,"context_line":"    server \u003d quantum_service.Service.create("},{"line_number":725,"context_line":"        binary\u003d\u0027quantum-dhcp-agent\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F7Ic%3D","line":722,"updated":"2013-03-06 08:46:18.000000000","message":"Please don\u0027t do this. Use http://tarballs.openstack.org/oslo-config/oslo.config-1.1.0b1.tar.gz instead","commit_id":"76d5bf1d8d4bf59a66ac55e93f68d88de655fad6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":719,"context_line":"    cfg.CONF.register_opts(DhcpLeaseRelay.OPTS)"},{"line_number":720,"context_line":"    cfg.CONF.register_opts(dhcp.OPTS)"},{"line_number":721,"context_line":"    cfg.CONF.register_opts(interface.OPTS)"},{"line_number":722,"context_line":"    cfg.CONF(args\u003dsys.argv[1:], project\u003d\u0027quantum\u0027)"},{"line_number":723,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":724,"context_line":"    server \u003d quantum_service.Service.create("},{"line_number":725,"context_line":"        binary\u003d\u0027quantum-dhcp-agent\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F7DM%3D","line":722,"in_reply_to":"AAAAN3%2F%2F7Ic%3D","updated":"2013-03-06 09:47:12.000000000","message":"Done","commit_id":"76d5bf1d8d4bf59a66ac55e93f68d88de655fad6"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":290,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":291,"context_line":"            proxy_cmd.extend(agent_utils.get_log_args("},{"line_number":292,"context_line":"                cfg.CONF, \u0027quantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":293,"context_line":"                network.id))"},{"line_number":294,"context_line":"            return proxy_cmd"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        pm \u003d external_process.ProcessManager("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F5iI%3D","line":293,"updated":"2013-03-07 04:59:27.000000000","message":"This is variable depending on the lookup_param in use.","commit_id":"e2316b1ee82d01e14885342145a6ce9c02912392"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":290,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":291,"context_line":"            proxy_cmd.extend(agent_utils.get_log_args("},{"line_number":292,"context_line":"                cfg.CONF, \u0027quantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":293,"context_line":"                network.id))"},{"line_number":294,"context_line":"            return proxy_cmd"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        pm \u003d external_process.ProcessManager("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F3iw%3D","line":293,"in_reply_to":"AAAAN3%2F%2F3oQ%3D","updated":"2013-03-08 06:34:53.000000000","message":"Mark,\nIt makes sense. Thanks for your detail explanation and patience. I am also relieved my basic understanding is almost correct (though my explanation might be insufficient.","commit_id":"e2316b1ee82d01e14885342145a6ce9c02912392"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":290,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":291,"context_line":"            proxy_cmd.extend(agent_utils.get_log_args("},{"line_number":292,"context_line":"                cfg.CONF, \u0027quantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":293,"context_line":"                network.id))"},{"line_number":294,"context_line":"            return proxy_cmd"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        pm \u003d external_process.ProcessManager("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F43g%3D","line":293,"in_reply_to":"AAAAN3%2F%2F4%2F8%3D","updated":"2013-03-07 15:55:42.000000000","message":"Line 298 should probably use the the same uuid too.\n\nDepending on the flag configuration and plugin used, metadata-proxy can service multiple networks.  Some of the vendors who don\u0027t run the L3 agent are using this hook to create a metadata network and attach to their logical router.","commit_id":"e2316b1ee82d01e14885342145a6ce9c02912392"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":290,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":291,"context_line":"            proxy_cmd.extend(agent_utils.get_log_args("},{"line_number":292,"context_line":"                cfg.CONF, \u0027quantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":293,"context_line":"                network.id))"},{"line_number":294,"context_line":"            return proxy_cmd"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        pm \u003d external_process.ProcessManager("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F4iQ%3D","line":293,"in_reply_to":"AAAAN3%2F%2F43g%3D","updated":"2013-03-08 01:21:43.000000000","message":"One question and one confirmation.\n\nProcessManager determines the pid file based on UUID, so L.298 and L.306 needs to match. If L.293 and L.298 should use the same value and router_id is used, L.306 also need to use router id. Is it right? If so, we need router id in disable_isolated_metadata_proxy. If a metadata-proxy invoked here corresponds to a network, it is easier to implement I think.\n\n\nLet me ask a bit more about metadata-proxy. I would like just to confirm a metadata-proxy spawned in this method services for a network or not. If my understanding is correct, a metadata-proxy here is spawned per network regardless of enable_metadata_network config. It does not depends on a plugin used.\n\nThanks,","commit_id":"e2316b1ee82d01e14885342145a6ce9c02912392"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":290,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":291,"context_line":"            proxy_cmd.extend(agent_utils.get_log_args("},{"line_number":292,"context_line":"                cfg.CONF, \u0027quantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":293,"context_line":"                network.id))"},{"line_number":294,"context_line":"            return proxy_cmd"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        pm \u003d external_process.ProcessManager("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F3oQ%3D","line":293,"in_reply_to":"AAAAN3%2F%2F4iQ%3D","updated":"2013-03-08 05:02:40.000000000","message":"Akihiro-  You make a good point about the easier implementation, so let\u0027s stay with network.id.\n\nThe second question is a little more complicated.  In most cases, the metadata proxy inside the DHCP namespace is spawned for only that network.  The special exception is some vendors are auto creating and attaching the 169.254.169.252/30 network in their implementation of the L3 Router.  This technique provides metadata service for all networks attached to the router which is why the enable_metadata_network changes the flag passed to the proxy from --network to --router when the subnet cidr is within 169.254.0.0/16.  This approach also makes alternative router implementations more straight forward.  I know there are currently no docs on this flag and I\u0027ve got to figure out a way to explain this.  Does this make sense?","commit_id":"e2316b1ee82d01e14885342145a6ce9c02912392"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":290,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":291,"context_line":"            proxy_cmd.extend(agent_utils.get_log_args("},{"line_number":292,"context_line":"                cfg.CONF, \u0027quantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":293,"context_line":"                network.id))"},{"line_number":294,"context_line":"            return proxy_cmd"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        pm \u003d external_process.ProcessManager("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F4%2F8%3D","line":293,"in_reply_to":"AAAAN3%2F%2F5XI%3D","updated":"2013-03-07 14:12:51.000000000","message":"Both network.id and router.id make sense as a log name.\n- metadata-proxy is spawned per network even when enable_metadata_network is True. From this point network.id looks reasonable.\n- metadata-proxy is associated with a router for metadata. From this point router.id looks reasonable.\n\nI prefer to network.id rather than router.id since metadata-proxy serves for not a router but a network.","commit_id":"e2316b1ee82d01e14885342145a6ce9c02912392"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":291,"context_line":"            proxy_cmd.extend(agent_utils.get_log_args("},{"line_number":292,"context_line":"                cfg.CONF, \u0027quantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":293,"context_line":"                network.id))"},{"line_number":294,"context_line":"            return proxy_cmd"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        pm \u003d external_process.ProcessManager("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F5XI%3D","line":293,"in_reply_to":"AAAAN3%2F%2F5iI%3D","updated":"2013-03-07 07:12:50.000000000","message":"I think it is just a name, why does not  line 298 use the lookup_param?","commit_id":"e2316b1ee82d01e14885342145a6ce9c02912392"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":288,"context_line":"                         \u0027--state_path\u003d%s\u0027 % self.conf.state_path,"},{"line_number":289,"context_line":"                         \u0027--metadata_port\u003d%d\u0027 % METADATA_PORT]"},{"line_number":290,"context_line":"            proxy_cmd.extend(config.get_log_args("},{"line_number":291,"context_line":"                cfg.CONF, \u0027quantum-ns-metadata-proxy%s.log\u0027 % network.id))"},{"line_number":292,"context_line":"            return proxy_cmd"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        pm \u003d external_process.ProcessManager("}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2F1fM%3D","line":291,"updated":"2013-03-10 10:38:56.000000000","message":"In fedora/rhel we do not have the prefix \u0027quantum\u0027 for the logfile name. This is due to the fact that it is in the directory /var/log/quantum.\nNot sure that this is an issue.","commit_id":"0109231fcdb3c9e850afef82ba27090a4a0178af"}],"quantum/agent/l3_agent.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":259,"context_line":"                         \u0027--router_id\u003d%s\u0027 % router_info.router_id,"},{"line_number":260,"context_line":"                         \u0027--state_path\u003d%s\u0027 % self.conf.state_path]"},{"line_number":261,"context_line":"            if cfg.CONF.debug and (cfg.CONF.log_dir or"},{"line_number":262,"context_line":"                                   cfg.CONF.log_file):"},{"line_number":263,"context_line":"                proxy_cmd.append(\u0027--log-file\u003dquantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":264,"context_line":"                                 router_info.router_id)"},{"line_number":265,"context_line":"            return proxy_cmd"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2BJQ%3D","line":262,"updated":"2013-03-04 23:50:08.000000000","message":"nit: I prefer have a helper method here which doing same check.","commit_id":"919d4e46a90ad09bfdda30c959ae7a4dc83c05c5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c347c10311297fe07b06f45bb853fdf24db68e04","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                         \u0027--state_path\u003d%s\u0027 % self.conf.state_path]"},{"line_number":261,"context_line":"            if cfg.CONF.debug and (cfg.CONF.log_dir or"},{"line_number":262,"context_line":"                                   cfg.CONF.log_file):"},{"line_number":263,"context_line":"                proxy_cmd.append(\u0027--log-file\u003dquantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":264,"context_line":"                                 router_info.router_id)"},{"line_number":265,"context_line":"            return proxy_cmd"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2Fbg%3D","line":263,"updated":"2013-03-04 13:48:17.000000000","message":"When cfg.CONF.log_dir is not specified and cfg.CONF.log_file is an absolute path, I think we need to extract the base directory from cfg.CONF.log_file.","commit_id":"919d4e46a90ad09bfdda30c959ae7a4dc83c05c5"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                         \u0027--state_path\u003d%s\u0027 % self.conf.state_path]"},{"line_number":261,"context_line":"            if cfg.CONF.debug and (cfg.CONF.log_dir or"},{"line_number":262,"context_line":"                                   cfg.CONF.log_file):"},{"line_number":263,"context_line":"                proxy_cmd.append(\u0027--log-file\u003dquantum-ns-metadata-proxy%s.log\u0027 %"},{"line_number":264,"context_line":"                                 router_info.router_id)"},{"line_number":265,"context_line":"            return proxy_cmd"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2Bb8%3D","line":263,"in_reply_to":"AAAAN3%2F%2F%2Fbg%3D","updated":"2013-03-04 21:02:50.000000000","message":"the same","commit_id":"919d4e46a90ad09bfdda30c959ae7a4dc83c05c5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":258,"context_line":"                         \u0027--pid_file\u003d%s\u0027 % pid_file,"},{"line_number":259,"context_line":"                         \u0027--router_id\u003d%s\u0027 % router_info.router_id,"},{"line_number":260,"context_line":"                         \u0027--state_path\u003d%s\u0027 % self.conf.state_path]"},{"line_number":261,"context_line":"            if cfg.CONF.debug:"},{"line_number":262,"context_line":"                proxy_cmd.append(\u0027--debug\u0027)"},{"line_number":263,"context_line":"                if (cfg.CONF.log_dir or cfg.CONF.log_file):"},{"line_number":264,"context_line":"                    proxy_cmd.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9i8%3D","line":261,"updated":"2013-03-05 06:46:38.000000000","message":"ditto\n\nis it not possible to have a generic function that will return the log parameters for the command line?","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                         \u0027--pid_file\u003d%s\u0027 % pid_file,"},{"line_number":259,"context_line":"                         \u0027--router_id\u003d%s\u0027 % router_info.router_id,"},{"line_number":260,"context_line":"                         \u0027--state_path\u003d%s\u0027 % self.conf.state_path]"},{"line_number":261,"context_line":"            if cfg.CONF.debug:"},{"line_number":262,"context_line":"                proxy_cmd.append(\u0027--debug\u0027)"},{"line_number":263,"context_line":"                if (cfg.CONF.log_dir or cfg.CONF.log_file):"},{"line_number":264,"context_line":"                    proxy_cmd.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9hI%3D","line":261,"in_reply_to":"AAAAN3%2F%2F9i8%3D","updated":"2013-03-05 06:58:03.000000000","message":"I don\u0027t it\u0027s worth it to write a so-called function to do it. we have a lots of debug opts.","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"}],"quantum/agent/metadata/agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":217,"context_line":"    eventlet.monkey_patch()"},{"line_number":218,"context_line":"    cfg.CONF.register_opts(UnixDomainMetadataProxy.OPTS)"},{"line_number":219,"context_line":"    cfg.CONF.register_opts(MetadataProxyHandler.OPTS)"},{"line_number":220,"context_line":"    cfg.CONF(args\u003dsys.argv[1:], project\u003d\u0027quantum\u0027)"},{"line_number":221,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":222,"context_line":"    utils.log_opt_values(LOG)"},{"line_number":223,"context_line":"    proxy \u003d UnixDomainMetadataProxy(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9iw%3D","line":220,"updated":"2013-03-05 06:46:38.000000000","message":"args: I think that this is the default","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"unresolved":false,"context_lines":[{"line_number":217,"context_line":"    eventlet.monkey_patch()"},{"line_number":218,"context_line":"    cfg.CONF.register_opts(UnixDomainMetadataProxy.OPTS)"},{"line_number":219,"context_line":"    cfg.CONF.register_opts(MetadataProxyHandler.OPTS)"},{"line_number":220,"context_line":"    cfg.CONF(args\u003dsys.argv[1:], project\u003d\u0027quantum\u0027)"},{"line_number":221,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":222,"context_line":"    utils.log_opt_values(LOG)"},{"line_number":223,"context_line":"    proxy \u003d UnixDomainMetadataProxy(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9RU%3D","line":220,"in_reply_to":"AAAAN3%2F%2F9Tg%3D","updated":"2013-03-05 09:21:49.000000000","message":"Thanks, that\u0027s obviously a cfg bug and is easily fixed - see Id5a769bdda5f2359da18c301cb6305aaf3ed8617","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    eventlet.monkey_patch()"},{"line_number":218,"context_line":"    cfg.CONF.register_opts(UnixDomainMetadataProxy.OPTS)"},{"line_number":219,"context_line":"    cfg.CONF.register_opts(MetadataProxyHandler.OPTS)"},{"line_number":220,"context_line":"    cfg.CONF(args\u003dsys.argv[1:], project\u003d\u0027quantum\u0027)"},{"line_number":221,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":222,"context_line":"    utils.log_opt_values(LOG)"},{"line_number":223,"context_line":"    proxy \u003d UnixDomainMetadataProxy(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9Tg%3D","line":220,"in_reply_to":"AAAAN3%2F%2F9WY%3D","updated":"2013-03-05 08:58:42.000000000","message":"I have seen it. but please see:\ndef log_opt_values(self, logger, lvl):\n        \"\"\"Log the value of all registered opts.\n\n        It\u0027s often useful for an app to log its configuration to a log file at\n        startup for debugging. This method dumps to the entire config state to\n        the supplied logger at a given log level.\n\n        :param logger: a logging.Logger object\n        :param lvl: the log level (e.g. logging.DEBUG) arg to logger.log()\n        \"\"\"\n        logger.log(lvl, \"*\" * 80)\n        logger.log(lvl, \"Configuration options gathered from:\")\n        logger.log(lvl, \"command line args: %s\", self._args)\n\nif we set the args\u003dsys.argv[1:], the self._args will have value, if not, self._args is none.\nin addition, pass in args instead of using default one does not hurt anything else.","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"unresolved":false,"context_lines":[{"line_number":217,"context_line":"    eventlet.monkey_patch()"},{"line_number":218,"context_line":"    cfg.CONF.register_opts(UnixDomainMetadataProxy.OPTS)"},{"line_number":219,"context_line":"    cfg.CONF.register_opts(MetadataProxyHandler.OPTS)"},{"line_number":220,"context_line":"    cfg.CONF(args\u003dsys.argv[1:], project\u003d\u0027quantum\u0027)"},{"line_number":221,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":222,"context_line":"    utils.log_opt_values(LOG)"},{"line_number":223,"context_line":"    proxy \u003d UnixDomainMetadataProxy(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9WY%3D","line":220,"in_reply_to":"AAAAN3%2F%2F9hA%3D","updated":"2013-03-05 08:27:06.000000000","message":"Well, you\u0027re going to have to explain why - in argparse\u0027s parse_args() you see:\n\n        # args default to the system args                                       \n        if args is None:\n            args \u003d _sys.argv[1:]","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    eventlet.monkey_patch()"},{"line_number":218,"context_line":"    cfg.CONF.register_opts(UnixDomainMetadataProxy.OPTS)"},{"line_number":219,"context_line":"    cfg.CONF.register_opts(MetadataProxyHandler.OPTS)"},{"line_number":220,"context_line":"    cfg.CONF(args\u003dsys.argv[1:], project\u003d\u0027quantum\u0027)"},{"line_number":221,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":222,"context_line":"    utils.log_opt_values(LOG)"},{"line_number":223,"context_line":"    proxy \u003d UnixDomainMetadataProxy(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9hA%3D","line":220,"in_reply_to":"AAAAN3%2F%2F9iw%3D","updated":"2013-03-05 06:58:03.000000000","message":"I think I have said it in commit msg, the default mechanism is not right enough in that log module. without the explicit setting, there is some function in log does not work well.","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"}],"quantum/agent/metadata/namespace_proxy.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    cfg.CONF.register_cli_opts(opts)"},{"line_number":156,"context_line":"    # Don\u0027t get the default configuration file"},{"line_number":157,"context_line":"    cfg.CONF(args\u003dsys.argv[1:], project\u003d\u0027quantum\u0027,"},{"line_number":158,"context_line":"             default_config_files\u003d[])"},{"line_number":159,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":160,"context_line":"    utils.log_opt_values(LOG)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9is%3D","line":157,"updated":"2013-03-05 06:46:38.000000000","message":"ditto regarding the args","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    cfg.CONF.register_cli_opts(opts)"},{"line_number":156,"context_line":"    # Don\u0027t get the default configuration file"},{"line_number":157,"context_line":"    cfg.CONF(args\u003dsys.argv[1:], project\u003d\u0027quantum\u0027,"},{"line_number":158,"context_line":"             default_config_files\u003d[])"},{"line_number":159,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":160,"context_line":"    utils.log_opt_values(LOG)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9g8%3D","line":157,"in_reply_to":"AAAAN3%2F%2F9is%3D","updated":"2013-03-05 06:58:03.000000000","message":"same","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":154,"context_line":"    cfg.CONF.register_cli_opts(opts)"},{"line_number":155,"context_line":"    # Don\u0027t get the default configuration file"},{"line_number":156,"context_line":"    cfg.CONF(project\u003d\u0027quantum\u0027,"},{"line_number":157,"context_line":"             default_config_files\u003d[])"},{"line_number":158,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":159,"context_line":"    utils.log_opt_values(LOG)"},{"line_number":160,"context_line":"    proxy \u003d ProxyDaemon(cfg.CONF.pid_file,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F5h8%3D","line":157,"updated":"2013-03-07 04:59:27.000000000","message":"This should fit on the same line as 156","commit_id":"e2316b1ee82d01e14885342145a6ce9c02912392"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    cfg.CONF.register_cli_opts(opts)"},{"line_number":155,"context_line":"    # Don\u0027t get the default configuration file"},{"line_number":156,"context_line":"    cfg.CONF(project\u003d\u0027quantum\u0027,"},{"line_number":157,"context_line":"             default_config_files\u003d[])"},{"line_number":158,"context_line":"    config.setup_logging(cfg.CONF)"},{"line_number":159,"context_line":"    utils.log_opt_values(LOG)"},{"line_number":160,"context_line":"    proxy \u003d ProxyDaemon(cfg.CONF.pid_file,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F5XE%3D","line":157,"in_reply_to":"AAAAN3%2F%2F5h8%3D","updated":"2013-03-07 07:12:50.000000000","message":"Done","commit_id":"e2316b1ee82d01e14885342145a6ce9c02912392"}],"quantum/plugins/linuxbridge/agent/linuxbridge_quantum_agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":624,"context_line":""},{"line_number":625,"context_line":"def main():"},{"line_number":626,"context_line":"    eventlet.monkey_patch()"},{"line_number":627,"context_line":"    cfg.CONF(args\u003dsys.argv[1:], project\u003d\u0027quantum\u0027)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"    logging_config.setup_logging(cfg.CONF)"},{"line_number":630,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9ik%3D","line":627,"updated":"2013-03-05 06:46:38.000000000","message":"this is the default we do not need it","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":624,"context_line":""},{"line_number":625,"context_line":"def main():"},{"line_number":626,"context_line":"    eventlet.monkey_patch()"},{"line_number":627,"context_line":"    cfg.CONF(args\u003dsys.argv[1:], project\u003d\u0027quantum\u0027)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"    logging_config.setup_logging(cfg.CONF)"},{"line_number":630,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9g4%3D","line":627,"in_reply_to":"AAAAN3%2F%2F9ik%3D","updated":"2013-03-05 06:58:03.000000000","message":"same","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"}],"quantum/plugins/openvswitch/agent/ovs_quantum_agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":751,"context_line":""},{"line_number":752,"context_line":"def main():"},{"line_number":753,"context_line":"    eventlet.monkey_patch()"},{"line_number":754,"context_line":"    cfg.CONF(args\u003dsys.argv[1:], project\u003d\u0027quantum\u0027)"},{"line_number":755,"context_line":"    logging_config.setup_logging(cfg.CONF)"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9ig%3D","line":754,"updated":"2013-03-05 06:46:38.000000000","message":"ditto","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"83760af49f6ef830b4a7f30d616c33fe78f11889","unresolved":false,"context_lines":[{"line_number":751,"context_line":""},{"line_number":752,"context_line":"def main():"},{"line_number":753,"context_line":"    eventlet.monkey_patch()"},{"line_number":754,"context_line":"    cfg.CONF(args\u003dsys.argv[1:], project\u003d\u0027quantum\u0027)"},{"line_number":755,"context_line":"    logging_config.setup_logging(cfg.CONF)"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9g0%3D","line":754,"in_reply_to":"AAAAN3%2F%2F9ig%3D","updated":"2013-03-05 06:58:03.000000000","message":"same","commit_id":"4e0da538b64ad384b3ecf57cd169aa0866e69d8f"}]}
