)]}'
{"quantum/agent/firewall.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":40,"context_line":"          source_port_max, dest_ip_prefix,"},{"line_number":41,"context_line":"      Note: source_group_ip in REST API should be converted by this rule"},{"line_number":42,"context_line":"      if direction is ingress:"},{"line_number":43,"context_line":"        remote_group_ip will be a remote_prefix_ip"},{"line_number":44,"context_line":"      if direction is egress:"},{"line_number":45,"context_line":"        remote_group_ip will be a dest_prefix_ip"},{"line_number":46,"context_line":"      Note: remote_group_id in REST API should be converted by this rule"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F92U%3D","line":43,"updated":"2013-03-05 02:31:39.000000000","message":"remote_group_ip will be a src_prefix_ip here","commit_id":"3394fcc4c9990bb515c56b0c984a494d7fd56332"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"aff1072dc99fbaecaf647255e1cc08c2dda68ce9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"          source_port_max, dest_ip_prefix,"},{"line_number":41,"context_line":"      Note: source_group_ip in REST API should be converted by this rule"},{"line_number":42,"context_line":"      if direction is ingress:"},{"line_number":43,"context_line":"        remote_group_ip will be a remote_prefix_ip"},{"line_number":44,"context_line":"      if direction is egress:"},{"line_number":45,"context_line":"        remote_group_ip will be a dest_prefix_ip"},{"line_number":46,"context_line":"      Note: remote_group_id in REST API should be converted by this rule"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F91k%3D","line":43,"in_reply_to":"AAAAN3%2F%2F92U%3D","updated":"2013-03-05 02:34:30.000000000","message":"Done","commit_id":"3394fcc4c9990bb515c56b0c984a494d7fd56332"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":36,"context_line":"      the rule must contain ethertype and direction"},{"line_number":37,"context_line":"      the rule may contain security_group_id,"},{"line_number":38,"context_line":"          protocol, port_min, port_max"},{"line_number":39,"context_line":"          remote_ip_prefix, source_port_min,"},{"line_number":40,"context_line":"          source_port_max, dest_ip_prefix,"},{"line_number":41,"context_line":"      Note: source_group_ip in REST API should be converted by this rule"},{"line_number":42,"context_line":"      if direction is ingress:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2F9Zg%3D","line":39,"updated":"2013-03-05 08:17:41.000000000","message":"remote_ip_prefix -\u003e source_ip_prefix","commit_id":"5362c3f22aea87640933ea16fa0595a68242ae41"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":36,"context_line":"      the rule must contain ethertype and direction"},{"line_number":37,"context_line":"      the rule may contain security_group_id,"},{"line_number":38,"context_line":"          protocol, port_min, port_max"},{"line_number":39,"context_line":"          remote_ip_prefix, source_port_min,"},{"line_number":40,"context_line":"          source_port_max, dest_ip_prefix,"},{"line_number":41,"context_line":"      Note: source_group_ip in REST API should be converted by this rule"},{"line_number":42,"context_line":"      if direction is ingress:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2F9Wk%3D","line":39,"in_reply_to":"AAAAN3%2F%2F9Zg%3D","updated":"2013-03-05 08:26:40.000000000","message":"Done","commit_id":"5362c3f22aea87640933ea16fa0595a68242ae41"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":38,"context_line":"          protocol, port_min, port_max"},{"line_number":39,"context_line":"          remote_ip_prefix, source_port_min,"},{"line_number":40,"context_line":"          source_port_max, dest_ip_prefix,"},{"line_number":41,"context_line":"      Note: source_group_ip in REST API should be converted by this rule"},{"line_number":42,"context_line":"      if direction is ingress:"},{"line_number":43,"context_line":"        remote_group_ip will be a source_prefix_ip"},{"line_number":44,"context_line":"      if direction is egress:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2F9ZY%3D","line":41,"updated":"2013-03-05 08:17:41.000000000","message":"source_group_ip -\u003e remote_ip_prefix","commit_id":"5362c3f22aea87640933ea16fa0595a68242ae41"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":38,"context_line":"          protocol, port_min, port_max"},{"line_number":39,"context_line":"          remote_ip_prefix, source_port_min,"},{"line_number":40,"context_line":"          source_port_max, dest_ip_prefix,"},{"line_number":41,"context_line":"      Note: source_group_ip in REST API should be converted by this rule"},{"line_number":42,"context_line":"      if direction is ingress:"},{"line_number":43,"context_line":"        remote_group_ip will be a source_prefix_ip"},{"line_number":44,"context_line":"      if direction is egress:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2F9Wg%3D","line":41,"in_reply_to":"AAAAN3%2F%2F9ZY%3D","updated":"2013-03-05 08:26:40.000000000","message":"Done","commit_id":"5362c3f22aea87640933ea16fa0595a68242ae41"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":40,"context_line":"          source_port_max, dest_ip_prefix,"},{"line_number":41,"context_line":"      Note: source_group_ip in REST API should be converted by this rule"},{"line_number":42,"context_line":"      if direction is ingress:"},{"line_number":43,"context_line":"        remote_group_ip will be a source_prefix_ip"},{"line_number":44,"context_line":"      if direction is egress:"},{"line_number":45,"context_line":"        remote_group_ip will be a dest_prefix_ip"},{"line_number":46,"context_line":"      Note: remote_group_id in REST API should be converted by this rule"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2F9ZU%3D","line":43,"updated":"2013-03-05 08:17:41.000000000","message":"remote_group_id -\u003e remote_ip_prefix\n\nsource_prefix_ip -\u003e source_ip_prefix","commit_id":"5362c3f22aea87640933ea16fa0595a68242ae41"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":40,"context_line":"          source_port_max, dest_ip_prefix,"},{"line_number":41,"context_line":"      Note: source_group_ip in REST API should be converted by this rule"},{"line_number":42,"context_line":"      if direction is ingress:"},{"line_number":43,"context_line":"        remote_group_ip will be a source_prefix_ip"},{"line_number":44,"context_line":"      if direction is egress:"},{"line_number":45,"context_line":"        remote_group_ip will be a dest_prefix_ip"},{"line_number":46,"context_line":"      Note: remote_group_id in REST API should be converted by this rule"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2F9Wc%3D","line":43,"in_reply_to":"AAAAN3%2F%2F9ZU%3D","updated":"2013-03-05 08:26:40.000000000","message":"Done","commit_id":"5362c3f22aea87640933ea16fa0595a68242ae41"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"      if direction is ingress:"},{"line_number":43,"context_line":"        remote_group_ip will be a source_prefix_ip"},{"line_number":44,"context_line":"      if direction is egress:"},{"line_number":45,"context_line":"        remote_group_ip will be a dest_prefix_ip"},{"line_number":46,"context_line":"      Note: remote_group_id in REST API should be converted by this rule"},{"line_number":47,"context_line":"      if direction is ingress:"},{"line_number":48,"context_line":"        remote_group_id will be a list of soruce_prefix_ip"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2F9ZI%3D","line":45,"updated":"2013-03-05 08:17:41.000000000","message":"emote_group_id -\u003e remote_ip_prefix\n\ndest_prefix_ip -\u003e dest_ip_prefix","commit_id":"5362c3f22aea87640933ea16fa0595a68242ae41"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"      if direction is ingress:"},{"line_number":43,"context_line":"        remote_group_ip will be a source_prefix_ip"},{"line_number":44,"context_line":"      if direction is egress:"},{"line_number":45,"context_line":"        remote_group_ip will be a dest_prefix_ip"},{"line_number":46,"context_line":"      Note: remote_group_id in REST API should be converted by this rule"},{"line_number":47,"context_line":"      if direction is ingress:"},{"line_number":48,"context_line":"        remote_group_id will be a list of soruce_prefix_ip"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2F9WQ%3D","line":45,"in_reply_to":"AAAAN3%2F%2F9ZI%3D","updated":"2013-03-05 08:26:40.000000000","message":"Done","commit_id":"5362c3f22aea87640933ea16fa0595a68242ae41"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"        remote_group_ip will be a dest_prefix_ip"},{"line_number":46,"context_line":"      Note: remote_group_id in REST API should be converted by this rule"},{"line_number":47,"context_line":"      if direction is ingress:"},{"line_number":48,"context_line":"        remote_group_id will be a list of soruce_prefix_ip"},{"line_number":49,"context_line":"      if direction is egress:"},{"line_number":50,"context_line":"        remote_group_id will be a list of dest_prefix_ip"},{"line_number":51,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2F9ZE%3D","line":48,"updated":"2013-03-05 08:17:41.000000000","message":"source_prefix_ip -\u003e source_ip_prefix","commit_id":"5362c3f22aea87640933ea16fa0595a68242ae41"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"        remote_group_ip will be a dest_prefix_ip"},{"line_number":46,"context_line":"      Note: remote_group_id in REST API should be converted by this rule"},{"line_number":47,"context_line":"      if direction is ingress:"},{"line_number":48,"context_line":"        remote_group_id will be a list of soruce_prefix_ip"},{"line_number":49,"context_line":"      if direction is egress:"},{"line_number":50,"context_line":"        remote_group_id will be a list of dest_prefix_ip"},{"line_number":51,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2F9WM%3D","line":48,"in_reply_to":"AAAAN3%2F%2F9ZE%3D","updated":"2013-03-05 08:26:40.000000000","message":"Done","commit_id":"5362c3f22aea87640933ea16fa0595a68242ae41"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":47,"context_line":"      if direction is ingress:"},{"line_number":48,"context_line":"        remote_group_id will be a list of soruce_prefix_ip"},{"line_number":49,"context_line":"      if direction is egress:"},{"line_number":50,"context_line":"        remote_group_id will be a list of dest_prefix_ip"},{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    __metaclass__ \u003d abc.ABCMeta"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2F9Y8%3D","line":50,"updated":"2013-03-05 08:17:41.000000000","message":"dest_prefix_ip -\u003e dest_ip_prefix","commit_id":"5362c3f22aea87640933ea16fa0595a68242ae41"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":47,"context_line":"      if direction is ingress:"},{"line_number":48,"context_line":"        remote_group_id will be a list of soruce_prefix_ip"},{"line_number":49,"context_line":"      if direction is egress:"},{"line_number":50,"context_line":"        remote_group_id will be a list of dest_prefix_ip"},{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    __metaclass__ \u003d abc.ABCMeta"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2F9WI%3D","line":50,"in_reply_to":"AAAAN3%2F%2F9Y8%3D","updated":"2013-03-05 08:26:40.000000000","message":"Done","commit_id":"5362c3f22aea87640933ea16fa0595a68242ae41"}],"quantum/agent/linux/iptables_firewall.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":231,"context_line":"                                   rule.get(\u0027source_port_range_min\u0027),"},{"line_number":232,"context_line":"                                   rule.get(\u0027source_port_range_max\u0027))"},{"line_number":233,"context_line":"            args +\u003d self._ip_prefix_arg(\u0027s\u0027,"},{"line_number":234,"context_line":"                                        rule.get(\u0027remote_ip_prefix\u0027))"},{"line_number":235,"context_line":"            args +\u003d self._ip_prefix_arg(\u0027d\u0027,"},{"line_number":236,"context_line":"                                        rule.get(\u0027dest_ip_prefix\u0027))"},{"line_number":237,"context_line":"            iptables_rules +\u003d [\u0027 \u0027.join(args)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F92I%3D","line":234,"updated":"2013-03-05 02:31:39.000000000","message":"IMO, this should be src","commit_id":"3394fcc4c9990bb515c56b0c984a494d7fd56332"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"aff1072dc99fbaecaf647255e1cc08c2dda68ce9","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                                   rule.get(\u0027source_port_range_min\u0027),"},{"line_number":232,"context_line":"                                   rule.get(\u0027source_port_range_max\u0027))"},{"line_number":233,"context_line":"            args +\u003d self._ip_prefix_arg(\u0027s\u0027,"},{"line_number":234,"context_line":"                                        rule.get(\u0027remote_ip_prefix\u0027))"},{"line_number":235,"context_line":"            args +\u003d self._ip_prefix_arg(\u0027d\u0027,"},{"line_number":236,"context_line":"                                        rule.get(\u0027dest_ip_prefix\u0027))"},{"line_number":237,"context_line":"            iptables_rules +\u003d [\u0027 \u0027.join(args)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F91g%3D","line":234,"in_reply_to":"AAAAN3%2F%2F92I%3D","updated":"2013-03-05 02:34:30.000000000","message":"Yup fixed in the patch rebased on this already.","commit_id":"3394fcc4c9990bb515c56b0c984a494d7fd56332"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":231,"context_line":"                                   rule.get(\u0027source_port_range_min\u0027),"},{"line_number":232,"context_line":"                                   rule.get(\u0027source_port_range_max\u0027))"},{"line_number":233,"context_line":"            args +\u003d self._ip_prefix_arg(\u0027s\u0027,"},{"line_number":234,"context_line":"                                        rule.get(\u0027remote_ip_prefix\u0027))"},{"line_number":235,"context_line":"            args +\u003d self._ip_prefix_arg(\u0027d\u0027,"},{"line_number":236,"context_line":"                                        rule.get(\u0027dest_ip_prefix\u0027))"},{"line_number":237,"context_line":"            iptables_rules +\u003d [\u0027 \u0027.join(args)]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F9ug%3D","line":234,"updated":"2013-03-05 03:41:34.000000000","message":"this should be unchanged, otherwise this is mismach with comments in firewall.py","commit_id":"2dfea4ae0a49076df152691628215aa929e3004b"}],"quantum/db/migration/alembic_migrations/versions/3cb5d900c5de_security_groups.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d1225f526e118ea52eb9b2a79cb3408c34d34313","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":62,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":63,"context_line":"        sa.Column(\u0027security_group_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":64,"context_line":"        sa.Column(\u0027remote_group_id\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":65,"context_line":"        sa.Column(\u0027direction\u0027,"},{"line_number":66,"context_line":"                  sa.Enum(\u0027ingress\u0027, \u0027egress\u0027,"},{"line_number":67,"context_line":"                          name\u003d\u0027securitygrouprules_direction\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2BOQ%3D","line":64,"updated":"2013-03-04 22:54:12.000000000","message":"In theory we should have had a new migration rather than an update of an existing migration.\n\nWhile altering an existing migration is ok for future grizzly users, it might be not ok for user which deploy from trunk.\n\nI don\u0027t know if we care (yet) about them though.","commit_id":"0125a7afd91b7bff33c43f24118dd96e593dd659"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"dad9900d5aecd2f8284b71586e7db53def7615ae","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":62,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":63,"context_line":"        sa.Column(\u0027security_group_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":64,"context_line":"        sa.Column(\u0027remote_group_id\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":65,"context_line":"        sa.Column(\u0027direction\u0027,"},{"line_number":66,"context_line":"                  sa.Enum(\u0027ingress\u0027, \u0027egress\u0027,"},{"line_number":67,"context_line":"                          name\u003d\u0027securitygrouprules_direction\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2BK8%3D","line":64,"in_reply_to":"AAAAN3%2F%2F%2BOQ%3D","updated":"2013-03-04 23:25:44.000000000","message":"In previous commits this cycle, we\u0027ve allowed similar revisions to migrations.  At the summit we should discuss what support we\u0027ll give those chasing trunk and get consensus on a policy.","commit_id":"0125a7afd91b7bff33c43f24118dd96e593dd659"}],"quantum/db/securitygroups_rpc_base.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d1225f526e118ea52eb9b2a79cb3408c34d34313","unresolved":false,"context_lines":[{"line_number":31,"context_line":"           q_const.IPv6: 128}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DIRECTION_IP_PREFIX \u003d {\u0027ingress\u0027: \u0027remote_ip_prefix\u0027,"},{"line_number":35,"context_line":"                       \u0027egress\u0027: \u0027dest_ip_prefix\u0027}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2BNs%3D","line":34,"updated":"2013-03-04 22:54:12.000000000","message":"I would probably leave source_ip_prefix here - since we already doing a sort of name conversion for distinguishing ingress/egress rules","commit_id":"0125a7afd91b7bff33c43f24118dd96e593dd659"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"aff1072dc99fbaecaf647255e1cc08c2dda68ce9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"           q_const.IPv6: 128}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DIRECTION_IP_PREFIX \u003d {\u0027ingress\u0027: \u0027remote_ip_prefix\u0027,"},{"line_number":35,"context_line":"                       \u0027egress\u0027: \u0027dest_ip_prefix\u0027}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2BKc%3D","line":34,"in_reply_to":"AAAAN3%2F%2F%2BNs%3D","updated":"2013-03-04 23:35:20.000000000","message":"good catch right.","commit_id":"0125a7afd91b7bff33c43f24118dd96e593dd659"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":294,"context_line":"                if rule_in_db.get(key):"},{"line_number":295,"context_line":"                    if key \u003d\u003d \u0027remote_ip_prefix\u0027 and direction \u003d\u003d \u0027egress\u0027:"},{"line_number":296,"context_line":"                        rule_dict[\u0027dest_ip_prefix\u0027] \u003d rule_in_db[key]"},{"line_number":297,"context_line":"                        continue"},{"line_number":298,"context_line":"                    rule_dict[key] \u003d rule_in_db[key]"},{"line_number":299,"context_line":"            port[\u0027security_group_rules\u0027].append(rule_dict)"},{"line_number":300,"context_line":"        self._apply_provider_rule(context, ports)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F91M%3D","line":297,"updated":"2013-03-05 02:37:13.000000000","message":"now we should have source and ingress version here","commit_id":"2dfea4ae0a49076df152691628215aa929e3004b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"aff1072dc99fbaecaf647255e1cc08c2dda68ce9","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                if rule_in_db.get(key):"},{"line_number":295,"context_line":"                    if key \u003d\u003d \u0027remote_ip_prefix\u0027 and direction \u003d\u003d \u0027egress\u0027:"},{"line_number":296,"context_line":"                        rule_dict[\u0027dest_ip_prefix\u0027] \u003d rule_in_db[key]"},{"line_number":297,"context_line":"                        continue"},{"line_number":298,"context_line":"                    rule_dict[key] \u003d rule_in_db[key]"},{"line_number":299,"context_line":"            port[\u0027security_group_rules\u0027].append(rule_dict)"},{"line_number":300,"context_line":"        self._apply_provider_rule(context, ports)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F9v0%3D","line":297,"in_reply_to":"AAAAN3%2F%2F91M%3D","updated":"2013-03-05 03:19:18.000000000","message":"sorry what do you mean?","commit_id":"2dfea4ae0a49076df152691628215aa929e3004b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":112,"context_line":"        \"\"\" return security group rules for each port"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        also convert remote_group_id rule"},{"line_number":115,"context_line":"        to source_ip_prefix adn dest_ip_prefix rule"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        :params devices: list of devices"},{"line_number":118,"context_line":"        :returns: port correspond to the devices with security group rules"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F9hg%3D","line":115,"updated":"2013-03-05 06:56:55.000000000","message":"typo adn \u003d\u003e and","commit_id":"5adfc40f79812516d4332ade819df69dc5ef93a4"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":112,"context_line":"        \"\"\" return security group rules for each port"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        also convert remote_group_id rule"},{"line_number":115,"context_line":"        to source_ip_prefix adn dest_ip_prefix rule"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        :params devices: list of devices"},{"line_number":118,"context_line":"        :returns: port correspond to the devices with security group rules"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F9fk%3D","line":115,"in_reply_to":"AAAAN3%2F%2F9hg%3D","updated":"2013-03-05 07:11:49.000000000","message":"Done","commit_id":"5adfc40f79812516d4332ade819df69dc5ef93a4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":294,"context_line":"                if rule_in_db.get(key):"},{"line_number":295,"context_line":"                    if key \u003d\u003d \u0027remote_ip_prefix\u0027:"},{"line_number":296,"context_line":"                        direction_ip_prefix \u003d DIRECTION_IP_PREFIX[direction]"},{"line_number":297,"context_line":"                        rule_dict[direction_ip_prefix] \u003d rule_in_db[key]"},{"line_number":298,"context_line":"                        continue"},{"line_number":299,"context_line":"                    rule_dict[key] \u003d rule_in_db[key]"},{"line_number":300,"context_line":"            port[\u0027security_group_rules\u0027].append(rule_dict)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F9hM%3D","line":297,"updated":"2013-03-05 06:56:55.000000000","message":"is there a test case for this (sorry I am not too familiar with the tests)?","commit_id":"5adfc40f79812516d4332ade819df69dc5ef93a4"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":294,"context_line":"                if rule_in_db.get(key):"},{"line_number":295,"context_line":"                    if key \u003d\u003d \u0027remote_ip_prefix\u0027:"},{"line_number":296,"context_line":"                        direction_ip_prefix \u003d DIRECTION_IP_PREFIX[direction]"},{"line_number":297,"context_line":"                        rule_dict[direction_ip_prefix] \u003d rule_in_db[key]"},{"line_number":298,"context_line":"                        continue"},{"line_number":299,"context_line":"                    rule_dict[key] \u003d rule_in_db[key]"},{"line_number":300,"context_line":"            port[\u0027security_group_rules\u0027].append(rule_dict)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F9fU%3D","line":297,"in_reply_to":"AAAAN3%2F%2F9hM%3D","updated":"2013-03-05 07:11:49.000000000","message":"We are testing both direction in https://review.openstack.org/#/c/23451/5/quantum/tests/unit/test_security_groups_rpc.py","commit_id":"5adfc40f79812516d4332ade819df69dc5ef93a4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":252,"context_line":"                         \u0027port_range_max\u0027: 68,"},{"line_number":253,"context_line":"                         \u0027source_port_range_min\u0027: 67,"},{"line_number":254,"context_line":"                         \u0027source_port_range_max\u0027: 67}"},{"line_number":255,"context_line":"            dhcp_rule[\u0027remote_ip_prefix\u0027] \u003d \"%s/%s\" % (dhcp_ip,"},{"line_number":256,"context_line":"                                                       IP_MASK[q_const.IPv4])"},{"line_number":257,"context_line":"            port[\u0027security_group_rules\u0027].append(dhcp_rule)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAN3%2F%2F9YY%3D","line":255,"updated":"2013-03-05 08:17:46.000000000","message":"dhcp_rule is passed to the agent side, so don\u0027t we need to use  source_ip_prefix instead of remote_ip_prefix ?","commit_id":"822b78e9473a1b97e04a4dc611bef46249f51ce2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":265,"context_line":"            ra_rule \u003d {\u0027direction\u0027: \u0027ingress\u0027,"},{"line_number":266,"context_line":"                       \u0027ethertype\u0027: q_const.IPv6,"},{"line_number":267,"context_line":"                       \u0027protocol\u0027: \u0027icmp\u0027}"},{"line_number":268,"context_line":"            ra_rule[\u0027remote_ip_prefix\u0027] \u003d \"%s/%s\" % (ra_ip,"},{"line_number":269,"context_line":"                                                     IP_MASK[q_const.IPv6])"},{"line_number":270,"context_line":"            port[\u0027security_group_rules\u0027].append(ra_rule)"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAN3%2F%2F9YU%3D","line":268,"updated":"2013-03-05 08:17:46.000000000","message":"Ditto","commit_id":"822b78e9473a1b97e04a4dc611bef46249f51ce2"}],"quantum/plugins/midonet/midonet_lib.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":221,"context_line":"        ethertype \u003d rule[\u0027ethertype\u0027]"},{"line_number":222,"context_line":"        security_group_id \u003d rule[\u0027security_group_id\u0027]"},{"line_number":223,"context_line":"        remote_group_id \u003d rule[\u0027remote_group_id\u0027]"},{"line_number":224,"context_line":"        remote_ip_prefix \u003d rule[\u0027remote_ip_prefix\u0027]  # watch out. not validated"},{"line_number":225,"context_line":"        tenant_id \u003d rule[\u0027tenant_id\u0027]"},{"line_number":226,"context_line":"        port_range_min \u003d rule[\u0027port_range_min\u0027]"},{"line_number":227,"context_line":"        external_id \u003d rule[\u0027external_id\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F9hY%3D","line":224,"updated":"2013-03-05 06:56:55.000000000","message":"not sure that i like the comment - it is very confusing","commit_id":"5adfc40f79812516d4332ade819df69dc5ef93a4"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":221,"context_line":"        ethertype \u003d rule[\u0027ethertype\u0027]"},{"line_number":222,"context_line":"        security_group_id \u003d rule[\u0027security_group_id\u0027]"},{"line_number":223,"context_line":"        remote_group_id \u003d rule[\u0027remote_group_id\u0027]"},{"line_number":224,"context_line":"        remote_ip_prefix \u003d rule[\u0027remote_ip_prefix\u0027]  # watch out. not validated"},{"line_number":225,"context_line":"        tenant_id \u003d rule[\u0027tenant_id\u0027]"},{"line_number":226,"context_line":"        port_range_min \u003d rule[\u0027port_range_min\u0027]"},{"line_number":227,"context_line":"        external_id \u003d rule[\u0027external_id\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F9fQ%3D","line":224,"in_reply_to":"AAAAN3%2F%2F9gk%3D","updated":"2013-03-05 07:11:49.000000000","message":"OK could you fix it in another patch?","commit_id":"5adfc40f79812516d4332ade819df69dc5ef93a4"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"unresolved":false,"context_lines":[{"line_number":221,"context_line":"        ethertype \u003d rule[\u0027ethertype\u0027]"},{"line_number":222,"context_line":"        security_group_id \u003d rule[\u0027security_group_id\u0027]"},{"line_number":223,"context_line":"        remote_group_id \u003d rule[\u0027remote_group_id\u0027]"},{"line_number":224,"context_line":"        remote_ip_prefix \u003d rule[\u0027remote_ip_prefix\u0027]  # watch out. not validated"},{"line_number":225,"context_line":"        tenant_id \u003d rule[\u0027tenant_id\u0027]"},{"line_number":226,"context_line":"        port_range_min \u003d rule[\u0027port_range_min\u0027]"},{"line_number":227,"context_line":"        external_id \u003d rule[\u0027external_id\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F9gk%3D","line":224,"in_reply_to":"AAAAN3%2F%2F9hY%3D","updated":"2013-03-05 07:00:37.000000000","message":"Sorry, this is mine. I\u0027d like to fix this comment if it\u0027s absolutely necessary in a separate patch since it\u0027s irrelevant to this patchset.","commit_id":"5adfc40f79812516d4332ade819df69dc5ef93a4"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"aff1072dc99fbaecaf647255e1cc08c2dda68ce9","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        # handle source"},{"line_number":237,"context_line":"        if not remote_ip_prefix is None:"},{"line_number":238,"context_line":"            nw_src_address, nw_src_length \u003d remote_ip_prefix.split(\u0027/\u0027)"},{"line_number":239,"context_line":"        elif not remote_group_id is None:  # security group as a srouce"},{"line_number":240,"context_line":"            source_pg \u003d self.pg_manager.get_for_sg(tenant_id, remote_group_id)"},{"line_number":241,"context_line":"            port_group_id \u003d source_pg.get_id()"},{"line_number":242,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F9ek%3D","line":239,"updated":"2013-03-05 07:18:08.000000000","message":"@tomoe, another typo here for your separate patch set.  srouce","commit_id":"5adfc40f79812516d4332ade819df69dc5ef93a4"},{"author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"unresolved":false,"context_lines":[{"line_number":236,"context_line":"        # handle source"},{"line_number":237,"context_line":"        if not remote_ip_prefix is None:"},{"line_number":238,"context_line":"            nw_src_address, nw_src_length \u003d remote_ip_prefix.split(\u0027/\u0027)"},{"line_number":239,"context_line":"        elif not remote_group_id is None:  # security group as a srouce"},{"line_number":240,"context_line":"            source_pg \u003d self.pg_manager.get_for_sg(tenant_id, remote_group_id)"},{"line_number":241,"context_line":"            port_group_id \u003d source_pg.get_id()"},{"line_number":242,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F9dw%3D","line":239,"in_reply_to":"AAAAN3%2F%2F9ek%3D","updated":"2013-03-05 07:27:54.000000000","message":"Thanks :-)","commit_id":"5adfc40f79812516d4332ade819df69dc5ef93a4"}]}
