)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"1ae4641ba44b60a0cacce4dbf6f50e562d3f9ab8","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"WIP/To-Do:"},{"line_number":15,"context_line":"* Document OVS server fixture"},{"line_number":16,"context_line":"* Add DB socket path to native OVS interface"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Follow up:"},{"line_number":19,"context_line":"* Add support for ovs-ofctl alternate sockets"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa80f949_0e6d1c04","line":16,"updated":"2015-11-04 06:41:23.000000000","message":"This is already implemented in [1] - we just need to specify a string such as \"unix:/my/path/to/sock.db\" instead of \"tcp:ip:port\".\n\nWe could probably add a help doc as to the format it accepts, and maybe a verification function for this, though.\n\n[1]: https://github.com/openstack/neutron/blob/master/neutron/agent/ovsdb/impl_idl.py#L31","commit_id":"b983f235c701eb56c644f44c67ef93b0e457b25d"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"898a2d93e96a46445b626db7d7efb9ed148d8c0c","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"WIP/To-Do:"},{"line_number":15,"context_line":"* Document OVS server fixture"},{"line_number":16,"context_line":"* Add DB socket path to native OVS interface"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Follow up:"},{"line_number":19,"context_line":"* Add support for ovs-ofctl alternate sockets"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da85f559_780c4241","line":16,"in_reply_to":"fa80f949_0e6d1c04","updated":"2015-11-11 07:37:44.000000000","message":"Removed from commit message.","commit_id":"b983f235c701eb56c644f44c67ef93b0e457b25d"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"80087a2f7ed3afa6511e034ec2d072a64f50c1d5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* Add DB socket path to native OVS interface"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Follow up:"},{"line_number":19,"context_line":"* Add support for ovs-ofctl alternate sockets"},{"line_number":20,"context_line":"* Use it in fullstack"},{"line_number":21,"context_line":"* Decide what functional tests may benefit from this"},{"line_number":22,"context_line":"* Add of_lib functional tests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa80f949_c648828a","line":19,"updated":"2015-11-03 17:23:31.000000000","message":"It would seem that ovs-ofctl is already taken care of; \u0027strace ovs-ofctl dump-flows \u003cbridge\u003e\u0027 shows that the program knows to look at /var/run/openvswitch/\u003cbridge\u003e.mgmt for a socket to connect to the ovs server. This file is created by ovs-vswitchd, which is spawned by the fixture itself.","commit_id":"b983f235c701eb56c644f44c67ef93b0e457b25d"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"898a2d93e96a46445b626db7d7efb9ed148d8c0c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* Add DB socket path to native OVS interface"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Follow up:"},{"line_number":19,"context_line":"* Add support for ovs-ofctl alternate sockets"},{"line_number":20,"context_line":"* Use it in fullstack"},{"line_number":21,"context_line":"* Decide what functional tests may benefit from this"},{"line_number":22,"context_line":"* Add of_lib functional tests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da85f559_9b07a017","line":19,"in_reply_to":"fa80f949_c648828a","updated":"2015-11-11 07:37:44.000000000","message":"ditto","commit_id":"b983f235c701eb56c644f44c67ef93b0e457b25d"}],"neutron/tests/common/ovs_fixtures.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"45969ab60646d3eda600322f8258cf320caeb4a0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.agent.linux import utils"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class OVSFixture(fixtures.Fixture):"},{"line_number":24,"context_line":"    def _setUp(self):"},{"line_number":25,"context_line":"        self.root_dir \u003d self.useFixture(fixtures.TempDir()).path"},{"line_number":26,"context_line":"        self.db \u003d os.path.join(self.root_dir, \u0027conf.db\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_5a92c958","line":23,"updated":"2015-11-05 13:29:28.000000000","message":"The name \u0027OVSFixture\u0027 is super confusing, seeing that we already have \u0027OVSBridgeFixtures\u0027 and \u0027BaseOVS\u0027. How about renaming to \u0027IsolatedOVSFixture\u0027?","commit_id":"b983f235c701eb56c644f44c67ef93b0e457b25d"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"898a2d93e96a46445b626db7d7efb9ed148d8c0c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.agent.linux import utils"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class OVSFixture(fixtures.Fixture):"},{"line_number":24,"context_line":"    def _setUp(self):"},{"line_number":25,"context_line":"        self.root_dir \u003d self.useFixture(fixtures.TempDir()).path"},{"line_number":26,"context_line":"        self.db \u003d os.path.join(self.root_dir, \u0027conf.db\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_5b16184d","line":23,"in_reply_to":"fa80f949_5a92c958","updated":"2015-11-11 07:37:44.000000000","message":"Done","commit_id":"b983f235c701eb56c644f44c67ef93b0e457b25d"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"80087a2f7ed3afa6511e034ec2d072a64f50c1d5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"             self.db,"},{"line_number":41,"context_line":"             \u0027/usr/share/openvswitch/vswitch.ovsschema\u0027],"},{"line_number":42,"context_line":"            run_as_root\u003dTrue)"},{"line_number":43,"context_line":"        utils.create_process("},{"line_number":44,"context_line":"            [\u0027ovsdb-server\u0027,"},{"line_number":45,"context_line":"             self.db,"},{"line_number":46,"context_line":"             \u0027-vconsole:emer\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_b0dd3c44","line":43,"updated":"2015-11-03 17:23:31.000000000","message":"Why not use AsyncProcess here? This will allow us a neater way of making sure the process started and a much nicer way to kill it later on.","commit_id":"b983f235c701eb56c644f44c67ef93b0e457b25d"}],"neutron/tests/functional/agent/test_ovs_lib.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"d4d8c0db7ad620d2aafcd1f12da782bc95efeda8","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        # Two bridges of the same name cannot exist in the same OVS database."},{"line_number":375,"context_line":"        # If this call succeeds that means that it was created in a separate"},{"line_number":376,"context_line":"        # database."},{"line_number":377,"context_line":"        ovs2.add_bridge(name)"},{"line_number":378,"context_line":"        self.addCleanup(ovs2.delete_bridge, name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_b4ac4b36","line":377,"updated":"2015-10-14 21:38:28.000000000","message":"add_bridge() defaults to passing --may-exist, so successive calls *should* succeed.","commit_id":"e43da53d92848ef164dfe9e822936b166ff4c65a"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"2babaff697469fe8271465d633c6b3d6ff624d09","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        # Two bridges of the same name cannot exist in the same OVS database."},{"line_number":375,"context_line":"        # If this call succeeds that means that it was created in a separate"},{"line_number":376,"context_line":"        # database."},{"line_number":377,"context_line":"        ovs2.add_bridge(name)"},{"line_number":378,"context_line":"        self.addCleanup(ovs2.delete_bridge, name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_83d22fff","line":377,"in_reply_to":"5a2ca52d_b4ac4b36","updated":"2015-10-15 00:43:05.000000000","message":"Wups, good point :) To be fair the test / ovs-server fixture does actually work. I\u0027ll change the test so that it\u0027s sane though.","commit_id":"e43da53d92848ef164dfe9e822936b166ff4c65a"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"80087a2f7ed3afa6511e034ec2d072a64f50c1d5","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        fixture_2 \u003d self.useFixture(ovs_fixtures.OVSFixture())"},{"line_number":368,"context_line":"        ovs2 \u003d ovs_lib.BaseOVS(fixture_2.socket)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        name \u003d base.get_rand_name(prefix\u003dnet_helpers.BR_PREFIX)"},{"line_number":371,"context_line":"        ovs1.add_bridge(name)"},{"line_number":372,"context_line":"        self.addCleanup(ovs1.delete_bridge, name)"},{"line_number":373,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_ba6f8391","line":370,"updated":"2015-11-03 17:23:31.000000000","message":"This should use net_helpers.OVSBridge() instead.","commit_id":"b983f235c701eb56c644f44c67ef93b0e457b25d"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"898a2d93e96a46445b626db7d7efb9ed148d8c0c","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        fixture_2 \u003d self.useFixture(ovs_fixtures.OVSFixture())"},{"line_number":368,"context_line":"        ovs2 \u003d ovs_lib.BaseOVS(fixture_2.socket)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        name \u003d base.get_rand_name(prefix\u003dnet_helpers.BR_PREFIX)"},{"line_number":371,"context_line":"        ovs1.add_bridge(name)"},{"line_number":372,"context_line":"        self.addCleanup(ovs1.delete_bridge, name)"},{"line_number":373,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_7b13dc5b","line":370,"in_reply_to":"fa80f949_ba6f8391","updated":"2015-11-11 07:37:44.000000000","message":"Done","commit_id":"b983f235c701eb56c644f44c67ef93b0e457b25d"}]}
