)]}'
{"neutron/tests/contrib/functional-testing.filters":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d75af431fc9bfafccfa4f40d38e6c2f0ef2b47b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"touch_filter2: RegExpFilter, /usr/bin/touch, root, touch, /etc/netns/qdhcp-[0-9a-z./-]+/resolv.conf"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# needed by test_ovs_flows which runs ovs-appctl ofproto/trace"},{"line_number":39,"context_line":"appctl_filter: CommandFilter, ovs-appctl, root"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a57f1b5_3cfb0c7b","line":39,"updated":"2016-02-12 06:39:39.000000000","message":"can this be a little more restrictive?\neg. only allow ofproto/trace?","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"2ee7ba8ced3f9681c03438026883d0f66883aa02","unresolved":false,"context_lines":[{"line_number":36,"context_line":"touch_filter2: RegExpFilter, /usr/bin/touch, root, touch, /etc/netns/qdhcp-[0-9a-z./-]+/resolv.conf"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# needed by test_ovs_flows which runs ovs-appctl ofproto/trace"},{"line_number":39,"context_line":"appctl_filter: CommandFilter, ovs-appctl, root"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"dae33548_d881a391","line":39,"in_reply_to":"3a57f1b5_3cfb0c7b","updated":"2016-02-15 07:42:34.000000000","message":"Done","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"}],"neutron/tests/functional/agent/test_ovs_flows.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3b7ada7d0c86dcbcc5c90a409f35b67be2c8c40e","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        self._assert_flow(re.compile("},{"line_number":303,"context_line":"            \u0027 table\u003d0, n_packets\u003d.*, priority\u003d4,in_port\u003d123,dl_vlan\u003d888 \u0027"},{"line_number":304,"context_line":"            \u0027actions\u003d(mod_vlan_vid:888|set_field:888-\u003evlan_vid),NORMAL\u0027),"},{"line_number":305,"context_line":"            flows)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def test_install_dvr_process(self):"},{"line_number":308,"context_line":"        self.br_int.install_dvr_to_src_mac("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_e0e8ab12","line":305,"updated":"2015-10-15 08:41:46.000000000","message":"i don\u0027t think this can be done for every flows\nas the flows are not exactly same between of_interfaces.\nwhile they are similar, they use different openflow protocol versions.\n\ni\u0027m not sure dump-and-compare is a good testing strategy\nfor every flows.  for some of flows, it might be better to\ntest at a little higher level.  eg. use OVS\u0027s trace functionality to simulate packets.\nhow do you think?","commit_id":"3d96c122110fa65519ae5d29b15f1a0f842dd75c"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"728f725714f9191adbb54534c0f72531ee5ca8f6","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        self._assert_flow(re.compile("},{"line_number":303,"context_line":"            \u0027 table\u003d0, n_packets\u003d.*, priority\u003d4,in_port\u003d123,dl_vlan\u003d888 \u0027"},{"line_number":304,"context_line":"            \u0027actions\u003d(mod_vlan_vid:888|set_field:888-\u003evlan_vid),NORMAL\u0027),"},{"line_number":305,"context_line":"            flows)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def test_install_dvr_process(self):"},{"line_number":308,"context_line":"        self.br_int.install_dvr_to_src_mac("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_aeb4def1","line":305,"in_reply_to":"5a2ca52d_50cedf82","updated":"2015-11-05 08:55:24.000000000","message":"As said during the summit, I like Yamamoto\u0027s idea! Let\u0027s try that. Higher level testing is better :)","commit_id":"3d96c122110fa65519ae5d29b15f1a0f842dd75c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"f0cdb673360ecbc0fa5cf222b5fae1e9f5f93017","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        self._assert_flow(re.compile("},{"line_number":303,"context_line":"            \u0027 table\u003d0, n_packets\u003d.*, priority\u003d4,in_port\u003d123,dl_vlan\u003d888 \u0027"},{"line_number":304,"context_line":"            \u0027actions\u003d(mod_vlan_vid:888|set_field:888-\u003evlan_vid),NORMAL\u0027),"},{"line_number":305,"context_line":"            flows)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def test_install_dvr_process(self):"},{"line_number":308,"context_line":"        self.br_int.install_dvr_to_src_mac("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_50cedf82","line":305,"in_reply_to":"5a2ca52d_e0e8ab12","updated":"2015-10-16 02:57:07.000000000","message":"This patch already uses regular expressions to absorb minor differences in flows between of_interface drivers.  I think this approach is viable as long as flows generated by different drivers match 1:1.\n\nFor appropriate testing levels, no idea from me.","commit_id":"3d96c122110fa65519ae5d29b15f1a0f842dd75c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d75af431fc9bfafccfa4f40d38e6c2f0ef2b47b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                  \u0027agent.openflow.ovs_ofctl.main\u0027)}),"},{"line_number":48,"context_line":"        (\u0027native\u0027, {\u0027main_module\u0027: (\u0027neutron.plugins.ml2.drivers.openvswitch.\u0027"},{"line_number":49,"context_line":"                                  \u0027agent.openflow.native.main\u0027)})],"},{"line_number":50,"context_line":"        test_ovs_lib.OVSBridgeTestBase.scenarios)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def setUp(self):"},{"line_number":53,"context_line":"        super(OVSAgentTestBase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_5c95a83c","line":50,"updated":"2016-02-12 06:39:39.000000000","message":"can you consider to make this a separate patch?","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"2ee7ba8ced3f9681c03438026883d0f66883aa02","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                  \u0027agent.openflow.ovs_ofctl.main\u0027)}),"},{"line_number":48,"context_line":"        (\u0027native\u0027, {\u0027main_module\u0027: (\u0027neutron.plugins.ml2.drivers.openvswitch.\u0027"},{"line_number":49,"context_line":"                                  \u0027agent.openflow.native.main\u0027)})],"},{"line_number":50,"context_line":"        test_ovs_lib.OVSBridgeTestBase.scenarios)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def setUp(self):"},{"line_number":53,"context_line":"        super(OVSAgentTestBase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_184aeb83","line":50,"in_reply_to":"3a57f1b5_5c95a83c","updated":"2016-02-15 07:42:34.000000000","message":"Done","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d75af431fc9bfafccfa4f40d38e6c2f0ef2b47b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            if retry_count \u003c 0:"},{"line_number":89,"context_line":"                raise Exception(\u0027port allocation failed\u0027)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _dump_flows(self, brname):"},{"line_number":92,"context_line":"        flows \u003d utils.execute([\"ovs-ofctl\", \"-O\", \"OpenFlow13,OpenFlow10\","},{"line_number":93,"context_line":"                              \"dump-flows\", brname], run_as_root\u003dTrue)"},{"line_number":94,"context_line":"        return flows.splitlines()[1:]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_dc96783e","line":91,"updated":"2016-02-12 06:39:39.000000000","message":"seems unused","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"2ee7ba8ced3f9681c03438026883d0f66883aa02","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            if retry_count \u003c 0:"},{"line_number":89,"context_line":"                raise Exception(\u0027port allocation failed\u0027)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def _dump_flows(self, brname):"},{"line_number":92,"context_line":"        flows \u003d utils.execute([\"ovs-ofctl\", \"-O\", \"OpenFlow13,OpenFlow10\","},{"line_number":93,"context_line":"                              \"dump-flows\", brname], run_as_root\u003dTrue)"},{"line_number":94,"context_line":"        return flows.splitlines()[1:]"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_3849af8c","line":91,"in_reply_to":"3a57f1b5_dc96783e","updated":"2016-02-15 07:42:34.000000000","message":"Done","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d75af431fc9bfafccfa4f40d38e6c2f0ef2b47b","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                              group\u003d\u0027AGENT\u0027)"},{"line_number":305,"context_line":"        super(OVSFlowTestCase, self).setUp()"},{"line_number":306,"context_line":"        self.phys_br \u003d self.useFixture(net_helpers.OVSBridgeFixture()).bridge"},{"line_number":307,"context_line":"        self.br_phys \u003d self.br_phys_cls(self.phys_br.br_name)  # XXX order"},{"line_number":308,"context_line":"        self.br_phys.set_secure_mode()"},{"line_number":309,"context_line":"        self.br_phys.setup_controllers(cfg.CONF)"},{"line_number":310,"context_line":"        self.router_addr \u003d \u0027192.168.0.1/24\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_1c73b016","line":307,"updated":"2016-02-12 06:39:39.000000000","message":"this comment seems cryptic.\ncan you have a REVISIT comment to explain?","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"2ee7ba8ced3f9681c03438026883d0f66883aa02","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                              group\u003d\u0027AGENT\u0027)"},{"line_number":305,"context_line":"        super(OVSFlowTestCase, self).setUp()"},{"line_number":306,"context_line":"        self.phys_br \u003d self.useFixture(net_helpers.OVSBridgeFixture()).bridge"},{"line_number":307,"context_line":"        self.br_phys \u003d self.br_phys_cls(self.phys_br.br_name)  # XXX order"},{"line_number":308,"context_line":"        self.br_phys.set_secure_mode()"},{"line_number":309,"context_line":"        self.br_phys.setup_controllers(cfg.CONF)"},{"line_number":310,"context_line":"        self.router_addr \u003d \u0027192.168.0.1/24\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_1ecf73b1","line":307,"in_reply_to":"3a57f1b5_1c73b016","updated":"2016-02-15 07:42:34.000000000","message":"This comment seems unnecessary.","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d75af431fc9bfafccfa4f40d38e6c2f0ef2b47b","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        ofport \u003d self.br_tun.add_tunnel_port(port_name, attrs[\u0027remote_ip\u0027],"},{"line_number":362,"context_line":"                                             attrs[\u0027local_ip\u0027])"},{"line_number":363,"context_line":"        self.br_tun.install_flood_to_tun(777, 888, [ofport])"},{"line_number":364,"context_line":"        test_packet \u003d (\"in_port\u003d1,dl_src\u003d12:34:56:ab:cd:ef,\""},{"line_number":365,"context_line":"                       \"dl_dst\u003d12:34:56:78:cc:dd,dl_type\u003d0x0800,\""},{"line_number":366,"context_line":"                       \"nw_src\u003d192.168.0.1,nw_dst\u003d192.168.0.2,\""},{"line_number":367,"context_line":"                       \"nw_proto\u003d1,nw_tos\u003d0,nw_ttl\u003d128,\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_576821b9","line":364,"range":{"start_line":364,"start_character":24,"end_line":364,"end_character":33},"updated":"2016-02-12 06:39:39.000000000","message":"what\u0027s this port 1?","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"2ee7ba8ced3f9681c03438026883d0f66883aa02","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        ofport \u003d self.br_tun.add_tunnel_port(port_name, attrs[\u0027remote_ip\u0027],"},{"line_number":362,"context_line":"                                             attrs[\u0027local_ip\u0027])"},{"line_number":363,"context_line":"        self.br_tun.install_flood_to_tun(777, 888, [ofport])"},{"line_number":364,"context_line":"        test_packet \u003d (\"in_port\u003d1,dl_src\u003d12:34:56:ab:cd:ef,\""},{"line_number":365,"context_line":"                       \"dl_dst\u003d12:34:56:78:cc:dd,dl_type\u003d0x0800,\""},{"line_number":366,"context_line":"                       \"nw_src\u003d192.168.0.1,nw_dst\u003d192.168.0.2,\""},{"line_number":367,"context_line":"                       \"nw_proto\u003d1,nw_tos\u003d0,nw_ttl\u003d128,\""}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_e90937df","line":364,"range":{"start_line":364,"start_character":24,"end_line":364,"end_character":33},"in_reply_to":"3a57f1b5_576821b9","updated":"2016-02-15 07:42:34.000000000","message":"Done","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d75af431fc9bfafccfa4f40d38e6c2f0ef2b47b","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                       \"nw_proto\u003d1,nw_tos\u003d0,nw_ttl\u003d128,\""},{"line_number":368,"context_line":"                       \"icmp_type\u003d8,icmp_code\u003d0,dl_vlan\u003d777\")"},{"line_number":369,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":370,"context_line":"        self.assertTrue(\"tun_id\u003d0x378\" in trace[\"Final flow\"])"},{"line_number":371,"context_line":"        self.assertTrue(\"vlan_tci\u003d0x0000,\" in trace[\"Final flow\"])"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        self.br_tun.delete_flood_to_tun(777)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_b79dd5bd","line":370,"range":{"start_line":370,"start_character":32,"end_line":370,"end_character":37},"updated":"2016-02-12 06:39:39.000000000","message":"can you make it clear that this is 888?","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"2ee7ba8ced3f9681c03438026883d0f66883aa02","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                       \"nw_proto\u003d1,nw_tos\u003d0,nw_ttl\u003d128,\""},{"line_number":368,"context_line":"                       \"icmp_type\u003d8,icmp_code\u003d0,dl_vlan\u003d777\")"},{"line_number":369,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":370,"context_line":"        self.assertTrue(\"tun_id\u003d0x378\" in trace[\"Final flow\"])"},{"line_number":371,"context_line":"        self.assertTrue(\"vlan_tci\u003d0x0000,\" in trace[\"Final flow\"])"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        self.br_tun.delete_flood_to_tun(777)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_1e5db3e9","line":370,"range":{"start_line":370,"start_character":32,"end_line":370,"end_character":37},"in_reply_to":"3a57f1b5_b79dd5bd","updated":"2016-02-15 07:42:34.000000000","message":"Done","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d75af431fc9bfafccfa4f40d38e6c2f0ef2b47b","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        self.br_tun.delete_flood_to_tun(777)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":376,"context_line":"        # trace outputs seem to have some variation"},{"line_number":377,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":378,"context_line":"            \"dl_vlan\u003d777\" not in trace[\"Final flow\"]):"},{"line_number":379,"context_line":"            self.fail(\"Unexpected final flow %s\" % trace[\"Final flow\"])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_57afc1e1","line":376,"updated":"2016-02-12 06:39:39.000000000","message":"why?","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"2ee7ba8ced3f9681c03438026883d0f66883aa02","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        self.br_tun.delete_flood_to_tun(777)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":376,"context_line":"        # trace outputs seem to have some variation"},{"line_number":377,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":378,"context_line":"            \"dl_vlan\u003d777\" not in trace[\"Final flow\"]):"},{"line_number":379,"context_line":"            self.fail(\"Unexpected final flow %s\" % trace[\"Final flow\"])"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_29e2ff03","line":376,"in_reply_to":"3a57f1b5_57afc1e1","updated":"2016-02-15 07:42:34.000000000","message":"ovs-appctl seems to return \"unchanged\" or the same flow as input.  I haven\u0027t checked the details but I think it suffices to check the vlan tag is intact here.","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c3b167965ab74e6f57b271ba09e726920c5310e8","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        self.br_tun.delete_flood_to_tun(777)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":376,"context_line":"        # trace outputs seem to have some variation"},{"line_number":377,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":378,"context_line":"            \"dl_vlan\u003d777\" not in trace[\"Final flow\"]):"},{"line_number":379,"context_line":"            self.fail(\"Unexpected final flow %s\" % trace[\"Final flow\"])"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_e23ac497","line":376,"in_reply_to":"dae33548_29e2ff03","updated":"2016-02-16 03:14:03.000000000","message":"it sounds like a bug to me.\ncan you add a REVISIT comment and post the trace to ovs-dev?","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"7b2dcc8d0e239fe885d22e7cb48af4c812486c3a","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        self.br_tun.delete_flood_to_tun(777)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":376,"context_line":"        # trace outputs seem to have some variation"},{"line_number":377,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":378,"context_line":"            \"dl_vlan\u003d777\" not in trace[\"Final flow\"]):"},{"line_number":379,"context_line":"            self.fail(\"Unexpected final flow %s\" % trace[\"Final flow\"])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_fbcb9870","line":376,"in_reply_to":"dae33548_e23ac497","updated":"2016-03-08 03:02:24.000000000","message":"ovs-appctl in the CI environment might want \"icmp\" rather than \"dl_type\u003d0x0800,nw_proto\u003d1\".  Let\u0027s see what happens.","commit_id":"01bb76687c1f808a0b2c0c76396d91ec8239b13c"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"5d9d1911f5c265775c924b57929cb8e92df8ba25","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                raise Exception(\u0027port allocation failed\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _run_trace(self, brname, spec):"},{"line_number":95,"context_line":"        required_keys \u003d [\u0027Final flow\u0027, \u0027Datapath actions\u0027]"},{"line_number":96,"context_line":"        t \u003d utils.execute([\"ovs-appctl\", \"ofproto/trace\", brname, spec],"},{"line_number":97,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":98,"context_line":"        trace \u003d {}"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_3eb261e5","line":95,"updated":"2016-03-10 17:19:44.000000000","message":"can we define constants for \u0027Final flow\u0027 and \u0027Datapath actions\u0027 instead of using strings?","commit_id":"e60f2cfbbfb2362623bbb8494965abf6f40df972"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"14eae64823067caf9443e0514decaf822b5bad51","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                raise Exception(\u0027port allocation failed\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _run_trace(self, brname, spec):"},{"line_number":95,"context_line":"        required_keys \u003d [\u0027Final flow\u0027, \u0027Datapath actions\u0027]"},{"line_number":96,"context_line":"        t \u003d utils.execute([\"ovs-appctl\", \"ofproto/trace\", brname, spec],"},{"line_number":97,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":98,"context_line":"        trace \u003d {}"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_23c6ae49","line":95,"in_reply_to":"5aef4532_3eb261e5","updated":"2016-03-11 07:07:05.000000000","message":"Done","commit_id":"e60f2cfbbfb2362623bbb8494965abf6f40df972"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"5d9d1911f5c265775c924b57929cb8e92df8ba25","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        t \u003d utils.execute([\"ovs-appctl\", \"ofproto/trace\", brname, spec],"},{"line_number":97,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":98,"context_line":"        trace \u003d {}"},{"line_number":99,"context_line":"        trace[\u0027raw\u0027] \u003d t.splitlines()"},{"line_number":100,"context_line":"        for line in trace[\u0027raw\u0027]:"},{"line_number":101,"context_line":"            (l, sep, r) \u003d line.partition(\u0027:\u0027)"},{"line_number":102,"context_line":"            if not sep:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_fe7e39e2","line":99,"updated":"2016-03-10 17:19:44.000000000","message":"the key \u0027raw\u0027 is not used by the caller of this method, so I don\u0027t think we need to put it in the dict. Maybe you can just define a new variable\n\nraw_output \u003d t.splitlines()\n\nam I missing something?","commit_id":"e60f2cfbbfb2362623bbb8494965abf6f40df972"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"14eae64823067caf9443e0514decaf822b5bad51","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        t \u003d utils.execute([\"ovs-appctl\", \"ofproto/trace\", brname, spec],"},{"line_number":97,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":98,"context_line":"        trace \u003d {}"},{"line_number":99,"context_line":"        trace[\u0027raw\u0027] \u003d t.splitlines()"},{"line_number":100,"context_line":"        for line in trace[\u0027raw\u0027]:"},{"line_number":101,"context_line":"            (l, sep, r) \u003d line.partition(\u0027:\u0027)"},{"line_number":102,"context_line":"            if not sep:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_a3e0fecd","line":99,"in_reply_to":"5aef4532_fe7e39e2","updated":"2016-03-11 07:07:05.000000000","message":"Done","commit_id":"e60f2cfbbfb2362623bbb8494965abf6f40df972"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"5d9d1911f5c265775c924b57929cb8e92df8ba25","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                         self.br_int.check_canary_table())"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"class OVSFlowTestCase(OVSAgentTestBase):"},{"line_number":317,"context_line":"    def setUp(self):"},{"line_number":318,"context_line":"        cfg.CONF.set_override(\u0027enable_distributed_routing\u0027,"},{"line_number":319,"context_line":"                              True,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_1e1b2582","line":316,"updated":"2016-03-10 17:19:44.000000000","message":"since not everybody is familiar with ofproto/trace can you please add a docstring explaining what these tests are testing and how, thanks!","commit_id":"e60f2cfbbfb2362623bbb8494965abf6f40df972"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"14eae64823067caf9443e0514decaf822b5bad51","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                         self.br_int.check_canary_table())"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"class OVSFlowTestCase(OVSAgentTestBase):"},{"line_number":317,"context_line":"    def setUp(self):"},{"line_number":318,"context_line":"        cfg.CONF.set_override(\u0027enable_distributed_routing\u0027,"},{"line_number":319,"context_line":"                              True,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_e37046df","line":316,"in_reply_to":"5aef4532_1e1b2582","updated":"2016-03-11 07:07:05.000000000","message":"Done","commit_id":"e60f2cfbbfb2362623bbb8494965abf6f40df972"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"5d9d1911f5c265775c924b57929cb8e92df8ba25","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        self.br_tun.setup_default_table(self.tun_p, True)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def test_provision_local_vlan(self):"},{"line_number":342,"context_line":"        self.br_phys.provision_local_vlan(port\u003d123, lvid\u003d888,"},{"line_number":343,"context_line":"                                          segmentation_id\u003d777,"},{"line_number":344,"context_line":"                                          distributed\u003dFalse)"},{"line_number":345,"context_line":"        trace \u003d self._run_trace(self.phys_br.br_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_dee41dad","line":342,"updated":"2016-03-10 17:19:44.000000000","message":"it would help readability if you define variables like:\n\nin_port \u003d 123\nlvid\u003d 888 and so on \n\nso that can be used here and later in lines 346-350\n\nditto for the other tests.","commit_id":"e60f2cfbbfb2362623bbb8494965abf6f40df972"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"14eae64823067caf9443e0514decaf822b5bad51","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        self.br_tun.setup_default_table(self.tun_p, True)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def test_provision_local_vlan(self):"},{"line_number":342,"context_line":"        self.br_phys.provision_local_vlan(port\u003d123, lvid\u003d888,"},{"line_number":343,"context_line":"                                          segmentation_id\u003d777,"},{"line_number":344,"context_line":"                                          distributed\u003dFalse)"},{"line_number":345,"context_line":"        trace \u003d self._run_trace(self.phys_br.br_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_a62e4cf8","line":342,"in_reply_to":"5aef4532_dee41dad","updated":"2016-03-11 07:07:05.000000000","message":"Done","commit_id":"e60f2cfbbfb2362623bbb8494965abf6f40df972"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"5d9d1911f5c265775c924b57929cb8e92df8ba25","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        self.br_tun.delete_flood_to_tun(777)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":393,"context_line":"        # trace outputs seem to have some variation,"},{"line_number":394,"context_line":"        # probably due to ovs commit ce58df5be."},{"line_number":395,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":396,"context_line":"            \"dl_vlan\u003d777\" not in trace[\"Final flow\"]):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_9eea95d9","line":393,"updated":"2016-03-10 17:19:44.000000000","message":"can you elaborate please?","commit_id":"e60f2cfbbfb2362623bbb8494965abf6f40df972"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"14eae64823067caf9443e0514decaf822b5bad51","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        self.br_tun.delete_flood_to_tun(777)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":393,"context_line":"        # trace outputs seem to have some variation,"},{"line_number":394,"context_line":"        # probably due to ovs commit ce58df5be."},{"line_number":395,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":396,"context_line":"            \"dl_vlan\u003d777\" not in trace[\"Final flow\"]):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_26d7dcc0","line":393,"in_reply_to":"5aef4532_9eea95d9","updated":"2016-03-11 07:07:05.000000000","message":"Older OVS returns \"unchanged\" but recent version returns test_packet string above as Final flow.","commit_id":"e60f2cfbbfb2362623bbb8494965abf6f40df972"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"7c8e876659aeda5bc4c774c44e493a275bba8b82","unresolved":false,"context_lines":[{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":398,"context_line":"        # We need to check if the vlan ID is intact here, but trace"},{"line_number":399,"context_line":"        # outputs seem to have some variation, probably due to ovs"},{"line_number":400,"context_line":"        # commit ce58df5be."},{"line_number":401,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":402,"context_line":"            (\"dl_vlan\u003d%(vlan)d\" % kwargs) not in trace[\"Final flow\"]):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_b16168ab","line":399,"range":{"start_line":399,"start_character":36,"end_line":399,"end_character":45},"updated":"2016-03-11 07:31:13.000000000","message":"this is variation among OVS versions, rather than iterations?","commit_id":"b2ddcc714a5073cd06795ea5fd1478420a9e57be"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"13ac0c9c3e91f37c9ffb6bc7e45423f607e9fd73","unresolved":false,"context_lines":[{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":398,"context_line":"        # We need to check if the vlan ID is intact here, but trace"},{"line_number":399,"context_line":"        # outputs seem to have some variation, probably due to ovs"},{"line_number":400,"context_line":"        # commit ce58df5be."},{"line_number":401,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":402,"context_line":"            (\"dl_vlan\u003d%(vlan)d\" % kwargs) not in trace[\"Final flow\"]):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa0719c6_468b5ec3","line":399,"range":{"start_line":399,"start_character":36,"end_line":399,"end_character":45},"in_reply_to":"1af94dfe_a72baa93","updated":"2016-03-23 15:14:00.000000000","message":"Wow a fix for it already, great!\nIwamoto can I ask you to update this comment referencing yamamoto\u0027s patch and maybe add a TODO to modify this once yamamoto\u0027s patch is merged into ovs? Thanks!","commit_id":"b2ddcc714a5073cd06795ea5fd1478420a9e57be"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c4ba95b8262f3a02d2accd893ad7ca93358b2d4f","unresolved":false,"context_lines":[{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":398,"context_line":"        # We need to check if the vlan ID is intact here, but trace"},{"line_number":399,"context_line":"        # outputs seem to have some variation, probably due to ovs"},{"line_number":400,"context_line":"        # commit ce58df5be."},{"line_number":401,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":402,"context_line":"            (\"dl_vlan\u003d%(vlan)d\" % kwargs) not in trace[\"Final flow\"]):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1af94dfe_a72baa93","line":399,"range":{"start_line":399,"start_character":36,"end_line":399,"end_character":45},"in_reply_to":"1af94dfe_b7d80ff1","updated":"2016-03-16 12:45:07.000000000","message":"http://openvswitch.org/pipermail/dev/2016-March/067830.html","commit_id":"b2ddcc714a5073cd06795ea5fd1478420a9e57be"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"31e9d75d90276e9f362d59100f77cad4b993dccb","unresolved":false,"context_lines":[{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":398,"context_line":"        # We need to check if the vlan ID is intact here, but trace"},{"line_number":399,"context_line":"        # outputs seem to have some variation, probably due to ovs"},{"line_number":400,"context_line":"        # commit ce58df5be."},{"line_number":401,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":402,"context_line":"            (\"dl_vlan\u003d%(vlan)d\" % kwargs) not in trace[\"Final flow\"]):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1af94dfe_b7d80ff1","line":399,"range":{"start_line":399,"start_character":36,"end_line":399,"end_character":45},"in_reply_to":"3afc51ec_2793e350","updated":"2016-03-16 02:31:11.000000000","message":"http://logs.openstack.org/55/235155/8/check/gate-neutron-dsvm-functional/8a0321c/testr_results.html.gz","commit_id":"b2ddcc714a5073cd06795ea5fd1478420a9e57be"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"ef3f413458ee9395810a08903345a43154fb8b11","unresolved":false,"context_lines":[{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":398,"context_line":"        # We need to check if the vlan ID is intact here, but trace"},{"line_number":399,"context_line":"        # outputs seem to have some variation, probably due to ovs"},{"line_number":400,"context_line":"        # commit ce58df5be."},{"line_number":401,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":402,"context_line":"            (\"dl_vlan\u003d%(vlan)d\" % kwargs) not in trace[\"Final flow\"]):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_f70f6086","line":399,"range":{"start_line":399,"start_character":36,"end_line":399,"end_character":45},"in_reply_to":"5aef4532_b16168ab","updated":"2016-03-11 08:56:39.000000000","message":"As far as I see, it\u0027s \"unchanged\" in ubuntu 14.04.\nIIRC the gate is running newer OVS for conntrack, and the output isn\u0027t \"unchanged\" there.","commit_id":"b2ddcc714a5073cd06795ea5fd1478420a9e57be"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f3d49abde44854732fbe7f0345fd024ee3553a34","unresolved":false,"context_lines":[{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":398,"context_line":"        # We need to check if the vlan ID is intact here, but trace"},{"line_number":399,"context_line":"        # outputs seem to have some variation, probably due to ovs"},{"line_number":400,"context_line":"        # commit ce58df5be."},{"line_number":401,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":402,"context_line":"            (\"dl_vlan\u003d%(vlan)d\" % kwargs) not in trace[\"Final flow\"]):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3afc51ec_2793e350","line":399,"range":{"start_line":399,"start_character":36,"end_line":399,"end_character":45},"in_reply_to":"5aef4532_f70f6086","updated":"2016-03-15 00:20:37.000000000","message":"can you provide a pointer to the output on gate?","commit_id":"b2ddcc714a5073cd06795ea5fd1478420a9e57be"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0c7db0f35b839bcd90c9186de167382750172682","unresolved":false,"context_lines":[{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":398,"context_line":"        # We need to check if the vlan ID is intact here, but trace"},{"line_number":399,"context_line":"        # outputs seem to have some variation, probably due to ovs"},{"line_number":400,"context_line":"        # commit ce58df5be."},{"line_number":401,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":402,"context_line":"            (\"dl_vlan\u003d%(vlan)d\" % kwargs) not in trace[\"Final flow\"]):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa0719c6_c03d8e90","line":399,"range":{"start_line":399,"start_character":36,"end_line":399,"end_character":45},"in_reply_to":"fa0719c6_468b5ec3","updated":"2016-03-23 16:14:32.000000000","message":"i merged the fix to ovs master.","commit_id":"b2ddcc714a5073cd06795ea5fd1478420a9e57be"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0479b2b93a373ec89c4841b86573d1086945be28","unresolved":false,"context_lines":[{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":398,"context_line":"        # We need to check if the vlan ID is intact here, but trace"},{"line_number":399,"context_line":"        # outputs seem to have some variation, probably due to ovs"},{"line_number":400,"context_line":"        # commit ce58df5be."},{"line_number":401,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":402,"context_line":"            (\"dl_vlan\u003d%(vlan)d\" % kwargs) not in trace[\"Final flow\"]):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa0719c6_f5cdda66","line":399,"range":{"start_line":399,"start_character":36,"end_line":399,"end_character":45},"in_reply_to":"fa0719c6_950bbe23","updated":"2016-03-24 02:12:21.000000000","message":"the gate is using some version from branch-2.5.\ni guess you can update OVS_BRANCH in gate_hook.sh.","commit_id":"b2ddcc714a5073cd06795ea5fd1478420a9e57be"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"7051d9c3ed88eb112b7a9b1bded4f34a441565df","unresolved":false,"context_lines":[{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        trace \u003d self._run_trace(self.tun_br.br_name, test_packet)"},{"line_number":398,"context_line":"        # We need to check if the vlan ID is intact here, but trace"},{"line_number":399,"context_line":"        # outputs seem to have some variation, probably due to ovs"},{"line_number":400,"context_line":"        # commit ce58df5be."},{"line_number":401,"context_line":"        if (\"unchanged\" not in trace[\"Final flow\"] and"},{"line_number":402,"context_line":"            (\"dl_vlan\u003d%(vlan)d\" % kwargs) not in trace[\"Final flow\"]):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa0719c6_950bbe23","line":399,"range":{"start_line":399,"start_character":36,"end_line":399,"end_character":45},"in_reply_to":"fa0719c6_c03d8e90","updated":"2016-03-24 01:57:02.000000000","message":"IIRC, the gate is using OVS master.\nThen we no longer need the above comment.","commit_id":"b2ddcc714a5073cd06795ea5fd1478420a9e57be"}]}
