)]}'
{"quantum/tests/unit/test_iptables_firewall.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2284377adf5de1358194231bf1866f60699d4cc1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from quantum.tests.unit import test_api_v2"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"cfg.CONF.register_opts(a_cfg.ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"_uuid \u003d test_api_v2._uuid"},{"line_number":31,"context_line":"FAKE_PREFIX \u003d {\u0027IPv4\u0027: \u002710.0.0.0/24\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F9O0%3D","line":28,"updated":"2013-03-05 10:11:09.000000000","message":"these are globals, so they will affect other tests as well potentially leading to errors because options are already defined.\n\nCan you consider either using import_opts, or adding a cleanup hook for resetting the configuration?\n\nboth approaches are used throughout unit tests, so it\u0027s something you could in theory copy \u0026 paste.","commit_id":"064e881ee91e67c4d3bc234e48c5a0b201c9b268"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"d44b42228e19702e630c4a1d71bbe993f62b3c36","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from quantum.tests.unit import test_api_v2"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"cfg.CONF.register_opts(a_cfg.ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"_uuid \u003d test_api_v2._uuid"},{"line_number":31,"context_line":"FAKE_PREFIX \u003d {\u0027IPv4\u0027: \u002710.0.0.0/24\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F9Oc%3D","line":28,"in_reply_to":"AAAAN3%2F%2F9O0%3D","updated":"2013-03-05 10:19:13.000000000","message":"That is exactly what I\u0027ve discovered I\u0027ll try import_opts","commit_id":"064e881ee91e67c4d3bc234e48c5a0b201c9b268"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":33,"context_line":"class IptablesFirewallTestCase(testtools.TestCase):"},{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(IptablesFirewallTestCase, self).setUp()"},{"line_number":36,"context_line":"        cfg.CONF.import_opt(\u0027root_helper\u0027,"},{"line_number":37,"context_line":"                            \u0027quantum.plugins.linuxbridge.common.config\u0027,"},{"line_number":38,"context_line":"                            \u0027AGENT\u0027)"},{"line_number":39,"context_line":"        self.utils_exec_p \u003d mock.patch("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F9Jw%3D","line":36,"updated":"2013-03-05 11:27:26.000000000","message":"why is this taken from linux bridge and not https://github.com/openstack/quantum/blob/master/quantum/agent/common/config.py#L38?","commit_id":"b84bf253b1274ebdda2b62024c570f7ef94385cc"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"d44b42228e19702e630c4a1d71bbe993f62b3c36","unresolved":false,"context_lines":[{"line_number":33,"context_line":"class IptablesFirewallTestCase(testtools.TestCase):"},{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(IptablesFirewallTestCase, self).setUp()"},{"line_number":36,"context_line":"        cfg.CONF.import_opt(\u0027root_helper\u0027,"},{"line_number":37,"context_line":"                            \u0027quantum.plugins.linuxbridge.common.config\u0027,"},{"line_number":38,"context_line":"                            \u0027AGENT\u0027)"},{"line_number":39,"context_line":"        self.utils_exec_p \u003d mock.patch("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F85Q%3D","line":36,"in_reply_to":"AAAAN3%2F%2F9Jw%3D","updated":"2013-03-05 14:32:17.000000000","message":"garyk, then I\u0027ll register_opt root_helper from quantum.agent.common.config. Or maybe just run the helper function.","commit_id":"b84bf253b1274ebdda2b62024c570f7ef94385cc"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d4bb6930a2a6046db933f725481e235ec1568f4b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class IptablesFirewallTestCase(base.BaseTestCase):"},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(IptablesFirewallTestCase, self).setUp()"},{"line_number":37,"context_line":"        cfg.CONF.register_opts(a_cfg.ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":38,"context_line":"        self.utils_exec_p \u003d mock.patch("},{"line_number":39,"context_line":"            \u0027quantum.agent.linux.utils.execute\u0027)"},{"line_number":40,"context_line":"        self.utils_exec \u003d self.utils_exec_p.start()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F5c4%3D","line":37,"updated":"2013-03-07 05:40:59.000000000","message":"Why not call:\n\na_cfg.register_root_helper(cfg.CONF) in line 32?","commit_id":"c77d8db892b7ab5a706aac8bddb3513766f32889"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d4bb6930a2a6046db933f725481e235ec1568f4b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class IptablesFirewallTestCase(base.BaseTestCase):"},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(IptablesFirewallTestCase, self).setUp()"},{"line_number":37,"context_line":"        cfg.CONF.register_opts(a_cfg.ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":38,"context_line":"        self.utils_exec_p \u003d mock.patch("},{"line_number":39,"context_line":"            \u0027quantum.agent.linux.utils.execute\u0027)"},{"line_number":40,"context_line":"        self.utils_exec \u003d self.utils_exec_p.start()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F1uo%3D","line":37,"in_reply_to":"AAAAN3%2F%2F5Vw%3D","updated":"2013-03-09 23:16:19.000000000","message":"Ok.  That reasoning makes sense.","commit_id":"c77d8db892b7ab5a706aac8bddb3513766f32889"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":"class IptablesFirewallTestCase(base.BaseTestCase):"},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(IptablesFirewallTestCase, self).setUp()"},{"line_number":37,"context_line":"        cfg.CONF.register_opts(a_cfg.ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":38,"context_line":"        self.utils_exec_p \u003d mock.patch("},{"line_number":39,"context_line":"            \u0027quantum.agent.linux.utils.execute\u0027)"},{"line_number":40,"context_line":"        self.utils_exec \u003d self.utils_exec_p.start()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F5Vw%3D","line":37,"in_reply_to":"AAAAN3%2F%2F5WY%3D","updated":"2013-03-07 07:28:38.000000000","message":"Regarding root_helper, it is recommended to use register_root_helper() in general. It is prepared to support migration of root_helper from [DEFAULT] to [AGENT] in Grizzly.\n\nBut it is a unit test. If you need to register root_helper explicitly only to [AGENT] section, please keep the current style.","commit_id":"c77d8db892b7ab5a706aac8bddb3513766f32889"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":"class IptablesFirewallTestCase(base.BaseTestCase):"},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(IptablesFirewallTestCase, self).setUp()"},{"line_number":37,"context_line":"        cfg.CONF.register_opts(a_cfg.ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":38,"context_line":"        self.utils_exec_p \u003d mock.patch("},{"line_number":39,"context_line":"            \u0027quantum.agent.linux.utils.execute\u0027)"},{"line_number":40,"context_line":"        self.utils_exec \u003d self.utils_exec_p.start()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F5WY%3D","line":37,"in_reply_to":"AAAAN3%2F%2F5c4%3D","updated":"2013-03-07 07:23:02.000000000","message":"It\u0027s just because the majority of the test modules use register_opts. Did think of that but personally thought it would be better this way.","commit_id":"c77d8db892b7ab5a706aac8bddb3513766f32889"}]}