)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"e92da4cdb3dc9d6cac567997d6f551902989db59","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hong Hui Xiao \u003cxiaohhui@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-20 11:48:12 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t snat traffic to internal ports when snat is disabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is a traffic between internal ports, and internal ports"},{"line_number":10,"context_line":"all have floatingip associated, router will snat the traffic if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_b25a1e4f","line":7,"updated":"2015-11-09 18:08:57.000000000","message":"I think it would be more clear to reviewers to set the title of this commit message to: \"Don\u0027t snat traffic to/from fixed IPs if behind same router\", so reviewers don\u0027t think this behavior is specific to whether snat is disabled.  It took me a while as I was reviewing this to see that it was most likely an accident that this rule wasn\u0027t added when snat was disabled.","commit_id":"35731fa47bb7681b449bf6331842b319a3cc9ddf"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"e92da4cdb3dc9d6cac567997d6f551902989db59","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t snat traffic to internal ports when snat is disabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there is a traffic between internal ports, and internal ports"},{"line_number":10,"context_line":"all have floatingip associated, router will snat the traffic if"},{"line_number":11,"context_line":"router disable snat."},{"line_number":12,"context_line":"When snat is enabled for router, a rule will be added to postrouting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_7202760d","line":9,"updated":"2015-11-09 18:08:57.000000000","message":"Just to make it more clear, I would start the description with something like: \"This fixes a bug where an iptables rule to not snat traffic to/from fixed IPs is only being added if enable_snat\u003dtrue.  We should add this rule no matter what the value is for enable_snat.\"","commit_id":"35731fa47bb7681b449bf6331842b319a3cc9ddf"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"e92da4cdb3dc9d6cac567997d6f551902989db59","unresolved":false,"context_lines":[{"line_number":11,"context_line":"router disable snat."},{"line_number":12,"context_line":"When snat is enabled for router, a rule will be added to postrouting"},{"line_number":13,"context_line":"chain to prevent such snat. So, we should add this rule no matter if"},{"line_number":14,"context_line":"snat is enabled for router."},{"line_number":15,"context_line":"Change-Id: I322e8d454ef1d529ceda541fb5fe577cd70b412f"},{"line_number":16,"context_line":"Closes-bug: #1505781"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_3dbeffd4","line":14,"updated":"2015-11-09 18:08:57.000000000","message":"Should have blank line after description for readability","commit_id":"35731fa47bb7681b449bf6331842b319a3cc9ddf"}],"neutron/agent/l3/router_info.py":[{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"5eb54ce40a0b46b7b0cc0a233d337dbe38ec0e78","unresolved":false,"context_lines":[{"line_number":596,"context_line":"                           \u0027! -o %(interface_name)s -m conntrack ! \u0027"},{"line_number":597,"context_line":"                           \u0027--ctstate DNAT -j ACCEPT\u0027 %"},{"line_number":598,"context_line":"                           {\u0027interface_name\u0027: interface_name})"},{"line_number":599,"context_line":"        return [dont_snat_traffic_to_internal_ports_if_not_to_floating_ip]"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def external_gateway_nat_snat_rules(self, ex_gw_ip, interface_name):"},{"line_number":602,"context_line":"        snat_normal_external_traffic \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_067c5eea","line":599,"updated":"2015-11-12 15:17:04.000000000","message":"nit: If there is no extension possibility, returning a list seems no necessary.","commit_id":"4341a4faeed937d014e95a94b77844d5a835acbe"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"a0a5be91b21d66540013a8dbd606248a94b20e4b","unresolved":false,"context_lines":[{"line_number":596,"context_line":"                           \u0027! -o %(interface_name)s -m conntrack ! \u0027"},{"line_number":597,"context_line":"                           \u0027--ctstate DNAT -j ACCEPT\u0027 %"},{"line_number":598,"context_line":"                           {\u0027interface_name\u0027: interface_name})"},{"line_number":599,"context_line":"        return [dont_snat_traffic_to_internal_ports_if_not_to_floating_ip]"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def external_gateway_nat_snat_rules(self, ex_gw_ip, interface_name):"},{"line_number":602,"context_line":"        snat_normal_external_traffic \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_da5d6bed","line":599,"in_reply_to":"da85f559_067c5eea","updated":"2015-11-15 04:01:34.000000000","message":"Agree","commit_id":"4341a4faeed937d014e95a94b77844d5a835acbe"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8a862a97c04a27ae48b92bb116830900bc4ccca6","unresolved":false,"context_lines":[{"line_number":596,"context_line":"                           \u0027! -o %(interface_name)s -m conntrack ! \u0027"},{"line_number":597,"context_line":"                           \u0027--ctstate DNAT -j ACCEPT\u0027 %"},{"line_number":598,"context_line":"                           {\u0027interface_name\u0027: interface_name})"},{"line_number":599,"context_line":"        return [dont_snat_traffic_to_internal_ports_if_not_to_floating_ip]"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def external_gateway_nat_snat_rules(self, ex_gw_ip, interface_name):"},{"line_number":602,"context_line":"        snat_normal_external_traffic \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_1cd04cf5","line":599,"in_reply_to":"da85f559_da5d6bed","updated":"2016-01-06 18:20:41.000000000","message":"I don\u0027t mind it this way for consistency and to avoid extra disruption below where it is called.","commit_id":"4341a4faeed937d014e95a94b77844d5a835acbe"}],"neutron/tests/unit/agent/l3/test_agent.py":[{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"1167298fc1b8af8d43cd7724863b6155d1cffb2d","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        orig_nat_rules \u003d ri.iptables_manager.ipv4[\u0027nat\u0027].rules[:]"},{"line_number":1019,"context_line":"        orig_mangle_rules \u003d ri.iptables_manager.ipv4[\u0027mangle\u0027].rules[:]"},{"line_number":1020,"context_line":"        # Reprocess without NAT"},{"line_number":1021,"context_line":"        router[\u0027enable_snat\u0027] \u003d False"},{"line_number":1022,"context_line":"        # Reassign the router object to RouterInfo"},{"line_number":1023,"context_line":"        ri.router \u003d router"},{"line_number":1024,"context_line":"        ri.process(agent)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_80d113fe","line":1021,"updated":"2015-10-18 15:47:10.000000000","message":"nit: is it possible to directly process without NAT ?","commit_id":"f746afd4cf4a6cfe6e0cc97310d7709c2e5209e3"}]}
