)]}'
{"doc/source/devref/contribute.rst":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"fd5371eda109f5766ab14ac00aa343907d84ca84","unresolved":false,"context_lines":[{"line_number":351,"context_line":"+++++++++++++"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"The existing shims shall now be moved out of tree, together with any test"},{"line_number":354,"context_line":"code. The entry points shall be moved as described below in `Entry Points`_."},{"line_number":355,"context_line":""},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"Configuration Files"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_d254a8cb","side":"PARENT","line":354,"updated":"2015-10-26 06:51:19.000000000","message":"Doesn\u0027t this leave an empty heading section? Or is gertty messing up the diff?","commit_id":"7b715bd6355986b593f01e059e1dd9b701a8c191"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5049658de1c1db9d1cb5bbbe7f759dfa1f80cdca","unresolved":false,"context_lines":[{"line_number":351,"context_line":"+++++++++++++"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"The existing shims shall now be moved out of tree, together with any test"},{"line_number":354,"context_line":"code. The entry points shall be moved as described below in `Entry Points`_."},{"line_number":355,"context_line":""},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"Configuration Files"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_e751f363","side":"PARENT","line":354,"in_reply_to":"3a29b11f_d254a8cb","updated":"2015-10-28 01:29:04.000000000","message":"The section I am removing is\n\n  Existing Shims\n    Liberty Steps\n\n(See the heading levels in the comment at the top of this file.)","commit_id":"7b715bd6355986b593f01e059e1dd9b701a8c191"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0090bfc6b636bb58936e3d5594572876176a8198","unresolved":false,"context_lines":[{"line_number":439,"context_line":"   third-party repo as is done in the neutron repo,"},{"line_number":440,"context_line":"   i.e. ``networking_foo/db/migration/alembic_migrations/versions/*.py``"},{"line_number":441,"context_line":"#. Remove the models from the neutron repo."},{"line_number":442,"context_line":"#. Add the names of the removed tables to ``REPO_FOO_TABLES`` in"},{"line_number":443,"context_line":"   ``neutron/db/migration/alembic_migrations/external.py`` (this is used for"},{"line_number":444,"context_line":"   testing, see below)."},{"line_number":445,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_21e642e8","side":"PARENT","line":442,"updated":"2015-10-22 12:47:18.000000000","message":"Aren\u0027t 3 party repos still supposed to maintain the names of their tables in external.py?","commit_id":"7b715bd6355986b593f01e059e1dd9b701a8c191"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"116baae7bec849e0264d3d1fb1a2715e5bbbc7ee","unresolved":false,"context_lines":[{"line_number":439,"context_line":"   third-party repo as is done in the neutron repo,"},{"line_number":440,"context_line":"   i.e. ``networking_foo/db/migration/alembic_migrations/versions/*.py``"},{"line_number":441,"context_line":"#. Remove the models from the neutron repo."},{"line_number":442,"context_line":"#. Add the names of the removed tables to ``REPO_FOO_TABLES`` in"},{"line_number":443,"context_line":"   ``neutron/db/migration/alembic_migrations/external.py`` (this is used for"},{"line_number":444,"context_line":"   testing, see below)."},{"line_number":445,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_364ae255","side":"PARENT","line":442,"updated":"2015-10-23 08:25:53.000000000","message":"this should probably be emphasized in bold or something as well. If a vendor fails to do this it will create a grand catastrophe when there is a table name collision upstream.\n\nIn fact, I wonder if we should have some runtime logic that throws giant ugly errors for using an unregistered table...","commit_id":"7b715bd6355986b593f01e059e1dd9b701a8c191"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"dccf6c662ec77bb84e0ba3702acb3758c4c28c79","unresolved":false,"context_lines":[{"line_number":439,"context_line":"   third-party repo as is done in the neutron repo,"},{"line_number":440,"context_line":"   i.e. ``networking_foo/db/migration/alembic_migrations/versions/*.py``"},{"line_number":441,"context_line":"#. Remove the models from the neutron repo."},{"line_number":442,"context_line":"#. Add the names of the removed tables to ``REPO_FOO_TABLES`` in"},{"line_number":443,"context_line":"   ``neutron/db/migration/alembic_migrations/external.py`` (this is used for"},{"line_number":444,"context_line":"   testing, see below)."},{"line_number":445,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_a3bd6003","side":"PARENT","line":442,"in_reply_to":"1a26ad4f_e7ad7332","updated":"2015-11-28 01:14:27.000000000","message":"Adding the removed tables to external.py only applies to 3rd-party repos that have tables built by neutron migrations from the pre-split era. Since these have now all been done (or have patches out for final removal), I am removing the step. It does not apply to new extension repos.\n\nI will change the text at line 359 to require prefixing table names. How to enforce table name uniqueness is still being investigated.","commit_id":"7b715bd6355986b593f01e059e1dd9b701a8c191"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"c6fb10471ff176a2361c0891f575121a41f627e3","unresolved":false,"context_lines":[{"line_number":439,"context_line":"   third-party repo as is done in the neutron repo,"},{"line_number":440,"context_line":"   i.e. ``networking_foo/db/migration/alembic_migrations/versions/*.py``"},{"line_number":441,"context_line":"#. Remove the models from the neutron repo."},{"line_number":442,"context_line":"#. Add the names of the removed tables to ``REPO_FOO_TABLES`` in"},{"line_number":443,"context_line":"   ``neutron/db/migration/alembic_migrations/external.py`` (this is used for"},{"line_number":444,"context_line":"   testing, see below)."},{"line_number":445,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_b32936e8","side":"PARENT","line":442,"in_reply_to":"3a29b11f_21e642e8","updated":"2015-10-22 18:13:26.000000000","message":"Good catch.","commit_id":"7b715bd6355986b593f01e059e1dd9b701a8c191"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5049658de1c1db9d1cb5bbbe7f759dfa1f80cdca","unresolved":false,"context_lines":[{"line_number":439,"context_line":"   third-party repo as is done in the neutron repo,"},{"line_number":440,"context_line":"   i.e. ``networking_foo/db/migration/alembic_migrations/versions/*.py``"},{"line_number":441,"context_line":"#. Remove the models from the neutron repo."},{"line_number":442,"context_line":"#. Add the names of the removed tables to ``REPO_FOO_TABLES`` in"},{"line_number":443,"context_line":"   ``neutron/db/migration/alembic_migrations/external.py`` (this is used for"},{"line_number":444,"context_line":"   testing, see below)."},{"line_number":445,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_e7ad7332","side":"PARENT","line":442,"in_reply_to":"3a29b11f_364ae255","updated":"2015-10-28 01:29:04.000000000","message":"There is also the issue of external repos adding new tables and causing a collision. How do we detect those? It may be possible to do something in neutron-db-manage upgrade. Let me ponder this a little.","commit_id":"7b715bd6355986b593f01e059e1dd9b701a8c191"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"96ac9717fbfb11ed7daa568c220de31edae9e70e","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        neutron-ovsvapp-agent \u003d neutron.cmd.eventlet.plugins.ovsvapp_neutron_agent:main"},{"line_number":546,"context_line":"        neutron-restproxy-agent \u003d neutron.plugins.bigswitch.agent.restproxy_agent:main"},{"line_number":547,"context_line":"    neutron.core_plugins \u003d"},{"line_number":548,"context_line":"        bigswitch \u003d neutron.plugins.bigswitch.plugin:NeutronRestProxyV2"},{"line_number":549,"context_line":"        brocade \u003d neutron.plugins.brocade.NeutronPlugin:BrocadePluginV2"},{"line_number":550,"context_line":"        nuage \u003d neutron.plugins.nuage.plugin:NuagePlugin"},{"line_number":551,"context_line":"    neutron.service_plugins \u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_530b1b2a","line":548,"updated":"2015-10-22 09:15:10.000000000","message":"i think that this is in the process of being removed","commit_id":"88537c906e5b43ef9aa1a7fc6907c658946346c9"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"c6fb10471ff176a2361c0891f575121a41f627e3","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        neutron-ovsvapp-agent \u003d neutron.cmd.eventlet.plugins.ovsvapp_neutron_agent:main"},{"line_number":546,"context_line":"        neutron-restproxy-agent \u003d neutron.plugins.bigswitch.agent.restproxy_agent:main"},{"line_number":547,"context_line":"    neutron.core_plugins \u003d"},{"line_number":548,"context_line":"        bigswitch \u003d neutron.plugins.bigswitch.plugin:NeutronRestProxyV2"},{"line_number":549,"context_line":"        brocade \u003d neutron.plugins.brocade.NeutronPlugin:BrocadePluginV2"},{"line_number":550,"context_line":"        nuage \u003d neutron.plugins.nuage.plugin:NuagePlugin"},{"line_number":551,"context_line":"    neutron.service_plugins \u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_f3e6ceae","line":548,"in_reply_to":"3a29b11f_530b1b2a","updated":"2015-10-22 18:13:26.000000000","message":"It\u0027s a review race!\n\nOn a more serious note, I\u0027ll try to make this list as current as possible before it merges. After that the decomposing patches should update this list. Or do you think there is no point in listing them here?","commit_id":"88537c906e5b43ef9aa1a7fc6907c658946346c9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"96ac9717fbfb11ed7daa568c220de31edae9e70e","unresolved":false,"context_lines":[{"line_number":549,"context_line":"        brocade \u003d neutron.plugins.brocade.NeutronPlugin:BrocadePluginV2"},{"line_number":550,"context_line":"        nuage \u003d neutron.plugins.nuage.plugin:NuagePlugin"},{"line_number":551,"context_line":"    neutron.service_plugins \u003d"},{"line_number":552,"context_line":"        bigswitch_l3 \u003d neutron.plugins.bigswitch.l3_router_plugin:L3RestProxy"},{"line_number":553,"context_line":"        brocade_vyatta_l3 \u003d neutron.services.l3_router.brocade.vyatta.vrouter_neutron_plugin:VyattaVRouterPlugin"},{"line_number":554,"context_line":"        brocade_mlx_l3 \u003d neutron.services.l3_router.brocade.mlx.l3_router_plugin:BrocadeRouterPlugin"},{"line_number":555,"context_line":"        fsl_firewall \u003d neutron_fwaas.services.firewall.freescale.fwaas_plugin:FirewallPlugin"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a29b11f_b6029d08","line":552,"updated":"2015-10-22 09:15:10.000000000","message":"ditto","commit_id":"88537c906e5b43ef9aa1a7fc6907c658946346c9"}]}