)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"37322e176b2af373ec64238fe8612634bd077532","unresolved":false,"context_lines":[{"line_number":12,"context_line":"needing DHCPv6 for the DNS configuration."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch configures RADVD daemon to include RDNSS entries in"},{"line_number":15,"context_line":"the Router Advertisements when the IPv6 subnet has dns_servers."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1495465"},{"line_number":18,"context_line":"Change-Id: Ia516d40b1c7a83cd7046b2b7f42d1204f44288a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba8a016a_6c2ee2fb","line":15,"updated":"2015-11-24 06:30:28.000000000","message":"dns_nameservers - not dns_servers","commit_id":"ff1d6299bc0923362679022de9c71159c4647385"}],"neutron/agent/linux/ra.py":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"86a82074103970da5bc71518b23900a658f8e62a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    subnet[\u0027ipv6_ra_mode\u0027] \u003d\u003d constants.DHCPV6_STATELESS]"},{"line_number":95,"context_line":"            interface_name \u003d self._dev_name_helper(p[\u0027id\u0027])"},{"line_number":96,"context_line":"            dns_servers \u003d list(iter_chain(*[[dns for dns in"},{"line_number":97,"context_line":"                subnet[\u0027dns_nameservers\u0027]] for subnet in v6_subnets if"},{"line_number":98,"context_line":"                subnet.get(\u0027dns_nameservers\u0027)]))"},{"line_number":99,"context_line":"            buf.write(\u0027%s\u0027 % CONFIG_TEMPLATE.render("},{"line_number":100,"context_line":"                ra_modes\u003dlist(ra_modes),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_e1cebf59","line":97,"updated":"2015-10-19 08:41:32.000000000","message":"Can\u0027t [dns for dns in subnet[\u0027dns_nameservers\u0027]] be simply subnet[\u0027dns_nameserver\u0027]?","commit_id":"e9ee042a2839e1d0f9db97fc0a2cfec963083602"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"380c0cba43d5866cf1926aa7777807036c492487","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    subnet[\u0027ipv6_ra_mode\u0027] \u003d\u003d constants.DHCPV6_STATELESS]"},{"line_number":95,"context_line":"            interface_name \u003d self._dev_name_helper(p[\u0027id\u0027])"},{"line_number":96,"context_line":"            dns_servers \u003d list(iter_chain(*[[dns for dns in"},{"line_number":97,"context_line":"                subnet[\u0027dns_nameservers\u0027]] for subnet in v6_subnets if"},{"line_number":98,"context_line":"                subnet.get(\u0027dns_nameservers\u0027)]))"},{"line_number":99,"context_line":"            buf.write(\u0027%s\u0027 % CONFIG_TEMPLATE.render("},{"line_number":100,"context_line":"                ra_modes\u003dlist(ra_modes),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_f4bc066e","line":97,"in_reply_to":"3a29b11f_5752d114","updated":"2015-10-20 05:19:35.000000000","message":"The list flattening is done by in iter_chain, and [dns for dns in x] is the same as x.\nSo it can be written as:\n\nlist(iter_chain(*[subnet[\u0027dns_nameservers\u0027] for subnet in v6_subnets if subnet.get(\u0027dns_nameservers\u0027)]))\n\nOr am I missing something?","commit_id":"e9ee042a2839e1d0f9db97fc0a2cfec963083602"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"be833a433e071a4191c1feb1474de6a12ca4ef7d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    subnet[\u0027ipv6_ra_mode\u0027] \u003d\u003d constants.DHCPV6_STATELESS]"},{"line_number":95,"context_line":"            interface_name \u003d self._dev_name_helper(p[\u0027id\u0027])"},{"line_number":96,"context_line":"            dns_servers \u003d list(iter_chain(*[[dns for dns in"},{"line_number":97,"context_line":"                subnet[\u0027dns_nameservers\u0027]] for subnet in v6_subnets if"},{"line_number":98,"context_line":"                subnet.get(\u0027dns_nameservers\u0027)]))"},{"line_number":99,"context_line":"            buf.write(\u0027%s\u0027 % CONFIG_TEMPLATE.render("},{"line_number":100,"context_line":"                ra_modes\u003dlist(ra_modes),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_5752d114","line":97,"in_reply_to":"3a29b11f_e1cebf59","updated":"2015-10-19 09:09:47.000000000","message":"The idea is to create a single list of dns_servers from all the v6 subnets. Since subnet[\u0027dns_nameservers\u0027] is a list, doing it as per your suggestion would create a list  which includes a list (i.e., the output would be [[\u00272001::100\u0027, \u00272001::200\u0027], \u00272001::300\u0027] and not [\u00272001::100\u0027, \u00272001::200\u0027, \u00272001::300\u0027]). Hope it clarifies. Thanks for reviewing.","commit_id":"e9ee042a2839e1d0f9db97fc0a2cfec963083602"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"954b5188cad4ec5d8b934a090eb929ddaf410934","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    subnet[\u0027ipv6_ra_mode\u0027] \u003d\u003d constants.DHCPV6_STATELESS]"},{"line_number":95,"context_line":"            interface_name \u003d self._dev_name_helper(p[\u0027id\u0027])"},{"line_number":96,"context_line":"            dns_servers \u003d list(iter_chain(*[[dns for dns in"},{"line_number":97,"context_line":"                subnet[\u0027dns_nameservers\u0027]] for subnet in v6_subnets if"},{"line_number":98,"context_line":"                subnet.get(\u0027dns_nameservers\u0027)]))"},{"line_number":99,"context_line":"            buf.write(\u0027%s\u0027 % CONFIG_TEMPLATE.render("},{"line_number":100,"context_line":"                ra_modes\u003dlist(ra_modes),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_2e646647","line":97,"in_reply_to":"3a29b11f_f4bc066e","updated":"2015-10-20 09:35:42.000000000","message":"Yes it works. Thank you @Iwamoto.","commit_id":"e9ee042a2839e1d0f9db97fc0a2cfec963083602"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"0986d41c32fb1ebff701aaa932efb9252c6ef00c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                ra_modes\u003dlist(ra_modes),"},{"line_number":100,"context_line":"                interface_name\u003dinterface_name,"},{"line_number":101,"context_line":"                prefixes\u003dauto_config_prefixes,"},{"line_number":102,"context_line":"                dns_servers\u003ddns_servers[0:3],"},{"line_number":103,"context_line":"                constants\u003dconstants))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        utils.replace_file(radvd_conf, buf.getvalue())"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_d5e0ab98","line":102,"updated":"2015-10-21 07:48:36.000000000","message":"This should be a constant, with apropriate documentation. I see that you have some down in the unit test for it, but that\u0027s not the right location.","commit_id":"131124d0a27124896d2c88c4fdf7ce7f8105d0ec"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"e7080377061d6cf359dbdb6bff53238c114081fe","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                ra_modes\u003dlist(ra_modes),"},{"line_number":100,"context_line":"                interface_name\u003dinterface_name,"},{"line_number":101,"context_line":"                prefixes\u003dauto_config_prefixes,"},{"line_number":102,"context_line":"                dns_servers\u003ddns_servers[0:3],"},{"line_number":103,"context_line":"                constants\u003dconstants))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        utils.replace_file(radvd_conf, buf.getvalue())"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_39a3199f","line":102,"in_reply_to":"3a29b11f_d5e0ab98","updated":"2015-10-21 08:54:36.000000000","message":"Sure @Sean.","commit_id":"131124d0a27124896d2c88c4fdf7ce7f8105d0ec"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"e6b1ce77e810dbcd1c8bdebcdb1adb02ed982748","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   {% endif %}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"   {% if dns_servers %}"},{"line_number":58,"context_line":"   RDNSS {% for dns in dns_servers %} {{ dns }} {% endfor %} {};"},{"line_number":59,"context_line":"   {% endif %}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"   {% for prefix in prefixes %}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_6eb7653a","line":58,"updated":"2015-10-21 19:23:29.000000000","message":"Is this only needed for SLAAC?","commit_id":"5959ee599c5c4869a56ce998001dadc243d1355c"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"ec1c3a53d736292bea5ddb112edbcfb5944e1cb3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   {% endif %}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"   {% if dns_servers %}"},{"line_number":58,"context_line":"   RDNSS {% for dns in dns_servers %} {{ dns }} {% endfor %} {};"},{"line_number":59,"context_line":"   {% endif %}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"   {% for prefix in prefixes %}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_af324da5","line":58,"in_reply_to":"3a29b11f_6eb7653a","updated":"2015-10-22 05:06:26.000000000","message":"I thought about it, but felt that if we advertise DNS info using RDNSS, it allows the clients to learn DNS from RA itself without explicitly depending on DHCPv6. And also since the same DNS info would have been included in DHCPv6, ideally there should not be any problem. \n\nBut if you think we should restrict this to SLAAC alone, I can add the necessary check. Pls let me know your thoughts. Thanks.","commit_id":"5959ee599c5c4869a56ce998001dadc243d1355c"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"6a2fb90060d18f661c61d5428d1b08fdb94a74f1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   {% endif %}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"   {% if dns_servers %}"},{"line_number":58,"context_line":"   RDNSS {% for dns in dns_servers %} {{ dns }} {% endfor %} {};"},{"line_number":59,"context_line":"   {% endif %}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"   {% for prefix in prefixes %}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_c15c2e1b","line":58,"in_reply_to":"3a29b11f_af324da5","updated":"2015-10-22 13:18:35.000000000","message":"I\u0027d follow the semantics of the individual modes that have been defined. I don\u0027t think that the same info needs to be sent from two different sources.","commit_id":"5959ee599c5c4869a56ce998001dadc243d1355c"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"439e7c9efde9369e58224a6dafc8530c89255bbb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   {% endif %}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"   {% if dns_servers %}"},{"line_number":58,"context_line":"   RDNSS {% for dns in dns_servers %} {{ dns }} {% endfor %} {};"},{"line_number":59,"context_line":"   {% endif %}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"   {% for prefix in prefixes %}"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_9096cdee","line":58,"in_reply_to":"3a29b11f_c15c2e1b","updated":"2015-11-05 13:52:41.000000000","message":"Ok Robert, I\u0027ll update the patch. Thanks.","commit_id":"5959ee599c5c4869a56ce998001dadc243d1355c"}],"neutron/tests/unit/agent/l3/test_agent.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a0c20cc294c3b64e6226fcbe0263c938be275a43","unresolved":false,"context_lines":[{"line_number":2182,"context_line":"        # Verify that radvd configuration file includes RDNSS entries"},{"line_number":2183,"context_line":"        expected \u003d \"RDNSS  \""},{"line_number":2184,"context_line":"        for dns in dns_list[0:ra.MAX_RDNSS_ENTRIES]:"},{"line_number":2185,"context_line":"            expected +\u003d \"%s  \" % dns"},{"line_number":2186,"context_line":"        self.assertIn(expected, self.utils_replace_file.call_args[0][1])"},{"line_number":2187,"context_line":""},{"line_number":2188,"context_line":"    def _pd_expected_call_external_process(self, requestor, ri, enable\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_800c4d43","line":2185,"updated":"2015-11-15 19:18:15.000000000","message":"FYI, this can be written as:\n \n \u003e\u003e\u003e \"RDNSS \" + \" \".join([dns for dns in dns_list[o:ra.MAX_RDNSS_ENTRIES]])\n \nor \n\n \u003e\u003e\u003e \"RDNSS {}\".format(\" \".join([str(dns) for dns in range(3)]))\n \u0027RDNSS 0 1 2\u0027","commit_id":"ff1d6299bc0923362679022de9c71159c4647385"}]}
