)]}'
{"quantum/extensions/quotasv2.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a5a33b37fc51d2dd3af961d2fab2b9a00b9953f0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                             \u0027allow_put\u0027: True,"},{"line_number":55,"context_line":"                                             \u0027convert_to\u0027: int,"},{"line_number":56,"context_line":"                                             \u0027is_visible\u0027: True}"},{"line_number":57,"context_line":"            self._extended_attributes \u003d len(QUOTAS.resources)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        attr_info \u003d EXTENDED_ATTRIBUTES_2_0[RESOURCE_COLLECTION]"},{"line_number":60,"context_line":"        req_body \u003d base.Controller.prepare_request_body("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F66Y%3D","line":57,"updated":"2013-03-06 12:41:10.000000000","message":"small nit, how about put those in a separated function \u0027_update_attributes_info\u0027?","commit_id":"556fe97126a731cbf122937ff1c263834057cea9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                             \u0027allow_put\u0027: True,"},{"line_number":55,"context_line":"                                             \u0027convert_to\u0027: int,"},{"line_number":56,"context_line":"                                             \u0027is_visible\u0027: True}"},{"line_number":57,"context_line":"            self._extended_attributes \u003d len(QUOTAS.resources)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        attr_info \u003d EXTENDED_ATTRIBUTES_2_0[RESOURCE_COLLECTION]"},{"line_number":60,"context_line":"        req_body \u003d base.Controller.prepare_request_body("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F66M%3D","line":57,"in_reply_to":"AAAAN3%2F%2F66Y%3D","updated":"2013-03-06 12:47:04.000000000","message":"Done","commit_id":"556fe97126a731cbf122937ff1c263834057cea9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self._resource_name \u003d RESOURCE_NAME"},{"line_number":43,"context_line":"        self._plugin \u003d plugin"},{"line_number":44,"context_line":"        self._driver \u003d importutils.import_class(DB_QUOTA_DRIVER)"},{"line_number":45,"context_line":"        self._extended_attributes \u003d 0"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _update_attributes(self):"},{"line_number":48,"context_line":"        for quota_resource in QUOTAS.resources.iterkeys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F6oo%3D","line":45,"updated":"2013-03-06 16:52:04.000000000","message":"As this value stores the number of resources with quota support rather than attributes itself, I prefer to a name suc as _num_quota_resources.","commit_id":"77ab8dc505ceb63b221e7cbe1d901d0442407ec7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self._resource_name \u003d RESOURCE_NAME"},{"line_number":43,"context_line":"        self._plugin \u003d plugin"},{"line_number":44,"context_line":"        self._driver \u003d importutils.import_class(DB_QUOTA_DRIVER)"},{"line_number":45,"context_line":"        self._extended_attributes \u003d 0"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _update_attributes(self):"},{"line_number":48,"context_line":"        for quota_resource in QUOTAS.resources.iterkeys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F6jA%3D","line":45,"in_reply_to":"AAAAN3%2F%2F6j8%3D","updated":"2013-03-06 17:25:27.000000000","message":"I think this variable is a flag to indicate we need to update quota resources. From this point of view, self.need_update True/False makes sense.\n\nOnly case where 0 and True have different meaning is a case where cfg.QUOTAS.quota_items is an empty list. In this case we don\u0027t need to call _update_attributes but it is very rare.\n\nIn addition, quota_items config variable only affects core resources (networks, subnets, ports) and does not affects resources provided by extensions. It is also confusing to users.","commit_id":"77ab8dc505ceb63b221e7cbe1d901d0442407ec7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self._resource_name \u003d RESOURCE_NAME"},{"line_number":43,"context_line":"        self._plugin \u003d plugin"},{"line_number":44,"context_line":"        self._driver \u003d importutils.import_class(DB_QUOTA_DRIVER)"},{"line_number":45,"context_line":"        self._extended_attributes \u003d 0"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _update_attributes(self):"},{"line_number":48,"context_line":"        for quota_resource in QUOTAS.resources.iterkeys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F6j8%3D","line":45,"in_reply_to":"AAAAN3%2F%2F6oo%3D","updated":"2013-03-06 17:03:25.000000000","message":"I agree, I got a little bit confused to begin with, thinking why this is not None if it was a reference.","commit_id":"77ab8dc505ceb63b221e7cbe1d901d0442407ec7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self._plugin \u003d plugin"},{"line_number":44,"context_line":"        self._driver \u003d importutils.import_class(DB_QUOTA_DRIVER)"},{"line_number":45,"context_line":"        self._extended_attributes \u003d 0"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _update_attributes(self):"},{"line_number":48,"context_line":"        for quota_resource in QUOTAS.resources.iterkeys():"},{"line_number":49,"context_line":"            attr_dict \u003d EXTENDED_ATTRIBUTES_2_0[RESOURCE_COLLECTION]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F6cQ%3D","line":46,"updated":"2013-03-06 19:00:56.000000000","message":"hope i have addressed as you guys wished.","commit_id":"77ab8dc505ceb63b221e7cbe1d901d0442407ec7"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def _get_body(self, request):"},{"line_number":57,"context_line":"        body \u003d self._deserialize(request.body,"},{"line_number":58,"context_line":"                                 request.best_match_content_type())"},{"line_number":59,"context_line":"        if self._update_extended_attributes is True:"},{"line_number":60,"context_line":"            self._update_attributes()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        attr_info \u003d EXTENDED_ATTRIBUTES_2_0[RESOURCE_COLLECTION]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F6Ao%3D","line":59,"updated":"2013-03-06 23:14:21.000000000","message":"need \"is True\"?","commit_id":"08ee0f9cbba4ad6af918a15a7f35732c2a549ca7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def _get_body(self, request):"},{"line_number":57,"context_line":"        body \u003d self._deserialize(request.body,"},{"line_number":58,"context_line":"                                 request.best_match_content_type())"},{"line_number":59,"context_line":"        if self._update_extended_attributes is True:"},{"line_number":60,"context_line":"            self._update_attributes()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        attr_info \u003d EXTENDED_ATTRIBUTES_2_0[RESOURCE_COLLECTION]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F5XY%3D","line":59,"in_reply_to":"AAAAN3%2F%2F6Ao%3D","updated":"2013-03-07 07:03:16.000000000","message":"No really. I\u0027ll update in another open patch - sorry","commit_id":"08ee0f9cbba4ad6af918a15a7f35732c2a549ca7"}]}