)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"14e403de562967aa76805175619408436f1fe4d1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"as in the previous patch, keystone would reject the request before"},{"line_number":19,"context_line":"the cross-domain headers could be annotated, resulting in an"},{"line_number":20,"context_line":"error response that was unreadable by the user agent."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"OpenStack CrossProject Spec:"},{"line_number":23,"context_line":"   http://specs.openstack.org/openstack/openstack-specs/specs/cors-support.html"},{"line_number":24,"context_line":"Oslo_Middleware Docs:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a29b11f_778c7f35","line":21,"updated":"2015-10-20 00:57:15.000000000","message":"Please add DocImpact tag.","commit_id":"5badf3e21239ea80fc4241585b06f17043ca4ec3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5f1d14ec34b35d75b7032512b4c55f201be5ed98","unresolved":false,"context_lines":[{"line_number":24,"context_line":"   http://docs.openstack.org/developer/oslo.middleware/cors.html"},{"line_number":25,"context_line":"OpenStack Cloud Admin Guide:"},{"line_number":26,"context_line":"   http://docs.openstack.org/admin-guide-cloud/cross_project_cors.html"},{"line_number":27,"context_line":"DocImpact"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I02acea6124d28370d92e7c94ca2d1d6c5c8937ac"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7a740942_884b52b0","line":27,"updated":"2015-12-04 01:13:23.000000000","message":"Please follow guidelines as detailed here:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-November/080294.html","commit_id":"6ab09c78566625215f0d7d15ebcadfc8399ce6eb"}],"neutron/pecan_wsgi/app.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0534682b2721d181fb77962327a3f810f000252e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from keystonemiddleware import auth_token"},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"from oslo_middleware import request_id"},{"line_number":19,"context_line":"from oslo_middleware import cors"},{"line_number":20,"context_line":"import pecan"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.common import exceptions as n_exc"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_87aaad83","line":19,"updated":"2015-11-12 03:52:18.000000000","message":"pep8 alphabet ordering issue here. otherwise looks good.","commit_id":"ca2a44afca3751c66ab82741e18f117f793a77c1"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"c3b529afcbd86b1737d258196ecfee53d8d5095f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        raise n_exc.InvalidConfigurationOption("},{"line_number":77,"context_line":"            opt_name\u003d\u0027auth_strategy\u0027, opt_value\u003dcfg.CONF.auth_strategy)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # This should be the last middleware in the list."},{"line_number":80,"context_line":"    app \u003d cors.CORS(app, cfg.CONF)"},{"line_number":81,"context_line":"    app.set_latent("},{"line_number":82,"context_line":"        allow_headers\u003d[\u0027X-Auth-Token\u0027, \u0027X-Openstack-Request-Id\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_8c77bfd3","line":79,"updated":"2015-11-13 23:11:17.000000000","message":"Could explain why?","commit_id":"4bd1e250717e4d6a0a662fe37287e69f106dcad3"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"c08723c9fe7ba6bda46b5cabed74967c5c3392a5","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        raise n_exc.InvalidConfigurationOption("},{"line_number":77,"context_line":"            opt_name\u003d\u0027auth_strategy\u0027, opt_value\u003dcfg.CONF.auth_strategy)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # This should be the last middleware in the list."},{"line_number":80,"context_line":"    app \u003d cors.CORS(app, cfg.CONF)"},{"line_number":81,"context_line":"    app.set_latent("},{"line_number":82,"context_line":"        allow_headers\u003d[\u0027X-Auth-Token\u0027, \u0027X-Openstack-Request-Id\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_6fbfedaa","line":79,"in_reply_to":"da85f559_4f4b095a","updated":"2015-11-13 23:55:38.000000000","message":"I would appreciate that you clarify the commit and perhaps rewrite the note as to me cors should the first middleware (according to the chain wsgi \u003d\u003e cors \u003d\u003e ...)","commit_id":"4bd1e250717e4d6a0a662fe37287e69f106dcad3"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"d5abe0ed203dacab5735cb600e2d47638af8710c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        raise n_exc.InvalidConfigurationOption("},{"line_number":77,"context_line":"            opt_name\u003d\u0027auth_strategy\u0027, opt_value\u003dcfg.CONF.auth_strategy)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # This should be the last middleware in the list."},{"line_number":80,"context_line":"    app \u003d cors.CORS(app, cfg.CONF)"},{"line_number":81,"context_line":"    app.set_latent("},{"line_number":82,"context_line":"        allow_headers\u003d[\u0027X-Auth-Token\u0027, \u0027X-Openstack-Request-Id\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_d8a4a109","line":79,"in_reply_to":"da85f559_6fbfedaa","updated":"2015-11-14 03:42:56.000000000","message":"In this method, it should be the last. The reason is that the last middleware in this method actually ends up the first one in the chain. Effectively, what I\u0027m doing here is: cors(authprotocol(requestId(app))), which sets up the chain wsgi-\u003ecors-\u003eauthprotocol-\u003erequestId-\u003eapp","commit_id":"4bd1e250717e4d6a0a662fe37287e69f106dcad3"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"36bbde8eaa54aae1437561452463c6247d226d9d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        raise n_exc.InvalidConfigurationOption("},{"line_number":77,"context_line":"            opt_name\u003d\u0027auth_strategy\u0027, opt_value\u003dcfg.CONF.auth_strategy)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # This should be the last middleware in the list."},{"line_number":80,"context_line":"    app \u003d cors.CORS(app, cfg.CONF)"},{"line_number":81,"context_line":"    app.set_latent("},{"line_number":82,"context_line":"        allow_headers\u003d[\u0027X-Auth-Token\u0027, \u0027X-Openstack-Request-Id\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_4f4b095a","line":79,"in_reply_to":"da85f559_8c5edf43","updated":"2015-11-13 23:21:55.000000000","message":"CORS is, basically, some additional HTTP headers that are added to any response, iff the browser is making the request from an allowed domain. This means that any error response from other middleware must pass through the CORS middleware to be properly annotated.\n\nAs an example, consider this chain: wsgi -\u003e keystone -\u003e cors -\u003e app. If keystone throws a login error, then the browser will not be able to read the response, because the request never made it to CORS. If the chain is, instead, wsgi -\u003e cors -\u003e keystone -\u003e app, then the cors middleware will add the headers to the error response, so that the browser can determine what happened and inform the user interface accordingly.\n\nA brief version of this explanation is in the commit message, but on retrospect it\u0027s not that well written.","commit_id":"4bd1e250717e4d6a0a662fe37287e69f106dcad3"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d1c2d9bbeb9e330b622976d0718fe3b5d9e53a0b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        raise n_exc.InvalidConfigurationOption("},{"line_number":77,"context_line":"            opt_name\u003d\u0027auth_strategy\u0027, opt_value\u003dcfg.CONF.auth_strategy)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # This should be the last middleware in the list."},{"line_number":80,"context_line":"    app \u003d cors.CORS(app, cfg.CONF)"},{"line_number":81,"context_line":"    app.set_latent("},{"line_number":82,"context_line":"        allow_headers\u003d[\u0027X-Auth-Token\u0027, \u0027X-Openstack-Request-Id\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_8c5edf43","line":79,"in_reply_to":"da85f559_8c77bfd3","updated":"2015-11-13 23:11:49.000000000","message":"Oups, could you explain why?","commit_id":"4bd1e250717e4d6a0a662fe37287e69f106dcad3"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"09745f0069bea5cc5addba795affdcd03050342d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        raise n_exc.InvalidConfigurationOption("},{"line_number":77,"context_line":"            opt_name\u003d\u0027auth_strategy\u0027, opt_value\u003dcfg.CONF.auth_strategy)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # This should be the last middleware in the list."},{"line_number":80,"context_line":"    app \u003d cors.CORS(app, cfg.CONF)"},{"line_number":81,"context_line":"    app.set_latent("},{"line_number":82,"context_line":"        allow_headers\u003d[\u0027X-Auth-Token\u0027, \u0027X-Openstack-Request-Id\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_d60bff22","line":79,"in_reply_to":"da85f559_d8a4a109","updated":"2015-11-15 21:18:34.000000000","message":"Makes sense. It would be good though if you can adjust the comment to indicate that it needs to be last so it can annotate all of the headers correctly.","commit_id":"4bd1e250717e4d6a0a662fe37287e69f106dcad3"}]}
