)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"532a39c519c3d60413bd9cb095874b3f5f27e856","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aaron Rosen \u003carosen@nicira.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-03-06 13:04:36 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add explit egress rules to nvp security profile"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following commit  7e26074b changed the previous behavior of quantum"},{"line_number":10,"context_line":"security groups by explicitly adding egress rules to the security profile."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAN3%2F%2F4cs%3D","line":7,"updated":"2013-03-07 18:56:19.000000000","message":"explit \u003d\u003e explicit","commit_id":"eab3f50d14bd901a3c71411d09ca3b57d903aed9"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"4dee249b2506a7b3127ce0942240c8e43dd978c9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aaron Rosen \u003carosen@nicira.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-03-06 13:04:36 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add explit egress rules to nvp security profile"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following commit  7e26074b changed the previous behavior of quantum"},{"line_number":10,"context_line":"security groups by explicitly adding egress rules to the security profile."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAN3%2F%2F4Ng%3D","line":7,"in_reply_to":"AAAAN3%2F%2F4cs%3D","updated":"2013-03-07 21:19:01.000000000","message":"Done","commit_id":"eab3f50d14bd901a3c71411d09ca3b57d903aed9"}],"quantum/plugins/nicira/nicira_nvp_plugin/nvplib.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1059,"context_line":"                      \u0027ip_prefix\u0027: \u00270.0.0.0/0\u0027}],"},{"line_number":1060,"context_line":"                    \u0027logical_port_ingress_rules\u0027:"},{"line_number":1061,"context_line":"                    [{\u0027ethertype\u0027: \u0027IPv4\u0027,"},{"line_number":1062,"context_line":"                      \u0027ip_prefix\u0027: \u0027127.0.0.1/32\u0027},"},{"line_number":1063,"context_line":"                     {\u0027ethertype\u0027: \u0027IPv4\u0027},"},{"line_number":1064,"context_line":"                     {\u0027ethertype\u0027: \u0027IPv6\u0027}]}"},{"line_number":1065,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F3zs%3D","line":1062,"updated":"2013-03-08 02:04:14.000000000","message":"I don\u0027t think this 127.0.0.1 rule here is needed, as it will be pushed down later on update if the default allow is ever removed.","commit_id":"8e477eca8c4e687ecdfec424a680ebb6db35afb3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"4dee249b2506a7b3127ce0942240c8e43dd978c9","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"                      \u0027ip_prefix\u0027: \u00270.0.0.0/0\u0027}],"},{"line_number":1060,"context_line":"                    \u0027logical_port_ingress_rules\u0027:"},{"line_number":1061,"context_line":"                    [{\u0027ethertype\u0027: \u0027IPv4\u0027,"},{"line_number":1062,"context_line":"                      \u0027ip_prefix\u0027: \u0027127.0.0.1/32\u0027},"},{"line_number":1063,"context_line":"                     {\u0027ethertype\u0027: \u0027IPv4\u0027},"},{"line_number":1064,"context_line":"                     {\u0027ethertype\u0027: \u0027IPv6\u0027}]}"},{"line_number":1065,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F244%3D","line":1062,"in_reply_to":"AAAAN3%2F%2F3zs%3D","updated":"2013-03-08 17:48:02.000000000","message":"Good point","commit_id":"8e477eca8c4e687ecdfec424a680ebb6db35afb3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":1077,"context_line":"    if security_profile.get(\u0027name\u0027) \u003d\u003d \u0027default\u0027:"},{"line_number":1078,"context_line":"        # If security group is default allow ip traffic between"},{"line_number":1079,"context_line":"        # members of the same security profile is allowed and ingress traffic"},{"line_number":1080,"context_line":"        # from the switch"},{"line_number":1081,"context_line":"        rules \u003d {\u0027logical_port_egress_rules\u0027: [{\u0027ethertype\u0027: \u0027IPv4\u0027,"},{"line_number":1082,"context_line":"                                                \u0027profile_uuid\u0027: rsp[\u0027uuid\u0027]},"},{"line_number":1083,"context_line":"                                               {\u0027ethertype\u0027: \u0027IPv6\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F3NM%3D","line":1080,"updated":"2013-03-08 12:30:13.000000000","message":"I always get confused about this... in NVP terms the ingress rule refers to traffic from the VIF to the switch or vice versa?","commit_id":"8e477eca8c4e687ecdfec424a680ebb6db35afb3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"4dee249b2506a7b3127ce0942240c8e43dd978c9","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"    if security_profile.get(\u0027name\u0027) \u003d\u003d \u0027default\u0027:"},{"line_number":1078,"context_line":"        # If security group is default allow ip traffic between"},{"line_number":1079,"context_line":"        # members of the same security profile is allowed and ingress traffic"},{"line_number":1080,"context_line":"        # from the switch"},{"line_number":1081,"context_line":"        rules \u003d {\u0027logical_port_egress_rules\u0027: [{\u0027ethertype\u0027: \u0027IPv4\u0027,"},{"line_number":1082,"context_line":"                                                \u0027profile_uuid\u0027: rsp[\u0027uuid\u0027]},"},{"line_number":1083,"context_line":"                                               {\u0027ethertype\u0027: \u0027IPv6\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F24w%3D","line":1080,"in_reply_to":"AAAAN3%2F%2F3NM%3D","updated":"2013-03-08 17:48:02.000000000","message":"From the switch. Egress to the vm is Ingress to the switch.  (This is the same with NAT in nvp.)","commit_id":"8e477eca8c4e687ecdfec424a680ebb6db35afb3"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1100,"context_line":"         \u0027port_range_max\u0027: constants.DHCP_RESPONSE_PORT,"},{"line_number":1101,"context_line":"         \u0027ip_prefix\u0027: \u00270.0.0.0/0\u0027})"},{"line_number":1102,"context_line":"    rules[\u0027logical_port_ingress_rules\u0027].append("},{"line_number":1103,"context_line":"        {\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027ip_prefix\u0027: \u0027127.0.0.1/32\u0027})"},{"line_number":1104,"context_line":"    try:"},{"line_number":1105,"context_line":"        body \u003d mk_body("},{"line_number":1106,"context_line":"            logical_port_ingress_rules\u003drules[\u0027logical_port_ingress_rules\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F3zo%3D","line":1103,"updated":"2013-03-08 02:04:14.000000000","message":"Probably better to append 127.0.0.1 rule only if user has no other ingress rules.  This may be confusing to someone who sees it in the NVP GUI, so I\u0027d rather have it only be visible in the less likely scenario where the user has deleted the default rule.","commit_id":"8e477eca8c4e687ecdfec424a680ebb6db35afb3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"4dee249b2506a7b3127ce0942240c8e43dd978c9","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"         \u0027port_range_max\u0027: constants.DHCP_RESPONSE_PORT,"},{"line_number":1101,"context_line":"         \u0027ip_prefix\u0027: \u00270.0.0.0/0\u0027})"},{"line_number":1102,"context_line":"    rules[\u0027logical_port_ingress_rules\u0027].append("},{"line_number":1103,"context_line":"        {\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027ip_prefix\u0027: \u0027127.0.0.1/32\u0027})"},{"line_number":1104,"context_line":"    try:"},{"line_number":1105,"context_line":"        body \u003d mk_body("},{"line_number":1106,"context_line":"            logical_port_ingress_rules\u003drules[\u0027logical_port_ingress_rules\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F24s%3D","line":1103,"in_reply_to":"AAAAN3%2F%2F3zo%3D","updated":"2013-03-08 17:48:02.000000000","message":"Done","commit_id":"8e477eca8c4e687ecdfec424a680ebb6db35afb3"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1099,"context_line":"    # If there are no ingress rules add bunk rule to drop all ingress traffic"},{"line_number":1100,"context_line":"    if not len(rules[\u0027logical_port_ingress_rules\u0027]):"},{"line_number":1101,"context_line":"        rules[\u0027logical_port_ingress_rules\u0027].append("},{"line_number":1102,"context_line":"            {\u0027ethertype\u0027: \u0027IPv4\u0027, \u0027ip_prefix\u0027: \u0027127.0.0.1/32\u0027})"},{"line_number":1103,"context_line":"    try:"},{"line_number":1104,"context_line":"        body \u003d mk_body("},{"line_number":1105,"context_line":"            logical_port_ingress_rules\u003drules[\u0027logical_port_ingress_rules\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F2tI%3D","line":1102,"updated":"2013-03-08 19:07:26.000000000","message":"we could assign rather than append, since we just checked that the list is empty, but its fine.","commit_id":"6bb31ed9f1a9291b9940473ebafb338f96ab3b84"}]}